- 15 May, 2019 40 commits
-
-
Xiaocheng Hu authored
Currently, WebTextCheckingCompletion instances are managed manually, making them prone to leaks. This CL changes them to be managed by std::unique_ptr to specify the ownership clearly and prevent them from being leaked. Bug: 962610 Change-Id: I37cee0747f3491fc9a622cf387274487cf765f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610491Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660055}
-
Daniel Rubery authored
For users with "Make searches and browsing better" enabled, we will share non-allowlisted URLs with Safe Browsing in real-time, to avoid the propagation delay with blocklist-based approaches. BUG=963165 Change-Id: I2c204946ce816a21b7ff4b0f72978f46d180e6d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611308 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#660054}
-
Mohamed Amir Yosef authored
This CL add some CHECKs for debugging purpose to detect cases when duplicate tombstones are tracked in the bookmarks tracker. Bug: 963469 Change-Id: I2f0c23c5ece50264e9a7f07f2cf8abd956ff72d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613182Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#660053}
-
Caroline Rising authored
Tab hover cards should appear immediately when keyboard focus is on either the tab or the tab's close button. This cl makes Tab a view observer of its close button and triggers hover cards when either the tab or the close button takes focus. Tab hover cards previously were hidden on any key event, this cl adds a check to avoid hiding hover cards on key events when the tab strip is keyboard focused. This also hides the hover cards on any mouse click since during keyboard navigation the mouse can be outside the tab strip where mouse events were previously captured. Bug: 963537 Change-Id: Ia5889e22c3ce29996956c56e84b7e2d54cd51396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612220Reviewed-by:
Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#660052}
-
Leon Scroggins III authored
When parsing a PNG header (i.e. up to the IDAT), skip ancillary chunks that the decoder does not need (rather than passing to libpng, as was done previously). This can speed up decoding (as well as reduce memory allocations) when a PNG header contains large and/or many unneeded chunks (e.g. tEXt). This is important because the header is parsed in the main thread. (Note that for simplicity, this change still passes unneeded chunks to libpng during decoding, which occurs in a background thread.) A resulting behavior change (side-effect) is that a PNG containing an ancillary chunk with a CRC error prior to the IDAT would previously have made the decoder Fail and no longer does. This is acceptable because these chunks are ancillary and can be ignored. Note that an IEND chunk before IDAT *is* passed to libpng, because that *should* result in a failure. Add a test to verify that we still handle tRNS correctly. Other chunks are tested by web_tests. Bug: 956259 Change-Id: I4d159597e99adcfcfe5cf81f9057624eae541de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599916 Commit-Queue: Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Auto-Submit: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#660051}
-
Abhijeet Kandalkar authored
make_element_type_helpers.py uses element_type_helpers.h.tmpl to generate html_element_type_helpers.h and svg_element_type_helpers.h This CL ports element_type_helpers.h.tmpl to use new downcast helper. Bug: 891908 Change-Id: Idb18e0869b99a1fa96f675750a2df7d34b4bbc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613140Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#660050}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/67cf8a9266d0..558df923fcce git log 67cf8a9266d0..558df923fcce --date=short --no-merges --format='%ad %ae %s' 2019-05-15 chrisforbes@google.com Fix color blend state handling for multiple attachments 2019-05-15 chrisforbes@google.com Move constant specialization to SpirvShader Created with: gclient setdep -r src/third_party/swiftshader@558df923fcce The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132433217,chromium:b/127454276 TBR=swiftshader-team+autoroll@google.com Change-Id: I6e047a8e2e152d50c9ef74a3d554f2e7768b25b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613597Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660049}
-
Greg Thompson authored
These were disabled due to problems with the overall text harness which have since been fixed. This is a partial revert of https://crrev.com/647051. BUG=711256,945630 Change-Id: Ifbda4d517d759b5648d5b51236523bb0d666e6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612910Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#660048}
-
Gary Kacmarcik authored
Change-Id: Ieabbbfa165fd8c66e1a3f672fc1cbf9e1c575117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613641 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#660047}
-
Elly Fong-Jones authored
This will put this icon back above contrast minimum (4.5): 9AA0A6 on FFFFFF = 2.64 5F6368 on FFFFFF = 6.04 Bug: 957394 Change-Id: I49a3f7dd30d06b140f1074651338122f84149c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612842 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660046}
-
Christopher Cameron authored
In crrev.com/659558, we removed a number of ifdef guards that appeared to be redundant. Apparently they weren't. Replace what used to be USE_DEFAULT_RENDER_THEME with USE_AURA (which was equivalent). Bug: 963366 Change-Id: I1ffcd83e780a92529f5449a014fe7dc06f6fc07b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612853Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660045}
-
Lukasz Anforowicz authored
The move helps in two ways: - It allows modifying request headers when processing redirects. This fixes existing wpt/fetch/sec-metadata/redirect tests (although note that redirects might still be mishandled in CORS mode - see https://crbug.com/956146). - It makes it possible to base the header on trustworthy input (i.e. allow for verifying of |request_initiator| supplied by a renderer process against |request_initiator_site_lock| supplied by the browser process). Bug: 872285, 924204 Change-Id: I323239cd76e18037be8eb56aad4e989932585a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478304 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
David Benjamin authored
This way other SSLClientSocketTests can also use EmbeddedTestServer. Bug: 492672 Change-Id: Iefc66c9f2d0b15e4ec1f793f58e2222994716c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591809Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#660043}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a253cff3c8ac..eaf2d928e6fa git log a253cff3c8ac..eaf2d928e6fa --date=short --no-merges --format='%ad %ae %s' 2019-05-15 courtneygo@google.com Add support for OES_depth_texture Created with: gclient setdep -r src/third_party/angle@eaf2d928e6fa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@google.com Change-Id: I77b2e7b9a91ba9322e3eb41a20e5d779aec3aba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612187Reviewed-by:
-
Adenilson Cavalcanti authored
The objective is to provide a fast and high quality hash for general use that will exploit the hardware features of the running CPU. It is warranted to be high quality and top speed, but it is prone to be updated when a newer/faster hash function is publicly available. There are *no warranties* that the hash generated will be the same on all CPUs (e.g. ARM x Intel) or build target (e.g. 32-bit vs 64-bit). For such cases, use PersistentHash() instead. It is also a non-cryptographic hash, therefore, use it when speed is most important. For now, it is powered by the latest version of CityHash on both ARM/Intel and is the same version (i.e. City32() x City64()) depending on now Chromium was built (32-bit app or 64-bit). Plus migrate server-side *independent* client code to use base::FastHash that was using deprecated CityHash. Bug: 902789 Change-Id: If38169b8f3a7f22f667efef8576fb28b3130d644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575082Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#660041}
-
Lukasz Anforowicz authored
It is sufficient to register the secure origin whitelist only as local state pref, because it is only accessed via local state (by SecureOriginPrefsObserver which is asked to monitor the local state in BrowserProcessImpl::PreCreateThreads). Bug: 937451 Change-Id: I98dd0b06a01bbf7f029f719eef9199bfed92c2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1575163 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#660040}
-
Yi Su authored
This CL changes the URL label color of TableViewURLCell's URL for search engine settings to Google Grey 700 for a11y reason. Bug: 963520 Change-Id: I03950af95b85ab096d315bafec6bbb645f2620b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610075Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#660039}
-
Chris Palmer authored
Bug: None TBR: alph Change-Id: I01d1abdc44cde63278512651372a05a6c2778749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611726 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#660038}
-
Brandon Tolsch authored
This reverts commit 15c84b57. Reason for revert: Causing failures on linux tsan bots Original change's description: > Media Engagement: only use/record for HTTPS origins. > > Bug: 958364 > Change-Id: Ifc87e6222df9de526f2900f13899af616604750e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591878 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659971} TBR=mlamouri@chromium.org,beccahughes@chromium.org Change-Id: I9eb37587218f1bc9ff25b474ebe14ba4bba6b131 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958364,963569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613783Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#660037}
-
Ahmed Mehfooz authored
Default transpareny for focus rings was removed in https://crbug.com/948959. Native Themes need to specify alpha values for focus rings after this change. Bug: 962373 Change-Id: I0b8fb048c9afe3028a1cd6edf95b3e21203ea4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610202Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#660036}
-
Peter Kasting authored
Bug: 957264 Change-Id: I04965b9f169c5ae360f60691557442f43012b8ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601371Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#660035}
-
Parastoo Geranmayeh authored
Change-Id: Ia3cb53410a3e2794a6725c70b8961ae0ca2f275d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610995Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#660034}
-
Toni Barzic authored
Ignore kiosk app launch error or success request if kiosk app launch controller has already been cleaned-up. BUG=962591 Change-Id: I72f744fded4e5b56f1b667ca5429a9920d636418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612602Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#660033}
-
Yining Wang authored
FindBrowserWithWebContents() may return null in some cases. This cl check the return value first to avoid potential crahsed. Bug: 962412 Change-Id: I4289155d2c95f4cf80d667b24b17fb94a9e4569c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612578Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Yining Wang <yiningwang@google.com> Cr-Commit-Position: refs/heads/master@{#660032}
-
danakj authored
The ContentMainDelegate can already control if BrowserMain() is run so it is not needed in ContentMain() and is a complexity that is harder to understand there, hard to find at all, and a layering violation. The ShellMainDelegate already returns 0 on OS_ANDROID now as of https://chromium-review.googlesource.com/c/chromium/src/+/1609676 but ChromeMainDelegate does not. AwMainDelegate already returns 0 for the browser process always. These are the only ContentMainDelegate impls that are used on Android. Change ChromeMainDelegateAndroid to stop running ChromeMainDelegate's RunProcess() since all it does on Android is return -1. Since the BrowserMainRunnerImpl returns -1 on success, have the delegate catch that and return 0 to avoid running BrowserMain() from ContentMain(). Removes the OS_ANDROID branch from ContentMain(). R=jam@chromium.org Bug: 961849 Change-Id: If1d4ad11c274e23973aa6e6974e62b9352c875bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612248Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#660031}
-
Parastoo Geranmayeh authored
Consider <input type="search"...> for heuristics type predictions when dropdowns might be have been used. Bug: 963119 Change-Id: I6604f86cb2a8978ec594531bd2d28aa40257e9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610096Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#660030}
-
Michael Giuffrida authored
Updates the Feedback app to allow the landing page type to be empty, for cases where we don't want to show a landing page after sending feedback (ie, when using Kiosk Next). Also fixes the board parsing logic so only eve devices (instead of all boards containing the substring "eve") are treated as Pixelbooks. Bug: 957784 Change-Id: Ie46153e0c7d08e213373d8acfb6593c6d6f45ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602448 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#660029}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibacfb7f20d2119103022f1ab52e1a20f695266d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612189Reviewed-by:
-
siyua authored
Previously the highlighted button for the bubble is set to be the icon in OmniboxPageActionIconContainer, so when the icon is actually in ToolbarPageActionIconContainer, the highlight will not be updated in BubbleDialogDelegateView::HandleVisibilityChanged() when the bubble is dismissed. Bug: 932818 Change-Id: Ic0aba1e922f7c240195cdef3d422422e5d9c6861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612363Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#660027}
-
Robert Ogden authored
Sorry for the size... many things have come to link against this code and they all needed to be removed or changed, esp the lofi code. Bug: 942572 Change-Id: I7e760ad51e78a83e7ef3a7884c5c3a7ddcc13fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603323Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#660026}
-
danakj authored
When WebContentsImpl destroys, it deletes the speculative main frame, but the renderer may have taken ownership of it already, and the notice of such action is in flight to the browser still. This leads to DCHECKs failing in the renderer. So inform the FrameMsg_Delete IPC what the intention of the browser is, there are 3 modes: - Deleting a non-main frame. This is the common case. These frames are all owned by the browser so it's all good, no races. - Deleting a speculative main frame at shutdown. This is the race we address here. - Deleting a speculative main frame because it's no longer needed. This race is not handled by this CL but we CHECK() it explicitly now instead of letting the renderer continue with a missing RenderFrame that it expects to be present until it crashes somewhere random later. R=avi@chromium.org, dcheng@chromium.org Bug: 957858, 838348 Change-Id: I2110bdaf8b116df48037f69db6cb992fa3796e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594834 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Tommy Steimel authored
Bug: 963032 Change-Id: I347570b37044f9679f94bbe60b9e24d578892ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611216Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#660024}
-
Eric Karl authored
This reverts commit 91d93479. It turns out that future work / optimizations around Android colorspace handling and Skia SW raster optimization require that we cache mixed colorspace images. Reverting this patch to bring back this option. If we see performance regressions on the bots, I'll address these in a follow-up. Bug: 955161 Change-Id: I0dda536cf05d349b615f55e7ec1a670df2026a2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592803Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
-
Oksana Zhuravlova authored
Change-Id: I0db54e83879a12f83bafd251f7b10cabe344f2c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612537Reviewed-by:
-
rbpotter authored
Temporary file names created with tempfile.NamedTemporaryFile cannot be used to open the file a second time on Windows, see: https://docs.python.org/2/library/tempfile.html Set the temp files to not be automatically deleted on close, close them after creation so they can be re-opened, and delete the files at the end of the tests. Bug: 961359 Change-Id: I88a86332f4454c1e98f7e5b0f7753771e7d4b4d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612043Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#660021}
-
Michael Lippautz authored
The bit is set whenever writing free list entries. Bug: 945806 Change-Id: Ifd5b7e6a8c4d7e4d557afd02fa79b1f1d60f4ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609912 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#660020}
-
arthursonzogni authored
This reverts commit c0700f9c. Reason for revert: https://crbug.com/963330 When a frame commit in process A, it tells the proxy of the focused frame for process A to "SetFocusedFrame". The problems happens when the focused frame is "pending deletion", it doesn't have any proxy anymore. The solution might be: 1) Unset the focused frame when it starts unloading. 2) Do not depends on the proxy to exist. This will be done in the reland. Original change's description: > Detached subframes with unload handler should not be visible to others. > > When a frame is unloading in one process, it must not be visible from the other > processes at some point. Previously, it was done when the frame completed the > unload, now it will be done when it starts unloading. > > To achieve that, the RenderFrameProxyHost are removed when the frame starts > unloading. Moreover, no new RenderFrameProxyHosts are created in a frame with an > unloading current document. > > + 2 tests added, originally made by lukasza@chromium.org (Thanks!) > > Bug: 960006, 950625 > Change-Id: I3f6fc405219a08d9d61f5c0ed8772601f9dc8835 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599182 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659004} TBR=creis@chromium.org,alexmos@chromium.org,lukasza@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 960006, 950625, 963330 Change-Id: I06a1eb44c05eaaff380e1b96f796c5b064c16c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613183Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#660019}
-
rbpotter authored
(1) Use relative paths in the downloads UI, instead of prefixing everything with chrome://downloads. (2) To make this work, add a <base href="chrome://downloads> to non optimized builds. (3) Match the behavior for incorrect subpaths like chrome://downloads/a/b/ to the behavior for other Web UIs (settings, extensions, and print preview). Bug: none Change-Id: I34978c736126537fddbb8118d03de0dce8201917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604054 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/023ca2db25ad..ddbdb74d5561 git log 023ca2db25ad..ddbdb74d5561 --date=short --no-merges --format='%ad %ae %s' 2019-05-15 dhanyaganesh@chromium.org cros_uprevchrome: change LIMIT to be Buildbucket's request Created with: gclient setdep -r src/third_party/chromite@ddbdb74d5561 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Icd47e2ec194cc314a4d697782a42e9c68bad7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613322Reviewed-by:
-
Alex Cooper authored
This reverts commit f9706cfd. Reason for revert:963529 Original change's description: > Update XRInputSource Gamepad to comply with SameObject requirement > > The WebXR spec requires that the Gamepad object on an XRInputSource be > tagged as "SameObject." The current implementation would allow for > the Gamepad to be toggled between null and present on the same > XRInputSource object as it currently is written. This change exposes a > method "NeedsReCreation" as well as static helper methods (and a deep- > copy constructor) to allow for that re-creation to occur in a pattern > which could be re-used by 958019 if the spec requires those changes. > While this change adds an xr_browser_test to validate the blink code > that destroys/re-creates the object, the work to add a WPT test for all > of the same object properties is tracked by 960958. > > The exemption to audit_non_blink_usage was added because the xr module > was currently utilizing device::Gamepad, but since it was previously > wrapped in base::Optional, that usage was not flagged. > > Note that 955101 (currently tagged for 77) may relax/change this > requirement, but this makes the code compliant with the spec for M76. > > Bug: 960978 > Change-Id: Ie36990f47e43c6df91af3fca06dd269a860a2a1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606421 > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#659625} TBR=dcheng@chromium.org,bajones@chromium.org,billorr@chromium.org,alcooper@chromium.org Change-Id: Ia5b987d3e4e5746d94a65cd2e8786012345b8c5d No-Presubmit: true No-Try: true Bug: 960978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613557 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#660016}
-
