- 02 Mar, 2020 40 commits
-
-
Reilly Grant authored
The flag to enable WebNFC is now the regular experimental web platform features flag. The "WebNFC" feature can still be used as a kill-switch but should not normally be touched by users or developers. Bug: 1035048 Change-Id: I7989ccd610affb5f0b8341f112a583e5dbacc3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071365Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746090}
-
Jonathan Freed authored
Change-Id: I3fe9e64585cbf6115748e9f8eddcdb84475d9aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083407Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#746089}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9ca9c52c4c04..4576851428dd git log 9ca9c52c4c04..4576851428dd --date=short --first-parent --format='%ad %ae %s' 2020-03-02 ehmaldonado@google.com git-cl: Remove support for GetPreferredTryMasters. Created with: gclient setdep -r src/third_party/depot_tools@4576851428dd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042324 Tbr: agable@chromium.org Change-Id: I6d45104d7d63fe5d03e8ea55900422e69be58f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083624Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746088}
-
Vasiliy Telezhnikov authored
This CL ports some fixes for SkiaRenderer/WebView for case when viz is not enabled. This is not very well supported configuration, fixing to avoid crashes. Bug: 1057623 Change-Id: Ideb473d7c36bde4034a311c27e1210c27ee9acac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083732Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746087}
-
Robert Sesek authored
Bug: 1057369 Change-Id: Ie17d277b09c084eb224cb3228deb489d2ce96168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083434 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746086}
-
Sreerenj Balachandran authored
Make sure to use the VDEnc(Low-Power Fixed Function Encoder on IA platforms)for the VP9 encoder if the driver and hardware have the support. BUG=1057196 TEST=Run the VP9 encoder application on a TGL device and make sure the pipeline is using hardware acceleraton and not falling back to the software encoder. Change-Id: I8af6be2421eeef15cbc69715877b6d1559dde0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075879 Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#746085}
-
Yue Zhang authored
* Clean up code related to "Create group" button. * Make TabGroup M4 the default setup when TabGroup flag is on. * Remove out-dated feature checks. TBR=yusufo@chromium.org Bug: 1020711 Change-Id: I9fc289f75ba37b17077644bc7593da38924a0402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913718 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746084}
-
Xinghui Lu authored
Now that different profiles own their own url_lookup_service, identity_manager can be a reference inside url_lookup_service. This can make url_lookup_service more self-contained and reduce the number of parameters pass into safe_browsing_url_checker. Bug: 1050859 Change-Id: Ic5886460327d79df245b57e4ced967b14bf3b99a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071359 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
-
Leonard Grey authored
Bug: 1055953 Change-Id: I6e95e0304e2587cb24e3f5e3f302f6ea43cb59aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083591 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#746082}
-
rbpotter authored
Bug: 1026426 Change-Id: I35cc47e76a5fd46d2851fc3e4b1dd0ff390ea4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079542 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746081}
-
Vladimir Levin authored
This patch makes it so that the activation due to scroll to text is allowed to span multiple blocks. The activated element is the block at the beginning of the range. R=chrishtr@chromium.org Bug: https://github.com/WICG/display-locking/issues/125 Change-Id: I4223a59f8910175aaa5c1e877afd2d1e70f9ec93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083574Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746080}
-
John Budorick authored
Includes content_browsertests and chrome_public_test_apk. Bug: 1056878, 1056325, 1046059 Change-Id: Ic34ecb06a4ef9926bf0550a989df28e477330343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083596Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746079}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b780372797ea..e92ada58142f Created with: gclient setdep -r src-internal@e92ada58142f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1053586,chromium:1057083 Tbr: jbudorick@google.com Change-Id: Iebc75342b6c63a1ec636e4bde4a0519676902caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083616Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746078}
-
Esmael El-Moslimany authored
The https://chromium-review.googlesource.com/c/chromium/src/+/2076533 CL makes it so the promo is not loaded on the app page during tests. This is likely the cause of the flaky tests. Bug: 1056063 Change-Id: I86c8e17e13625a444e278e9d5f0fe78b78ce3cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083339 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746077}
-
Vasiliy Telezhnikov authored
It seems like on NVidia keeping reference to eglImage itself is not enough. When all siblings get deleted all future siblings texture are corrupted (like driver reuses this texture memory). This CL adds gpu driver workaround for NVidia to keep one sibling for the time of SharedImage is kept alive by client. After client calls DestroySharedImage this extra sibling is deleted allowing to clean up memory. As SharedImageBacking is kept alive only by representations after this moment there always will be at least one sibling inside them to prevent bug to occur. Bug: 1052114 Change-Id: Ie1714e1f696e4e59cc5fba12c15e421f694f1a25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080488Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#746076}
-
Tiancong Wang authored
This is an effort to only allow using cros orderfiles and thus hugepages on Chrome OS devices, by checking is_chromeos_device. Try to eliminate possibly of errors on unsupported platforms like linux-chromeos. BUG=chromium:1056198 TEST=linux-chromeos is not using orderfile anymore TEST=emerge chromeos-chrome still has orderfile with crrev.com/c/1995570 Change-Id: I0b394e6e0731e1236db80c77293c3c44afe19684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076404Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Aaron Gable authored
Mac10.14 Tests is now stable and green, and is ready to be promoted to the main waterfall alongside its prior-release siblings. This CL makes a few changes to accomplish that: 1) Updates the OS of the existing main waterfall Mac Builder to 10.14 2) Moves Mac 10.14 Tests to be triggered by Mac Builder 3) Moves it from just master (like all FYI bots) to exist in branch CI as well 4) Moves it from FYI to CI consoles This change leaves Mac Builder Next intact, so that it can be updated and used for 10.15 soon. Bug: 1018852 Change-Id: I3d5723ab7c565c37681696acb2f2de79ddcac1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036769 Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/416d37452275..a4347a9460bb git log 416d37452275..a4347a9460bb --date=short --first-parent --format='%ad %ae %s' 2020-03-02 capn@google.com Enable ASTC on supported builds only Created with: gclient setdep -r src/third_party/swiftshader@a4347a9460bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id0f5cc116f7de8f3cff80b013f9e0892cf1f717e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083620Reviewed-by:
-
Anastasia Helfinstein authored
Bug: 1057289 Change-Id: Id8130c2559b617a156925d5b431b4ac58e237fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080866 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746072}
-
John Budorick authored
Bug: 1054841 Change-Id: I482dce770a291718ea5d86b4b0e2633c7cbefc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080436 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The document element is always contained in LayoutView. The subsequence for LayoutView and the early return in full-cached situation in GraphicsLayer::PaintWithoutCommit() (for pre-CompositeAfterPaint) make the subsequence for the document element useless. This CL avoids paint chunks that were forced for the document element by the subsequence. These paint chunks are useless for layerization in CompositeAfterPaint because they should be always merged into the scrolling contents layer of the LayoutView, but had overall drawback on raster invalidation. Many paint invalidation web tests have raster invalidation clients and reasons. Some tests progress with less raster invalidation because of stabler paint chunk ids. paint/invalidation/css-grid-layout/grid-item-z-index-change-repaint.html regresses with more raster invalidation when the document element's negative-z-index children becomes positive-z-index, which is rare and acceptable. This is also a preparation of crrev.com/c/2070688 which will fix transparent background hit test in CompositeAfterPaint, to avoid extra paint chunks that would otherwise be created for the document element in that CL. Change-Id: Ic72c4ad4c1e0ce6cd967973b1158965f549580e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083380 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746070}
-
Hesen Zhang authored
- The deliver window should be within notification expiration config. Bug: 1057272 Change-Id: Ib859870d16a53f937ac8849d7cc989d08b86975e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079270Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746069}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I027ec43ea634324fab49339dd5e2eef0cc0eaf8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082608Reviewed-by:
-
Daniel Rubery authored
This CL moves the FileTypePolicies and associated code to components/safe_browsing/core. This is useful for fixing our measurement of the download warning CTR. In a future CL, I will refer to this code from components/download to record click throughs based on the UMA value for the download. Bug: 1053772 Change-Id: I47708b0395eee9997ebdaf01435993107e23b687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076416Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#746067}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff1896a1..93969500 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic99b55b6a34a039e41177c56299edd7f101989bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083651Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746066}
-
Andrey Kosyakov authored
... in the chain of URLLoaderFactory proxies. This ensures that DevTools network interception is closer to network and intercepts preflight requests produced by CorsURLLoader. The implementation relies on URLLoaderFactoryOverride introduced by crrev.com/c/1928100. Bug: 1027011, b/132267312 Change-Id: I9b5f629d5d92048d6d763ba743e3967f646b5d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073146Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746065}
-
Peng Huang authored
This is a reland of 334077c8 Original change's description: > Vulkan: support Android devices without Android hardware buffer > > Some Android P devices don't support vulkan extension > VK_ANDROID_external_memory_android_hardware_buffer. For those devices, > chrome will fallback to ExternalVkImageBacking which uses > VK_KHR_external_memory_fd extension or pixel copy for GL and Vulkan > inerop. > > Bug: 1049864 > Change-Id: I101a4c83a2dbfcfdbade29084a863e7563f631e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067290 > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#743931} Bug: 1049864 Change-Id: I8bfa463e06ee510203be1f66fbef1e7d46865869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078594Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#746064}
-
Daniel Campello authored
This new notification is originated when the attached power adapter does not supply enough power. BUG=b:147843861 TEST=deploy_chrome # Notification displays when power adapter is connected Change-Id: Ibb3852c584375d0ffa4ed99eb788fa1522fef80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078905Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Daniel Campello <campello@chromium.org> Cr-Commit-Position: refs/heads/master@{#746063}
-
Antonio Gomes authored
... now that the legacy IPC BeforeUnloadACK is no more. This CL is a follow up of [1], were dtapuska@ asked to move away from using the ACK terminology, now that it became a mojo completion callback. Basically, signature changes from OnBeforeUnloadACK() to BeforeUnloadCompleted(). [1] https://crrev.com/c/2010920 BUG=1042800 R=arthursonzogni@chromium.org TBR=kinuko@chromium.org Change-Id: Id4c5b41648d2f799a35ceb689660fefff6ee16ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079096Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#746062}
-
Sreerenj Balachandran authored
The current implementation of VA-API encoder follows static/hard-coded approaches to set the EntryPoint for the decode/encode/vpp pipelines. It shouldn't be a problem for decode & vpp since only one type of EntryPoint has been supported by the VA-API based UMDs. But it will mess up the logic of encoder pipeline. For eg: Some of the IA platforms (eg: KBL) support both VAEntryPointEncSlice and VAEntryPointEncSliceLP for H264(AVC). On the other hand newer platforms may only support VAEntryPointEncSliceLP. Upcoming TGL devices are perfect examples where we will only have the VAEntryPointEncSliceLP for VP9 encode. With out this proposed patch, the current chromium vaapi code base will only check the support of a VAEntryPointEncSlice for any non-JPEG encode profiles during the early stages of vaapi configuration and that will leads to software fallback and related issues. This patch tries to generalise the Entrypoint selection. For generic methods like GetSupportedProfiles (which will usually get invoked even before Initializing the accelerator so that upper level can switch between software and hardware encode), we query the driver for each profile+entrypoint combo and keep the order of EntryPoints as returned by the User Mode Driver. Selection of actual EntryPoint to be used for the encoding will happen later on, during the VaapiWrapper initialization. BUG=1057196 TEST= Manually, Run the H264 encoder applications on different platforms like Kabylake, Broadwell etc with VaapiLowPowerEncoder enabled. Kabylake should be utilizing the low-power encode(VAEntrypointEncSliceLP) and other older platforms should fall back to dual-pipe-encoder (VAEntrypointEncSlice). Check the VLOG,DVLOG outputs to ensure the entrypoint. Also run the VP9 encoder application on a platform where there is only VAEntrypointEncSliceLP support (eg: ICL, TGL) for the accelerated vp9 encoder and make sure the chromium media encoder pipeline is not falling back to the software. Change-Id: Ic80ad7a3dee0e32dd8de2a6a0f0094a3d28f40c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2075899 Commit-Queue: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Reviewed-by:
-
Ryan Hansberry authored
Before crrev.com/c/1899420, bluez informed Chrome each time an advertisement was received, even if nothing had changed about the advertisement from its previous instance. Once that CL landed, bluez switched to only informing Chrome of an advertisement when it was first found during a scan, or when metadata of the advertisement changed (i.e., RSSI, which can remain unchanged for several seconds). This CL accounts for that new behavior by informing observers an advertisement has been received on the DeviceAdded() event. I ran an Instant Tethering scan 50 times without this patch, and 50 times with it, and recorded time taken to find an expected BLE advertisement (found in chrome://histograms): * Without patch: * Mean: 4436 ms. * Median: 1680 ms. * 75th percentile: 11135 ms. * 95th percentile: 12185 ms. * With patch: * Mean: 636 ms. * Median: 522 ms. * 75th percentile: 895 ms. * 95th percentile: 1838 ms. Fixed: b:149945805,1051769 Change-Id: I73dc1d5678d166a6ce443ddfda76c34212aa92aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071377Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#746060}
-
Paul Moy authored
Add a new device command to send a command to an existing diagnostic on the platform and get back an update from the diagnostic. Bug: chromium:1049762 Test: DeviceCommandGetRoutineUpdateJobTest.* Change-Id: I011c320ef242304a403dfb200e0a15b92f0db45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076521 Commit-Queue: Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#746059}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae92244054c4..f52d3ed084e3 git log ae92244054c4..f52d3ed084e3 --date=short --first-parent --format='%ad %ae %s' 2020-03-02 srte@webrtc.org Adds transport overhead to route changes in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@f52d3ed084e3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0df7beef79e7aeda475e8868868992a2465e4a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083618Reviewed-by:
-
Jun Cai authored
This CL converts base::Bind and base::Callback in //ppapi/thunk to Once or Repeating Bug: 1007819 Change-Id: Ib46aaf7a3465a0e9e55b73d58e73e6ed905cabac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078906 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#746057}
-
Fredrik Söderquist authored
Allow checking for an array of values rather than a single value. This clears up the situation where different UAs support different (and disjoint) sets of values for a property. In this case 'image-rendering'. Also adjust assertPresentationAttributeIsNotSupported(...) such that the assert description makes more sense by adding a negation. Bug: 1056055 Change-Id: Ibe5cddb09f242754f02aa96b4bc8571f2aabecf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082557Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#746056}
-
Yulun Wu authored
Change-Id: I5b56232b66fff49739500a171a28615be96f0b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079458 Commit-Queue: Yulun Wu <yulunwu@chromium.org> Auto-Submit: Yulun Wu <yulunwu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#746055}
-
Nate Fischer authored
This fixes an inverted boolean: I meant to workaround bad cookies for apps targeting < R, not apps targeting >= R. Bug: 1052058 Test: Manual - log the value and launch com.discoverfinancial.mobile Change-Id: I3d0007fdabcf366ec91739673883e9cffd335fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081362 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#746054}
-
Shakti Sahu authored
We never called Delete on the temporary directory created for this test. Added delete call on teardown. Change-Id: I186a798e63545daa55c4c196219202951e24bc43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082881Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746053}
-
Haiyang Pan authored
Some of tests in chrome_public_test_apk requires play store to be installed. The rest of test suites will stick with google_apis images, as some of them need root permission to run tests. Bug: 1057150, 1048781, 922145 Change-Id: I210b7b69ca5e5827abca0fd0ba90a89ddcb9d6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072408Reviewed-by:
-
Vincent Boisselle authored
The fix consists to let the SyncAuthManager do a retry to fetch the access token when the first request is canceled. Bug: 1050313 Change-Id: I173830f5b28b9fe2ec2a2d67032b52fc2eef344e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062294 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#746051}
-
