- 13 Feb, 2020 40 commits
-
-
Alan Cutter authored
This is a reland of 41647287 When is_chrome_branded build flag is true the kPassiveMixedContentWarning runtime flag is disabled. Original change's description: > Instantiate missing hosted_app_browsertests > > This CL fixes the following warnings thrown by browser_tests: > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppTestWithAutoupgradesDisabled> > [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<HostedAppPWAOnlyTestWithAutoupgradesDisabled> > > Change-Id: Iebf53094d7909a16ccd07e9e6150d600203ba5c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053225 > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740919} Change-Id: I661cfc1b2cefb6f3622e9b19f5dc5bdf328204ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053679 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#741245}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/fbbf981a3401..6f95788326bb git log fbbf981a3401..6f95788326bb --date=short --first-parent --format='%ad %ae %s' 2020-02-13 tmathmeyer@chromium.org Fix scrolling bugs by switching to plain DataGrid Created with: gclient setdep -r src/third_party/devtools-frontend/src@6f95788326bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051517 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id8070756b5976d7107ea71803527ce5a954ba3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055489Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741244}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eceeb201f72b..e90568eeef90 git log eceeb201f72b..e90568eeef90 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 bclayton@google.com Update Marl to a047dd0bb Created with: gclient setdep -r src/third_party/swiftshader@e90568eeef90 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifd821e45eeec7b2badbf0db98b3516308b69860d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055486Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e61ca55caf34..0b15317ba70c git log e61ca55caf34..0b15317ba70c --date=short --first-parent --format='%ad %ae %s' 2020-02-13 rmhasan@google.com [Typ] Add setter for lineno in Expectation instance Created with: gclient setdep -r src/third_party/catapult@0b15317ba70c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:986447 Tbr: skyostil@google.com Change-Id: I425b8914f4f570ec63d88eb333dcb024a5c8f560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055490Reviewed-by:
-
Oriol Brufau authored
This reverts commit 7b72bfb4. Reason for revert: not web compatible, too much breakage Original change's description: > [css-grid] Accommodate spanning items crossing flexible tracks > > The specification added a step to increase sizes to accommodate spanning > items crossing flexible tracks instead of ignoring their contents > completely. This is done after handling all grid items that don't cross > such tracks, and this time items are considered together, not grouped by > their span size. > > This is a reland of r705228, which was reverted due to a performance > regression. The main problem was that non-spanning items in flex tracks > have to be handled with a variant of the algorithm for arbitrary spans, > which was much slower. But now that has been greatly improved by > r714511 and r715665. I have also refactored the patch to avoid worsening > the performance of spanning items that don't cross flex tracks. > > However, the algorithm for arbitrary spans is still a bit slower than > the one for span of 1. Therefore the nested-grid perf test will decrease > by ~5%. This is expected since it has lots of non-spanning items in > flexible tracks, that will now be handled with the arbitrary span algo. > > Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items > > BUG=935102 > > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html > TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html > TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html > > Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Sergio Villar <svillar@igalia.com> > Reviewed-by: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Manuel Rego <rego@igalia.com> > Cr-Commit-Position: refs/heads/master@{#719104} TBR=jfernandez@igalia.com,rego@igalia.com,svillar@igalia.com,obrufau@igalia.com Bug: 1051039, 935102 Change-Id: I6f1fd18fd8f0f1e43acbac9bb47a6d2925b7c2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055623Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#741241}
-
Luciano Pacheco authored
Change column header to: 1. Text elide with ellipsis. 2. Remove some additional width from the resize dragger. 3. Remove additional margin for the size column which aligns right. These fix the issue where the sorting arrow icon background was being cut by the dragger icon. Bug: 992821 Change-Id: Ie3582d2e5f446104d9defb40626b609030730984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053651 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741240}
-
Daniel Rubery authored
We should be reporting unscannedFileEvents for all statuses that indicate the file was not scanned. We also should report unscannedFileEvents if the status is correct, but the response proto indicates failure. Bug: 1045986 Change-Id: I7a725dd16795f875ec509a183ff452577f7058cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050963Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#741239}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bee77f5..e3ebc4f9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I06dff4c4dca83311a40be5dc0147f1fd85e8d328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055703Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741238}
-
Gil Dekel authored
Certain chromebooks now come with panels that have integrated privacy screens on them. This CL introduces user and device policies for the now supported privacy screen feature. Bug: b:146234183, b:138397511 Change-Id: Id0aae80535524fea5d3470b9f66065911ab5a7de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045158 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Cr-Commit-Position: refs/heads/master@{#741237}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b79b57e047bb..ef599fb0f431 git log b79b57e047bb..ef599fb0f431 --date=short --first-parent --format='%ad %ae %s' 2020-02-13 cclao@google.com Vulkan: Fold glClear into draw call when command graph is disabled 2020-02-13 cnorthrop@google.com Capture/Replay: Track and restore mapped buffer data Created with: gclient setdep -r src/third_party/angle@ef599fb0f431 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ic2c8252fc7a9e476c1d8bb9896ef6e43e867f959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055484Reviewed-by:
-
Wez authored
--test-launcher-jobs should normally only be passed on the test command- line if it was specified on the runner-script's command-line. However, if the test has |enable_test_server| set then the number of test jobs and test server instances must match, so in that case we assume that the test uses the TestLauncher, and set --test-launcher-jobs based on either the number of CPU cores specified for QEMU to emulate, or on a fixed default concurrency level if running on a device. Change-Id: Ic8e226b1ad832463471da051aaac6f8aaf38b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052125 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#741235}
-
Darwin Huang authored
Mention where to find fuzzing coverage of sqlite tools, which are especially helpful right after importing new sqlite releases into Chrome. sqlite Fuzzing coverage tools should be more easily discoverable by Chrome's sqlite maintainers with this called out specifically in the sqlite/fuzz/README.md. Change-Id: I5b876e2fe486719aae8190eef48f34c22b13b6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053767 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#741234}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0ffd42151c6..04a7136fd704 Created with: gclient setdep -r src-internal@04a7136fd704 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iecad1f90fcd13b1ba644e9ddd08406b15405575d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055487Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741233}
-
Daniel Clark authored
Prior to this CL, when changing the displayed month in datetime-local/date/week via the month switcher menu or the prev/next month buttons, the selection did not update. This caused an issue for keyboard selection: if the user changes the month via keyboard and then tries to adjust the selected day, the calendar will jump back to the old month because the selection is still in the old month. This change fixes the issue by moving the selection to the new month whenever the month is changed. This change also fixes the 'm'/'y'/'d' hotkeys, which were not pushing updates to the in-page control. The (benign) accessibility tree changes are due to the addition of the click handler to the popup document's body element. Bug: 1047439 Change-Id: I420833cc4036a5215674dab7cec269218672193d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040550Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#741232}
-
Sven Zheng authored
Now Skia Gold can make comments on gerrit, so it's time to move this out of fyi. Bug: 958242 Change-Id: I1274cc5da4feb7e9904bf788b9d9d7633dfeac5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053803Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741231}
-
Dave Tapuska authored
Use ui/gfx's typemapping directly there is now no need for blink to override it. Change-Id: I948329f32637dfefe2920535fd8bb3e808092a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055345 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741230}
-
Avery Musbach authored
You shall not be able to enter overview by pressing the overview button with one finger, while dragging the split view divider with another finger. See the video linked on Monorail. Test: manual Change-Id: I779e20fcc951d44355ee4c05d71e5bac1c83024f Fixed: 1051758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055735Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741229}
-
Lei Zhang authored
Add end-to-end tests to make sure printing PDFs with line caps and line joins to PostScript printers on Windows works correctly. Bug: 1049410 Change-Id: I92e2b22f49ad7e70660d34252b8224031ef03583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044996Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741228}
-
Sam Bowen authored
We will use these types from both blink and //content and from code inside //components. This patch affects Clank downstream and will be submitted together with a patch in that repo to avoid breakage. Clank CL: https://crrev.com/i/2545991 See discussion in design doc: https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit# Bug: 1044252 Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#741227}
-
Robert Sesek authored
Bug: 710376, 778317 Change-Id: Ifc5cd2a0d961c3503a7732252398cdd24f30fcf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053929Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741226}
-
behdad authored
The tests are way less likely to fail as a result of noise TBR=Crouleau@chromium.org Bug: chromium:1052054 Change-Id: I55d29c2de1ef72db5315c1d792dd7fd9c67f5d3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055047Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#741225}
-
Lukasz Anforowicz authored
Bug: 1049604 Change-Id: Ice20cf9ed6539d531d6e771013d1ef34e7d9635f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054295 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#741224}
-
Mitsuru Oshima authored
* Moved directories: ash/components/fast_ink -> ash/fast_ink ash/components/cursor -> ash/fast_ink/cursor ash/laser -> ash/fast_ink/laser Rationale: fast_ink is a framework that can bypass native ui's cc and /cursor and /laser are clients of this framework. * Consolidated OWNERS to one Bug: 1046624 Change-Id: I8c9475e4ccf4413b6626975f65479f87af51bed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050843Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#741223}
-
Ehsan Kia authored
Screenshot: https://screenshot.googleplex.com/7ZyeNAwxjxC.png Bug: 1052026 Change-Id: Ie0e5f58b03e1fdc21d2c6dafc1c6990636b2ebc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054564 Commit-Queue: Ehsan Kia <ehsankia@google.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#741222}
-
Katie Dektar authored
This reverts commit b3bd6f98. Reason for revert: Speculative fix for crbug.com/1052142: Landing this coincided with MSAN failures in BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioDefaultName BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioRuleId Original change's description: > tracing: Update to latest TrackEventDescriptor message and roll Perfetto > > git log f440b92c2422..02808dc0a181 --date=short --first-parent --format='%ad %ae %s' > 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Add configuration for TrackEvent" > 2020-02-12 fmayer@google.com Merge "Roll trace_to_text to pick up aosp/1232924" > 2020-02-12 skyostil@google.com Merge "TrackEvent: Implement dynamic categories" > > Created with: > gclient setdep -r src/third_party/perfetto@02808dc0a181 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: None > Tbr: perfetto-bugs@google.com > Change-Id: Ia7577abef7435e6ef8a37ac3a42b94363c44c986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054248 > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> > Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741071} TBR=skyostil@chromium.org,nuskos@chromium.org Change-Id: Ib11cfbd9a29aa21515b64d322128a9ddbac8360c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055592Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741221}
-
Adrienne Walker authored
Devtools was using this interface, and when IndexedDB moves to the storage service, it will need to access it via mojo instead. This creates a function for observing IndexedDB changes on the IndexedDBControl interface and replaces users and tests. The IndexedDBDispatcherHostTest tests are disabled and were both broken (identically without this change). They are updated to at least pass, although enabling them will be done in a followup to avoid getting this reverted. Bug: 1015214 Change-Id: I455d06545e9bbc780173244846b7e801f6bae2cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052768 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#741220}
-
Katie Dektar authored
This reverts commit 67a641bc. Reason for revert: Need to revert this roll in order to revert the roll which may have caused crbug.com/1052142. Original change's description: > Roll src/third_party/perfetto 02808dc0a181..465b5e722d31 (9 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/02808dc0a181..465b5e722d31 > > git log 02808dc0a181..465b5e722d31 --date=short --first-parent --format='%ad %ae %s' > 2020-02-13 treehugger-gerrit@google.com Merge "perf sampling: minimal UI for stacks as slice columns" > 2020-02-13 hjd@google.com Merge "Fix Mac compile of api_integrationtest.cc" > 2020-02-13 fmayer@google.com Merge "Remove stale comment." > 2020-02-13 lalitm@google.com Merge "tp: make diff testing script run all tests by default" > 2020-02-13 lalitm@google.com Merge "tp: cleanup diff test script in preperation for unified execution" > 2020-02-13 ddrone@google.com Add frame_tree_node_id to LatencyInfo.Flow event > 2020-02-12 treehugger-gerrit@google.com Merge "processor: Override/extend args correctly when merging" > 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Register available categories with service" > 2020-02-12 treehugger-gerrit@google.com Merge "UI: update logo and sidebar animation" > > Created with: > gclient setdep -r src/third_party/perfetto@465b5e722d31 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:148777631 > Tbr: perfetto-bugs@google.com > Change-Id: I60adf3a7482a2df1c8419eb6916812a7bfa6035c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053302 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#741125} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: Idf533af0c122b7c71e74280b0fd87c1638d35abd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:148777631,1052142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055556Reviewed-by:
-
Sasha McIntosh authored
Initially this DCHECK was placed to prevent an increase in case #3, checking quads against the target space occluding region. This case is not a particularly high cost computation and is still relatively uncommon. The occluder in conentspace region may be empty if the target space occluding rect is reduced to 0 after mapping into content space. Bug: 1051922 Bug: 1051566 Change-Id: Iffd3433a7bf38be9951479c0d8d4c0d5f2b93dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053410Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#741218}
-
James Cook authored
Be explicit about whether or not browser sync consent is required when looking up the IdentityManager primary account. Updated: * kiosk mode tests * login / user session * device local account tests * plugin vm See go/cros-primary-account and go/consent-aware-api-dd Bug: 1042400, 1046746 Test: existing browser_tests Change-Id: I0f272f7bbcc2a4b0378cdf0e3590491617fe62a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054275Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#741217}
-
Dan Harrington authored
This indicates how important the request is. Bug: b/149323794 Change-Id: I23bd7177a89fa1122c9365268e1cffc45a4c9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055025Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#741216}
-
Katie D authored
This test appears to be flaking frequently: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyaAsSBUZsYWtlIl1jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFByZXJlbmRlckJyb3dzZXJUZXN0LlByZXJlbmRlckNhbmNlbE1haW5GcmFtZVJlZGlyZWN0VW5zdXBwb3J0ZWRTY2hlbWUM TBR=tbansal@chromium.org,darin@chromium.org Bug: 1050143 Change-Id: I6fec8b6c4f1262c6884ad05be9be28e69775f805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055670Reviewed-by:
-
Nate Chapin authored
Bug: 1051106 Test: fast/animation/animation-constructor-after-detach-crash.html Change-Id: I1024e2c28d4ceafa22b738d20bdcc59144b20773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055396 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
behdad authored
Added more instructions on skipping representative perf tests stories. Bug: chromium:1044705 Change-Id: Ic17b8ccbf345f4be207e0aa25c9a4fdfb0b1350c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035855 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
This flag was introduced by https://crrev.com/c/533895, but not set correctly. Bug: 732874 Change-Id: Ide151862a74cfeff575517e07ce3652fee201021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053743Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741212}
-
David Munro authored
Test: Manual Bug: None Change-Id: I14fbb5586dd2cef623f37c76f392a1719a775968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053668Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#741211}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I6c6ed4e09bd52e2d9ca2fbec3a17e2a18368cffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055386Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#741210}
-
David Tseng authored
Also: - fixes the handling of menuItemSelected to only be respected from a focused node (Chrome now fires it more noisely) - add a full test suite for options page testing which drives the UI end to end and verifies local ChromeVox state (this motivated the above fix) - noticed a regression in the way <select> nodes work (TODO'ed and not handled fixing in this change) - adds a unit test for verifying number style reading behavior Test: see above Change-Id: I4dce435c6de54399128c1a21f805671b54ac3904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003895 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#741209}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I3ff44841ffcccb679698f1572372b157454b03c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054566Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741208}
-
Shakti Sahu authored
This CL disables SurfaceView for ThinWebView since currently we have an issue with surface control in Q which breaks this feature. https://chromium-review.googlesource.com/c/chromium/src/+/2029240 will fix this, but it will land in M82. Hence disabling SurfaceView for now so as to unblock features like ephemeral tab. Bug: 1024622 Change-Id: Id6825934bd2270e6b45d66c2f3e9aa6db9dadf76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048507Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741207}
-
Sammie Quon authored
Moves a couple non-splitview tests from SplitViewOverviewSessionTest to TabletOverviewSessionTest. This has less setup and functions, it works well enough for the moved tests. Test: ash_unittests Bug: none Change-Id: I6874fa8906895f8dc3279a3918544ad582f756c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053085 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#741206}
-
