GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266107 0039d316-1c4b-4281-b951-d872f2087c98

This change cleans up some code in pnacl_coordinator and pnacl_resources to
remove code that can't be reached and simplify error reporting paths. This is
in preparation for moving all of this code out of the trusted plugin.

BUG=239656

Review URL: https://codereview.chromium.org/257463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266106 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266104 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add support for more ASAN errors generation to chrome://crash/... (https://codereview.chromium.org/247543002/)

Reason for revert:
This break the debug build.

Original issue's description:
> Add support for more ASAN errors generation to chrome://crash/...
> 
> Adds the following crash url to chrome/chromium builds when SYZYASAN is defined (built with syzyasan=1 in GYP_DEFINES):
> heap-corrupted-block
> 
> This allows easy validation of the instrumentation/reporting for a given build without having to track down a known/unfixed memory error.
> 
> 
> R=chrisha@chromium.org
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265942

TBR=chrisha@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/250793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266101 0039d316-1c4b-4281-b951-d872f2087c98

Call StopListening() during the Shutdown phase instead of calling it
in the destructor. This fixes a DCHECK failure during browser shutdown
when the PortForwardingController tries to access a BrowserContext
that's been destroyed.

BUG=366698

Review URL: https://codereview.chromium.org/258433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266100 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/257583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266099 0039d316-1c4b-4281-b951-d872f2087c98

Listen to Ctrl key in FileManager, and when gear menu is opened while Ctrl key is pressed, the gear menu is shown as secret mode.
The drive-related setting items will be shown only when gear menu is in secret mode and drive volume is focused.
Drive-related settings are now implemented as Comands to be consistent with other menu items.

BUG=239365

Review URL: https://codereview.chromium.org/243013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266098 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347832

Review URL: https://codereview.chromium.org/243703009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266097 0039d316-1c4b-4281-b951-d872f2087c98

This fixes a bug where the bubble disappears when the window resizes.

BUG=366215

Review URL: https://codereview.chromium.org/251373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266096 0039d316-1c4b-4281-b951-d872f2087c98

When switching modes, we disable CRTCs that do not fit on current freamebuffer,
change framebuffer size, then enable required CRTCs in the right locations.
This fails in a switch from extended desktop to mirror mode, e.g. from
1366x768+1920x1080 to 1024x768 mirrored. Both CRTCs fit into current framebuffer
but they are smaller than the framebuffer we are about to resize to (1024x768)
so XRRSetScreenSize(1024,768) call fails because it cannot shrink framebuffer
size below size of currently enabled CRTCs. The solution is to disable CRTCs
that are bigger than minimum of current and new framebuffer.

BUG=chromium:366280
TEST=switch between mirror and extended desktop on Link or Squawks. Screen size\
(in DISPLAY=:0.0 xrandr --verbose) should shrink when switching to mirror mode.
R=djkurtz@chromium.org
R=oshima@chromium.org
Signed-off-by: Dominik Behr <dbehr@chromium.org>

Review URL: https://codereview.chromium.org/253513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266095 0039d316-1c4b-4281-b951-d872f2087c98

This change is motivated by the need to set the test install attributes before the browser policy connector is initialized for the first time. In particular, test class members may cause the policy connector to be initialized in their constructors, so we also need to set the install attributes in the constructor of a member.

BUG=243341

Review URL: https://codereview.chromium.org/247283007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266094 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266092 0039d316-1c4b-4281-b951-d872f2087c98

> Moves the notification icon out of the status area overflow.
>
> This only happens the first time it is created per data dir,
> so that the user can change back their setting if desired.
>
> This approach uses COM to talk with Windows Explorer to
> change the user's notification area preferences.
>
> R=dimich@chromium.org
> BUG=347693
>
> Review URL: https://codereview.chromium.org/110693004
>
> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265807 0039d316-1c4b-4281-b951-d872f2087c98

BUG=347693

Review URL: https://codereview.chromium.org/252513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266091 0039d316-1c4b-4281-b951-d872f2087c98

Includes logging to help diagnose web_components_unittest flake.

BUG=365739
TBR=dsinclair

Review URL: https://codereview.chromium.org/256603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266090 0039d316-1c4b-4281-b951-d872f2087c98

The request to create a fallback OutputSurface should always succeed
and there's no way to leave compositing mode. So remove this capability
from cc and instead just LOG(FATAL) if the fallback OutputSurface
ends up being NULL.

The only case where the fallback OutputSurface isn't created is in the
ChromeOS browser compositor, and in this case the
GpuProcessTransportFactory will LOG(FATAL) before cc even finds out,
so this new LOG(FATAL) should never be hit in practice, but documents
our expectations.

This removes the call to WebWidget::didExitCompositingMode.

R=enne
BUG=366130,266666

Review URL: https://codereview.chromium.org/256573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266089 0039d316-1c4b-4281-b951-d872f2087c98

As the flakiness on the temporary random directories creation was solved
by using base::rand_util on crrev.com/15479003, the number of folders
can be increased back.

BUG=NONE

Review URL: https://codereview.chromium.org/251493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266088 0039d316-1c4b-4281-b951-d872f2087c98

Add optional ET_GESTURE_MULTIFINGER_SWIPE detection to the unified
GestureDetector implemenation.  This is currently used only on Aura.

BUG=354397

Review URL: https://codereview.chromium.org/243403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266087 0039d316-1c4b-4281-b951-d872f2087c98

Add an entry in about flags to facilitate turning on the Suggestions service.

BUG=366263

Review URL: https://codereview.chromium.org/250033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266086 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org,mek@chromium.org
BUG=351958,361116

Review URL: https://codereview.chromium.org/227413008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266085 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue with the app list folder name view where the
textfield bounds was a pixel too small due to the caret width.

BUG=359415

Review URL: https://codereview.chromium.org/255583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266084 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266083 0039d316-1c4b-4281-b951-d872f2087c98

Include the following CLs:

Implement AES in different modes of operation, using AES-NI and
PCLMULQDQ-NI, for WIN32 and WIN64 platforms. Only the WIN32 assembly
code is used right now.
https://codereview.chromium.org/250463004/

R=agl@chromium.org,rsleevi@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/259643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266082 0039d316-1c4b-4281-b951-d872f2087c98

This change defines and implements and observer for the component
update service and refactors the existing code to use it. No new
events of features have been added here. More changes will follow to
make the observer usable by chrome://components

BUG=366388

Review URL: https://codereview.chromium.org/251403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266081 0039d316-1c4b-4281-b951-d872f2087c98

It's entirely possible for the channels to be in other states, such as
ready.

BUG=none
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/252543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266080 0039d316-1c4b-4281-b951-d872f2087c98

The refresh crash was getting in the way of debugging and reproducing the node
browser issue.  This CL fixes both at once.

The refresh crash happened because the SyncInternalsMessageHandler will retain
its state across a refresh, but the JavaScript code it talks to will not.  The
message handler will receive a second message from the JavaScript code to
inform it that it's time to register with the ProfileSyncService.  This CL adds
a check to ensure that this double-request will not result in
a double-registration.

The node browser issue was caused by a mismatch between the C++ and JavaScript
APIs.  The C++ side passed an array of arguments, but the JavaScript code was
expecting the two arguments to be passed separately.

BUG=363300,360197

Review URL: https://codereview.chromium.org/248153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266079 0039d316-1c4b-4281-b951-d872f2087c98

* Use Oobe.addUserForTesting instead of chrome.send
* Merge multiple invocations of EvaluateJavaScriptInContext
* Take a screenshot if we time out on finding _GaiaLoginContext
* Increase timeout to find _GaiaLoginContext.
* Add a disabled test - test is disabled since it hits live gaia.

BUG=361862
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/252643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266078 0039d316-1c4b-4281-b951-d872f2087c98

The new struct is used to pass parameters to StreamParser::InitCB. This
change makes it easier to add new parameters.

BUG=338529
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/254473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266077 0039d316-1c4b-4281-b951-d872f2087c98

This removes the need to read from the scanout buffer. Doing that is really, really slow.

TEST=chrome --ozone-platform=dri on pixel
BUG=366205
NOTRY=true

Review URL: https://codereview.chromium.org/249413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266076 0039d316-1c4b-4281-b951-d872f2087c98

The bug happens because kiosk command switches is in place after
profile is loaded. As a result, CCD app is loaded.

BUG=366382

Review URL: https://codereview.chromium.org/256633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266075 0039d316-1c4b-4281-b951-d872f2087c98

It looks like the error that the windows dom_perf tests are hitting could be
caused by improperly closing the socket, which this might fix.

error: [Errno 10053] An established connection was aborted by the software in your host machine

BUG=335624

Review URL: https://codereview.chromium.org/259623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266074 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365235

Review URL: https://codereview.chromium.org/257463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266073 0039d316-1c4b-4281-b951-d872f2087c98

This seems to have broken views_unittest (label_unittest) on ChromiumOS

> Automatically call OnNativeThemeChanged when a widget is added to a hierarchy
> with a widget.
> 
> Split off from https://codereview.chromium.org/245863002/
> 
> BUG=347832 (tangentially)
> 
> Review URL: https://codereview.chromium.org/248073005

TBR=estade@chromium.org

Review URL: https://codereview.chromium.org/256683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266072 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366504

Review URL: https://codereview.chromium.org/255513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266070 0039d316-1c4b-4281-b951-d872f2087c98

BUG=366750

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266069 0039d316-1c4b-4281-b951-d872f2087c98

Test must be disabled because the time range values will change
and binary files don't land well through CQ :(

BUG=366750
TEST=none
TBR=acolwell
NOTRY=true

Review URL: https://codereview.chromium.org/252633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266067 0039d316-1c4b-4281-b951-d872f2087c98

This CL exists as an effort to actually land
https://codereview.chromium.org/225513005/.

This applies a small fix to the hid_service_win.cc module.

BUG=359560
TBR=rpaquay
TBR=jracle@logitech.com

Review URL: https://codereview.chromium.org/256673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266066 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=NONE

Review URL: https://codereview.chromium.org/253343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330735

Review URL: https://codereview.chromium.org/246633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266059 0039d316-1c4b-4281-b951-d872f2087c98

Remove the WCHAR_T_IS_UNSIGNED definition since it is not really useful. Replace its use with a static_cast.

BUG=354405
NOTRY=true

Review URL: https://codereview.chromium.org/248843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266058 0039d316-1c4b-4281-b951-d872f2087c98

There are no changes in implementation in this CL. This is in preparation
for making IPC::Channel support filters on the Channel's thread.

BUG=364241
TBR=cpu@chromium.org,nduca@chromium.org

cpu: OWNERS for win8
nduca: OWNERS for components/tracing

Review URL: https://codereview.chromium.org/245443005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266057 0039d316-1c4b-4281-b951-d872f2087c98