GitLab

I meant to remove this in https://codereview.chromium.org/1138933004

BUG=486220
TEST=Android apptest runner doesn't crash with argument error.
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1124103008

Cr-Commit-Position: refs/heads/master@{#329898}

Changes to more closely match GetCharacterFromKeyCode().

BUG=44048

Review URL: https://codereview.chromium.org/1108893002

Cr-Commit-Position: refs/heads/master@{#329897}

https://chromium.googlesource.com/chromiumos/chromite/+log/bf808553f8da8a477bce5d5bb80a8af8939e6e73..c9bfb471ec08e85d0c8baa35341403013153956c

Pulls in fix for wrong .cros_cache location (see https://chromium-review.googlesource.com/266580).

BUG=brillo:1036
TEST=cros chrome-sdk --board=link [from chromium/src]
TBR=namnguyen

Review URL: https://codereview.chromium.org/1146443002

Cr-Commit-Position: refs/heads/master@{#329896}

BUG=472256

Review URL: https://codereview.chromium.org/1132093003

Cr-Commit-Position: refs/heads/master@{#329895}

BUG=chromium:487455
TEST=None

Review URL: https://codereview.chromium.org/1131063006

Cr-Commit-Position: refs/heads/master@{#329894}

These were needed to get a clean build working.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1129193005

Cr-Commit-Position: refs/heads/master@{#329893}

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/1136713003

Cr-Commit-Position: refs/heads/master@{#329892}

Revert of Move token handle obtaining to UserSessionManager (patchset #1 id:1 of https://codereview.chromium.org/1129293004/)

Reason for revert:
most likely culprit for interactive ui test failures here: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/2847

Original issue's description:
> Move token handle obtaining to UserSessionManager
>
> BUG=484690,484734
> R=nkostylev@chromium.org
>
> Committed: https://crrev.com/71ede7fdaf6404ec0f70a60d60f679fee07902a9
> Cr-Commit-Position: refs/heads/master@{#329868}

TBR=nkostylev@chromium.org,antrim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484690,484734

Review URL: https://codereview.chromium.org/1140823007

Cr-Commit-Position: refs/heads/master@{#329891}

* Add host parameter to QuicTestPacketMaker constructor to allow for non-default
  hostnames in generated packets.
* Change hostname in QuicNetworkTransactionTest.SecureResourceOver* in
  anticipation for a future CL that will enforce certificate validation in these
  unittests.
* s/kServerHostname/kDefaultServerHostName/ in QuicHttpStreamTest to match
  QuicStreamFactoryTest.

BUG=474217

Review URL: https://codereview.chromium.org/1142523004

Cr-Commit-Position: refs/heads/master@{#329890}

Implement SubframeTask to represent out-of-process iframes.

R=nick@chromium.org
BUG=470988

Review URL: https://codereview.chromium.org/1137183002

Cr-Commit-Position: refs/heads/master@{#329889}

This change adds a new member to ui::DisplaySnapshot, 'product_id',
which is populated from the EDID in DrmDisplaySnapshot when it is
created.

DisplaySnapshot::product_id() is then turned into a hexadecimal string
and used to try and load an ICC file from a common path.

BUG=471749
TEST=On a link_freon system blue-vcgt-test-color-profile.icc was copied into
/usr/share/color/icc/30e400000000.icc and the system rebooted and the display
was observed tinted blue.

Review URL: https://codereview.chromium.org/1129863003

Cr-Commit-Position: refs/heads/master@{#329888}

The results param was needed in shared_state.TearDownState() because of
page_test.DidRunTest hook. Now that hook is removed, we no longer need to
provide access to the results object in this method.

BUG=435757

Review URL: https://codereview.chromium.org/1140143002

Cr-Commit-Position: refs/heads/master@{#329887}

Revert of Roll ASan/Win to LLVM r237003 (patchset #1 id:1 of https://codereview.chromium.org/1140623002/)

Reason for revert:
Caused build hangs.
BUG=487929

Original issue's description:
> Roll ASan/Win to LLVM r237003
>
> Brings in coverage support for Windows.
>
> Green build with this revision:
> http://build.chromium.org/p/chromium.fyi/builders/CrWinAsan%20tester/builds/217/steps/gclient%20runhooks/logs/stdio
>
> TBR=inferno@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/9f05e50063c1c643ecbe7851dc388b6346414c08
> Cr-Commit-Position: refs/heads/master@{#329280}

TBR=rnk@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1134413003

Cr-Commit-Position: refs/heads/master@{#329886}

Currently HostResolverImpl tries to probe IPv6 support for every
Resolve() request, i.e. very often. The probe is implemented using
a dummy UDP socket. This doesn't look efficient because IPv6 state
doesn't change often.

Also this change will decrease frequency of the crash in the linked bug.
In that bug the root cause is that on OSX system certificate library may
close recently created file descriptors it doesn't own. Not creating
dummy UDP sockets very often will help to avoid hitting this bug in the
OS very often.

BUG=481163

Review URL: https://codereview.chromium.org/1138833003

Cr-Commit-Position: refs/heads/master@{#329885}

TEST=TaskSwitchTimeTrackerTest.HasLastActionTimeShouldBeFalseAfterConstruction
TEST=TaskSwitchTimeTrackerTest.HasLastActionTimeShouldBeTrueAfterOnTaskSwitch
TEST=TaskSwitchTimeTrackerTest.RecordAfterTwoTaskSwitches
TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesFromTheShelfAreRecorded

BUG=469359, 471356

Review URL: https://codereview.chromium.org/1133123003

Cr-Commit-Position: refs/heads/master@{#329884}

Change QuicNetworkTransactionTest::RunTransaction() and
QuicNetworkTransactionTest::CheckResponseData() signatures to take
HttpNetworkTransactions by scoped_ptr const reference instead of naked pointer
to match four other members of the same testing class.

BUG=474217

Review URL: https://codereview.chromium.org/1130003005

Cr-Commit-Position: refs/heads/master@{#329883}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5b15054..f51ed3b

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1131273003

Cr-Commit-Position: refs/heads/master@{#329882}

otherwise the visibility state gets out of sync

BUG=471670
TEST=CursorWindowControllerTest.VisibilityTest

Review URL: https://codereview.chromium.org/1137303004

Cr-Commit-Position: refs/heads/master@{#329881}

Review URL: https://codereview.chromium.org/1136353002

Cr-Commit-Position: refs/heads/master@{#329880}

BUG=487689
TEST=these crashes stop

Review URL: https://codereview.chromium.org/1139943003

Cr-Commit-Position: refs/heads/master@{#329879}

There exists lots of tracing for the old CAOpenGLLayer path in
ui::IOSurfaceLayerHelper. The new path doesn't have this tracing.

This adds tracing for the swap state (this is the pseudo-thread
counter corresponding to PendingSwapAck in ui::IOSurfaceLayerHelper,
along with trace events for the important functions related to swaps
on Mac.

BUG=487882

Review URL: https://codereview.chromium.org/1137093003

Cr-Commit-Position: refs/heads/master@{#329878}

BUG=409158
TEST=manual

Review URL: https://codereview.chromium.org/1135293002

Cr-Commit-Position: refs/heads/master@{#329877}

Fix one more instance of an OWNERS file living in an empty subdirectory
of the directory it is supposed to be setting the owners of.

Review URL: https://codereview.chromium.org/1135143004

Cr-Commit-Position: refs/heads/master@{#329876}

The test is crashing flakily.

BUG=488067
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
NOTRY=true

Review URL: https://codereview.chromium.org/1141863002

Cr-Commit-Position: refs/heads/master@{#329875}

BUG=478309

Review URL: https://codereview.chromium.org/1140953003

Cr-Commit-Position: refs/heads/master@{#329874}

Adjust the strings in the extension message bubble to indicate which extension
is overriding certain settings if it's not point to a specific one. If it is
pointing to a specific one, use "This extension".

BUG=485614

Review URL: https://codereview.chromium.org/1125403006

Cr-Commit-Position: refs/heads/master@{#329873}

This test is consistently timing out on Android One.

BUG=448092
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect
NOTRY=true

Review URL: https://codereview.chromium.org/1141833002

Cr-Commit-Position: refs/heads/master@{#329872}

This is no longer needed as the underlying syscalls
unlink/rmdir and both intercepted at the IRT level.  I
believe this was overlooked when we fixed:
https://code.google.com/p/nativeclient/issues/detail?id=3709

This should fix the recent lua5.2 failures on the
naclports waterfall.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=487701

Review URL: https://codereview.chromium.org/1136953014

Cr-Commit-Position: refs/heads/master@{#329871}

Current interest/eventually/live rect is calculated based
on  max_tiles_for_interest_area setting which is not the
best choice for determining the size. As part of this patch
tiling interest rect is calculated based on viewport area.
Which is multiplied by a constant factor. The factor is
currently 9, viewport dist in all directions.
Also, max_tiles_for_interest_area setting is removed
and its associated switch and entries in chrome://flags.

BUG=483520

Review URL: https://codereview.chromium.org/1126793002

Cr-Commit-Position: refs/heads/master@{#329870}

R=piman@chromium.org

Review URL: https://codereview.chromium.org/1134783003

Cr-Commit-Position: refs/heads/master@{#329869}

BUG=484690,484734
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/1129293004

Cr-Commit-Position: refs/heads/master@{#329868}

There is certainly a deeper issue here, but since I expect RenderFrameProxyHost::render_frame_host_ to be disappearing very soon, this small fix seems okay to suppress the crash.

BUG=487406

Review URL: https://codereview.chromium.org/1134273002

Cr-Commit-Position: refs/heads/master@{#329867}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6505e22..5b15054

TBR=jsbell@chromium.org,timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1145493002

Cr-Commit-Position: refs/heads/master@{#329866}

Removes need for allowing circular includes.

Review URL: https://codereview.chromium.org/1123283007

Cr-Commit-Position: refs/heads/master@{#329865}

Otherwise it exits before I've had a chance to attach the debugger.

BUG=none
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1129233007

Cr-Commit-Position: refs/heads/master@{#329864}

Remove the old and disabled test.

Previously we used to run the test partly in cpp and partly in JS.
This CL changes the test code to run entirely in JS, requiring less
context switches (== faster) and improving readability.

BUG=248500, 160361
Test=None, no visible changes.

Review URL: https://codereview.chromium.org/1144473003

Cr-Commit-Position: refs/heads/master@{#329863}

BUG=435757, 455391
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1142453002

Cr-Commit-Position: refs/heads/master@{#329862}

Currently, various methods related to marking proxies as bad in the ProxyList
and ProxyService classes take a single ProxyServer for optionally marking an
additional proxy as bad (i.e. ProxyList::UpdateRetryInfoOnFallback and
ProxyService::MarkProxiesAsBadUntil). This is linked to fundamental assumptions
in the Data Reduction Proxy that only two proxy servers are being used.

As part of moving to a dynamic configuration, it is possible that more than 2
proxy servers could be used for the Data Reduction Proxy, so using a vector
of ProxyServer objects makes more sense in the interface.

BUG=470587

Review URL: https://codereview.chromium.org/1128823005

Cr-Commit-Position: refs/heads/master@{#329861}

-0 is treated as double 0.0f in V8. This makes GetAsInteger()
return -0 is not an integer type. Extension APIs with integer parameters
will fail to get the value using GetAsInteger(). This CL convert integer
-0 to integer 0.

BUG=471011

Review URL: https://codereview.chromium.org/1126983009

Cr-Commit-Position: refs/heads/master@{#329860}

Created an ETC1 encoder that uses SSE2 to improve compression speed.
The SSE encoder extends TextureCompressor and uses the same algorithm as TextureCompressorETC1.

Added unittest for TextureCompressorETC1.

Moved shared code into a etc1 header.

Added new performance test scenarios.

Reland necessary for 32-bit GN issues.

Performance difference on Ubuntu x64, Haswell Processor:
Without SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.966321587562561 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .0956009104847908 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .4367307722568512 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 5.948055744171143 us

With SSE:
*RESULT Compress256x256BlackAndWhiteGradientImage: ETC1 Low= 1.0316201448440552 us
*RESULT Compress256x256SolidBlackImage: ETC1 Low= .25716209411621094 us
*RESULT Compress256x256SolidColorImage: ETC1 Low= .2768038809299469 us
*RESULT Compress256x256RandomColorImage: ETC1 Low= 1.834145426750183 us

BUG=434699
TEST=newly added unittest TextureCompressorETC1Test::Compress256x256CreateETC1, TextureCompressorETC1Test::Compress256x256RatioETC1

Committed: https://crrev.com/5f3849aa8307399b7e6dfe5665ed149594244077
Cr-Commit-Position: refs/heads/master@{#329840}

Review URL: https://codereview.chromium.org/1096703002

Cr-Commit-Position: refs/heads/master@{#329859}