- 04 Dec, 2017 40 commits
-
-
Dmitry Gozman authored
This is a preparation to replace routing id + legacy IPC with Mojo interface retrievable from SharedWorkerHost. Temporarily duplicated some code from WorkerDevToolsAgentHost, which makes it possible to migrate shared and service workers separately. Removed a test for WORKER_STATE manipulations altogether with the state itself. Bug: 776009 Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e Reviewed-on: https://chromium-review.googlesource.com/783110 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#521277}
-
Leo Zhang authored
This CL is based on crrev.com/c/762540 1, Polish the UI. 2, Reading all language infos from native. 3, Enable "Remove" in the language menu. 4, Enable "Add language" for the settings page. 5, Created "Add language" fragment, it will list all unselected languages and provide a "search" function for users to find the language quickly. Tested on my local devices, demo video link https: //googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings.mp4 Bug: 783049 Change-Id: Ie5fdba908a99ad1116538bd69fe9c703c4c9051a Reviewed-on: https://chromium-review.googlesource.com/790091 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521276}
-
Tetsui Ohkubo authored
In Chrome OS, notification corners are rounded. However, when the actions row is expanded, its corners were not rounded. TEST=manual BUG=789056 Change-Id: Id29f3d1d193a682c478249089ae4bfa30c52fad3 Reviewed-on: https://chromium-review.googlesource.com/803134 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521275}
-
Xiaocheng Hu authored
This patch exposes two subroutines of ComputeInlineBoxPosition: - ComputeInlineAdjustedPosition - ComputeInlineBoxPositionForInlineAdjustedPosition After this patch, we can start converting callers of ComputeInlineBoxPosition with the following pattern: DoSomeBusiness(position) { adjusted = ComputeInlineAdjustedPosition(position); if (/* adjusted is laid out with LayoutNG */) return NGAlternativeImplementation(adjusted); legacy_box_position = ComputeInlineBoxPositionForInlineAdjustedPosition(adjusted); DoLegacyBusiness(legacy_box_position); } Bug: 771398 Change-Id: Iea01925e7ef986c5b00dd5b6e7172f7065c8df9e Reviewed-on: https://chromium-review.googlesource.com/792453Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#521274}
-
Christopher Lam authored
This CL adds the "HostedAppFrame.WrenchMenu.MenuAction" metric which tracks which menu actions are being clicked from the hosted app browser frame. Bug: 785661 Change-Id: I4b6c349892615452ce8ed6ebc8b1c23e5f1a8a9e Reviewed-on: https://chromium-review.googlesource.com/802838 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#521273}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e0e3bb53. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6851 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=qyearsley No-Export: true Change-Id: I2265c0367b490b15126095e36fb4d623f0329ecd Reviewed-on: https://chromium-review.googlesource.com/805097 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521272}
-
cathiechen authored
"Marker_rect" should contains the block direction offset of marker when propagate overflowRect to its ancestors. Change-Id: Idcbd3ab4688f48879bad3a702b5f19f63e8819d6 Reviewed-on: https://chromium-review.googlesource.com/798936Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: cathie chen <cathiechen@tencent.com> Cr-Commit-Position: refs/heads/master@{#521271}
-
Christopher Lam authored
Flake examples: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51019 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests/builds/51016 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel/builds/3170 TBR=mkwst@chromium.org Bug: 791389 Change-Id: I23a57c249151746ba07b70f36ee7aa4ee8da0aeb Reviewed-on: https://chromium-review.googlesource.com/804905 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#521270}
-
chrome-release-bot authored
TBR=amineer@chromium.org Change-Id: Ia61c712446434a346dbe3ed954fb5b7438dd76a2 Reviewed-on: https://chromium-review.googlesource.com/805098Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#521269}
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL does not remove ash::system_notifier::CreateSystemNotification right now, as we also have to remove ununsed old |icon| assets with it. BUG=757703 Change-Id: Ibb7e8cdbf01068489b2c0f17443a66043834f1eb Reviewed-on: https://chromium-review.googlesource.com/802658Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#521268}
-
Christopher Lam authored
This CL adds standard wrench menu action stats for Copy URL, Open in Chrome, Site Settings and App Info. Bug: 785661 Change-Id: I1b94804076282ef9ecb97c581fb147670adaae70 Reviewed-on: https://chromium-review.googlesource.com/790172 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Michael McGreevy authored
This histogram has the same function as WebApk.Install.InstallSource (which tracks the mechanism by which a web app is installed on Android), but is intended for use on any platform. The associated enum has an extra entry, which will be used to count installs which are initiated via calls to BeforeInstallPrompt.prompt(). Once there is enough historical data for Android in Webapp.Install.InstallSource, WebApk.Install.InstallSource will be removed (tracking bug: crbug.com/790788) Bug: 785661 Change-Id: Ie7d185a7e66e1caa2c25e850745171cb32165518 Reviewed-on: https://chromium-review.googlesource.com/802336 Commit-Queue: Michael McGreevy <mcgreevy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#521266}
-
Patti authored
Hebrew does not translate the string for 'Javascript'. This means any labels containing the English string will not have the RTL mark, and it will be displayed in LTR mode. Normally this would be OK, however, the permission labels in Page Info for Android have a width that matches the parent, so the label ends up aligning the text all the way on the left. Fix by changing the label width to wrap the content instead of matching its parent width. Note other strings are fine because they have Hebrew translations. Bug: 774934 Change-Id: I756c9e9584c8c89ab86462ba43aa8cefc10f024e Reviewed-on: https://chromium-review.googlesource.com/776333Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521265}
-
Yuzu Saijo authored
Bug: 777765, 763280 Change-Id: Ic808ad2a2d0735777e570118645ef6f5ca06cc4d Reviewed-on: https://chromium-review.googlesource.com/802657Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#521264}
-
Takayoshi Kochi authored
Support for creating V0 shadowRoot on elements that has a UA shadow was removed, but this flag is used to block V0 author shadow creation on elements which might add UA shadow later. For that purpose AreAuthorShadowsAllowed() exists, and AlwaysCreateUserAgentShadowRoot is redundant. Change-Id: I07387a2862eb5695eadf3cdcee8adc49467fab38 Reviewed-on: https://chromium-review.googlesource.com/803174Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521263}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=mmenke@chormium.org Change-Id: I95be755819bd151634e88ca26016e102d4d02f27 Reviewed-on: https://chromium-review.googlesource.com/799014Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521262}
-
Fumitoshi Ukai authored
add config for new bot names in tools/mb, testing/buildbot and ios/build/bots rename as cl/177104371 Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id46a0e61115d0699925f0219313086b3bae0dd65 Reviewed-on: https://chromium-review.googlesource.com/792672Reviewed-by:
smut <smut@google.com> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
XMLHttpRequest's responseXML's SecurityOrigin is aliased with its ExecutionContext, i.e. either with Document or an isolated world, in XMLHttpRequest::InitResponseDocument(). This CL is a preparation for making SecurityContext::GetSecurityOrigin() and XMLHttpRequest::GetSecurityOrigin() return const SecurityOrigin* in [1], while preserving the aliasing behavior in XHR. [1] https://chromium-review.googlesource.com/744586 This CL - Introduces XMLHttpRequest::GetMutableSecurityOrigin(), - Uses ExecutionContext::GetMutableSecurityOrigin() for aliasing with another Document and - Uses the registered SecurityOrigin of an isolated world in DOMWrapperWorld for aliasing with the isolated world. This CL Takes IsolatedCopy() before DOMWrapperWorld::SetIsolatedWorldSecurityOrigin() in WebLocalFrameImpl::SetIsolatedWorldSecurityOrigin(), to make SecurityOrigin inside its argument (WebSecurityOrigin) const. This IsolatedCopy() doesn't cause semantic changes, because the callers of SetIsolatedWorldSecurityOrigin() never pass an aliased WebSecurityOrigin. Bug: 779730 Change-Id: I503c0623f15e37cba010a0c7f0b72e2b44f5af08 Reviewed-on: https://chromium-review.googlesource.com/752006 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Takeshi Yoshino <tyoshino@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521260}
-
Hidehiko Abe authored
Migrated seven test cases. BUG=234463 TEST=Ran bots. Change-Id: Idc33683a4221246ac3ec9e3414435144273c8866 Reviewed-on: https://chromium-review.googlesource.com/803774Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
-
Christopher Lam authored
Flakes starting from: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64945 til https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64973 TBR=gene@chromium.org Bug: 517420 Change-Id: Ib75f72c56584acdc9e3f95163443e3eef14b5ace Reviewed-on: https://chromium-review.googlesource.com/804622Reviewed-by:
-
David Reveman authored
Modifier flags needs same treatment as pressed keys. Move modifier flag tracking to Seat class. Bug: 788731 Tbr: yoshiki@chromium.org Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ife2fae2d622dfff3617830ba232d0267fdbc9b35 Reviewed-on: https://chromium-review.googlesource.com/805359Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521257}
-
Raymes Khoury authored
This adds support to automatically grant the Default Search Engine the notifications permission on Android. The behavior is similar to the way the geolocation permission works for the DSE. Although the behavior is mostly the same, this CL changes the way permissions (geolocation and notifications) are transferred between DSEs when the user changes their DSE. The new approach stores the permissions that the user had set on the DSE origin prior to it becoming the DSE. When the user changes the DSE, we restore the old settings. No UI for the notifications part has yet been implemented. Bug: 780344 Change-Id: Ifa57e395ad4a647f42debb78146d50574ee1b636 Reviewed-on: https://chromium-review.googlesource.com/756657 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#521256}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Id90c5a04af42b64ddc7b66984dc2b948f75f6532 Reviewed-on: https://chromium-review.googlesource.com/789719Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521255}
-
Victoria Su authored
Added a use counter for :-webkit-any-link Change-Id: I4da11399a356b9cb9fd2be54930656bf23115b69 Reviewed-on: https://chromium-review.googlesource.com/804805 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#521254}
-
Yuki Awano authored
- Do not call OnInfoBubbleDestroyed if anchor view is not live. Anchor view can be destructed before info bubble is destructed. Bug: 787796 Test: ash_unittests:TrayNetworkTest.NetworkInfoBubble with asan Original commit: > Activate widget of anchor view only if it's live > > Bug: 787796 > Test: ash_unittests:TrayNetworkTest.NetworkInfoBubble > Change-Id: I54918830a0cc246af8ce34510f3a0e10193450d0 > Reviewed-on: https://chromium-review.googlesource.com/788710 > Commit-Queue: Yuki Awano <yawano@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520506} Change-Id: If366e4778d9af5526817eb884173c1c57ef86384 Reviewed-on: https://chromium-review.googlesource.com/802605Reviewed-by:
-
Marti Wong authored
To be consistent with history and bookmarks, adjust the style of reading list's toolbar: 1. Horizontal margin: 16pt 2. Vertical margin: 8pt 3. Spacing between button: 8pt 4. Font size: (same as bookmark cell) 5. Shadow opacity and radius Screenshot: https://drive.google.com/file/d/1DU5BpaWTIGFJuHUje7ideAcYEyWQG600 https://drive.google.com/file/d/1Bvxv5rcrn2P1dPQwai0rD9J_0pC9pKnN Bug: 789417 Change-Id: I6b5791941ea68e5fe9c52ae46569ce0bbd3ad9fc Reviewed-on: https://chromium-review.googlesource.com/796251 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521252}
-
Christopher Lam authored
TBR=dmazzoni@chromium.org Bug: 791268 Change-Id: I81d58c4b588969b9f7a119aa424abe85f2f6a5bd Reviewed-on: https://chromium-review.googlesource.com/804919Reviewed-by:
-
Christopher Lam authored
This CL adds a button that opens the app info dialog to the hosted app menu. Bug: 762401 Change-Id: I23ec79904932bdb35dce80d642a6d3582e29ec5e Reviewed-on: https://chromium-review.googlesource.com/788630 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
-
Blake O'Hare authored
Now there's a default empty body, so no need to override with another empty body. Bug: Change-Id: Ic089e628e44e41dd3c1d0891fd8640f4e9eea89d Reviewed-on: https://chromium-review.googlesource.com/795396 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#521249}
-
Yutaka Hirano authored
This CL tightens the throttling policy initially (if certain conditions are met), and loosen the policy when Document::WillInsertBody is called. Bug: 785770 Change-Id: I1fea7ced1105f48dabb25a68a546fd281db5e6eb Reviewed-on: https://chromium-review.googlesource.com/799517 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
-
Wez authored
The accelerator system was fixed to use this function when mapping the modifiers in a WebInputEvent to construct an Accelerator, and the reverse mapping, from ui::Event flags to WebInputEvent modifiers, already handles the AltGraph modifier correctly. A simple test is also added to verify that the two functions both handle the required set of modifier flags. Bug: 787137, 25503 Change-Id: I53e5353dc4f1fa5eba15f1b91ec4c361e50264db Reviewed-on: https://chromium-review.googlesource.com/802081Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#521247}
-
David Bokan authored
MouseEvents are initialized with client coordinates and translated into offset and page coordinates based on the main frame's scroll offset. This patch fixes the scroll offset calculation for when root-layer-scrolls is turned on. Bug: 781431 Change-Id: Ibdbb24600ff6f0ded589b9e4a31be8bf9e753cb5 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Reviewed-on: https://chromium-review.googlesource.com/798537 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521246}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=jochen@chromium.org Change-Id: I93ef943b0160683eaea33d40d8d86c0b04253baf Reviewed-on: https://chromium-review.googlesource.com/799512Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521245}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=zentaro@chromium.org Change-Id: Ic92828720da66aac49d94d9403c6a56b0ae2cbee Reviewed-on: https://chromium-review.googlesource.com/799013Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521244}
-
Ben Wells authored
Using resource ids with the content settings API is supported but is apparently not being used. This change adds some DCHECKS to check that this is true as preparation for removing resource ids from the API. Bug: 754178 Change-Id: I6ac49bf697fc342332905c7e814ef4e61f32695f Reviewed-on: https://chromium-review.googlesource.com/790075Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#521243}
-
Morten Stenshorne authored
A margin before a block may push the start of the block to the next fragmentainer. The remaining part of the margin will then be "eaten" by the fragmentainer boundary, as per spec: https://www.w3.org/TR/css-break-3/#break-margins Blocks that start exactly at a fragmentainer boundary no longer create a bogus empty fragment in the former fragmentainer. This affects the BlockStartAtColumnBoundary unit test. Quite a few layout tests behave better now, by going from Crash to Failure, from Crash to Pass, or from Failure to Pass. fast/multicol/dynamic/insert-spanner-between-out-of-flow.html regresses. Not sure why, but it's not so interesting, since that test uses column-span: all, which we still don't support. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3be1b735e70f05a375ea328a7fc11fd515e77e3a Reviewed-on: https://chromium-review.googlesource.com/803482 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#521242}
-
Denis Kuznetsov authored
Bug: 676195 Change-Id: I450fcf3416f620ce9867d55ea225c610583d1169 Reviewed-on: https://chromium-review.googlesource.com/764168Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#521241}
-
Naina Raisinghani authored
This patch stashes all ComputedStyle information about all descendants when an element will need to undergo Reattach. It does so by recursing over all ContainerNode, ShadowRoot and PseudoElement descendants in the case where the node itself needs to Reattach. We then use the ComputedStyle stashed on the Node in LayoutTreeBuilder::style() eliminating the need to call Element::styleForLayoutObject() in Layout Tree Construction. Bug: 595137 Change-Id: I7e6ca2431e602dff80d7d3e84d1bffe1e25d8b2c Reviewed-on: https://chromium-review.googlesource.com/765097 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#521240}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=mmenke@chromium.org Change-Id: I480fc15a2b48369f3943661d092a4a85e0698400 Reviewed-on: https://chromium-review.googlesource.com/799596Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#521239}
-
François Degros authored
Change-Id: I2fe10a0aa80796b4af0a36c7db355cfa8b8144e7 Bug: Reviewed-on: https://chromium-review.googlesource.com/790112Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#521238}
-
