- 19 Nov, 2019 40 commits
-
-
zhaoyangli authored
This change will make EG2 tests work when FakeChromeIdentity is passed between test and app processes. - Overrode (BOOL)edo_isEDOValueType to let EDO framework pass it by value. - Made the class confirm to NSSecureCoding protocol as its required by EDO pass-by-value. - Overrode -isEqual and -hash methods to compare by values so that comparing between copied objects will work. Bug: 1015907, 922813 Change-Id: Iefadf89b401dabcee53e44ff1c6ce903cc979de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922336Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#716467}
-
Demetrios Papadopoulos authored
Updating chrome://downloads to use Polymer 3/JS modules and removing usage of HTML imports Size comparison (~5.7% reduction) Before: vulcanized.html 90k crisper.js 135k Total 225k After: vulcanized.html 1.1k downloads.js 211k Total: 212.1k Bug: 1022215 Change-Id: I788d8d0534324b1ac68542b4d867265f74953110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910748 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716466}
-
Reilly Grant authored
BluetoothAdapter::OnDiscoveryChangeComplete() needs to be able to handle the case where a callback destroys the BluetoothAdapter. This issue was not noticed in tests because TestBluetoothAdapter takes a reference to the BluetoothAdapter when executing these callbacks. It has been updated to use a WeakPtr as the real backends do. I noticed that both BluetoothAdapter and nearly all of its subclasses have a WeakPtrFactory. The factory in the base class has been removed and subclasses are required to provide their own. Bug: 1025067 Change-Id: I91f952e01fd3bda618455f294ce0cba2e2a7dad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922298 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#716465}
-
Sammie Quon authored
This will help animations and dragging as the damage rects for the active window are quite large. Deactivation of the app list window is still sync. Test: ash_unittests Bug: 1022045 Change-Id: I206521dc7c3ef7dbcf8e18a37e3b43d58717fe33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904760 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#716464}
-
nancy authored
AppServiceAppModelBuilder is used to replace CrostiniAppModelBuilder. AppService integration to ui/app_list has been enabled for a couple of months, so it should be safe to remove CrostiniAppModelBuilder. BUG=1016159 Change-Id: Ifd9a4d9abfac3c1e2cd18f8a9bd6e0b040a9dcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919535 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#716463}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/2577dd772d69..0e34b1b2b34b git log 2577dd772d69..0e34b1b2b34b --date=short --no-merges --format='%ad %ae %s' 2019-11-18 vapier@chromium.org config: delete all precq builders Created with: gclient setdep -r src/third_party/chromite@0e34b1b2b34b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I86b39db1ea06bf2c8903a5af61179c0bd50d8ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
John Chen authored
Fix NavigationTracker::DetermineUnknownLoadingState method to check for document.readyState == "interactive" in eager page load mode, to prevent testEagerMode from being flaky. Bug: 1025967 Change-Id: Id41825869b249fb19a80723fabc1fea3a3bcda23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922972 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#716461}
-
shrekshao authored
Recently https://chromium-review.googlesource.com/c/chromium/src/+/1922706 The suppression is revert by suppressor. But that is likely needed. As some android specific workaround only exists in angle but not cmd decoder. Bug: 1025719 Change-Id: Ie01549bb621831c5003820464561b98d333b0c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923328Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#716460}
-
Sophie Chang authored
This also removes some of the Previews code that relied on the inverse behavior. This is the minimum set of things that need to be deleted so we can prepare Previews to use the slow page prediction model I will do more code health-y things in future CLs (i.e. remove unnecessary params, interface squashing, etc.) Bug: 1022532 Change-Id: I168c844c1b01dd1330cbe45e221064f7efca91d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922601 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#716459}
-
Jon Mann authored
This is a better home because these components are not generic elements, they are higher level components which directly use translated strings and contain Chrome OS networking specific logic. Moving to cr-components will also allow this code to access translated strings directly without needing to use a global CrOncStrings object which will allow us to add a11y strings without updating CrOncStrings everywhere it's defined and filled. Bug: 1023068 Change-Id: I176f6c00900a2bab3186b2b39b7be1c00d99de34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918031 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#716458}
-
Bryan Clark authored
Test: Ran locally Change-Id: I85a57b57dfa38405e6d0c08e3b063c8778fadb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923488Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#716457}
-
Jia authored
Bug: 881215 Change-Id: Ic32e7fc886b50d0b91716cf3ee3eeb1022c0bd6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921932Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716456}
-
Kent Tamura authored
MilestoneDate() returns a base::Time::Exploded object instead of a double value. MilestoneString() is significantly simplified by runtime string generation. It now returns WTF::String(), and some callsites need to add .Ascii().c_str() to pass it to String::Format(). This CL should have no user-visible behavior changes. Change-Id: I19b870cad686fbf2f61c084c9ea069dd7b8bebb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915639Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#716455}
-
Rahul Arakeri authored
This CL updates the exipry-milestone of the flag to 90. This feature is a part of an ongoing effort for "scrolling unification". Even after the feature "Compositor threaded scrollbar scrolling" is turned on by default, being able to access this flag will be handy for quickly debugging gesture based scrolling bugs. Change-Id: Ie426aa07b2c2c0f7f501f0e843a797df6b871076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922649Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#716454}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ff2f380fd37a..684929ceb1a6 git log ff2f380fd37a..684929ceb1a6 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 fmalita@chromium.org [skottie] Fix single-node camera orientation relative to z=0 plane 2019-11-18 jsimmons@google.com Use the default font family if no match is found for any of the families in the text style Created with: gclient setdep -r src/third_party/skia@684929ceb1a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I7a2f48c0a1c1283f9ada9db6b57bfd28a9395763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922769Reviewed-by:
-
Vikas Soni authored
This CL does a texture transform matrix calculations similar to what android's SurfaceTexture framework does under the hood. This matrix was not provided by AImageReader api and hence the calculations has to be done in chrome. This matrix is applied to the texture coordinates by display compositor in order to draw the pixels correctly. Before this CL this matrix was hardcoded to an identity matrix but certain video format. Bug: 1025273 Change-Id: I68aea1114f14cedbccfc1a59a4f8d2834d921711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919805Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#716452}
-
Lukasz Anforowicz authored
This CL changes the following method of content::mojom::FrameHost from: SubresourceResponseStarted(url.mojom.Url url, uint32 cert_status); to: SubresourceResponseStarted( url.mojom.Origin origin_of_final_response_url, uint32 cert_status); because it turns out that implementations of that method only ever depend on the origin of the final URL (and not on other parts of the full URL like path or query). Bug: 973885 Change-Id: If73a905e856640cd2959063faae4033f01788a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899739 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#716451}
-
Nicholas Verne authored
This will distinguish it from the "real" container upgrade (which upgrades the Linux distribution) Bug: 1025629 Change-Id: Icc35ccdbbbf500ba5b9d008c81d9a1880bfffbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923207 Auto-Submit: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#716450}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/52c6f67dbcab..43eea8f2ec00 Created with: gclient setdep -r src-internal@43eea8f2ec00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I9fca0847fcf5d7e3ec7271116be99ee3ce34f8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923249Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716449}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1f392b83a83a..35a67a5796a1 git log 1f392b83a83a..35a67a5796a1 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@35a67a5796a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ibfd56d9a127069953439248620b0d2b59074b1f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922967Reviewed-by:
-
Ahmed Mehfooz authored
Bug: 1025363 Change-Id: Ief058d765aead7ea71f9b866a53165bd99a4c991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919800Reviewed-by:
-
Chris Blume authored
The Pixel 4 supports wide color gamut. There is already a roll-out in place to test wide color gamut on the Pixel 4. This CL adds a field trial to match that roll-out. R=isherman@chromium.org Change-Id: Ibf678bf497aafa05b620b8e4e0750713ecfc2288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922458Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#716446}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/437131108da3..f7d5f0c0637e git log 437131108da3..f7d5f0c0637e --date=short --no-merges --format='%ad %ae %s' 2019-11-19 eroman@chromium.org [Net Log viewer] Add a test for filtering events by source ID as plain text. 2019-11-18 eroman@chromium.org [NetLog viewer] Remove code that routes file:// and about: URLs through 'chrome.send'. 2019-11-18 fancl@chromium.org Autocomplete-box loses focus only when dropdown select Created with: gclient setdep -r src/third_party/catapult@f7d5f0c0637e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1024891,chromium:1025755,chromium:993890 Change-Id: I2ad8df1975279d2cef60c126e2c05dbbded86301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923247Reviewed-by:
-
Tao Bai authored
Reschedule the current task if it waits longer than needed to run. Bug: 1017431 Change-Id: I69f7199c9999bbe39514b1d1e5b563ffdf56d80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875552Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#716444}
-
Jiawei Shao authored
This patch forces the WebGPU command buffer only choose the first D3D12 adapter as the available WebGPU adapter on Windows. On Windows the shared image between different GPUs has not been supported yet, so we must ensure WebGPU is always using the same GPU as the one used by the reset of Chromium. As ANGLE is using the first D3D11 adapter, currently in WebGPU command buffer we should also choose the first D3D12 adapter as the only one that can be chosen as a WebGPU adapter. BUG=chromium:996713 Change-Id: I92fe94c32773dd9392c25b52021df85f6bd4e3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909648Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Cr-Commit-Position: refs/heads/master@{#716443}
-
Jonathan Ross authored
This reverts commit 0333405c. Reason for revert: Nevermind, I misread the conversation about the decision on reverting the last patch. We DO want separate mac and android no-passthrough suppressions. Rather than a generic one for all platforms. Original change's description: > Reland "Suppress two WebGL tests on Android" > > This reverts commit 7e1a7438. > > Reason for revert: The original patch was correct, these still need to remain disabled. > > If Android fails, then separately https://chromium-review.googlesource.com/c/chromium/src/+/1923328 will land to suppress those > > Original change's description: > > Revert "Suppress two WebGL tests on Android" > > > > This reverts commit 49b134d3. > > > > Reason for revert: Fix for issue was landed: https://chromium-review.googlesource.com/c/chromium/src/+/1922357 > > > > Original change's description: > > > Suppress two WebGL tests on Android > > > > > > Recently the two tests concerned here were suppressed on > > > [ mac no-passthrough ] however they also fail on Android. > > > I'm updating to be just [ no-passthrough ] until the root > > > cause can be addressed. > > > > > > TBR=ynovikov@chromium.org > > > TEST=webgl2_conformance_tests > > > WebglExtension_WEBGL_draw_instanced_base_vertex_base_instance > > > WebglExtension_WEBGL_multi_draw_instanced_base_vertex_base_instance > > > > > > Bug: 1025719 > > > Change-Id: Ia6389b4456b4a231e26014e18dccb28fa9b0165c > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921558 > > > Reviewed-by: Jonathan Ross <jonross@chromium.org> > > > Commit-Queue: Jonathan Ross <jonross@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#716165} > > > > TBR=ynovikov@chromium.org,jonross@chromium.org > > > > Change-Id: I4c43da5a00b2f90d006148d68a62811df88c850a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1025719 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922706 > > Reviewed-by: Jonathan Ross <jonross@chromium.org> > > Commit-Queue: Jonathan Ross <jonross@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716398} > > TBR=ynovikov@chromium.org,jonross@chromium.org > > Change-Id: Ib65ea29ad66c67869de72a115ef39c3155847aa2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1025719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922983 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716439} TBR=ynovikov@chromium.org,jonross@chromium.org Change-Id: Ia46ccb4db60c768bf1edd8c2e5c5de3bc4039623 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922990Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716442}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fa20b0b9db94..4224dda31863 git log fa20b0b9db94..4224dda31863 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 eseckler@google.com Merge "processor: Support delta timestamps and other units in ClockTracker" Created with: gclient setdep -r src/third_party/perfetto@4224dda31863 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I8836aea5f5befccec08ae4c131a7144a52f71a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922772Reviewed-by:
-
Alexey Baskakov authored
This is a preparation CL to implement Uninstall for the new web apps. Bug: 901226 Change-Id: Icaa903d3a9d02929f1ab308e60693e031858134f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921021 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#716440}
-
Jonathan Ross authored
This reverts commit 7e1a7438. Reason for revert: The original patch was correct, these still need to remain disabled. If Android fails, then separately https://chromium-review.googlesource.com/c/chromium/src/+/1923328 will land to suppress those Original change's description: > Revert "Suppress two WebGL tests on Android" > > This reverts commit 49b134d3. > > Reason for revert: Fix for issue was landed: https://chromium-review.googlesource.com/c/chromium/src/+/1922357 > > Original change's description: > > Suppress two WebGL tests on Android > > > > Recently the two tests concerned here were suppressed on > > [ mac no-passthrough ] however they also fail on Android. > > I'm updating to be just [ no-passthrough ] until the root > > cause can be addressed. > > > > TBR=ynovikov@chromium.org > > TEST=webgl2_conformance_tests > > WebglExtension_WEBGL_draw_instanced_base_vertex_base_instance > > WebglExtension_WEBGL_multi_draw_instanced_base_vertex_base_instance > > > > Bug: 1025719 > > Change-Id: Ia6389b4456b4a231e26014e18dccb28fa9b0165c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921558 > > Reviewed-by: Jonathan Ross <jonross@chromium.org> > > Commit-Queue: Jonathan Ross <jonross@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716165} > > TBR=ynovikov@chromium.org,jonross@chromium.org > > Change-Id: I4c43da5a00b2f90d006148d68a62811df88c850a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1025719 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922706 > Reviewed-by: Jonathan Ross <jonross@chromium.org> > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716398} TBR=ynovikov@chromium.org,jonross@chromium.org Change-Id: Ib65ea29ad66c67869de72a115ef39c3155847aa2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1025719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922983Reviewed-by:
-
Alexey Baskakov authored
This is a preparation CL to implement Uninstall for the new web apps. A web app can't be fully uninstalled by any call site. Instead: A call site may request uninstallation, but the app may stay installed if it is required by other sources. CanUserUninstallFromSync+UninstallWebAppFromSyncByUser is just one scenario for uninstallation. UninstallExternalWebApp will be extended. Bug: 901226 Change-Id: I91f13754c0cc4a2fe80fd2a7b79e340ea9c3b2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921019Reviewed-by:
-
Xianzhu Wang authored
This reverts commit 93235d0e. Reason for revert: The failing test just needs a rebaseline (done in this CL). We don't have CQ coverage for mac10.10 so the original CL passed CQ. Original change's description: > Revert "[CompositeAfterPaint] Remove internals.elementLayerTreeAsText()" > > This reverts commit bd07dee9. > > Reason for revert: Fails color-layer test on Mac10.10: > https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/48789 > > Original change's description: > > [CompositeAfterPaint] Remove internals.elementLayerTreeAsText() > > > > The layer tree mode is not supported in CompositedAfterPaint. > > Remove it and rewrite the tests so that the tests will pass in > > CompositeAfterPaint. > > > > Change-Id: Ided24dc50b6804397777fec8fbce45d8d6cb3174 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918295 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#716300} > > TBR=kenrb@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org > > Change-Id: I5a8667762698a7879975510df28578558c29295e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923208 > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716389} TBR=kenrb@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,loyso@chromium.org Change-Id: I1d26efe39fb7dd21ce0509a43cdd62981c68ad1d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923329 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Gavin Williams authored
-Read the name of the popUpButton before the value to give the user better context. Change-Id: I824f3382df5164cf03e24941d678d575b9baaf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919525Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#716436}
-
jonross authored
The angle_end2end_tests have begun failing on the Win10 FYI x64 Release (AMD RX 550) bot. While this is a regression, we are interested in qualifying the GPU currently, not pursuing regressions. With all other bots fine we are just temporarily removing these tests from this bot. TBR=ynovikov@chromium.org TEST=angle_end2end_tests Bug: 1025745 Change-Id: Iffa03627dd8e6f4e6151c8aef6730189d6ae3ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922694Reviewed-by:
-
Matthew Wang authored
Bug: 1025854 Change-Id: Idd237754668d1d9f13a47ff914bee0c143c0d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922451 Auto-Submit: Matthew Wang <matthewmwang@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Rayan Kanso authored
The new Background Service features just hit the latest version of Chrome. It would be good to monitor the overall usage metrics for a few more milestones. Bug: 988721 Change-Id: I6cea481310b519e0e9965bae8cca0dc80296c3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919765 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
This reverts commit c42ecf7b. Reason for revert: Breaks chromedriver_unittests on Linux CFI https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/15659 Original change's description: > [ChromeDriver] Wait for Current Frame to load > > When Waiting for Pending Navigation, code will respond to loading events > for the current frame as well as the top frame. ChromeDriver will > therefore wait for changes in the current frame to complete before > running the next command. > > Bug: chromedriver:3164 > Change-Id: Id9000afcb7e7a7689466c395071dcccc09c8b23d > Fixed: chromedriver:3164 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859637 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Tricia Crichton <triciac@chromium.org> > Cr-Commit-Position: refs/heads/master@{#716204} TBR=johnchen@chromium.org,triciac@chromium.org Change-Id: I8d840ae0c9cd1e24c5537e5dfe101f4aedc120df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:3164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923213Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#716432}
-
Caleb Rouleau authored
This follows the advice from https://stackoverflow.com/questions/1408356/keyboard-interrupts-with-pythons-multiprocessing-pool I tested it and it works. Bug: 1026004 Change-Id: Ic57ba9fec12d4838b0c5b7c7ca9278d8d0fc8e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922592 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#716431}
-
Caleb Rouleau authored
TEST=Ran instructions from https://bugs.chromium.org/p/chromium/issues/detail?id=1023441 manually and it seems to work now. Bug: 1023441 Change-Id: Ic36dcd5e74c884d7636bd57ccb9e7e014b8484b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912916 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#716430}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d0f5ec35. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." c8b6e1ce "Chromedriver] Fix PerformAction to support multi touch points cases" 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." eb07c684 "[scroll-snap] Add keyboard test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic138c9cce75d19378605f955e39fceb06c705422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921544Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716429}
-
chrome://new-tab-pageEsmael El-Moslimany authored
The launch of WebUI NTP depends on an effort that has begun that will allow WebUI pages to use <iframe>'s. The embedded <iframe> content will be site-isolated from the embedder if the embedder is a WebUI page. The parts of the page that depend on this are the OneGoogleBar, doodle, voice search and promo. I plan to work on tasks that do not depend on embedding isolated content. - Create placeholder WebUI page - Create parts of the page * search box * shortcuts and most-visited sites * customization * search suggestion chips (if still relevant after zero-suggest) - Flag that uses chrome://new-tab-page in place of chrome-search://local-ntp/local-ntp.html Bug: 997229 Change-Id: I333588a379193d9fe6c542eaed589ff2e6cb4f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769054 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
-
