- 21 Nov, 2018 40 commits
-
-
Emircan Uysaler authored
getDisplayMedia() allows capturing user's display content. Before launching this feature, we want to add a kill switch that can be set from server side in case there exists some use case that causes security or privacy problems. Bug: 326740 Change-Id: I34cf0cb412c599712fa10b0beb40b18404cf0440 Reviewed-on: https://chromium-review.googlesource.com/c/1313192 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610208}
-
Tarun Bansal authored
At the time of page load, navigation predictor may take some action (such as prefetch). This CL records metrics around the accuracy of the action taken. Bug: 903945 Change-Id: Id4bea8b7e7aec1f017e070213438b20905f1d96c TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1338944Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#610207}
-
edchin authored
Two private methods in BVC take in a WebState as an argument. They call the TabHelper to get the corresponding Tab, then never use the Tab reference. This CL removes these unnecessary references to Tab. Change-Id: Ie5be3d4600fafe9bd4777ece6717eb67525e8c30 Reviewed-on: https://chromium-review.googlesource.com/c/1344835Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610206}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9a370396f131..ea02708e078c git log 9a370396f131..ea02708e078c --date=short --no-merges --format='%ad %ae %s' 2018-11-21 bsalomon@google.com Add SK_API to SkCanvas::ImageSetEntry to fix Chrome roll 2018-11-21 mtklein@google.com move NEON matrixProcs into matrixProcs.cpp 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 836674c28b1e..6aab06e0e5d4 (1 commits) 2018-11-21 reed@google.com add flag to flutter 2018-11-21 bsalomon@google.com Make experimental_drawImageSet support per-quad alpha. 2018-11-21 reed@google.com Revert "Revert "add rect-parameter to makeImageSnapshot"" 2018-11-21 brianosman@google.com Revert "Prefer GrAAConvexPathRenderer over ccpr" Created with: gclient setdep -r src/third_party/skia@ea02708e078c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860021 TBR=csmartdalton@chromium.org Change-Id: I7af4b53a6c7a2fc462253becdd305574608f60a5 Reviewed-on: https://chromium-review.googlesource.com/c/1347072Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610205}
-
John Z Wu authored
Actually made it into a method instead since I felt asking a CWVAutofillSuggestion for its property passwordSuggestion is kind of confusing. As a method I think it's more clear. Change-Id: I3eb32cfff01236f099dcda720a812bdaa0f78c20 Reviewed-on: https://chromium-review.googlesource.com/c/1347101 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610204}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a285cdeb4d1a..eacc22d07da8 Created with: gclient setdep -r src-internal@eacc22d07da8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iedc32bf4232895898de5aa2f3754f6fa96d7727c Reviewed-on: https://chromium-review.googlesource.com/c/1347106Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610203}
-
Nigel Tao authored
The App Registry is discussed in chrome/services/app_service/README.md. BUG=826982 Change-Id: If914f4237b6a42c2b212225be280218b69d676b3 Reviewed-on: https://chromium-review.googlesource.com/c/1338590Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610202}
-
Nicolas Pena authored
This CL unifies the timestamp computations for FID as reported to UMA and FID as exposed in the Web Perf API. It moves the UMA reporting from the PageWidgetDelegate to the EventTiming class. After this CL, the same types of events are logged by both the UMA metric and the webexposed metric. In addition, this CL removes the check that there are default actions or event handlers from EventTiming, which means that now the webexposed API will expose events even if they have no associated event handlers. In particular, this means that a click will now trigger mousedown, click, and mouseup entries, in that order. This is reflected in changes to the layout tests. Bug: 897656 Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc Reviewed-on: https://chromium-review.googlesource.com/c/1334564 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#610201}
-
Esmael El-Moslimany authored
cr-input skip validation when old and new values are both falsy After validation, if the input value is invalid, the red underline will be drawn under the input. When initializing the cr-input, the value switches from undefined to '' and then it is updated to new values from there. This causes an issue because the underline opacity and width have transition. So if the value is valid after initialization, the underline will appear blue and then transition away (the color change is instant). This CL addresses this by skipping validation until a real value has been set. Bug: 907022 Change-Id: I2369cb41467c3d6ee9b3b30004188579df107906 Reviewed-on: https://chromium-review.googlesource.com/c/1345415Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610200}
-
Alexandr Ilin authored
The data collected for the following histograms have not been used recently: - ResourcePrefetchPredictor.PrefetchingDuration - ResourcePrefetchPredictor.ReportingEvent Bug: 900064 Change-Id: I4f1d6b479c1a5a1f1a5c30160322acd436fcbc8c Reviewed-on: https://chromium-review.googlesource.com/c/1343091Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610199}
-
Chris Morin authored
Create ARC server socket in chrome instead of in session_manager. BUG=b:119447298 TEST=Ensure container starts up Change-Id: I6207f16fd6cfaa5a9eface6cf1ae6806c053157b Reviewed-on: https://chromium-review.googlesource.com/c/1343046 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#610198}
-
Becca Hughes authored
There is a memory leak in the contents observer. BUG=885394 Change-Id: Iea5044f3c739c4c42962e5aea5c5dfda6d5790f4 Reviewed-on: https://chromium-review.googlesource.com/c/1335784Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610197}
-
Mikel Astiz authored
This is a reland of 05048d0f Meanwhile, a patch has landed that is believed to fix the issue observed in recent flakes. Original change's description: > Reenable a test in TwoClientPreferencesSyncTest on CrOS > > Recent changes (linked to the bug) are believed to have deflaked the > test, so let's reenable it on all platforms. > > Bug: 873902 > Change-Id: I9804fa4d83c3b1afb9b71356d134736b63b11298 > Reviewed-on: https://chromium-review.googlesource.com/c/1343083 > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609649} Bug: 873902 Change-Id: I0c82df1ed8ca63ec4c0490a3f76ac1c9efddd5c6 Reviewed-on: https://chromium-review.googlesource.com/c/1347351Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#610196}
-
Mustaq Ahmed authored
Bug: 860713 Change-Id: I561cb3042aa1d83bd45ed7ec2678df1994da67f3 Reviewed-on: https://chromium-review.googlesource.com/c/1347058Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#610195}
-
liberato@chromium.org authored
In preparation for adding more tests to D3D11VideoDecoder, this CL converts use of the command decoder stub to CommandBufferHelper. Otherwise, we have to mock out the stub for the test. Change-Id: I4234841d26dbb0187e626cfd20d534916506b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/1343340 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610194}
-
Mei Liang authored
This CL fixes the arithmetic exception when recording tab launch type. TasksUma::recordTAbLaunchType should return early when total tab count is equal to zero. Bug: 906616 Change-Id: I03c9d069b1292d3adc73f14b1b99bc50c1709392 Reviewed-on: https://chromium-review.googlesource.com/c/1343534Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610193}
-
Joe Mason authored
This updates the logging/proto and scanner subdirs R=csharp@chromium.org Bug: 830892 Change-Id: I15b1cfe9fdb123553b4d00c0e42395adbc068db3 Reviewed-on: https://chromium-review.googlesource.com/c/1338406 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610192}
-
Xi Cheng authored
Change-Id: I39c796801d9cfc70465633a9c682d66ba7e41cd6 Reviewed-on: https://chromium-review.googlesource.com/c/1345535 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610191}
-
François Beaufort authored
Change-Id: I27a55289aaf2f5a2ba4f504dfb97602b9a4418c6 Reviewed-on: https://chromium-review.googlesource.com/c/1345970Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#610190}
-
Antonio Gomes authored
CL converts ArcAuthContext away from PO2TS, as part of the IdentityManager servicification effort (//services/identity). No functionality change is expected. Note that there is still one reference to PO2TS left, that is used to construct UbertokenFetcher. It will be removed on a follow up pass. CL also takes the opportunity to migrate ArcBackgroundAuthCodeFetcher away from OAuth2TokenService::Consumer, since it is tied to ArcAuthContext. BUG=905243 TEST=Run on test device. TEST=Run browser_tests --gtest_filter=Arc* TEST=Run unit_tests --gtest_filter=Arc* Change-Id: I1a74df3b79a7753e96dc7993d636692efa18d1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1345130 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610189}
-
Steven Holte authored
Update variations_seed proto and metrics protos, and send seed versions to UMA, so it's available for analysis. Change-Id: Id2954646c6c000af8accde3e43f1eedc9e5c1c1f Reviewed-on: https://chromium-review.googlesource.com/c/1339242Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#610188}
-
Majid Valipour authored
Previously scroll source was resolved anytime it was accessed. However this is problematic in two ways: - The Document.scrollingElement can change so we could resolve to a different node if that happens. However Attach/Detach process expect the resolved node to be the same and violating this invariant can cause unexpected behavior. - Resolution process can trigger layout which may not be allowed during detachment (see issue 890143) This patch changes this behavior so that the scroll source is only resolved at ScrollTimeline construction and the resolved node is used for the lifetime of scroll timeline. Bug: 890143 Change-Id: I8a745385e22e2c0718a5f9cade763f5eb2174c83 Reviewed-on: https://chromium-review.googlesource.com/c/1342677Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610187}
-
Erik Luo authored
Motivated by the desire to make Console links keyboard navigable, this CL removes the BrowserConsole module and moves logic back into ConsoleViewMessage. BrowserConsole did not explicitly depend on BrowserSDK. Bug: 865674 Change-Id: Ibb004c52699b1d504b32accdfa4ee19adc907633 Reviewed-on: https://chromium-review.googlesource.com/c/1338329Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#610186}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3adb7977dae0..fe39a6f342f6 git log 3adb7977dae0..fe39a6f342f6 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 zoddicus@users.noreply.github.com Add tests coverage for OpTypeVector column count validation (#2087) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@fe39a6f342f6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8d21c4bd9389e3b8fa4af21c3097290f6bcba2bc Reviewed-on: https://chromium-review.googlesource.com/c/1346889Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610185}
-
Rebekah Potter authored
This reverts commit d12f01a6. Reason for revert: Causes crbug.com/907378, and the Blink change that caused that bug is expected to be reverted. Original change's description: > Fix Print Preview sidebar outline > > The scroller is now focusable due to Blink changes at r608013. > Remove the outline and take it out of the tab order. > > Bug: 905604 > Change-Id: Ib8154c691e1240b27118288950c8efdf46c803b6 > Reviewed-on: https://chromium-review.googlesource.com/c/1343285 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609495} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905604 Change-Id: Iea4a67f80284091c2acf0fee24215a7f5b174a03 Reviewed-on: https://chromium-review.googlesource.com/c/1344837Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#610184}
-
Kyle Milka authored
Add flag for showing search suggestions on the local NTP. Add flag for showing promos on the local NTP. Move kUseGoogleLocalNtp and kDoodlesOnLocalNtp into ntp_features. Update flag-metadata for ntp flags. Bug: 904565, 906278 Change-Id: I465c1f3c42092f491112439260d9fe8546e038a7 Reviewed-on: https://chromium-review.googlesource.com/c/1338233Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#610183}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5825fead. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I99637ffece142e86ae23e98ccb5ae132489e2c43 Reviewed-on: https://chromium-review.googlesource.com/c/1347091 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610182}
-
Mikel Astiz authored
This will allow tests to introduce doubles in future patches. Bug: 895455 Change-Id: I33b99a8a90f00ab47678a852e4521e90deee1390 Reviewed-on: https://chromium-review.googlesource.com/c/1346453Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610181}
-
Mohamed Amir Yosef authored
Bug: 882887 Change-Id: Id2b3c2c6d80b30552fd94face69b32223f455c68 Reviewed-on: https://chromium-review.googlesource.com/c/1296543 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#610180}
-
Geoff Lang authored
The context may have been destroyed because it was lost, recreate it for the next iteration of the fuzzer. BUG=907303 BUG=907350 Change-Id: Ie2acb7d8da68be7f96427766c697624e0d54bd7a Reviewed-on: https://chromium-review.googlesource.com/c/1346730 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610179}
-
Nico Weber authored
Add debug logging to debug why https://chromium-review.googlesource.com/c/1346670 has no effect on the bot. TBR=hans@chromium.org Bug: 899438 Change-Id: Ibec766f0ccf5554556c4c578625469d20504fff9 Reviewed-on: https://chromium-review.googlesource.com/c/1347211Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610178}
-
Nico Weber authored
Revert "Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234"" This reverts commit 1ffe990d. Reason for revert: roll-dep is still broken with this (https://bugs.chromium.org/p/chromium/issues/detail?id=906114#c19) Original change's description: > Reland "Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234" > > This is a reland of c5612605 > > Original change's description: > > Remove workaround made unnecessary by https://chromium-review.googlesource.com/c/1312234 > > > > Bug: 875037 > > Change-Id: Ia4a6393237602b88bb0130d9f916972e930d95b3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1339339 > > Reviewed-by: Hans Wennborg <hans@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608783} > > TBR=hans > > Bug: 875037 > Change-Id: Iac24d9ec462cd4d5720d78a52b7f867be3ab2ec7 > Reviewed-on: https://chromium-review.googlesource.com/c/1344198 > Commit-Queue: Hans Wennborg <hans@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609974} TBR=thakis@chromium.org,hans@chromium.org,martiniss@chromium.org,ehmaldonado@chromium.org Change-Id: I1b2327216797da231e11427a29edece425cd35bd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875037 Reviewed-on: https://chromium-review.googlesource.com/c/1347333Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610177}
-
Yuchen Liu authored
Record whether the license is released or not in persistent storage. Add a new field "key_type" to persistent storage for each session. If the license is installed to the device successfully, we update the field with KEY_TYPE_OFFLINE. If the license is released, we should update the key type to KEY_TYPE_RELEASE to reflect this change. In case the JS doesn't provide any response from server and calls "load" again, we can check the key type to avoid restore released keys, which may lead to an exception. Bug: 883895 Test: link in the bug Change-Id: I4672bd0d640b2fd9faa8c6feae45894bd1aee062 Reviewed-on: https://chromium-review.googlesource.com/c/1327171 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#610176}
-
Mohamed Amir Yosef authored
This CL adds the ability to change a subscription from lazy to unlazy. Bug: 882887 Change-Id: I0dc68442feb2ac460b82896ee424c806f6613041 Reviewed-on: https://chromium-review.googlesource.com/c/1296603 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#610175}
-
Ned Nguyen authored
This updates wpt_expectations_updater to merge specifiers of same platform type to a simpler specifier when possible, but still keep separate expectation lines for different specifiers. This is needed for later CLs which will update Layout test expectation formats to no longer have mutual exclusive specifiers on the same expectation line (CL https://chromium-review.googlesource.com/c/chromium/src/+/1336439) Bug: 807751 Change-Id: Icd47c6d5d3f35a789ed266ee20fbb60dca382ac3 Reviewed-on: https://chromium-review.googlesource.com/c/1336912 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#610174}
-
lgcheng authored
1. Fix text size overflow issue for OOBE opt-in session. 2. Fix learn more text style inconstancy. TBR=xiyuan@chromium.org Bug: 907021 Test: Manual Change-Id: I6bd7ea9036a9bb89a139e02a2c1c15b33d3a1f60 Reviewed-on: https://chromium-review.googlesource.com/c/1345429 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610173}
-
Jan Krcal authored
This CL introduces a per-data-type metric for reporting configuration duration for in-memory (ephemeral) data-types. This is important for monitoring health of the end-to-end product. Bug: 894028 Change-Id: I3ee3f9f11d31b1eb49e5722eb12391a2dd05bb36 Reviewed-on: https://chromium-review.googlesource.com/c/1343085 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610172}
-
Denis Kuznetsov authored
This flow is using attestation-based flow, but provides extra EnrollmentToken along with Register request. TBR: alemate@chromium.org Bug: 854101 Change-Id: I9a0710dcffc7a2f68fe43097a9e0d321769ddf35 Reviewed-on: https://chromium-review.googlesource.com/c/1327211 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#610171}
-
Esmael El-Moslimany authored
When a div has its cursor style set to pointer, it is highlighted when clicked. This can be replicated on desktop using the dev tools device toolbar. When expand button does not have a label, the expand button is highlighted. The actionable attribute is used set the cursor style to pointer. The label div has has 0 dimensions when no label is slotted. Moving the actionable attribute down to the label div works for both when a label is present and missing. Bug: 907057 Change-Id: I23a0950b789c842739997554a3232c1805b3089e Reviewed-on: https://chromium-review.googlesource.com/c/1344819Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610170}
-
Becca Hughes authored
Add support for seeking to MediaController and the underlying media session. Consolidates the SeekForward/SeekBackward methods into a single Seek method. BUG=893296 Change-Id: I6e76406e2ec3d8afe3a31ae8acfdaf1dcbf667d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306297Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610169}
-