- 31 May, 2014 17 commits
-
-
pavely@chromium.org authored
It is not used anywhere. R=rogerta@chromium.org BUG= Review URL: https://codereview.chromium.org/301323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273968 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
This silences the false positive update warning, and starts with parts of Window's SystemTrayDelegate as a template to build on. BUG=none Review URL: https://codereview.chromium.org/292123014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273967 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Sets up a experiment that, when active, demotes all suggestions with inline autocompletions so that a suggestion without one (or, more precisely, a suggestion with an empty inline autocompletion) appears first / within the omnibox. BUG= Review URL: https://codereview.chromium.org/303013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273966 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=371150 TEST=no visible change to instant extended Review URL: https://codereview.chromium.org/292123015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273965 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
SSE2 is now the baseline for X86 platforms. BUG=378608 TEST=compiles Review URL: https://codereview.chromium.org/308003004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273964 0039d316-1c4b-4281-b951-d872f2087c98
-
jchaffraix@chromium.org authored
The Blink roll will make the test fail so disable the test temporarily. This was seen with the original author of the test <srawlins@google.com> as they think it's an easy fix. BUG=379339 TBR=mvanouwerkerk@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/308863005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273963 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
I'm doing to ultimately remove ContextFactory::Set/GetInstance(). BUG=none TEST=none R=jbauman@chromium.org Review URL: https://codereview.chromium.org/301233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273962 0039d316-1c4b-4281-b951-d872f2087c98
-
mfomitchev@chromium.org authored
The overlay is now dismissed after the first non-empty paint or the page load, whichever comes first. Removed all listening for repaints (OnUpdateRect). Also updated the code for overlay fadeout to avoid the need to repaint the overlay layer before the animation is started - we now fadeout the WindowSlider's layer if it was the one being shown when the fadeout was started. BUG=NONE Review URL: https://codereview.chromium.org/278173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273961 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Main thing that needed work here was the unittest. BUG=339726 Review URL: https://codereview.chromium.org/303263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273960 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
With the zoom refactor in flight: https://codereview.chromium.org/287093002/, zoom plumbing for BrowserPlugin in the content layer is now entirely dead code. We need to revisit zoom in the chrome layer for <webview> so that the embedder's zoom is propagated to the guests. This will be done at a later time when we need to get <webview> in WebUI working again. BUG=330264 TBR=jam@chromium.org for trivial browser_plugin_guest_delegate.h code deletion. Review URL: https://codereview.chromium.org/303423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273959 0039d316-1c4b-4281-b951-d872f2087c98
-
aboxhall@chromium.org authored
BUG=309681 R=asvitkine@chromium.org, dtseng@chromium.org, kalman@chromium.org Review URL: https://codereview.chromium.org/308003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273958 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://historytedchoc@chromium.org authored
$('alertOverlay') is null so the call for classList failed. Guard the condition to see if the element exists. BUG=379194 Review URL: https://codereview.chromium.org/301223009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273956 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
Review URL: https://codereview.chromium.org/309623003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273954 0039d316-1c4b-4281-b951-d872f2087c98
-
siggi@chromium.org authored
This is a minimal diff that refactors the key/value stash into a class. The next step is to pull the class implementation out to a separate implementation file and add a unittest. Also normalizes the use of the anonymous namespace to exclude functions that are DLL exports. BUG=378916 Review URL: https://codereview.chromium.org/302033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273953 0039d316-1c4b-4281-b951-d872f2087c98
-
alokp@chromium.org authored
Device pixel ratio is used to scale test rect and sampling locations. It can be non-integral on some devices. For example it is 1.325 on Nexus 7. The scaled quantities - dimensions of screenshot and sampled pixel locations - need to be converted to integers before they can be used. BUG=368495 Review URL: https://codereview.chromium.org/303113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273951 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
BUG=377636 TEST=run the test 50 times and no flakiness observed Review URL: https://codereview.chromium.org/306953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273950 0039d316-1c4b-4281-b951-d872f2087c98
-
alekseys@chromium.org authored
BUG=239879 Review URL: https://codereview.chromium.org/308713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273949 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 May, 2014 23 commits
-
-
groby@chromium.org authored
BUG=364821 NOTRY=true R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/306033005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273945 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
Right now ubsan=1 doesn't work with Chromium-packaged Clang because of missing libraries. BUG=174801 R=thakis@chromium.org Review URL: https://codereview.chromium.org/299403007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273944 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
BUG=379359 R=thestig@chromium.org TBR=thestig@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/307993008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273940 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
R=binji@chromium.org Review URL: https://codereview.chromium.org/304393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273938 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
This fixes a problem I saw this morning where we were alerting on any movement in jank, including improvements. BUG= Review URL: https://codereview.chromium.org/308863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273937 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
Improve the verification routines especially in the case that no count is necessary. Also add a test. R=darin@chromium.org Review URL: https://codereview.chromium.org/304303006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273936 0039d316-1c4b-4281-b951-d872f2087c98
-
kalman@chromium.org authored
(manifest or permission features). This fixes the availability data on accessibilityFeatures and bluetoothLowEnergy, among others; anywhere the API and dependency name differ. BUG=375615 R=rockot@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/302143003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273935 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Otherwise if the initial load does not induce a replaceState, there is not pageId in the history state to route to. Instead, always route from the URL. This allows us to just pass-through the page state. BUG=348948 TEST=See bug Review URL: https://codereview.chromium.org/306043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273934 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273932 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Widens an existing suppression to account for more script state leaks. BUG=364821 NOTRY=true R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/302093007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273931 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
This brings in dbd4c06 In linux and mac, use Arial to replace Tahoma for displaying east europe characters 64ab40e Fix xcode build. 961a34a Followup comments from https://codereview.chromium.org/298893007/ 40c4fb8 Fix a security issue in FPDF_GetMetaText by Bo Xu - 2 days ago 17211ae Do not use FX_BOOL for int values. 6387aff Fix licenses in headers to pass Chromium's checklicenses tool. 33729cd Add Lei to AUTHORS 9ea3da2 adjust output dir for msvs to fix msvs link error 2296d76 Change cc list to be pdfium-reviews@googlegroups.com db140c8 Use unsigned type for decoding in _A85Decode. 282e53d Fix memory leak on array size overflow. 2611932 Fix build error on Windows stand alone build Review URL: https://codereview.chromium.org/302143005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273930 0039d316-1c4b-4281-b951-d872f2087c98
-
prasadv@chromium.org authored
BUG=379195 Review URL: https://codereview.chromium.org/306023008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273929 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
ContextFactory::Set/GetInstance is going away and not necessary anymore. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/306123007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273926 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
happen if the URL is bookmarked and all its visits are deleted. BUG=377711 Review URL: https://codereview.chromium.org/300843004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273925 0039d316-1c4b-4281-b951-d872f2087c98
-
kmadhusu@chromium.org authored
patch from issue 308103003 BUG=none TEST=none TBR=samarth@chromium.org,sky@chromium.org,jered@chromium.org Review URL: https://codereview.chromium.org/308653007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273922 0039d316-1c4b-4281-b951-d872f2087c98
-
ch.dumez@samsung.com authored
Drop ENABLE_NEW_GAMEPAD_API build flag as it is no longer needed now that the Blink side has been updated and all the #ifdefs have been removed. R=dmichael@chromium.org, brettw@chromium.org BUG=344556 Review URL: https://codereview.chromium.org/302893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273921 0039d316-1c4b-4281-b951-d872f2087c98
-
bbudge@chromium.org authored
Adds resource and host, unit test for the resource, and an example plugin. Implements only the hardware accelerated case. Software fallback will be in a follow-on CL. Adds two new PP_Error codes: PP_ERROR_UNREADABLE_INPUT PP_ERROR_PLATFORM_FAILED BUG=281689 R=dmichael@chromium.org, fischman@chromium.org, jar@chromium.org, piman@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/270213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273920 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
R=yzshen@chromium.org Review URL: https://codereview.chromium.org/304233011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273919 0039d316-1c4b-4281-b951-d872f2087c98
-
sbc@chromium.org authored
This change contains most of the changes that clang-format wanted to make to nacl_io. I left out a few that we not obviously better, mostly related to complex PPAPI macros. R=binji@chromium.org, binji BUG= Review URL: https://codereview.chromium.org/303223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273918 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
The very first invocation of [NSCursor push]/[NSCursor set] leaks, intentionally. Suppress all invocations for now. ([NSCursor set] only in the suppressions, seems -push seems to get inlined. BUG=257276, 379331 TBR=thestig@chromium.org, shess@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/303123009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273917 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
Chrome OS specific garbage collection in addition to profile specific clean up also cleans up shared location but only once regardless number of logged in users. BUG=235263 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273763 R=asargent@chromium.org Review URL: https://codereview.chromium.org/303693011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273916 0039d316-1c4b-4281-b951-d872f2087c98
-
tonyg@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/308843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273915 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
> skia: Use medium filter quality in PaintSimplifier. > > Preventing all bitmap filtering in the paint simplifier is a bad > idea as it's very cache unfriendly when down-sampling due to > requiring both the full size decoded image and the high/medium > quality image normally used to be cached for good performance. > > However, forcing medium quality filtering is worthwhile as it's > faster than high quality and still provides caching benefits. > > BUG= > > Review URL: https://codereview.chromium.org/305623008 Looks like this had a negative effect on memory usage. TBR=reveman@chromium.org BUG=379164 Review URL: https://codereview.chromium.org/308703006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273914 0039d316-1c4b-4281-b951-d872f2087c98
-