- 07 Nov, 2018 40 commits
-
-
dpapad authored
Test steps: 1) Build Android Chrome once ninja -C out/gchrome/ chrome_public_apk 2) Touch a WebUI target that was previously unnecessarily included as a dependency, for example: touch chrome/browser/resources/md_history/app.js 3) Build Android Chrome again. There should be nothing to do. Bug: 901261 Change-Id: If81312b54bc785bc4faced24d3f516b029fd1d86 Reviewed-on: https://chromium-review.googlesource.com/c/1324195Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606199}
-
Xiaohan Wang authored
When ENABLE_MOJO_CDM is false, we should still support ClearKey key system, hence use DefaultCdmFactory in this case. Thanks to yucliu@ for finding this issue. Change-Id: I72d730497daefb6c0c2709915a9ee3ec482e1125 Reviewed-on: https://chromium-review.googlesource.com/c/1324191Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606198}
-
Dale Curtis authored
Variably length arrays tend be less efficient than alloca(); see https://www.phoronix.com/scan.php?page=news_item&px=Linux-Kills-The-VLA BUG=none TEST=cq R=sergeyu Change-Id: Ibb16415b960b1ab5b262fab39537c7cf63ce5586 Reviewed-on: https://chromium-review.googlesource.com/c/1324196 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606197}
-
Erik Luo authored
(Behind experiment) - Navigate to linkified substrings via keyboard - Press Enter on a selected link to navigate to it This CL does NOT cover anchors. Links produced outside of Console will be addressed in a followup, e.g. BrowserConsole's Network logs, JSPresentationUtils' stack trace Bug: 865674 Change-Id: Ib0e1c39823801a9403dcdcf8b68d884197ed9690 Reviewed-on: https://chromium-review.googlesource.com/c/1317925Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606196}
-
Antoine Labour authored
Previously, InProcessGpuThreadHolder initialized texture_target_exception_list according to the production expectations, in particular assuming native GMB types when available. However all unit tests use viz::TestGpuMemoryBufferManager (if any GMBManager at all) which only produces shared memory GMBs. This means the wrong target will be used for those. It's mostly harmless on Mac (GL_TEXTURE_RECTANGLE_ARB) but no so much on other platforms (GL_TEXTURE_EXTERNAL_OES which doesn't allow glTex*Image*). Instead, leave texture_target_exception_list empty, individual tests can initialize it if they need (e.g. if they use a GpuMemoryBufferFactory). Bug: 897214 Change-Id: I55984ef49797fa97f00e2bda35b60a4e6ba734bc Reviewed-on: https://chromium-review.googlesource.com/c/1322610 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606195}
-
Vlad Tsyrklevich authored
A subsequent refactor moves the singleton into client/. Remove it from common, turn :common back to a static_library, and restructure the constructor back into an Init() method to accomodate the new singleton design. Bug: 896019 Change-Id: I7bfe4b996b165ba34831565160c8ef46f3e48498 Reviewed-on: https://chromium-review.googlesource.com/c/1322111 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#606194}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5ee1c6aed6c..fd5e90efc65a git log d5ee1c6aed6c..fd5e90efc65a --date=short --no-merges --format='%ad %ae %s' 2018-11-07 derat@chromium.org chromeos_config: Run Tast VM tests on betty-pre-cq. Created with: gclient setdep -r src/third_party/chromite@fd5e90efc65a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17fdd4d6ec54e413e95e0ca5f91c31b6ca5acca5 Reviewed-on: https://chromium-review.googlesource.com/c/1323634Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606193}
-
Christian Biesinger authored
R=dgrogan@chromium.org Change-Id: I9570f9a1821c137f23df235393e8b99ce980a8fe Reviewed-on: https://chromium-review.googlesource.com/c/1324235 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#606192}
-
Shakti Sahu authored
This CL attempts to limit scaling of very tiny images to a certain factor. The contents would still be drawn within the rounded rect. It also separates the full-width image to a different view holder which would prevent resizing issues of AsyncImageView on reuse. Bug: 902950 Change-Id: I804ae1ba44db7c875860a395161b5c9eba4e7147 Reviewed-on: https://chromium-review.googlesource.com/c/1297357 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#606191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/28f76deac908..19757a1acfeb git log 28f76deac908..19757a1acfeb --date=short --no-merges --format='%ad %ae %s' 2018-11-07 tsepez@chromium.org Remove some redundant C-style casts in cjs_event.cpp 2018-11-07 tsepez@chromium.org No V8: ifdef out more of cpdfsdk_formfillenvironment.h 2018-11-07 tsepez@chromium.org Beef up cfx_globaldata_unittest.cpp. 2018-11-07 thestig@chromium.org Remove some checks that are never true in patterns code. 2018-11-07 tsepez@chromium.org Fix stray whitespace in fpdfsdk/DEPS. 2018-11-07 tsepez@chromium.org Render annotation in annotation_ink_multiple.pdf. 2018-11-07 tsepez@chromium.org Add EmbedderTest::LoadPageNoEvents() and UnloadPageNoEvents() Created with: gclient setdep -r src/third_party/pdfium@19757a1acfeb The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1a3435681dc1227c93c6af34b2f46ca549fc3efb Reviewed-on: https://chromium-review.googlesource.com/c/1323635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606190}
-
Kristi Park authored
Allow users to reorder their custom links with drag and drop. Screencast: https://screencast.googleplex.com/cast/NDkxMzY1Mzc2OTgzMDQwMHxmY2JhMTNkYy01NQ Bug: 851335 Change-Id: I8e77fbdd7c10ec95f60dc5a41e45ae06f7a62543 Reviewed-on: https://chromium-review.googlesource.com/c/1309228 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606189}
-
Matt Falkenhagen authored
This reverts r581129. The metric is expiring and not needed, see bug. Bug: 902100 Change-Id: I3af413975f42dbf12003746fefd08f1b2245e78f Reviewed-on: https://chromium-review.googlesource.com/c/1322171Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606188}
-
Matt Falkenhagen authored
The owner is auto cc'd on restricted bugs. Also UMA cannot be accessed externally anyway, so it's more appropriate for the internal group. Change-Id: I077d287a6951ec153224628b3597ea3e77b02acf Reviewed-on: https://chromium-review.googlesource.com/c/1321654Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606187}
-
Dan Harrington authored
Auto-fetch requests will be canceled if the page is loaded in the foreground. This CL ensures that background loading doesn't take place while the foreground active tab still points to the requested URL, since it has a good chance of eventually loading. Bug: 883486 Change-Id: I4cf8b039ed5dc92aea08c9e0f7b597893f880113 Reviewed-on: https://chromium-review.googlesource.com/c/1313567 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#606186}
-
Mitsuru Oshima authored
This is a workaround. Using fully opaque color somehow causes the content clipping on the arc content window. It'll be investigated separately. Bug: 901538 Test: manual. Change-Id: Ifee1ccdeb3e877008f33ef62ba1dd5024bb4b196 Reviewed-on: https://chromium-review.googlesource.com/c/1324393Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606185}
-
Robert Ma authored
Using wpt-import in Chromium bc37aee6. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." d2f6756a "Window onerror is not triggered bug fix" Manual import because of https://crbug.com/869360 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations msisov@igalia.com: external/wpt/webvtt NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I54fc4f16d88df8a3d2ba0ca948c728407e81adba Reviewed-on: https://chromium-review.googlesource.com/c/1323696 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#606184}
-
Douglas Stockwell authored
web-animations-js has some performance impact in wrapping native `requestAnimationFrame`. In the case of PDF, none of the polyfilled behavior is necessary as the animation effects are trivially implemented through native `element.animate`. R=dsinclair@chromium.org, hnakashima@chromium.org Change-Id: I9ab09a91e697a491f0c57009293333053a79f618 Reviewed-on: https://chromium-review.googlesource.com/c/1322178Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#606183}
-
Adrienne Walker authored
Followup to 3212ece4 which only handled single thread. FindIt indicates that multithread is at fault as well. Bug: 902644 Change-Id: If774e275f4a7f146993661ac4472978856eb1b00 Reviewed-on: https://chromium-review.googlesource.com/c/1324416 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#606182}
-
Mihai Sardarescu authored
This CL add a source for update and revoke credentials operations. It then surfaces the source in the chrome://signin-internals page. This CL also records the following histograms that track refresh token events: * Signin.RefreshTokenUpdated.ToValidToken.Source * Signin.RefreshTokenUpdated.ToInvalidToken.Source * Signin.RefreshTokenRevoked.Source These histograms are needed to validate the assumptions of how often tokens are revoked by the browser and the sources for the token revocations. Bug: 896182 Change-Id: I2fcab80ee8e5699708e695bc3289fa6d34859a90 Reviewed-on: https://chromium-review.googlesource.com/c/1286464Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#606181}
-
Ben Wells authored
These were previously prevented due to strict checking by the installation pipeline that isn't appropriate for web apps that have been explicitly installed (either by users or the system). The specific check was that the display in the manifest is one of standalone, full screen or minimal. This meant web apps that were installed with a browser display setting (e.g. showtime) would fail. This check is now gated behind an option, that is on by default. The desktop web app installation disables this option. Bug: 882945 Change-Id: I84d97d713d358c849d8480299604310dd08efb2a Reviewed-on: https://chromium-review.googlesource.com/c/1322262Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#606180}
-
Roger Tawa authored
When the user enters an old password into the credential provider after a password change, make sure to use an appropriate message. At the same time make sure that all error paths return a valid string otherwise a blank error will be shown. Bug: 902706 Change-Id: I2835f8b11d8f1f116e64333d47515115b642b066 Reviewed-on: https://chromium-review.googlesource.com/c/1323270Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606179}
-
Dale Curtis authored
Apparently it's in the 96th percentile by size and we haven't a need for it anymore. BUG=902185 TEST=none Change-Id: I12dec552bacb9942eea15ccd4e139527155f77ea Reviewed-on: https://chromium-review.googlesource.com/c/1321587Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606178}
-
Dale Curtis authored
Extremely high frequency, but apparently useless, so remove. BUG=none TEST=none Change-Id: I6da011e77b724914be1a9829c1464397e3523cf0 Reviewed-on: https://chromium-review.googlesource.com/c/1321790Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#606177}
-
Saman Sami authored
There is no reason to keep the surface alive if it's explicitly evicted. Bug: 893793 Change-Id: I95b77abb386345368dbb8a295b695543aa94a749 Reviewed-on: https://chromium-review.googlesource.com/c/1321259 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606176}
-
Jun Mukai authored
TabDragging's PressSecondFingerWhileDetached/0 is still failing, and this fails due to a corner case of focus and visibility handling in the window system; - the test scenario falls into a certain gesture, which will minimize the dragged window https://cs.chromium.org/chromium/src/ash/wm/workspace/workspace_window_resizer.cc?g=0&l=594 - TabDragController restores focus at the end of dragging https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller.cc?g=0&l=1433 On the classic environment, this shows the dragged window and re-activates it, while it fails to activate on Mash, and so it fails at https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc?sq=package:chromium&g=0&l=2576 This CL allows focus directly on the minimized window; - DesktopWindowTreeHostMus shouldn't early-return if the window is invisible because of minimized status - DesktopFocusRules should check the minimized status too, otherwise FocusController can't find the focusable / activatable windows - TestWindowService should take care of synchronizing the window's show state and its visibility. The DesktopWindowTreeHostMusTest's case is changing the window state but not changing the visibility. - sometimes a window is created with minimized status. DesktopWindowTreeHostMus::Show() needs to take care of such situation, otherwise it isn't starting with minimized status. BUG=902598 TEST=the edited test case and unfiltered test case Change-Id: Icae808806ba134a3789b39438179818011379064 Reviewed-on: https://chromium-review.googlesource.com/c/1321859Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#606175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39f97da7dc62..1f3ebd2b9a65 Created with: gclient setdep -r src-internal@1f3ebd2b9a65 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic61fca0fbecff9a628b4e545821d25d61515edb3 Reviewed-on: https://chromium-review.googlesource.com/c/1323633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606174}
-
Tien Mai authored
Fix some missing permissions for the logon stub process needed to be able to run Chrome during winlogon Bug: 887444 Change-Id: Ie6c54855cee2b95ef6cb0de1829251d324548733 Reviewed-on: https://chromium-review.googlesource.com/c/1301850 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606173}
-
Livvie Lin authored
Bug: 900031 Change-Id: I58e2846c9dd447bed42983db49b1d1ecf0e235b6 Reviewed-on: https://chromium-review.googlesource.com/c/1321671 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606172}
-
Stephen Martinis authored
This reverts commit 3b04594a. Reason for revert: builder has recovered. Original change's description: > Remove chromeos-amd64-generic-rel from CQ > > The bot is broken at the moment. > > NOTRY=true > > Bug: 902806 > Change-Id: I1ee551c95617444e5ec4edbdb3d8d4fde6d7dc5f > Reviewed-on: https://chromium-review.googlesource.com/c/1324090 > Commit-Queue: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606093} TBR=martiniss@chromium.org,bpastene@chromium.org,jbudorick@chromium.org Change-Id: I6c4f751514d9fc67ccf4004643f2368cc5effc68 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902806 Reviewed-on: https://chromium-review.googlesource.com/c/1324415Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#606171}
-
danakj authored
Why would the browser be changing the page visibility after it has detached the main frame, closing the RenderWidget and destroying the WebView? It wouldn't. R=dcheng@chromium.org Change-Id: Ibc49c8b9ffbcf174819d88423125ca2e47c775d8 Bug: 894899 Reviewed-on: https://chromium-review.googlesource.com/c/1323698 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606170}
-
Greg Kerr authored
Bug: 902597 Change-Id: I4c9b9866fabfb3e41ee29c8cafc8fab1d4e19526 Reviewed-on: https://chromium-review.googlesource.com/c/1324190Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606169}
-
Geoff Lang authored
The GL_COMMANDS_COMPLETED_CHROMIUM and GL_READBACK_SHADOW_COPIES_UPDATED_CHROMIUM query types are implemented using fences but some fence types are not guarenteed to be marked as complete after a glFinish. Force them to mark the query as completed after a glFinish, the client expects this. BUG=894781 Change-Id: I77517f54ecc557c949ee20a26b54d67fa79cb0d9 Reviewed-on: https://chromium-review.googlesource.com/c/1315689 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#606168}
-
Istiaque Ahmed authored
In all the cases, we require an extension ID to be present to interact with RulesRegistry, so add checks for extension's presence in RulesRunfunction. This handles IPC Fuzzer NPE test case by killing the offending renderer. Bug: 901674 Test: See fuzzer test case. Change-Id: I8bf6e223a38be6da1666c7633d6f0b7ec45e697a Reviewed-on: https://chromium-review.googlesource.com/c/1318532Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606167}
-
Jonathan Backer authored
TBR=piman@chromium.org Change-Id: I9213cbc82da275f828b79dc50e1e1a339c129ac4 Reviewed-on: https://chromium-review.googlesource.com/c/1323804Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#606166}
-
Boris Sazonov authored
This CL makes ToolbarPhone.mMenuButton private without any changes to the behavior. Bug: None Change-Id: I267a9926dfa63614168ac7ada2a35629591222c0 Reviewed-on: https://chromium-review.googlesource.com/c/1323671Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#606165}
-
Ken Rockot authored
This adds a simple base::Token type which supports random generation OR constexpr construction from fixed values. Trivially changes UnguessableToken to be implemented on top of Token. Token and UnguessableToken are essentially the same data type, with Token having weaker constraints on what qualifies as valid usage. Specifically, it is considered valid and reasonable to construct constexpr Token objects over pre-generated random values. Bug: 895591 Change-Id: I9fdc0eafdb1dd184a4f013c93708bc2136e6095f Reviewed-on: https://chromium-review.googlesource.com/c/1320190 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606164}
-
Anthony Vallee-Dubois authored
This patch triggers auto translate behavior on navigations started from <a> tags that have an hrefTranslate attribute. It also merges the tests written by Aaron in https://chromium-review.googlesource.com/c/chromium/src/+/1227173. Bug: 900586 Change-Id: I1b8e23651ff839ab8cafadf02e72ac6ceca108de Reviewed-on: https://chromium-review.googlesource.com/c/1315949Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#606163}
-
Vikas Soni authored
This is a reland of 4df3f6e1 with some changes to not seperate out vulkan and GL constructor for RasterDecoderContextState. Original change's description: > Add VulkanContextProvider to RasterDecoderContextState. > > Add VulkanContextProvider to RasterDecoderContextState which is needed > to get VkDevice in shareable image. Refactor RasterDecoderContextState > class to have seperate constructors for Vulkan and GL. > > Bug: 891060 > Change-Id: I0ca7e657d33fdcfa62ab6465f7023a914610b7ce > Reviewed-on: https://chromium-review.googlesource.com/c/1312194 > Commit-Queue: vikas soni <vikassoni@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605146} Bug: 891060 Change-Id: Id2f4ae194445861f59ea24299f98cc94c477be98 Reviewed-on: https://chromium-review.googlesource.com/c/1320512 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606162}
-
Dave Tapuska authored
The feature first shipped two stable releases ago in M69. Bug=848890 Change-Id: Id969cf348d9523ec50803d7feadec7071b652730 Reviewed-on: https://chromium-review.googlesource.com/c/1323770Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#606161}
-
Thomas Guilbert authored
This reverts commit 43dcbdf0. Reason for revert: 902871 Original change's description: > Add RemotingAppLauncher and DefaultRemotingApp > > The RemotingAppLauncher instantiates RemotingApps at runtime. It uses > the app manifest to find class names of RemotingApps, and loads them via > reflection. > > The DefaultRemotingApp is a simple wrapper around the default media > receiver application. > > Bug: 790766 > Change-Id: I01f51ebe90de361b947d67fe904a2faddc35f5de > Reviewed-on: https://chromium-review.googlesource.com/c/1306778 > Reviewed-by: Zhiqiang Zhang <zqzhang@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605389} TBR=dtrainor@chromium.org,zqzhang@chromium.org,tguilbert@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790766 Change-Id: I3995a570a71923053711bb1ea491f9d24521fdea Reviewed-on: https://chromium-review.googlesource.com/c/1324194Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#606160}
-