- 21 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: Ic72a6611ab418566180ee72608e1115b1d1e9db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007816 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733731}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: Ie97c0f54434c8cb5aaa030e0fa54b05b5466032a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007466 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Greg Daniel authored
This reverts commit 9feadb9f. Reason for revert: Fix has landed in chrome Original change's description: > Suprress failing tests Pixel_WebGL (vulkan_pixel_skia_gold_test) > > Skip failing tests of vulkan_pixel_skia_gold_test: > Pixel_WebGLGreenTriangle_AA_NoAlpha > Pixel_WebGLTransparentGreenTriangle_NoAlpha_ImplicitClear > Pixel_WebGLGreenTriangle_NoAA_NoAlpha > > TBR=bsheedy@chromium.org > > Bug: chromium:1042693 > Change-Id: I9dc03d61a9e28a6b035a33058acff27697f23df0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003557 > Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org> > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#732444} TBR=bsheedy@chromium.org,behdadb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1042693 Change-Id: I0195d6c320cecacb91420a40fe695235e4a95cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012906Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#733729}
-
Shakti Sahu authored
This CL handles some histograms that are reaching expirations. Removed histograms : Download.Service.Files.Cleanup.Attempts.* Android.DownloadManager.Chips.Enabled Extended histograms : Android.ThumbnailDiskStorage.* Android.DownloadManager.Thumbnail.MaxRequiredStretch.* Android.ThumbnailProvider.BitmapCache.Size.* Android.ThumbnailProvider.CachedBitmap.Found.* Download.Service.Upload.HasUploadData.* Download.Start.ContentType.NormalProfile.* Bug: 1037057, 1037482, 1037054, 1034594, 1034593, 1034592, 1034586, 1034584 Change-Id: I5d7e42d98e79e3cd2cde0b90b5b831b915d86b39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000970 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#733728}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/804b4adfa9e9..8f5aa560c98d Created with: gclient setdep -r src-internal@8f5aa560c98d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I2cc09b2c6573d03f7bf3ed2327ed3cdfdcf83044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013207Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#733727}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: I21c2b6e63b6b329eb215bef2dc87b15f4fb872b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007580 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 983940 Change-Id: Ie46727c855e23f5c8f4b33767275fd2c97ea436c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010798 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#733725}
-
Brandon Wylie authored
When focusing/unfocusing the omnibox with the search engine logo feature enabled, there are some bad looking omnibox transitions where it will go from padlock -> globe -> search loupe when focusing, and search loupe -> globe -> padlock when unfocusing. Adding in logic to smooth out these transitions and adding some unit tests along the way. Bug: 1031232 Change-Id: I03f9a97a0900e9ddcef95bd9f80bc5572750b567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990208Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#733724}
-
Anastasia Helfinstein authored
This change removes code that sets the role of the above icons to button. Having this annotation prevented Switch Access from opening the status tray, and did not provide useful semantic information for ChromeVox or other accessibility features. Bug: 1023006 Change-Id: Ieb8e5389bbd9444617f3fbcdf1a6d08e805803bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005815Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#733723}
-
Julian Pastarmov authored
The histograms still deliver useful metrics about the usage and health state of the feature. Bug: 1037331 Change-Id: Id7d8cf148bcf3e933674de03202cc236e6f76404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011802 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Auto-Submit: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#733722}
-
Bettina authored
Use signon_realm as std::string instead of GURL because the signon_realm in Android is a string in password_specifics. To make it compatible for all platforms and easier to maintain, use a std::string all around. The only method that isn't touched here is RemoveRowsByUrlAndTimea as it uses a filter that needs a GURL. Bug: 1042117 Change-Id: I7c63981d4dd608ea22da8906a2d4144c08e8787c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001346 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733721}
-
Alex Cooper authored
Shows the status of the AR/VR permissions on the Android PageInfo bubble and in site settings. Strings are placeholders Bug: 1033592 Change-Id: I694ff1f8af812acdafd4be3446e9f31751a8d3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994304 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 30 histograms that show frequent access in the past 90 days. These are the 86% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-07-19. Change-Id: If175be9590842bf9db2d73e696c2830615afbd11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012828 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
-
Nico Weber authored
`gn format` recently changed its formatting behavior for deps, source, and a few other elements when they are assigned (with =) single-element lists to be consistent with the formatting of updates (with +=) with single-element. Now that we've rolled in a GN binary with the change, reformat all files so that people don't get presubmit warnings due to this. This CL was uploaded by git cl split. R=agrieve@chromium.org Bug: 1041419 Change-Id: Ia44520196c6007b0c9c8802d9d8e122192d2252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997824 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#733718}
-
Azeem Arshad authored
This CL removes the enable-service-worker-long-running-message flag. This feature has already been removed in an earlier CL (https://crrev.com/c/1789966) and is not required anymore. Bug: 869714 Change-Id: I4c9924d1c0ec28ca411ff87b58b526f6739850a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008622Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#733717}
-
Ben Joyce authored
Bug: 1019186 Change-Id: Ief330ebb44d58d54b91d8d88fe1a2ea61f703b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013262Reviewed-by:
-
David Van Cleve authored
//components/sqlite_proto was initially a direct move of the SQLite-wrapping key-value store implementation from //chrome/browser/predictors. This change renames the classes to be more generic, by deleting all occurrences of "loading predictor" and variants. It also: - unfriends a class from //chrome/browser/predictors and updates the interface to KeyValueData (fka LoadingPredictorKeyValueData) accordingly. - adds tests to provide for some redundancy in coverage in case the current client code changes. Bug: 1036494 Change-Id: Ibe2c6d336e29f854c0e75997cd8fd38e18d30ef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978948 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733715}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I4daeee79c3f215dcdc200ed775b95e4f21f09011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007639 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#733714}
-
Chong Gu authored
Add a --headless switch that can be used when starting web_engine_shell, disables view presentation if enabled. Bug: 927966 Change-Id: I2a6fe47a511567f3308db731c3b7ee12e98e2d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007876Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#733713}
-
Jonathan Freed authored
Change-Id: Ibbb567b9e2f526231a3271c5b50c77bd9ae50846 Bug: 1035491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974584Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Jonathan Freed <freedjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#733712}
-
Sophie Chang authored
Bug: 1036490 Change-Id: I5112c1183b4f654d17b45ef0e1551a0bd510e2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006491 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#733711}
-
Sylvain Defresne authored
[ios] Use chrome_browser_state_forward.h in /ios/chrome/browser/ui/browser_view/browser_view_controller_dependency_factory.h Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=edchin@chromium.org Bug: 1042208 Change-Id: I05e290342c6fe16634b3fc538d701f1d84701389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007742 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Alexander Cooper authored
This reverts commit def2d4ba. Reason for revert:Suspect fixed with issue 1034735 The fix for 1034735 landed the same day this test was disabled. From the flakiness dashboard, it seems like the last flaky run did not have this fix, and subsequent runs were still green. Re-enabling as it is suspected that 1034735 actually fixed this flakiness Original change's description: > Android: disable flaky VR test > > No change to logic. This disables a flaky test on < M only, since it was > only observed to flake on Lollipop. > > TBR=bsheedy@chromium.org > > Bug: 1039890 > Test: None > Change-Id: I15d7600b9eacc7c333d62fcdb796e258deef2c75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990026 > Reviewed-by: Nate Fischer <ntfschr@chromium.org> > Commit-Queue: Nate Fischer <ntfschr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729179} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1039890 Change-Id: Idb7c4b5479e53cd79ad039792a1d7365c4cc8e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013003Reviewed-by:
-
Dave Tapuska authored
The class brings no benefit over gfx::Point. Use the gfx::Point so we can eliminate code duplication. BUG=640049 Change-Id: I20d885c68478d14f8dfe5982d4cde93a63764aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007474 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Etienne Pierre-Doray authored
This reverts commit f5886456. Reason for revert: Causes slow renderers on startup with bit9 (See issue 1021701). Original change's description: > [Setup]: Use memory mapped files in LzmaUtilImpl. > > This CL removes usage of LzmaFileAllocator and tries to write unpack > result directly in the output file. > When uncompressing a folder that maps directly to a file, this is > possible and a memory mapping is used. In practice, this is always > the case. Support for folder containing multiple files is kept as > fallback and uses a pre-allocated file buffer, which is then copied in > individual files. > > For running full setup install from chrome.packed.7z (Kb) > Before: > Setup.Install.PeakPagefileUsage 19748 > Setup.Install.PeakWorkingSetSize 250528 > GetCumulativeDiskUsageInBytes 761134 > After: > Setup.Install.PeakPagefileUsage 19720 > Setup.Install.PeakWorkingSetSize 250512 > GetCumulativeDiskUsageInBytes 297818 > > The difference in memory is not significant, but improvement > are expected mostly for disk usage. > > Bug: 933975 > Change-Id: I26c1b118fc512d2caaa8112d3da37e6db460486b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845956 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709940} TBR=grt@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933975, 1021701 Change-Id: I478cbb2464638096482601db533465062c4f5454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994905 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#733707}
-
Jiajun Ou authored
Some details: - Add a class property setting |chromeLongPressAndForceTouchHandlingEnabled| to CWVWebView. - A virtual const method |EnableLongPressAndForceTouchHandling()| is added to web_client to pass the above setting to //ios/web. - Add methods to web_state_delegate_bridge. - Eagerly creating WKWebView in CWVWebView's initializers now. - A fix to |ResetWithWebViewConfiguration()| to make it a real "reset" function. Design Doc: https://docs.google.com/document/d/1VpDvrS9pvjKwPOIwc1-vXKFptOJHLY45hCxUl0z_MnQ Calling Flow: Apple's WebKit Framework -> crw_wk_ui_handler.mm self.webStateImpl --via web_state_impl.mm--> web_state_delegate.h web::WebStateDelegate --’s subclass--> web_state_delegate_bridge.mm web::WebStateDelegateBridge -> web_state_delegate_bridge.h CRWWebStateDelegate (CWVWebView implements this delegate) -> the user-implemented delegate CWVUIDelegate (shell_view_controller.m in this case) Bug: 1029270 Change-Id: I0e01fee627bd331ada3778ac4b3a0774cc712118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960047Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jiajun Ou <garzonou@google.com> Cr-Commit-Position: refs/heads/master@{#733706}
-
Maksym Onufriienko authored
Updated generated test_results.json to have the format described here https://chromium.googlesource.com/chromium/src/+/master/docs/testing/json_test_results_format.md Bug: 1032141 Change-Id: I3bbd9f75b31a79d0ecc08353bd857abd0c0736d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967965 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#733705}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I4558781852c15c7eda3ca8b503bccee013cb462e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010763 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Matthew Mourgos authored
Since an animating background layer is already used to visually animate the position of the ShelfWidget's |opaque_background_|, this change also creates an animating layer for the drag handle. This animating drag handle is a child of the animating background layer. This makes the animating drag handle follow the already existing animation for the animating background layer. Bug: 1040303 Change-Id: I452fba942f88e7194690d8937c22b10b7907a7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001852Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#733703}
-
Xing Liu authored
Update notification on Android is migrating to notification scheduler system. This flag needs to be kept for development purpose. So expand to M83. TBR=dtrainor@chromium.org Bug: NONE Change-Id: I7f341a35fd01397d30ebb0b71f6f37a309a93023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012623Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=eugenebut@chromium.org Bug: 1042208 Change-Id: Ia7b458b9629a49c87dbae15a7231e369730e513d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007762 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
Devtools was crashing using FlexNG as various sizes were going below zero. This was occurring as we were subtracting scrollbars from the min/max sizes, and this patch removes this logic. Bug: 845235 Change-Id: I3abb0594a94e3f23953bcab5f1dd0638468b063f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012161Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#733700}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 1042208 Change-Id: I01d3540bee98e66b436e82135179f05dddc6ee5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007745 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Thomas Tellier authored
Bug: 1028943 Change-Id: I32357a5f8673d4c12a583478525dbce682aa1e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992421Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#733698}
-
Henrique Nakashima authored
Use SharedPreferencesManager consistently instead of SharedPreferences directly. Move the usages to methods in SigninPreferencesManager. Bug: 1022108 Change-Id: Ibf5806daee967b14b5a4af1584f00038ad7ebaca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011287Reviewed-by:
-
Elly Fong-Jones authored
This has never been on by default and it doesn't look like it will be any time soon. We'll stick with the Cocoa task manager for the foreseeable future, so remove the flag and stop compiling the Views task manager or its tests for Mac. Bug: 836957 Change-Id: I0ed80f4e57c8bea11b46e9992c109e446b446fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012881Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#733696}
-
Peng Huang authored
For vulkan non surface controla case, the impl_on_gpu_->gl_surface() could be nullptr, so we need to check it to avoid accessing the nullptr. Bug: 1041931 Change-Id: I137aea162a679eb61af7006aff083ff5a02c9dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012805 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#733695}
-
Maksim Ivanov authored
Implement displaying the "TPM firmware update required" error on the Login Screen, in case this error is received from the cryptohomed daemon. This error is currently only generated when a smart card authentication is attempted to be used on a Chromebook with a TPM chip that is known to be ROCA-vulnerable (see https://www.chromium.org/chromium-os/tpm_firmware_update). In order to fix the error the user or the admin need, as described in the error message, to install the update of the TPM's firmware according to the instructions. Before this CL, the only thing the user would see is that the login fails for some unknown reason. Bug: 1011327 Test: manual - find a device with a ROCA-vulnerable TPM 1.2 chip, try to add a new user using a smart card, check that the error is displayed Change-Id: I0039950903196f702994404304c8d89da7e93879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010985 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#733694}
-
Brian Ho authored
Currently, WebGPU does not work on Linux or Chrome OS devices with Intel GPUs because Chrome's GPU process sandbox blocks various syscalls from the Vulkan loader (invoked from vkCreateInstance), libdrm, and the i915 implementations of vkEnumeratePhysicalDevices. In particular, we need: - Whitelist the Vulkan ICD directories and files (icd.d/ and icd.d/intel_icd.x86_64.json) [1] - Whitelist /dev/dri for open [2] - Recursively whitelist /sys/dev/char for stat and read-only access [3] - Whitelist getdents (used in the implementation of readdir) [4] While these are significant changes, they all seem to be already whitelisted for GL support on AMD GPUs [5][6]. This CL simply makes a corresponding fork for Intel GPUs. For more information, refer to go/chrome-sandbox-changes-webgpu-intel. [1] https://github.com/KhronosGroup/Vulkan-Loader/blob/08d344208e60e0bb8c8fbe25b9b1f2bf63801e2f/loader/loader.c#L3674 [2] https://gitlab.freedesktop.org/mesa/drm/blob/master/xf86drm.c#L3950 [3] https://gitlab.freedesktop.org/mesa/drm/blob/master/xf86drm.c#L3687 [4] https://stackoverflow.com/questions/36144807/why-does-linux-use-getdents-on-directories-instead-of-read [5] https://cs.chromium.org/chromium/src/services/service_manager/sandbox/linux/bpf_cros_amd_gpu_policy_linux.cc?l=39&rcl=bc8a41f43cad861be651e2344a8c131881cfdc60 [6] https://cs.chromium.org/chromium/src/content/gpu/gpu_sandbox_hook_linux.cc?l=171&rcl=bc8a41f43cad861be651e2344a8c131881cfdc60 Bug: 1021275, 996470, 866567 Change-Id: I07ee030165ed91839a055b0c99eeb5a1f6546bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954245Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#733693}
-
Adam Langley authored
Extensions don't have a domain name, which begs the question of what the RP ID for an extension should be. This change defines the RP ID for extensions to be their origin, i.e. “http(s)” is now special in that the origin gets its scheme and port removed in order to form an RP ID. For other origins that doesn't happen and thus the RP ID is just the origin string. Since extensions are not a concept in content/, allow the embedder to handle this mapping and add a mapping for chrome-extension:// in the Chrome embedder code. Change-Id: Ie6453469404a81f5589843177d935c07eac8b59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979591Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#733692}
-
