GitLab

https://android.googlesource.com/platform/external/perfetto.git/+log/fe37d1fa52f1..631e93892acf

git log fe37d1fa52f1..631e93892acf --date=short --first-parent --format='%ad %ae %s'
2020-01-31 taylori@google.com Merge "perfetto-ui: Make track selection work with pinned tracks"
2020-01-31 fmayer@google.com Merge "Use correct self count for `objects`."
2020-01-31 lalitm@google.com Merge "tp: convert to index vector when filter is followed by sort"
2020-01-31 lalitm@google.com Merge "trace_processor: delete old table code"
2020-01-31 lalitm@google.com Merge "trace_processor: add benchmark for filter followed by sort"

Created with:
  gclient setdep -r src/third_party/perfetto@631e93892acf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I5728fdbc4ec945ed367fa8e1e876e4b9e0d4a39a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033118Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737346}

This patch just moves some code around so that it is a little better
organized. There are no behavior changes here, just some comments and
reoderdering.

This is split off from
https://chromium-review.googlesource.com/c/chromium/src/+/2028177

R=rakina@chromium.org, yosin@chromium.org

Change-Id: Ib4862e5a9baee36e295144a0af5a8b2120ac71cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032167Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737345}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/6b7add10ae84..8b9cdcbe79ef

git log 6b7add10ae84..8b9cdcbe79ef --date=short --first-parent --format='%ad %ae %s'
2020-01-31 mmortensen@google.com Handle ninja logs properly when processing goma logs.
2020-01-30 gbiv@google.com scripts: add enumerate_hot_packages.py
2020-01-30 saklein@chromium.org cros deploy: Remove ignore-build-slot argument.
2020-01-30 bpastene@chromium.org cros_chrome_sdk: Don't add the toolchain dir to the compiler's cmd line.
2020-01-30 saklein@chromium.org cros build-ap: Add build code and config modules.

Created with:
  gclient setdep -r src/third_party/chromite@8b9cdcbe79ef

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I73243a8313dbf5d98a361982a310bacdb4388007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033113Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737344}

python client is being deprecated.

Bug: 984869
Change-Id: I43f7a74e1d5a108b378748a7a89f23ced37eb417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033005
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737343}

This reverts commit e84c5eea.

Reason for revert: landed a fix for devtools
(https://crrev.com/c/2033236)

Original change's description:
> Revert "[blinkpy] Integrate Typ's expectations_parser module into blinkpy"
> 
> This reverts commit 88fbf344.
> 
> Reason for revert: Breaks parsing of test expectations on the DevTools waterfall - https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/355
> 
> Original change's description:
> > [blinkpy] Integrate Typ's expectations_parser module into blinkpy
> > 
> > This CL will replace blinkpy's test expectations logic with typ's
> > expectations_parser module. This change will significantly reduce the
> > amount the code used for parsing and maintaining test expectations.
> > Typ's expectations_parser module also parses the new expectations
> > format.
> > 
> > Bug: 986447
> > Change-Id: I16842bb2fcbc8a75221f3f208ed1550523470716
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918294
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Reviewed-by: Robert Ma <robertma@chromium.org>
> > Reviewed-by: Luke Z <lpz@chromium.org>
> > Reviewed-by: John Chen <johnchen@chromium.org>
> > Commit-Queue: Rakib Hasan <rmhasan@google.com>
> > Cr-Commit-Position: refs/heads/master@{#737159}
> 
> TBR=lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com
> 
> Change-Id: Id3b9bab45cae06dc21173d7d5fb99f294ec4e95f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 986447
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030956
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Yang Guo <yangguo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737277}

TBR=yangguo@chromium.org,lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com

Change-Id: Ib16faa774386a1f85b28264433d6215625cde0bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 986447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033327Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737342}

This required some shuffling around to get things to work right.
In particular, prior to this patch I had restore triggered
from the browser_impl.cc's constructor. This proves problematic on
android now as tabs may be created synchronously. When BrowserImpl.java
calls to browser_impl.cc's constructor all the connections (clients)
haven't been set up (and BrowserImpl.java can't call to the native side,
because it's waiting for the return value from creation). This lead to
all sorts of crashes and what not.

The fix is to trigger restore later on, and specifically once everything
has been wired up, which is when setClient() is called.

BUG=1046406
TEST=BrowserFragmentLifecycleTest

Change-Id: Iee2dfcab5ab8b45371099b33b65aa35ffb458ce4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031594Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737341}

Bug: 1006150
Change-Id: Id5a3135c709b1785a323a66eb559464a967803c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033155
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737340}

TBR=ioanap@chromium.org
NOTRY=true

Bug: 1043480
Change-Id: I4394dec42a6ca2397c5d23da6f2e0c6636da7b6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033324Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737339}

This patch implements committed interstitials for safebrowsing
for subresources (as a follow-up to crrev.com/c/2003857).

In this patch:
- Make sure to only add safebrowsing navigation throttle for
  main frames when committed interstitials are enabled.
- Implement safe_browsing_subresource_helper and update
  safe_browsing_ui_manager to handle subresources (such as
  js files).
- Add a browsertest for testing safebrowsing interstitials
  for subresources (both with and without committed
  interstitials enabled).

BUG=1044593,1042662

Change-Id: I813e916aa27dcb262fcd39d9b20af0f6d5d41e1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030485
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737338}

This CL marks (on Android) the android-app scheme as hierarchical
("standard") in order for them to not get butchered by "truncate to
origin" referrer policies, such as the new default policy (currently
in the process of rolling out; crbug.com/1014207) of
strict-origin-when-cross-origin.

URLs of the android-app scheme are of the form
android-app://my.package.name/some/more/information; because they're not
"standard" (GURL) / "hierarchical" (KURL), when you take their origin
you get an opaque origin; because they're cross-origin with everything
else, a policy of "truncate to origin on cross-origin requests" (which
is the new default) ends up zeroing these referrers out, which might
not be what we want.

Marking the scheme as standard means that you can meaningfully take
the origin (usually yielding the package name), which gives the behavior
we want.

Bug: 1046384
Change-Id: Ib5b80b197964ba2f0623699c0e33e945c20a0ba2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024691Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737337}

TBR=odejesush@chromium.org
NOTRY=true

Bug: 1044742
Change-Id: I0b8edaf6c88fef9bb188e5e35f26bc225a9fb0cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033326Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737336}

This CL defines a ResourceType enum inside components/safe_browsing/core, and
uses it in place of content::ResourceType. To ensure these enums stay in
sync so that converting between them is trivial, this CL adds static asserts in
components/safe_browsing/content, where both types are accessible.

This is a step towards removing content/ dependencies from
componens/safe_browsing/core.

Change-Id: I174021de4d8a7f0287b50d73426dd1da4c6ed9ab
Bug: 1028755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028150
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737335}

This reverts commit 49e19ab9.

Reason for revert: Landed without testing (No-Try: true). Will revert, enable tests and reland.

Original change's description:
> Reland "media: use VEA SupportedProfile |min_resolution| for PeerConnection"
> 
> This reverts commit a629c52f.
> 
> Reason for revert: M80/81 blocker. Bug 1046501.
> 
> Original change's description:
> > Revert "media: use VEA SupportedProfile |min_resolution| for PeerConnection"
> > 
> > This reverts commit 72037f82.
> > 
> > Reason for revert: M80 Stable blocker bug 1046501
> > 
> > Original change's description:
> > > media: use VEA SupportedProfile |min_resolution| for PeerConnection
> > > 
> > > crrev.com/c/1828078 added and wired the video encode acceleration
> > > minimum resolution; this CL uses this information from peerconnection's
> > > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a
> > > hw accelerator for resolutions below the given one.
> > > 
> > > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then
> > > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241
> > > are encoded using libvpx while larger ones are encoded using "ExternalEncoder",
> > > i.e. the video encode accelerator in Chrome, in this case VA-API.
> > > 
> > > Bug: 1008491
> > > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398
> > > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#720981}
> > 
> > TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 1008491
> > Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889
> > Reviewed-by: Miguel Casas <mcasas@chromium.org>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Henrik Boström <hbos@chromium.org>
> > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#736904}
> 
> TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org
> 
> Change-Id: I92b4e10f9ef39d2c642a6c9ae4d3a1e3f0fbb609
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1008491
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033345
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737332}

TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org,ssilkin@google.com

Change-Id: I1cadec33578747fca04b44867a8951a9c69d3280
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033348
Commit-Queue: Ben Mason <benmason@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737334}

The sole test in the suite cycles focus through elements on the toolbar.
Since we added an element to the toolbar (the extensions menu button),
it needed to be included in the cycle.

Bug: 984654
Change-Id: I0c6aa82fa1f09bee28422b5f9d97634ef7d37e0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027788Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737333}

This reverts commit a629c52f.

Reason for revert: M80/81 blocker. Bug 1046501.

Original change's description:
> Revert "media: use VEA SupportedProfile |min_resolution| for PeerConnection"
> 
> This reverts commit 72037f82.
> 
> Reason for revert: M80 Stable blocker bug 1046501
> 
> Original change's description:
> > media: use VEA SupportedProfile |min_resolution| for PeerConnection
> > 
> > crrev.com/c/1828078 added and wired the video encode acceleration
> > minimum resolution; this CL uses this information from peerconnection's
> > rtc_video_encoder.cc and video_codec_factory.cc to avoid using a
> > hw accelerator for resolutions below the given one.
> > 
> > TEST=https://codepen.io/miguelao/full/jONQBYb on nocturne (pixel slate), then
> > inspecting chrome:webrtc-internals, verifying that resolutions below 321x241
> > are encoded using libvpx while larger ones are encoded using "ExternalEncoder",
> > i.e. the video encode accelerator in Chrome, in this case VA-API.
> > 
> > Bug: 1008491
> > Change-Id: Iccfe6be8811ca265d6dbc742beb3ec0901406a40
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848398
> > Commit-Queue: Miguel Casas <mcasas@chromium.org>
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#720981}
> 
> TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,guidou@chromium.org,ilnik@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1008491
> Change-Id: Ie7279fcc02e041f4e1a4a0ed0cef248aa24d472e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028889
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> Reviewed-by: Henrik Boström <hbos@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736904}

TBR=mcasas@chromium.org,haraken@chromium.org,sprang@chromium.org,hbos@google.com,hbos@chromium.org,guidou@chromium.org,ilnik@chromium.org,ssilkin@chromium.org

Change-Id: I92b4e10f9ef39d2c642a6c9ae4d3a1e3f0fbb609
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033345
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737332}

Previously, a DCHECK would ensure that there's only one edge to a
destination object, i.e., edges are unique. This should be the case when
adding edges between objects. Since root groups reuse the same state
abstraction there may be duplicates edges in there.

Change-Id: Iba1debc3f2a8c5e0f2f8b627179d44abad97080c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031032
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737331}

This is prep for always displaying a widget as key if one of its children is key.

No behavior change intended.

Bug: 1046540
Change-Id: I3b667e5f285ac1b8c681f25714647dec8242bf6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031427Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737330}

This reverts commit 3475028d.

Reason for revert: M80 release blocker. Bug 1046501.

Original change's description:
> Revert "Remove deprecated enable-webrtc-hw-{h264,vp8,vp9}-encoding flags"
> 
> This reverts commit a387ca32.
> 
> Reason for revert: M80 Stable blocker bug 1046501
> 
> Original change's description:
> > Remove deprecated enable-webrtc-hw-{h264,vp8,vp9}-encoding flags
> > 
> > This CL removes the 3 flags  enable-webrtc-hw-{h264,vp8,vp9}-encoding
> > because they were deprecated in M76 and will be hidden in M78.  These
> > flags are used in peerconnection/rtc_video_encoder_factory.cc to
> > filter the supported codecs to be added to the SDP.
> > 
> > The same filtering effect can be obtained by using the still existing
> > flag --disable-webrtc-hw-encoding which is also surfaced to
> > chrome:flags and used in peerconnection/video_codec_factory.cc [1],
> > albeit at a coarser granularity: no codec-level enable/disable is
> > available.
> > 
> > [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/peerconnection/video_codec_factory.cc?type=cs&q=IsWebRtcHWEncodingEnabled&g=0&l=180
> > 
> > Bug: 599650
> > Change-Id: I35bde6cd50c88ca8641dd9a6bd5a3e44394cde43
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863153
> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> > Auto-Submit: Miguel Casas <mcasas@chromium.org>
> > Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#708063}
> 
> TBR=dgozman@chromium.org,dcheng@google.com,mcasas@chromium.org,pfeldman@chromium.org,foolip@chromium.org,hiroh@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 599650
> Change-Id: I6473fb68d3aac1e937da9ded8138befdd857e762
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028852
> Reviewed-by: Krishna Govind <govind@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#736659}

TBR=dgozman@chromium.org,dcheng@google.com,mcasas@chromium.org,pfeldman@chromium.org,govind@chromium.org,foolip@chromium.org,hiroh@chromium.org,benmason@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 599650
Change-Id: Idef433d7d615f517f404f9c265c14dea494a6115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033246
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737329}

This CL modernizes the ActivityServiceLegacyCoordinator
 - to use the superclass -initWithBaseViewController:browser:
initializer, instead of -initWithBaseViewController:.
 - to remove the public property for dispatcher, webstatelist,
browserstate and tabmodel.

Bug: 1029346
Change-Id: Ieba5a4df18470a91de783ca1703414e0df34c0f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033153
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737328}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d1e28ea0ef92..023284c1ce32

git log d1e28ea0ef92..023284c1ce32 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 szuend@chromium.org Port NodeURL unit test from web test to karma
2020-01-31 szuend@chromium.org Perpare PersistenceImpl for source map asyncification

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@023284c1ce32

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1032016,chromium:1032561
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I3591762f9396cc256c77d7b08471614732675bf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033110Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737327}

https://android.googlesource.com/platform/external/perfetto.git/+log/d1b176ec137a..fe37d1fa52f1

git log d1b176ec137a..fe37d1fa52f1 --date=short --first-parent --format='%ad %ae %s'
2020-01-31 lalitm@google.com Merge "trace_processor: migrate sched table to db tables"

Created with:
  gclient setdep -r src/third_party/perfetto@fe37d1fa52f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I790b3e4f444edf44f422892c45ae2cea2ce6645e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033111Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737326}

Bug: 1044034
Change-Id: Id6ddb20aa0d94c218c2c9f06a41ea0305c473e02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031404
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737325}

Code cleanup as per TODO from eons ago. This method is not used, and
is no longer even implemented.

Bug: none
Test: manual and unit tests
Change-Id: I7caf825f3be486e2bf88294f2e0b6eb92baf712f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032003Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737324}

Following bot results are included.
1200 1205 1207 1209 1210 1211 1212 1214 1215 1222 1223

20 lines were removed and 8 lines were deflaked by consecutive
results since 1197.

TBR=yosin@chromium.org
NOTRY=true

Bug: 982194
Change-Id: Ife85f6cfdb4032df2bb2187abe17ef5874c0aaca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029471Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737323}

This CL rearranges the variables in alphabetic order and fix the
variable initialization syntax according to Chromium c++ style guide.

Change-Id: I30495332713ac938a755999cda6547290070adf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031704
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737322}

Was for temporary debugging of a hang. This has been addressed.

Bug: 938047
Change-Id: I34504975e0ccd84ba21bf042217dadc61fb4993c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032572
Auto-Submit: Eric Karl <ericrk@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737321}

Bug: 1036572
Change-Id: Ie8ea7c7db3a32e258cb3b5ef873132ebf0c6ebc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032576
Auto-Submit: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737320}

TBR=bling-p10-rolls@google.com

Change-Id: I4b46c5358fce362180826e2a45bd71dafd38b59c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032227Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737319}

Add feature flag "pdf-two-up-view", which indicates whether users
have access to two-up view toggle button inside PDF viewer.

Bug: 51472
Change-Id: Icc37e4a595348c87248dfaa57b3e175cf2d98ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023926
Commit-Queue: Hui Yingst <nigi@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737318}

As a follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1935836
that adds the first use case, we can now lift the namespace.

Bug: 839091
Change-Id: I59614aef63b4449897a68ea6a9b6ba9f8f7da077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028287
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737317}

This reverts commit 3edb7dbb.

Reason for revert: consistently fails on downstream bots.

Original change's description:
> [iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature.
> 
> Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests.
> 
> The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup.
> 
> Bug: 1045981
> Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#737283}

TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org

Change-Id: I58ffda870f5d63c9b23fb9fb40903d14b2fd9ead
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1045981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032120Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737316}

Since all Password views now have their own controller, let's get rid
of the ManagePasswordsBubbleModel.

Bug: 1044034
Change-Id: Id90d288d2bea3439dc251651185054242630b528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030767
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737315}

- Resizes toolbars.
- Updates fakeOmnibox height.

screenshots:
https://drive.google.com/drive/folders/1VloKJh9nJOi-73XmBTH_QAXQRbTN1wuo?usp=sharing

Bug: 1035850
Change-Id: If97c06b1cb9257fe490a75a4d86b703f6426940b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978001
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737314}

This CL adds a second container for generic UI to the CollectUserData
action. The first container is right after prepended_sections (no
change), the new second container is after appended_sections.

Conceptually, this will allow the specification of additional sections,
both prepended and appended ones, in either the dedicated proto or via
generic UI.

In the mid-term, I plan to remove those legacy additional sections
completely, but for now, the two will co-exist.

Bug: b/145043394
Change-Id: Iaabfa5fd7d3b71b287e9b0458fcd0790553ee490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030488
Commit-Queue: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737313}

This CL is one of many refactoring CLs that would split the
ManagePasswordsBubbleModel into different controllers one per view.

Bug: 1044034
Change-Id: I80836c2ce3bb89efcd6765108a59922a5459368c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022672
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737312}

Reason for reland: Keep ProducerEndpoint around forever.

Managed to repro the flakiness locally and therefore fix the issue. The
SMB was kept forever but the ProducerEndpoint contains the
unique_ptr<SharedMemory> that the SMB uses which meant that when it went
away we were left with a dangling pointer.

Bug: 1007310
Change-Id: I0e5e09169e369f4c3c7d93d3b23f1931d977fc64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027368Reviewed-by: Stephen Nusko <nuskos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737311}

Before, chips were replaced as a list. Now they are compared one by one,
if they are "the same", only the chip's |enabled| state is updated.

Bug: b/144075373
Change-Id: I7e9e970217faa85e66c559194fe0159f98d67a4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027908Reviewed-by: Clemens Arbesser <arbesser@google.com>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#737310}

setFirstSetupComplete() should not be called when user clicks settings
on the SigninFragment. This cl add a test for checking that behavior.

Bug: 1041412
Change-Id: Ia05191af117312c1ea8c11b31428ef8450d595f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012027
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737309}

There are no usages of HeapDeque that use an inline buffer.

Bug: 986235
Change-Id: I72d2c173690b5498cbb0726ae7521fdea2756a84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032117Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737308}

This CL migrates
wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html
to use the new /common/security-features/ infrastructure.

This CL removes the last use of
wpt/upgrade-insecure-requests/support/testharness-helper.sub.js
(other tests under wpt/upgrade-insecure-requests/ have been
already migrated) and thus removes the file.

Follow-up of a comment at
https://chromium-review.googlesource.com/c/chromium/src/+/2024249

Bug: 906850
Change-Id: I7a992491652d988115d1d9e62eafe179473e534a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027899Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737307}