- 20 Jun, 2018 2 commits
-
-
Katie D authored
The unused link was to install text-to-speech engines. We hope to use this in the future but don't have a place for it in M69. Removing before feature freeze. Bug: 850748 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie4c4d92bf285f3371bd5f51e8e485cfca3a0f18e Reviewed-on: https://chromium-review.googlesource.com/1106556Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#568653}
-
David Grogan authored
Also pass content size to the flex algorithm in a few places where border-box size had been getting passed. 33 new passes Bug: 845235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I3d6556bed482a6aed7b5089390f874654a87ed60 Reviewed-on: https://chromium-review.googlesource.com/1096451 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#568652}
-
- 19 Jun, 2018 38 commits
-
-
Steven Holte authored
TBR=mlamouri NOTRY=true Bug: 854349 Change-Id: I97e80d2798a902bcdece04cf74deb7138a20f2af Reviewed-on: https://chromium-review.googlesource.com/1107173Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#568651}
-
Devlin Cronin authored
As a workaround for flakiness in https://crbug.com/177163, crrev.com/9b393cf4 made all extension api subtests exit immediately for windows debug builds. However, this can lead to a number of issues: - Unnecessarily disabling tests that use RunExtensionSubtest that *aren't* flaky - Requiring tests that rely on RunExtensionSubtest() as only a portion of their validation to also be disabled. - Masking flakiness by having the test return true (instead of show up as disabled for a platform). Instead of doing this, we should find and disable specific flaky tests on specific platforms. This CL removes the logic to suppress extension api subtests. Sheriffs note: Since this has passed the CQ, this CL does not directly disable any tests. Any tests found to be flaky on Windows Dbg as a result of this CL should be disabled on Windows Dbg directly, rather than reverting this CL. (They were flaky before, and simply not run.) Bug: 177163 Change-Id: Id44a3b9ffd1882e15c1251a9665ffdf99a259373 Reviewed-on: https://chromium-review.googlesource.com/1106284Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568650}
-
Ned Nguyen authored
NOTRY=true # no tests on CQ cover this TBR=eyaich@chromium.org Bug: 713357 Change-Id: I252064713b2c8e5584f9db2fec35e58c0bf8a5f3 Reviewed-on: https://chromium-review.googlesource.com/1107213Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#568649}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/efd58885b78d..9cccc5ce4fb9 git log efd58885b78d..9cccc5ce4fb9 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 ayatane@chromium.org sysmon: Ignore chromeos3-* devservers 2018-06-19 dgarrett@google.com gclient: Stop using implicit git_cache_dir. 2018-06-19 lhchavez@google.com Add 'signed' image type examples / docs to cros flash 2018-06-19 dgarrett@google.com chromeos_config: Move toolchain builders to swarming. 2018-06-19 dgarrett@google.com build_status: Remove config_lib.UseBuildbucketScheduler. 2018-06-19 yunlian@google.com cros_gdb: set debug-file-directory for simple chrome. 2018-06-19 vapier@chromium.org pylintrc: convert warnings list into readable ids Created with: gclient setdep -r src/third_party/chromite@9cccc5ce4fb9 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853866,chromium:853391,chromium:852017,chromium:853969,chromium:853025,chromium:843275,chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: I38b6b86c7271b9ca0ec2148faa144816e012ac81 Reviewed-on: https://chromium-review.googlesource.com/1107006Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568648}
-
Sylvain Defresne authored
ProfileSyncService DCHECK in Shutdown that all observer have been unregistered, so refactor DesktopPromotionSyncService to unregister its observer in Shutdown. The refactor consist in removal of the helper observer class DesktopPromotionSyncObserver that is folded in the service as it makes it easier to track whether the observer is still registered (the alternative is to introduce a delegate class that is implemented by the service and invoked by the observer when it needs to unregister). As the class had no behaviour at this point, merging it with the observer is simpler. Also fix the fact that desktop_metrics_logger_initiated_ was not initialized in DesktopPromotionSyncObserver constructor, so the check in OnStateChange was undefined behaviour (most likely the result would have been that the variable was read to be non-false). Mark some local variable as const and avoid reading prefs that are not used. Bug: 854118 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8d5d2bcb09da0430d3a08d79058bdecd047f3f28 Reviewed-on: https://chromium-review.googlesource.com/1105978 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568647}
-
Ned Nguyen authored
Bug:713357 NOTRY=true # changes not affecting CQ TBR=eyaich@chromium.org Change-Id: Ife9474655e1a92e2cca1d4b6c0f2b38a134aff75 Reviewed-on: https://chromium-review.googlesource.com/1107205Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/41b453a48844..4004ae0e033a git log 41b453a48844..4004ae0e033a --date=short --no-merges --format='%ad %ae %s' 2018-06-19 lfy@google.com GLES1: Point rasterization (partial implementation) 2018-06-19 jmadill@chromium.org D3D11: Suppress basic line XFB dEQP tests. Created with: gclient setdep -r src/third_party/angle@4004ae0e033a The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I3d89829abc3658ad68da07daea1057bb31ab521c Reviewed-on: https://chromium-review.googlesource.com/1107097Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568645}
-
Tommy Steimel authored
This CL adds CSS to make the overlay enclosure the size of the video to prevent it from defaulting to 0x0. This fixes a bug where once the overlay cast button disappeared (due to the hide timer), the user was unable to bring it back by tapping on the overlay enclosure (since there was nothing to tap on). Bug: 853855 Change-Id: If4504b84c023cf7f52620ce7d58a71a5522be587 Reviewed-on: https://chromium-review.googlesource.com/1105516 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#568644}
-
Andrey Lushnikov authored
R=dgozman Change-Id: Ie10da2525c9192d652735c3331ed1bb28670c582 Reviewed-on: https://chromium-review.googlesource.com/1105597Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#568643}
-
Varun Khaneja authored
Partly, this undoes the change made in CL crrev.com/c/1095569 It turns out that there's no need to send the status code from Java to native -- it can be logged from Java-land. This CL also changes the type of histogram "SB2.RemoteCall.InternalErrorStatusCode" but that's acceptable since it only logged '0' values so far which were neither interesting in the past and nor will be interesting in the future. Bug: 851587 Change-Id: I959f5a1a557b09f7691cdc200625d14b8adbde41 Reviewed-on: https://chromium-review.googlesource.com/1105310 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
-
Mei Liang authored
This CL adds logging for the following UMA histogram on cold start: 1. Tabs.Tasks.AverageTabGroupSize 2. Tabs.Tasks.TabGroupCount 3. Tabs.Tasks.TabGroupDensity 4. Tabs.Tasks.TabsInGroupCount 5. Tabs.Tasks.TabsInGroupRatio All of these histograms will help us understand how users use tabs. Bug: 848150 Change-Id: Ieb290911a6f8f6dccd7133cce2e7cc72362f56bf Reviewed-on: https://chromium-review.googlesource.com/1085629Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#568641}
-
Scott Chen authored
This CL removes all changes from media_router, which were causing flakey tests. The intention is to reland those separately as a follow-up CL. Bug: 832177 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I68c653f4e492807988cdb09c2387e42111bd8db7 Reviewed-on: https://chromium-review.googlesource.com/1106419 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568640}
-
Bo Liu authored
Move java_peer_avaiable_on_client_thread_ to an early return. Call ApplicationStatusListener::GetState only once. Have java side call back to native to set TerminationInfo, so that it's easier to add more arguments in the future. No behavior change intended. Change-Id: I6b9ef14719414513fb307944e126eac9f51bf28f Reviewed-on: https://chromium-review.googlesource.com/1105461Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568639}
-
Stuart Langley authored
ThreadChecker has a set of boilerplate macros that should be used so that it is compiled out correctly on non DCHECK enabled builds. No Logic Changed, No New Tests. Bug: 841659 Change-Id: I93369ee67285ace07b630cd05b11b9e1d1cc9cfc Reviewed-on: https://chromium-review.googlesource.com/1107017Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#568638}
-
dpapad authored
Bug: 854353 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2e8a75a0e87dab4b9fb806420b9961d509651b09 Reviewed-on: https://chromium-review.googlesource.com/1106969Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568637}
-
Varun Khaneja authored
Change-Id: I13986be3ed8bccff230cf7e00d37318a05246993 Reviewed-on: https://chromium-review.googlesource.com/1107119Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568636}
-
Marijn Kruisselbrink authored
Flushing just the main thread could cause tasks on the leveldb and/or file task runners to not be executed when we expected them to. Flushing those task runners as well should reduce test flakiness. And re-enable LocalStorageContextMojoTestWithService.InvalidVersionOnDisk as this seems to fix the flakiness in that test. Bug: 756550 Change-Id: I7fbdfad9ed5581a0a2dbd030500cc80b9eb2fea1 Reviewed-on: https://chromium-review.googlesource.com/1107117Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#568635}
-
Zhongyi Shi authored
This test verifies that migration will be timed out after kWaitTimeForNewNetworkSecs and closes the connection if there's no network available. Bug: 818259, 843299 Change-Id: I58e4945d84e153f621187a1b1b46ac9dbb4e3372 Reviewed-on: https://chromium-review.googlesource.com/1107106 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#568634}
-
Steven Holte authored
TBR=sky NOTRY=true Bug: 854294 Change-Id: Ic904d41cbc236a8812472e7f0dba0cb45396f256 Reviewed-on: https://chromium-review.googlesource.com/1107135Reviewed-by:
-
Kyle Horimoto authored
Previously, the test assumed that the service did not actually start up until an API call was made on one of its exposed interfaces. However, that was actually incorrect; the service starts up as soon as a client binds to it. The issue was actually that I had forgotten to call SecureChannelPtr::FlushForTesting() at the end of SetUp(). Bug: 824568, 752273 Change-Id: I4ffd1f49f096fec5b72ce18870efd112d1ea0124 Reviewed-on: https://chromium-review.googlesource.com/1106972Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568632}
-
Chris Harrelson authored
* Don't intersect with the overall dirty rect except at changes of root layer, because otherwise the location and rect don't change * Early out intersections when a ClipRect is infinite (since it has no effect) * Don't adjust infinite ClipRects (since it has no effect) * Simplify / resolve TODOs in some cases where we previously had to construct an "infinite" layout rect In local testing, this CL yields a 10% improvement on the intersection-observer/deep-layers.html performance test due to faster hit testing. Bug: 831762 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie7a1e2fb5cbeb8f7f9a267489785266ed7b8ca47 Reviewed-on: https://chromium-review.googlesource.com/1104964 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568631}
-
Lindsay Pasricha authored
Bug: 852019 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I06eaac40d540fd1581fcbac01595d41bab969374 Reviewed-on: https://chromium-review.googlesource.com/1101241 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
gogerald authored
Bug: 853924 Change-Id: I69570abedd76a9f21fa42269061445e54f23fcfa Reviewed-on: https://chromium-review.googlesource.com/1106702 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568629}
-
Liquan(Max) Gu authored
Change-Id: Idc618ff767e6015b9e4043d74db3f141ccf43b44 Reviewed-on: https://chromium-review.googlesource.com/1106763Reviewed-by:
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd1a2724e60e..208cf41c691b Created with: gclient setdep -r src-internal@208cf41c691b The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853368 TBR=mmoss@chromium.org Change-Id: I2711ddb8757e18dad036816b7b4eca511f4b1a66 Reviewed-on: https://chromium-review.googlesource.com/1106564Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568627}
-
Adrienne Walker authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I12a5bfe98138afea0b0f32a7cd6a74f2c41ca74d Reviewed-on: https://chromium-review.googlesource.com/1106813 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#568626}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/79d42dfb1174..179059f63e9e git log 79d42dfb1174..179059f63e9e --date=short --no-merges --format='%ad %ae %s' 2018-06-19 vasili.skurydzin@ibm.com AIX: Enable usage of fetch and gclient Created with: gclient setdep -r src/third_party/depot_tools@179059f63e9e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ided779339acc6adff403b2c44461a8420590d969 Reviewed-on: https://chromium-review.googlesource.com/1106565Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568625}
-
Chris Lu authored
Adds the clear data type cells to the table view. Video: https://drive.google.com/open?id=11wNSwTOGKwI9r_6-ojWkLmMHYc-lqvAH Bug: 805201 Change-Id: I6729233d8a3c4d42bc4b649d56ae0f786ec59b5b Reviewed-on: https://chromium-review.googlesource.com/1101907 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#568624}
-
Anita Woodruff authored
- Renamed onRequestPermissionsResult -> handlePermissionResult in the AndroidPermissionDelegate interface; this avoids a name-clash with the method on FragmentActivity, hopefully making it easier to reason about what is calling what. - Made handlePermissionResult return a boolean indicating whether the result was handled. - *Actually return false sometimes instead of always true from ActivityAndroidPermissionDelegate/ActivityWindowAndroid* <-- this is the only bit that actually might change behaviour. - Made WindowAndroid an AndroidPermissionDelegate itself so it's now a proper decorator pattern - it had most of the methods already and this will allow easier unit testing. R=tedchoc@chromium.org Change-Id: I3787529184ce1acafd3d71d6f511941478026ecc Reviewed-on: https://chromium-review.googlesource.com/1105042 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
-
Sarah Hu authored
Bug: 840013 Change-Id: I1e1e8a21144d2b1cdf62b40b33f7b16f8d157d98 Reviewed-on: https://chromium-review.googlesource.com/1106707 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568622}
-
erikchen authored
This CL is not intended to have any behavior change. We need to update some keyEquivalents in MainMenu.xib, and it is much easier to update the whole file to use Xcode 8.3.2 than to try to get an instance of Xcode 5.1.1 running on a macOS 10.9.5 device. We refrain from updating all xibs since most of them are going away with the migration to Views, and historically, updating xibs has had subtle behavior changes. Bug: 851714 Change-Id: Ibae17d5d645a373f29549d08b9d3c1bf95c0b08a Reviewed-on: https://chromium-review.googlesource.com/1106897Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568621}
-
Chris Mumford authored
DeleteFile ignores db lock file so leveldb_chrome::DestroyDB is preferred. Bug: 802298 Change-Id: I15af9ae4c402f94d537a5b4495e8a60f6dd906fe Reviewed-on: https://chromium-review.googlesource.com/1069415 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#568620}
-
Jacob Dufault authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1093741, which was reverted in https://chromium-review.googlesource.com/c/1105240/ Bug: 851012 Change-Id: Icc587ff829e187b2eae7456aec227f5d66beb1ee Reviewed-on: https://chromium-review.googlesource.com/1106641Reviewed-by:
-
Dirk Pranke authored
The mac10.12-blink-rel bot has no machines that can run its tasks. To fix this, and to be explicit about the other configurations needed, this CL makes the swarming dimensions explicitly specified for those mac builders. TBR=robertma@chromium.org BUG=854039 Change-Id: Id4e79d9c0f47f36fd258769cfcc5f39b8c12e677 Reviewed-on: https://chromium-review.googlesource.com/1106613Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#568618}
-
Dirk Pranke authored
They weren't using it before, but it should work, so this turns it on. NOTRY=true Change-Id: I4f47b37ef00cee52639e7bf482a9e32a90458c7d Reviewed-on: https://chromium-review.googlesource.com/1106766 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#568617}
-
Mohamed Heikal authored
onTrimMemory tries to get a reference to the ControlContainer view and calls getToolbarResourceAdapter().dropCachedBitmap() on it. If the UI has not finished inflation yet, then the findViewById(R.id.control_container) returns null causing a crash. This cl adds a null check before calling methods on the ControlContainer. Bug: 853682 Change-Id: I621d21a92509c0c3211da99841cd59991cb38813 Reviewed-on: https://chromium-review.googlesource.com/1106900Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#568616}
-
Eugene But authored
Updated BuildNavigationItemImpl to call SetURL instead of assigning to ivar. This way ErrorRetryStateMachine::SetURL gets called as required. Bug: 725241 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I72ee391dabe18c60ea2c01c384fa3485b9bee1e9 Reviewed-on: https://chromium-review.googlesource.com/1106973Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#568615}
-
chaopeng authored
This issue is causing by: 1. MainThreadScheduler set TouchStartExpectedSoon based on the gesture event sequence when page has touchstart event handler 2. Scroll latching makes mouse wheels to gesture events. We change it the check from page has touchstart event handler to we actually cc blocking event. In the issue case, page has touchstart event handler but no wheel event handler, user scroll with wheel will not cause a cc blocking event so it would not block the network request. We also change TouchStartExpectedSoon to BlockingInputExpectedSoon. Bug: 828235 Change-Id: Iefff163ca091f2761542a527e2c4432bc1078f4c Reviewed-on: https://chromium-review.googlesource.com/1075719 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568614}
-
