GitLab

Similar to ChromeVox, show a sticky notification when Switch Access is
enabled that explains how to disable the feature.

Relnotes: N/A
Bug: 996351
Change-Id: I56546ddfe0d5a4e76eb07e5e55fcdf88ef6b2a1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131015
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756015}

This ensures it's accessible even if the detached scheduler needs to be
accessed through ExecutionContext.

Bug: 1066883
Test: http/tests/broadcastchannel/broadcast-channel-constructor-in-detached-window.html
Change-Id: Ia6d42010b4c6660db231b0f0b04c0a13d2dd6e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132777
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756014}

This CL moves the implementation of Windows SoftwareOutputDevice
class declarations into the header so they can be tested. It also adds
unit tests for SoftwareOutputDeviceWinProxy.

Change-Id: I2c4173dadc24965f70b4d94663849a5555d8225c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124298
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756013}

Address comments to UI implementation - update margins and logo size.
New screenshots:
http://slides/1Trd6FeBKqts4iAfYpE8lzzgpeaB_hE8vL8tTY5YA2PI

Bug: 1054798
Change-Id: Ic7bf2d72f5cb6cf07b27b95159b06d838283255b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132398Reviewed-by: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756012}

SVG <image> content always respects image-orientation

Meanwhile, we paint oriented images incorrectly due to a failure to
size the element correctly and a failure to account for the oriented
size when computing the aspect ratio transform. Part of the problem
was incorrect inverse mapping of the src rect used in other parts of
the code, and a missing orientation argument to SizeAsFloat. The code
has been fixed and call sites adjusted, with commentary.

The test fails due to a lack of fuzzy matching.

Bug: 1066685, 1034283
Change-Id: Ifc7fc71599605c4381a71815b989e974b9516517
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131407Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756011}

Since old DoWork/DoDelayedWork() was removed completely.

Bug: 885371
Change-Id: I3e59d89ace56900859bbb1359d36cb54c7981b47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130823Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756010}

Could not repro the flakes. But from flake logs tentatively adding a
wait for ukm metrics.

Fixed: 1050728, 1063736
Change-Id: If494242b4bf0dce8afc472b9100db00f08b42fc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130768
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756009}

This cl changes payments::ServiceWorkerPaymentApp::UkmSourceId() to
use |installable_web_app_info_->sw_scope| for JIT installable PHs while
calculating UkmSourceId.

Without this change using |stored_payment_app_info_->scope| for JIT
installable PHs would cause browser crash in incognito mode. Please
note that explicitly returning InvalidUkmSourceId for incognito
mode is not needed since UKM recorder does not record entries in
incognito mode.

Change-Id: I291d1404c89f5261e97d61ca8b74bbbfa905b229
Bug: 1066199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132944Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756008}

Bug: 1026426
Change-Id: I46539fbff2ed19bcfd810235d2f9ec5798f33298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133301Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756007}

This CL adds aria-label for the two external link buttons in the sync
section in chrome://settings/syncSetup page.

Bug: 1066599
Change-Id: I95ff9149b9e1e3da0dbea25b067a26aa7af6fd0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132452Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756006}

https://dawn.googlesource.com/dawn.git/+log/5b29904d76bc..2b24fab368ae

git log 5b29904d76bc..2b24fab368ae --date=short --first-parent --format='%ad %ae %s'
2020-04-02 cwallez@chromium.org Add enga@chromium.org as OWNER
2020-04-02 cwallez@chromium.org Fix -Wunreachable-code-break
2020-04-02 cwallez@chromium.org Normalize case X : {} break; to case X : { break;}

Created with:
  gclient setdep -r src/third_party/dawn@2b24fab368ae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Idae79350a432acb43af9bacc31497e4aa618e9cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134624Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756005}

If enabled, the v2 feed stream loading task is kicked off when the NTP
or start surface is created. Not currently user-visible; this is
happening silently while the existing feed is created and shown.

The binary size increase is mainly due to generated proto code that was
added previously but has not been linked until now. We are generating
the sources with "option optimize_for = LITE_RUNTIME;" which matches the
existing feed library and provides an acceptable speed/size tradeoff.

Once the v2 feed component is fully launched, we can begin removing the
existing feed library. For a recent measurement of the binary size we
would eliminate by removing the existing feed library, see this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1829821.

Binary-Size: The increase is temporary (see above).
Bug: 1044139
Change-Id: Ic596d28e03300ad617f98f0b725cdf5ed1b0b986
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132648Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756004}

This reverts commit 7032611d.

Reason for revert: No more BOT_DIEDs?

Original change's description:
> Move linux-chromeos-chrome's browser_tests into its own swarming pool.
>
> To prevent it from leaving junk around on the machine that causes
> other tests in that same pool to fail.
>
> Bug: 1039746
> Change-Id: I58a9bc242c56f5d7af196335cdd7d621cdb90a15
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995779
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#730595}

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1039746
Change-Id: I488153b4319b162b7f8b4c809469104a0360ee30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133233Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756003}

https://android.googlesource.com/platform/external/perfetto.git/+log/96e14888195d..2da86adf0fb8

git log 96e14888195d..2da86adf0fb8 --date=short --first-parent --format='%ad %ae %s'
2020-04-02 treehugger-gerrit@google.com Merge "trace-processor stat for data source guardrail."
2020-04-02 treehugger-gerrit@google.com Merge "Poll heapprofd memory and add guardrails."
2020-04-02 treehugger-gerrit@google.com Merge "tp: Add missing cmath include needed for std::isnan."

Created with:
  gclient setdep -r src/third_party/perfetto@2da86adf0fb8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ia7ed747315867619fdca6a887f8bf9e9a3eb6c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134619Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#756002}

This is almost entirely from Aaron Tagliaboschi's work at
https://chromium-review.googlesource.com/c/chromium/src/+/2019602

This code also removes the unconditional use of GetFrozenUserAgent in
isolated_prerender_tab_helper.cc which looked like a mistake;
::GetUserAgent uses that when the experiment is on.

Bug: 955620
Change-Id: Id4b719e0b4b1aada85418a889203bb5a85a3e72b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079466
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756001}

This patch adds a new method for generating a complete drag event in
TouchCommon: "performDrag". The difference between this method and the
existing ones is that it is a single call for the down/move/up stream
and most importantly uses deterministic timing. The existing methods
are inherently flaky because they use the system time when generating
sequential events. This will confuse gesture detectors and cause them
to fire flings or empty events when they otherwise wouldn't. The new
method specifies a duration that can be used to simulate a fast or
slow drag.

Bug: 813584, 882003, 947694
Change-Id: I42ab8e8803c8b4e3c81a2876240c365ffc39f4f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134200
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#756000}

Test: manual. Press ctrl+/-/0 ensure that it is recorded in
chrome: //user-actions.
Bug: 152466126
Change-Id: I4ff152672ac53b2ad77e78be172a06ff7b081862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120839Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755999}

https://chromium.googlesource.com/openscreen.git/+log/07dc402b0545..4400d32f044c

git log 07dc402b0545..4400d32f044c --date=short --first-parent --format='%ad %ae %s'
2020-04-02 jophba@chromium.org Add cast socket messages to the standalone receiver

Created with:
  gclient setdep -r src/third_party/openscreen/src@4400d32f044c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/openscreen-chromium
Please CC jophba@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: jophba@chromium.org
Change-Id: I1975e4065b5888c20247cb2f52edfec7c4ae0565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134364Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755998}

This change updates the string descriptions used for the gesture
navigation accessibility setting.

Bug: 1066310
Change-Id: I75f1c3609a0cf1cd68e784cd66cf2e8db8e104a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130683Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755997}

- Added new ZeroStateSlice
- The UI now should receive a zero state slice if
  loading fails.

I've changed SurfaceInterface so that the initial state isn't provided
on a different function call. This makes things a bit easier in
FeedStream.


Bug: 1044139
Change-Id: Ia8c3ec15fa0460b0add78ee5ba28e21f8a643237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133231Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755996}

Extend one more milestone because of M82 is skipped.

Bug: 1066014
Change-Id: I03ce2a3672f5206dbb447a1a3734938391e5ca71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131150Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755995}

This reverts commit be06dabb.

Reason for revert: the feature is not ready yet.

Original change's description:
> Reland "Enable sync trusted vault support by default"
> 
> This is a reland of f52179a5
> 
> The feature was disabled by default before branching because some
> implementation parts were missing on Android.
> 
> Original change's description:
> > Enable sync trusted vault support by default
> >
> > The feature is in a working state can be enabled by default.
> >
> > Bug: 1000146
> > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702
> > Reviewed-by: Marc Treib <treib@chromium.org>
> > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#731898}
> 
> Bug: 1000146
> Change-Id: If2c11c87bbc021daaa6656f9e85b592302dd8327
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035966
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#738548}

TBR=treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1000146
Change-Id: I44607cf1822145fb8a98e4a72a1361dbae274b00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127091
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755994}

On Windows separate device nodes are created for each function of a
composite USB device. This change implements the additional steps
necessary to collect all of the device paths for these child nodes when
the parent USB device node is enumerated.

As implemented this works for devices that are already connected when
enumeration is performed but not for devices that are detected after
startup because the DBT_DEVICEARRIVAL window message is delivered
before these nodes are created. This will be addressed in a follow-up.

Bug: 637404
Change-Id: I080e40104c422e446f07e3d5dee47291802a7728
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132532
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755993}

Change-Id: If11171fae55dc0b4fa492908884ab48d1805b18c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092692
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755992}

Also rework the code logic so that it prints logcat link even if
there is an exception

Bug: 1065170
Change-Id: I1b128d9cdef42a2ea2489d7ce6e9db41e3a9374f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128969Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#755991}

Enable the test after fix in https://crrev.com/c/2132683.

Bug: 1032993
Change-Id: Iec720cc1d61962b453a519624e43077f0c56b162
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133882Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755990}

Bug: 1061793
Change-Id: Ia4220faffaf01be3a2a7b62da80143af93b97dd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106957Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755989}

Migrating ios-simulator JSON config to Chromium recipe configs.
- test definitions in test_suites.pyl for ios-simulator. new sim
  variants introduced into variants.pyl
- chromium recipe and xcode property references set in *.star files.
  - Also add flexibility for executable specification on
    mac_ios_builder in ci.star
- re-use ios_sim_debug_static_bot mb config

Bug: 1055164,912681
Change-Id: I375512304959d90545019497f32b7f415c3d9ed2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071585
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755988}

Use raw string literals instead to avoid hurting readers' eyes (note:
no one should read them though). For example, this CL turns
const char kUsb[] = "{\"functions\":[{\"parameters\":[{\"$ref\":...
to
const char kUsb[] = R"R({"functions":[{"parameters":[{"$ref":...
in gen/extensions/common/api/generated_schemas.cc

This makes generated .cc file size slightly smaller: e.g. in linux cros
build, the sizes in bytes are (before->after):
gen/chrome/../apps/platform_apps/../generated_schemas.cc 14137 -> 12396
gen/chrome/../extensions/../generated_schemas.cc        426698 -> 367237
gen/extensions/../generated_schemas.cc                  369079 -> 318170
gen/extensions/shell/../generated_schemas.cc              1632 -> 1535

Note that this should not have any impact on binary size.

Bug: None
Test: None, no visible changes expected.
Change-Id: I432c510396ead6e86fae71f63a3e2c099420b485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133658Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755987}

This will inform changes to the size of the |policy_maker_| in
the Windows sandbox.

Bug: 1059129
Change-Id: I75fd61ae909eea8fdb3fde5565d828d7220c21f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127409Reviewed-by: James Forshaw <forshaw@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755986}

Bug: 1062700
Change-Id: I3b25b0e49f07c40a72eeb170d2f9d218aa56ba3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117316Reviewed-by: Renjie Tang <renjietang@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755985}

MVP.
Use the old CandidateWindow for UI.
Screenshot view here http://screen/RMd0QQFyoNo
Emoji-map lives in Google3, view here
http://google3/i18n/input/javascript/chos/ui/resource/emoji/emoji-map.csv
Interactions:
-Tab,Right,Enter commit the chosen emoji
-Up,Down moves to choose candidates

Bug: 1065308
Change-Id: If1b3a662a3a6e7e410099c1abca8cfce3d2a1a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123494
Commit-Queue: My Nguyen <myy@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755984}

Fixed: 1064138
Change-Id: I6693327ee56c6d70eac93a2bb1fabe81a4a45e31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134389
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755983}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cd454025b331..4ecdd22b0b60

git log cd454025b331..4ecdd22b0b60 --date=short --first-parent --format='%ad %ae %s'
2020-04-02 vapier@chromium.org repo: update to 2.5 launcher

Created with:
  gclient setdep -r src/third_party/depot_tools@4ecdd22b0b60

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I92bc6fe08e37fc2c6111ea2f3cb04ed88bf8afd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134363Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#755982}

Because flags cannot map to two feature toggles, the patch also
merges the two relevant feature toggles into one.

Change-Id: I79bb0eaee505d35713db34d8a5df677cbb19c09d
Bug: 1000146
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134008
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755981}

https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-shadowoffsetx
The standard in the above link says that shadow offset should not be
modified by the transform matrix.

Adding a test to verify that, and fixing it so the offset does not
get modified by the transform matrix.

I tried to add a html reference test, simulating a shadow but there is
some slightly aliasing errors due to the change in the way the
compositor handles the shadow and the blur.
Adding a png reference test to validate that it will still work in the
future.

I'm also removing an unnecessary c-style cast in:
  composite_flags.setBlendMode((SkBlendMode)GetState().GlobalComposite());

Bug: 1044803
Change-Id: Ib98a35d9b9fdcb71c0cccca114099e985b569fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128766Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755980}

Test: none
Fixed: 1022599
Change-Id: I44cf265ddb3877912ed565f87a4e6b0cd2552065
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131018Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755979}

Change-Id: If62caac724f9f2bcb163bdf1710c592ebe927834
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118396
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755978}

Since we have SwANGLE bots now to run these, we can offload the GPU bots.
Also, possibly reduce the flakiness on them due to anglebug.com/4396.

Bug: 1007018
Change-Id: I3023bfb163804fe5aacb0d8a0fa93523b757feda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132945Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755977}

Bug: 1067062
Change-Id: If52f744b7471d11f00601c85754fa5019b982805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134614Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755976}