- 13 Aug, 2018 12 commits
-
-
Yuki Yamada authored
This CL renames V8EventListener to V8EventListenerOrEventHandler in order to use callback interface EventListener generated by event_listener.idl: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/events/event_listener.idl?type=cs&q=%22callback+interface+EventListener%22&sq=package:chromium&g=0&l=23 https://dom.spec.whatwg.org/#interface-eventtarget The generated class will be named as "V8EventListener", so we have to rename current V8EventListener. Bug: 872138 Change-Id: Iceaf2e0ccbfb0f0b4be38381b14d79c63d0982af Reviewed-on: https://chromium-review.googlesource.com/1170670Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#582495}
-
Trent Apted authored
The file itself already compiles, but when we audit the dependency tree, we find a bunch of hidden dependencies between externs files. To fix, move these externs to the volume_manager_wrapper target and update all modules already depending on the wrapper already to get these externs via that target instead of repeating them redundantly. Some modules depend on (e.g.) the volume_info.js extern but don't already have a dependency on volume_manager_wrapper. This CL doesn't add one for those, but they may need updating later. Bug: 867700 Change-Id: I4e4e5b3c9fb6f59af5f06fa945c34c58832f8fe4 Reviewed-on: https://chromium-review.googlesource.com/1171970Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#582494}
-
Makoto Shimazu authored
TBR=peter@chromium.org NOTRY=true Bug: 873540 Change-Id: I988b931a5c15ba946e2cbec30b9c1557c862ee58 Reviewed-on: https://chromium-review.googlesource.com/1171974Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582493}
-
Kenneth Russell authored
This test became unacceptably flaky with the upgrade to 10.13.6. Tbr: ynovikov@chromium.org Bug: 872423 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8fded8d47792dce57ea6da6532f7d42b5c075bd4 Reviewed-on: https://chromium-review.googlesource.com/1172148Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582492}
-
Alexey Baskakov authored
Extract all the low-level skia/gfx/color_util stuff as ResizeIconsAndGenerateMissing function. This is a cut-and-paste CL, no behavior changes. Notes: - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL: Merge IconInfo and BitmapAndSource - they are essentially the same. - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test was always broken (a bug in ValidateAllIconsWithURLsArePresent helper) https://codereview.chromium.org/1066623008/patch/80001/90005 This is a re-land of: https://chromium-review.googlesource.com/c/chromium/src/+/1166751 MSan issue solved, ouput parameters initialized everywhere: SkColor generated_icon_color = SK_ColorTRANSPARENT; TBR=ortuno@chromium.org Bug: 860581 Change-Id: Ib26c765083e67e3a1c938a49994a5f5d5ecc8265 Reviewed-on: https://chromium-review.googlesource.com/1170665 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#582491}
-
Tetsui Ohkubo authored
On Chrome OS, there's no way to access notifier settings bubble from outside MessageCenterView, as right click menu is removed and inline settings is introduced. Therefore, they are dead code right now. BUG=802997 Change-Id: If498fa9b8949975d4c7c06a38667798b7124fc12 Reviewed-on: https://chromium-review.googlesource.com/1168268Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#582490}
-
Han Leon authored
This CL is the 4th step of the plan below aiming to eliminate the native struct content::ServiceWorkerResponse defined in content/common/service_worker/service_worker_types.h. 1st step: https://chromium-review.googlesource.com/c/chromium/src/+/1134731 2nd step: https://chromium-review.googlesource.com/c/chromium/src/+/1149706 3rd step: https://chromium-review.googlesource.com/c/chromium/src/+/1155999 4th step: (this CL) - Use blink.mojom.FetchAPIResponse to represent responses to background fetches. Specifically, use this mojom struct to replace the existing [Native] mojom struct content.mojom.ServiceWorkerResponse defined in content/common/service_worker/service_worker.mojom. Thus we can reduce the last 1 user of content::ServiceWorkerResponse. 5th step: - Remove content::ServiceWorkerResponse and do any left cleanup. BUG=789854 Change-Id: I85e6e9489dac50e1cc6905bd28a2d47b7a90fde7 Reviewed-on: https://chromium-review.googlesource.com/1164848Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#582489}
-
Makoto Shimazu authored
This is continuously fails on Android CFI. TBR=nyquist@chromium.org NOTRY=true Bug: 845180 Change-Id: I6829cc75cdd71eee0891838477a57c14c478e27b Reviewed-on: https://chromium-review.googlesource.com/1171973Reviewed-by:
-
Zhuoyu Qian authored
As the comment in login_user_view.h by jdufault@, rename user_dropdown_ to dropdown_. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: Id490ce8cb0a899da78d6fbab1cd2bfacd6169227 Reviewed-on: https://chromium-review.googlesource.com/1170157Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#582487}
-
Tetsui Ohkubo authored
Previously, settings button for volume slider was hidden when volume slider was shown as a single row bubble, not in a main bubble. This CL changes the settings button to be always shown. When the button is clicked in the slider bubble, it will open the main bubble. TEST=manual BUG=870473 Change-Id: Icc5b3d528414ee49ce6f0ffb4f4d47c0ce69c9ec Reviewed-on: https://chromium-review.googlesource.com/1170667 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
-
Tetsui Ohkubo authored
This CL implements a counter view at the top of UnifiedSystemTray that shows number of notifications hidden by scrolling. Screenshot: http://screen/LK1ETwVGn2d BUG=863635 Change-Id: I4cc16ec8f7e5f1f0b64836b1217655a52ca9882e Reviewed-on: https://chromium-review.googlesource.com/1168945Reviewed-by:
-
Khushal authored
This fixes 2 bugs which could result in using invalid textures from the image cache, if an image is originally uploaded at original size and mips are generated with a subsequent copy later. 1) When we generate mips the original texture is deleted, while if the DrawImage is ref-ed and there is an external ref on the SkImage backed by the original texture it could potentially be used after its deleted. 2) If skia fails to mip the texture for any reason, the "mipped" image returned is backed by the original texture which we would subsequently delete. R=ccameron@chromium.org, ericrk@chromium.org TBR=piman@chromium.org Bug: 870317 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iec925f35c7880db89f9b68a9cee5e0b76b8ce4d9 Reviewed-on: https://chromium-review.googlesource.com/1171960Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#582484}
-
- 12 Aug, 2018 19 commits
-
-
Kenneth Russell authored
conformance2/textures/misc/tex-mipmap-levels.html fails three times in a row when it fails. Mark it as Fail rather than Flaky. Bug: 870856 Tbr: ynovikov@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib49cb54ee451b4f5f556a0b5899c12d9e88d80b3 Reviewed-on: https://chromium-review.googlesource.com/1171942Reviewed-by:
-
Jinsuk Kim authored
Removes a TODO by moving a test-only method in WebContentsImpl to test package. Change-Id: Ia143ee015b3a68b0ec946a85d042b30cbce07172 Reviewed-on: https://chromium-review.googlesource.com/1168953 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582482}
-
Jinsuk Kim authored
Reduced the visibility of some methods to private. Change-Id: I696d5976e8d0f3823a61af445f7eb1c33b79fda3 Reviewed-on: https://chromium-review.googlesource.com/1170153Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/656d609a952a..f4cf64ec0669 git log 656d609a952a..f4cf64ec0669 --date=short --no-merges --format='%ad %ae %s' 2018-08-12 peah@webrtc.org AEC3: Enforcing nonlinear mode when transparent mode is active Created with: gclient setdep -r src/third_party/webrtc@f4cf64ec0669 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:873074 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0004e39737a41814ac3b77b6143c6f9621c8f93 Reviewed-on: https://chromium-review.googlesource.com/1172103Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582480}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2ef04d1e. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22604 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I13dd0e4c95a393b7ad1a09eeffeed86870b9a3b0 Reviewed-on: https://chromium-review.googlesource.com/1172099 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582479}
-
Kai Ninomiya authored
Due to a race condition between OnSignalAck and CheckResultsAvailable, getSyncParameter or clientWaitSync can report that a WebGLSync has passed before the readback results are actually available to getBufferSubData. This results in getBufferSubData falling back to the slower path sometimes. To remedy this, this change switches from using SignalQuery to a custom callback mechanism managed by the individual QueryTracker Query object. This callback is called immediately when the Query discovers that it has completed. Bug: 873424 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2136e3ea4d55dc4b5c2392d24791b787500a30af Reviewed-on: https://chromium-review.googlesource.com/1171908Reviewed-by:
-
Robert Ma authored
TBR=foolip No-Try: True Bug: 870526 Change-Id: Id8d7d6c24425674d2a57abbf2b502781726bb0e3 Reviewed-on: https://chromium-review.googlesource.com/1172097Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#582477}
-
Thomas Tangl authored
When a custom passphrase is detected in the unified consent service, unified consent is revoked. Bug: 872221 Change-Id: I5c571e38a8752973f8b393f570c6a2e11b56183b Reviewed-on: https://chromium-review.googlesource.com/1170694 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#582476}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/02d174687cc9..f1a25c06cd15 git log 02d174687cc9..f1a25c06cd15 --date=short --no-merges --format='%ad %ae %s' 2018-08-12 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@f1a25c06cd15 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I8aa51d07b884863b92b0a21c9427799aeac6a65f Reviewed-on: https://chromium-review.googlesource.com/1172102Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582475}
-
Alexander Alekseev authored
Bug: 852551 Change-Id: Ie7b3a95dee5ed135661f47f765e0fb37adb84273 Reviewed-on: https://chromium-review.googlesource.com/1171958Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#582474}
-
Alexander Alekseev authored
This Cl enables "Back" and "Forward" icons to follow the color style of the button. Bug: 852551 Change-Id: I75cec2058d7e330db5c7b5d226f47cd0f9f54571 Reviewed-on: https://chromium-review.googlesource.com/1171956Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I223c443b1baa87ef7f471ac9a63dcf532c968114 Reviewed-on: https://chromium-review.googlesource.com/1172091Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582472}
-
Xiaoqian Dai authored
Only the Edit printer dialog needs the scrollable behavior. Bug: 851903 Change-Id: I31ed7430b7caf1a6fcd878e732e3206868f40e79 Reviewed-on: https://chromium-review.googlesource.com/1168151Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#582471}
-
BUG=762641 TBR=alemate@chromium.org Change-Id: Ifeb4d9fca628409dbb436098f6e7aa4f8f03c10f Reviewed-on: https://chromium-review.googlesource.com/1172081Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582470}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I395ce21322e74fe44a7a84974a61ca6000d58a90 Reviewed-on: https://chromium-review.googlesource.com/1172078 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582469}
-
Peter Kasting authored
Bug: 870861 Change-Id: I8f5f47a2f87256ea3edf764ad5acedc287566d8b TBR: palmer Reviewed-on: https://chromium-review.googlesource.com/1172074Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582468}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ifc3b27a5ffc4d212dae7de39c99f48d9d60908bd Reviewed-on: https://chromium-review.googlesource.com/1171992Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582467}
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6a13ee017776283e0ecad95a24d0e663699c3c3d Reviewed-on: https://chromium-review.googlesource.com/1171867 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f820a5ea1c5c..656d609a952a git log f820a5ea1c5c..656d609a952a --date=short --no-merges --format='%ad %ae %s' 2018-08-11 minyue@webrtc.org Add UTC time to init event in AEC debug dump. Created with: gclient setdep -r src/third_party/webrtc@656d609a952a The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If4803f068b2c6b7ec68ac2c5daedecdadc67756f Reviewed-on: https://chromium-review.googlesource.com/1171718Reviewed-by:
-
- 11 Aug, 2018 9 commits
-
-
Christian Biesinger authored
This also required fixing the relayout when the scrollbar changes, which fixes css3/flexbox/scrollbars-auto.html (and avoids breaking two tests in external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox) Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I790f0524b029a3c2340b6b9715c5b3529c75357f Reviewed-on: https://chromium-review.googlesource.com/1162657 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#582464}
-
David Black authored
AssistantOptInView visibility state is synced to the user's consent state as known by VoiceInteractionController. Note that it is possible for VoiceInteractionController to get out of sync (b/111882861). This CL also: - Animates footer entry on Assistant launch. - Animates transition of footer views when consent is granted/revoked. See bug for demo. Bug: b:111315696 Change-Id: I848c1301e13795711e8e1ff5916ac8e4020f4c0b Reviewed-on: https://chromium-review.googlesource.com/1171853Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#582463}
-
Xianzhu Wang authored
Object (DisplayItemClient) paint invalidation has not been very useful in layout tests (we care more about raster invalidations), and should be better tested with unit tests. Removing them from repaint layout test results can reduce rebaselines. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a01f025013734f788d199adc3fed4d02859b7d2 Reviewed-on: https://chromium-review.googlesource.com/1170037 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582462}
-
David Black authored
This was previously created to send contextual HTML cards from AssistantManagerServiceImpl to AssistantScreenContextController. Now, thanks to changes in Libassistant, contextual cards will flow through our existing AssistantInteractionSubscriber.OnHtmlResponse pipeline. This interface is no longer necessary. Bug: b:112113187 Change-Id: Iccc11fdd92ce8144650038b487e735f28a3de98b Reviewed-on: https://chromium-review.googlesource.com/1171722 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
James Robinson authored
Fuchsia cares about binary size, like iOS and Android. This configures the default build to -Oz instead of -O2. This reduces the size of text segment of the service_exe webrunner executable by about 13% when building for ARM64 release mode non-component: O2: text data bss dec hex filename 83509089 3370852 1109788a 87989729 53e9de1 out/fuchsia_arm64/exe.unstripped/service_exe text data bss dec hex filename 73707333 3398764 1110516 78216613 4a97da5 out/fuchsia_arm64/exe.unstripped/service_exe Oz: Change-Id: I09774eb71f690a483f3f6064cace265a7f7f80e6 Reviewed-on: https://chromium-review.googlesource.com/1171864Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
David Black authored
This parameter is needed to distinguish between user initiated requests and requests that we make ourselves. User generated requests initiate a conversation interaction that will return contextual cards. This may result from a suggestion chip press or Assistant stylus tool selection. Requests that do not originate from the user will not return contextual cards or start a conversation interaction. Instead, we will cache the screen context to send alongside subsequent voice/text queries for context. This portion is not yet wired up. Bug: b:112113187 Change-Id: I12cd531745d174738988808d7637c8529ddd80d0 Reviewed-on: https://chromium-review.googlesource.com/1170428 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
David Bokan authored
This is a reland of ace3f1f7 Original change's description: > [RootScroller] Allow main document horizontal overflow > > When implicitly promoting an element to be the root scroller, we first > check if the main document has any overflow. If it does, we err on the > side of not promoting since it is likely the main document's content is > important and meant to be scrollable. > > This heuristic turns out to be too restrictive. For example, this makes > it hard to build a root scrolling carousel. This CL loosens the > restriction to allow horizontal overflow. > > Bug: 838683 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6007f6faa8e2006799a9dca6240b68ff0de7f09a > Reviewed-on: https://chromium-review.googlesource.com/1165859 > Commit-Queue: David Bokan <bokan@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581408} Bug: 838683 Change-Id: I886908a56db7a463c619135ed08712312ccacbfc Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel TBR: bokan, dtapuska Reviewed-on: https://chromium-review.googlesource.com/1171717 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Kevin Marshall authored
SandboxPolicyFuchsia is not thread affine but its ServiceDirectory is not. This CL schedules the ServiceDirectory's deletion on the same thread that was used for its construction. Change-Id: I98e950481e49106ba64c759cef2c903b5dcf5d3b Reviewed-on: https://chromium-review.googlesource.com/1171673Reviewed-by:
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I55fde6cc5f184386b780a060c5b6868b4e174735 Reviewed-on: https://chromium-review.googlesource.com/1172063 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
