- 24 Jun, 2020 23 commits
-
-
James Vecore authored
This is a reland of https://crrev.com/c/2251062 This CL adds and verifies Polymer3 support in the Nearby Share subpage. A browser test is used to verify the Polymer3 setup is working correctly. The test suites added are: OSSettingsNearbyShareSubPageTest.* and OSSettingsNearbyShareSubPageV3Test.* Change-Id: Id9b6d7303b5c42ecda65aed0e558cc41e245b9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261175Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#781634}
-
wutao authored
This metric is useful to catch UI perf regressions. Bug: 1095029 Test: None Change-Id: I9dedaf938ef4bd65250e4088c68bc692b1779354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259477Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mitsuru Oshima (slow:gardening) <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781633}
-
chrome://media-appTrent Apted authored
The API was transitioned in r781392. Bug: 1096225, 996088 Change-Id: I4c83e0e6cddd4b5ee22bb0308636fb5a3fad6723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260296Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#781632}
-
Nate Chapin authored
* Remove Document::SetReferrerPolicy and OutgoingReferrer, use the LocalDOMWindow variants * Remove most of the uses of Document::GetReferrerPolicy Bug: 1029822 Change-Id: I33bd81b95b033307ccdb2a9a835f2c952006e12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258426Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#781631}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592927234-6bc8fa97bba2bd68cb01fd0ff8ce06df7602d283.profdata to chrome-win32-master-1592936751-767ef07082a8dc3f12048c56b1a9381a023bc8f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ic825e4b820f65e673cd0feada9f6db37637b2c55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261450Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781630}
-
Nate Chapin authored
This ensures that ExecutionContext is the primary FeatureContext (SecurityContextInit is also a FeatureContext for its brief lifetime). RuntimeEnabledFeatures must now be called with an ExecutionContext instead of a Document. Bug: 1029822 Change-Id: I4b1e390ed507967246472a466f60e9488177e37d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255552 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
James Hollyer authored
This uses the InputControllerEvDev to allow application to turn off mouse acceleration when using pointer lock on Chrome OS. Bug: 982379 Change-Id: Ie3b9d5f67d7a5514b90b25d8b13e9f6f5b01e390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2188908 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#781628}
-
Robert Ogden authored
Adds a few histograms which are useful for tracking in the wild. Bug: 1082505 Change-Id: If99f482c86e57599db33f181b0ef8c88d8e660c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255522 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#781627}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: Ie306e67fbdbdb6c5e98c4edcda9b86dd3d1e9251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261484 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
-
Rachel Wong authored
There is a bug where the Suggested Content shown count could be incremented even if it was not shown in the launcher. MaybeIncreaseSuggestedContentInfoShownCount currently depends on the value of ShouldShowAssistantPrivacyInfo. Since the Assistant count is incremented first, the value of ShouldShowAssistantPrivacyInfo could change and be outdated by the time Suggested Content does its own increment. This change fixes the logic so that Suggested Content shown count is not incremented if Assistant is incremented. Bug: 1079169 Change-Id: Ib632312504ce4d5102d47355fef2e1dbfe81cbc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259694Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781625}
-
Peter Kasting authored
runtime/references is no longer checked by default; remove NOLINT annotations. presubmit_canned_checks.py now handles [] as callers intend; remove "no-op fake filter" arguments. Bug: none Change-Id: I7767c1b2bc45a07c0ce78b9855f085668ea7efa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248883 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781624}
-
Nate Chapin authored
Historically, the sandbox flags for a Document were finalized in the Document constructor. This meant that when a PluginDocument should be blocked by plugin sandboxing, we constructed the PluginDocument, then immediately replaced it with a SinkDocument once we detected that we should have blocked the PluginDocument. Now that the sandbox flags are finalized in DocumentInit, we can inspect them before creating the PluginDocument and instead go straight to constructing the SinkDocument. Bug: 1029822 Change-Id: Id859fe817cddf81f0e83b8ded53279527c86bcb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261094 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
-
Darren Shen authored
For lift activated regions like the virtual keyboard, it is quite difficult to perform a long press, because lifting the finger to perform passthrough will immediately trigger a press. A solution to this is to send a right click event when the user is hovering over the same anchor point for 5s in a lift activated region. Bug: b/157374150 Change-Id: I93ac8e02e45a9a11a9e846504ea6320cd7e3f592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224474 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781622}
-
Xing Liu authored
This is the plumbing for the old download offline content provider code path. Bug: 1078454 Change-Id: I20ceca491477b5c12738c647e158d21681a50fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253201Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781621}
-
Ben Pastene authored
For a new bot on https://ci.chromium.org/p/chrome/g/chrome/console Bug: 1092973 Change-Id: I6dd868649bbf5760299db08691afb418310251da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258681Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#781620}
-
Mustafa Emre Acer authored
This CL is a follow up to crrev.com/c/2246833. It starts displaying the lookalike interstitial for domains that fall back to punycode because of standard ICU checks (as described in http://www.unicode.org/reports/tr39/#Restriction_Level_Detection). Bug: 1095120 Change-Id: I20d749c1d95ad4fb3c759081a165e034d05c94bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258430 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#781619}
-
David Bertoni authored
This CL adds testing for the Declarative Net Request API with Service Worked-based extensions through parameterized test fixtures. I also did flake testing per crbug.com/1087765. Using fetch() instead of XmlHttpRequest has cured testBackgroundPageRequest of its flakiness by waiting to test the result of getting the page until the renderer has received the callback from the browser. Bug: 1093066, 1087765 Change-Id: I7f0af6d1084c457f61e7718b6e957490dbbbfb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248064Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781618}
-
Tommy C. Li authored
Previously, we were setting the color for the Remove Suggestion button incorrectly, making it slightly different from other icons in the omnibox. (We accidentally set related_text_color instead of icon_color.) This CL corrects that problem. Bug: 1071183 Change-Id: Ifc56fd6afd7da56c4d1cecdbdb44faa40dbe3063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260951 Commit-Queue: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#781617}
-
Haiyang Pan authored
Bug: 997376 Change-Id: Icb0010398ec0c609bb9638d19df25b2ed6c341e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255662 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#781616}
-
Tom Anderson authored
This CL includes 2 event fixes that were originally part of CL [1] to fix similar event-related issues. * event.h - "As() const" always called back into itself, causing an infinite loop. The intention was to call the non-const As() function. * event.cc - Xlib modifies the event data when parsing some events, but we never do, so let us parse the event before Xlib. * gen_xproto.py - Ensure the extension is present before creating extension events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2253223/ BUG=1098194, 1098204 R=thestig Change-Id: I414acd9c138a92fbddd09da705127f1d7f60b552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261177 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#781615}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: If04aee8a0bf9c0decf9a829e86ed7e440c618f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261428 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781614}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592927234-93fd17f09f62ae1a92f26a9127978b7f390ce8f1.profdata to chrome-win64-master-1592935173-8e4ecbeaa648b10e168b33ede78da61a4b393ac3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I323b92d2fd6940046bf23b9a1995496af6e2909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261477Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8dbca52cb29a..49e6f89bf28a 2020-06-23 patrick.brosset@microsoft.com Grid: shift grid labels a bit when they're inside the grid and at the corner If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096629 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35e2d1660fb9912dfb1b088566991fceeea31f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261452Reviewed-by:
-
- 23 Jun, 2020 17 commits
-
-
Wenhan (Han) Zhang authored
Change-Id: I5534ce0a95a967804c9a757e75fe523447e54469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255381 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#781611}
-
Nico Weber authored
Generated files in infra/config/generated by running: lucicfg generate infra/config/main.star TBR=mark@chromium.org Bug: 1098454 Change-Id: I8096cef8111688010492184deccb1c9f85dafaf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261369Reviewed-by:Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#781610}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc5464c325c9..a6c1ece07a47 2020-06-23 bpastene@chromium.org cros_test: Use Simple Chrome's cached version as default when flashing. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: Iee4aebadd0003aaaaa65309f7fb64377c116ebe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261479Reviewed-by:
-
Evan Stade authored
This flag enables third party cookie management in the page info bubble on WebLayer. Bug: 1071775 Change-Id: If41e96859475bf7790ccdc6534cf0190863892de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258859 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Erik Chen authored
As part of prototyping for Lacros, these DCHECKs are deterministically hit by meet.google.com during screen sharing. Given that at least one of these DCHECKs is also being hit in the wild via DCHECK enabled canary asan builds, I am removing these for now. Bug: 990711 Change-Id: I614fc932aadeab92e033de299a3482fb91d440a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261102 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#781607}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b47cc50aadb6..62a2f51304f9 2020-06-23 syoussefi@chromium.org Vulkan: Remove DispatchHelper 2020-06-23 nguyenmh@google.com Re-enable presubmit commit message format check 2020-06-23 jmadill@chromium.org Update glslang_validator binary for Windows. 2020-06-23 syoussefi@chromium.org Add mip-related corner-case tests 2020-06-23 syoussefi@chromium.org Update glslang_validator binary for Linux. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I6b839f91c107b340a25beb7c6161600b05245ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261062Reviewed-by:
-
Jimmy Gong authored
- Set minimum window size to 600x320 as per UX guidelines as it is the minimum size that displays all informational columns for a print job. Bug: 1053704 Change-Id: I8f122affd87cd8e5cfac20d5ce8d935e3237a49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259133Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#781605}
-
Matthew Mourgos authored
This change adds two new app list spoken feedback tests. These tests ensure that app item reordering and folder creation are announced correctly in the app list. Also in this change, the incomplete NavigateAppLauncher test has been removed as its purpose it no longer required. In its place, the tests PeekingLauncherFocusTraversal and FullscreenLauncherFocusTraversal already exist which cover the same relevant test case for app list focus traversal. Bug: 784942 Change-Id: I02120a6eff8ba1dad698a86bf1977aa9895988d7 AX-Relnotes: n/a. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242917 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781604}
-
Ian Kilpatrick authored
As above - there should be no behaviour change. Bug: 842296 Change-Id: I84c388fcdc18b36f6e0a8821a3bd7031645ae49f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261100 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781603}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8194c8c76cf2cb270208203fc35daaf6f3ddedb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261425Reviewed-by:
-
Xianzhu Wang authored
Timing stats [1][2] show that debug builds are much more than 2~3x slower than release builds, so the original 3x timeout was too short. We also have seen more timeouts on debug bots because of that. [1] One sample of release build timing stats: (click the "Timing stats" link at the top-right corner) https://test-results.appspot.com/data/layout_results/linux-blink-rel/36524/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html [2] One sample of debug build timing stats: https://test-results.appspot.com/data/layout_results/linux_chromium_dbg_ng/7051/blink_web_tests%20%28with%20patch%29/layout-test-results/results.html Change-Id: I0eeeecf3547e576046238338246aa6849386166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259134Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#781601}
-
Alex St-Onge authored
Bug: 1091502 Change-Id: Ic6d77a89e54c8c0b7db729509005fcb9731584e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261395Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Alex St-Onge <alstonge@chromium.org> Cr-Commit-Position: refs/heads/master@{#781600}
-
Ella Ge authored
This CL fixes a bug in location delegation that it only checks the client app's ACCESS_COARSE_LOCATION but not ACCESS_FINE_LOCATION. The #hasAndroidLocationPermission method will: 1. returns true if at least one of the two permission is granted 2. returns false if at least one of the two permission is requested, but none of them are granted 3. returns null if none of them are requested. This CL also fixes a typo in installed_webapp_geolocation_bridge.cc The error code should be set to "position", not "current_position_" Bug: 1069506 Change-Id: I9171cc5e8d47a237b431369cb8c86e88ea3d3f5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258312Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#781599}
-
Chris Cunningham authored
Add IDL for AudioDecoder and associated IO/callbacks/init. Bug: 1094087 Change-Id: I9dca7ab13a8feeaabb8714faa37df5c901789cc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255142 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#781598}
-
Reilly Grant authored
This change removes the uninclusive term "master" from the name of this class. Bug: 1097189 Change-Id: I1d268411316529d33e6bbe8c6228b065c7ad5634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261365 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781597}
-
rbpotter authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/2233827, now that unpack_pak changes to prevent colliding generated directories have landed in https://chromium-review.googlesource.com/c/chromium/src/+/2251050 This adds an optimized Polymer 3 build target for the OS settings page. Bug: 1045266 Change-Id: Idfeeb0c28b2e2b48226d06ab727cc833861beb90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253215 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
-
Jon Mann authored
In the recent change to sync networks after they are configured, the check to see if a network was configured by sync was executed before the metadata has actually been set. Bug: 966270 Change-Id: If8bce1c693f8ee6f55f35bc49a64d4ceaf734bc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259378 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#781595}
-
