GitLab

This reverts commit 5f4571dc.

Reason for revert: Another metric, TaskStartedNative, is logged incorrectly.

Original change's description:
> Fix crash when Background Memory metrics task is scheduled immediately.
> 
> It is scheduled with a random delay between 0ms and 59999ms. When it is
> exactly 0, the delayed task is actually executed as a regular task,
> and since it is scheduled just before the task that starts native,
> it runs without native, causing a crash.
> 
> Moving recordMetrics() to after native is initialized fixes the issue.
> 
> Bug: 1017130
> Change-Id: Ica5d0a125b93433bd2291a6c73ac30d3fd890aa8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880172
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#709269}

TBR=hnakashima@chromium.org,mheikal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1017130
Change-Id: Ie5bef0866b02530232aeb383adfaae5feaf6511a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883044Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709906}

GOOGLE_CHROME_BUILD is more a branding thing. Since
Google Chrome builds set both GOOGLE_CHROME_BUILD and
OFFICIAL_BUILD, this doesn't have an effect in practice.

People who do non-Google Chrome-branded OFFICIAL_BUILD
asan builds will now get the different flags, which seems
like a good change.

While here, also deduplicate the common flags and add
a comment saying that the OFFICIAL_BUILD asan flags
are basically never used.

Bug: 961769
Change-Id: I42491c1d4d3ab876b0de92d0746266580dafe1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882109
Commit-Queue: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709905}

This behaviour will move to the InstanceID infrastructure, but in order
to mitigate risk for M79 let's start off in a more localized fashion.

Bug: 1006279
Change-Id: I29695df8cbb044cd51b0aee399362fc771197c57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880037Reviewed-by: Josh Nohle <nohle@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Peter Beverloo <peter@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709904}

Don't trigger the initial load for restored WebStates since the number
of WKWebViews is unbounded and may lead to an OOM crash. Instead,
disable and re-enable WebUsageEnabler SetTriggersInitialLoad

Bug: 1018337
Change-Id: Iaccecc3c0a1e68465b31b8503eee7b6d061d4f58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879205Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709903}

There were some reported oom's, so curb size to something reasonable.
This CL only affects the fuzzer.

Bug: 1018506, 1018522
Change-Id: I051da49d510fb108dea95925104c839d11ef5aa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883871Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709902}

Bug: 937369
Change-Id: Id8d3c7cb738b8c871b76a23cee23fd7dd43d6981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879601
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709901}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/99564c9b..f9d7f08e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iec8c63863c6120b57ed3b44e20ebe78e7182c0cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882939Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709900}

This CL removes the subtitle of the toggle when signed in or when
signed out with the feature disabled.

Bug: 1014660
Change-Id: I6e9913c889aed461a4adb10e7a4169f09936409e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883071
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709899}

This change is the last mile of of the Chrome-wide effort to prefer Sequences to
Physical Threads (https://chromium.googlesource.com/chromium/src/+/master/docs/threading_and_tasks.md#Prefer-Sequences-to-Physical-Threads)

This change is intended to be a no-op from sync's point of view.

Change-Id: Ie771c3a681b0483711ec1232544b92f2766caf47

Bug: 1014464
Change-Id: Ie771c3a681b0483711ec1232544b92f2766caf47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856922
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709898}

In the most common case, texture draw quads are just images and
can be bypassed very much like tiles or video quads. When it has
a background blend, we can still apply the RPDQ parameters but it's
no longer appropriate to merge the background alpha with the layer's
opacity.

Unfortunately, it starts getting really tricky to sort out the
proper order of operations for per-vertex opacity, layer opacity, and
other forms of masking. This seems like a pretty rare corner case
for texture quad usage (I only found unit tests and one place in
Chrome that uses it), so CanPassBeDrawnDirectly just prevents quads
with per-vertex opacities form being bypassed.

Bug: 1013735
Change-Id: I504d9492f5261c4930776c8d91504c9b71e1df70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863590
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709897}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97bcfab8abdd..91527d03092e


Created with:
  gclient setdep -r src-internal@91527d03092e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: I073d8470c1ad839a0053907611a418782a8d7938
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883772Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709896}

Changes some new uses, and does fairly harmless modifications
to keep GOOGLE_CHROME_BRANDING out of .h files.

Bug: 961769
Change-Id: Ia273654e515c1ba07cbd91b51937422d792a9f9c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882110Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709895}

Use of "${ x | trim }" of Mako template unconditionally removes
whitespaces including newlines.  It makes it hard to insert empty
lines in generated code.

This patch revisits the newline problem again, and improves it.

Bug: 839389
Change-Id: If838b4766fe8938e7f7c2bfb2ff8802d56ac9441
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883830Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709894}

Inspired by https://groups.google.com/a/chromium.org/d/topic/chromium-dev/Y8kOXPOqA9A/discussion

Tbr: dcheng@chromium.org
No-Presubmit: true
Change-Id: Ib83a4c72028fe7a36f7cb68b0399bb1a84dec902
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844059
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709893}

Bug: 1017690
Change-Id: I68b0643a099456c41c1abd483c1ae66edc957398
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878411
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709892}

Trivial change which only cleans up WebRTC logs containing the string
"request_id=n". We used to mix "request_id=n" and "request_id = n" but
now all white-spaces are removed to make the logs more consistent and
easier to parse.

Bug: 1017219
Change-Id: I0aed5cccb7c77d14a63b8a972ae92ce748ba88cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878368Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709891}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Id2c18902346490fa5b66a711c2bd7ee7a71281c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883771Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709890}

So it's not split between two files.

Change-Id: Ib39b2e1147a6424884f7f26cdcd505681a51fc63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880989
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709889}

LockObserver browser tests were disabled on Android Kit Kat
because of flaky failures of the navigation performed in
SetUpOnMainThread(). Since it is not important to perform the
navigation from SetUpOnMainThread(), this CL moves it to the
test body.

The failure seems related to this comment:
https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.cc?l=650-664&rcl=786a9194459684dc7a6fded9cabfc0c9b9b37174

This CL also removes the ContentMockCertVerifier in
LockManager browser tests, and instead specifies the
switches::kIgnoreCertificateErrors command-line flag,
which is simpler.

Bug: 1011765, 1014015
Change-Id: Ia1e140605a6734a95012f5c6019c6cef4918f372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854901
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709888}

This is a temporary workaround as the XPC used to show alert style
notifications does not work on 10.15+. Showing those as banners is
not ideal as they auto dismiss into the notifications center but it
is better than not showing them at all.

Bug: 1007418
Change-Id: Ib50ed9f2125b7bdf5885b5ffd63e81137e50e2a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883648Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709887}

We want to use V8::BackingStore as the backing store implementation for
WTF::ArrayBuffer to clarify memory ownership. However, libwtf, where
WTF::ArrayBuffer is at the moment, does not load libv8. Therefore this
CL moves the implementation of WTF::ArrayBuffer to DOMArrayBuffer, which
is the only real user of WTF::ArrayBuffer anyways.

Note that in the long run we want to remove WTF::ArrayBuffer completely.
This CL is one step to enable that removal.d

This CL did the following changes:
* Move the implementation of WTF::ArrayBuffer and co from
/platform/wtf/typed_arrays/* to /core/typed_arrays/array_buffer/*.
* Adjust includes where necessary.
* Adjust the include guards.
* Introduce a new DEPS file.
* Adjust BUILD.gn files.
* Add exception to third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py.
* Change the namespace of all moved classes from WTF:: to blink::

R=haraken@chromium.org

Bug: chromium:1008840
Change-Id: Iaee4937d3acce7ea578fbf2e278b6fa91f3b4627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875731Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709886}

This dialog's button labels can change as its model is updated, so always reset
them in UpdateUIForCurrentSheet() before calling DialogModelChanged().

Bug: 1011446
Change-Id: I3125ffe6e9b13c5f365c473de0b5eb226a7ebfb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878629
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709885}

In GetSelectionStart|Endpoint, the rect local to the layoutObject at the
selection start or end might be empty. The CL add checks for that.

Bug: 1018679
Change-Id: I203ca1c6683e984699691f5d99a4f3bc3353f5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880362Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com>
Cr-Commit-Position: refs/heads/master@{#709884}

https://webrtc.googlesource.com/src.git/+log/c189ace20a43..3eae7e4e3cdf

git log c189ace20a43..3eae7e4e3cdf --date=short --no-merges --format='%ad %ae %s'
2019-10-28 sprang@webrtc.org Add exponential backoff of retransmissions for a given packet
2019-10-28 perkj@webrtc.org Ignore low probe results when using NetworkStateEstimator under field trial
2019-10-28 jonaso@webrtc.org ICE : add field trial for initial select dampening

Created with:
  gclient setdep -r src/third_party/webrtc@3eae7e4e3cdf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I10fc5def882475142265c4c84623c43a46041989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883130Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709883}

This is (3) in
https://docs.google.com/document/d/1sMG4xAT-myWtFaNa0kuLjRqsyxSy12ahgRIbffy1Bxk/.

Bug: 1018050
Change-Id: Ib265bd86153842b4f90c836fb0b06d200e94a787
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880361
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709882}

https://dawn.googlesource.com/dawn.git/+log/04863c42bedd..f6281a5530c0

git log 04863c42bedd..f6281a5530c0 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 enga@chromium.org perf_tests: Add missing trace event "id"

Created with:
  gclient setdep -r src/third_party/dawn@f6281a5530c0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
TBR=cwallez@google.com

Bug: None
Change-Id: I14e626ecbacb15ff32818334cf4b11bc6a30497a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883129Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709881}

Only start monitoring after BrowserMainLoop::PreMainMessageLoopRun()
invokes base::DisallowUnresponsiveTasks().

R=erikchen@chromium.org, rkaplow@chromium.org

Bug: 1018359
Change-Id: I597c4b6a45797c66c0fa1b30fc3efdc9108aa81e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881709
Auto-Submit: Gabriel Charette <gab@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709880}

https://android.googlesource.com/platform/external/perfetto.git/+log/512f209de9b5..2b0233b972a6

git log 512f209de9b5..2b0233b972a6 --date=short --no-merges --format='%ad %ae %s'
2019-10-28 khokhlov@google.com Fix Windows build
2019-10-28 lalitm@google.com traceconv: bump shas to a58d04db
2019-10-28 primiano@google.com Fix strnicmp for MSVC
2019-10-28 treehugger-gerrit@google.com Merge "Fuchsia importer: Don't rely on non-guaranteed alignment"
2019-10-28 primiano@google.com Merge "tools(ci): support running with podman"
2019-10-27 primiano@google.com Trace Processor: add --httpd
2019-10-27 primiano@google.com String utils: add StringView.find(StringView) and ToLower

Created with:
  gclient setdep -r src/third_party/perfetto@2b0233b972a6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:142489755,chromium:143074239
Change-Id: I2b61d46405894109d70f47351ed6c42b0cb43fd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883131Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709879}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e4fd34ae..99564c9b

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I15fee9f5387f3aa40eb75787fae24bb90ca25a45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882937Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#709878}

These tests must allow tasks on the cache thread and the main loop to
run to allow for proper cleanup. Without this, files in the profile dir
may be held open beyond the lifetime of the test function, inhibiting
ScopedTempDir's ability to clean them up during TestBrowserContext
destruction.

BUG=546640,1016662

Change-Id: I1f9b50cb91a7fd287a103a4528ffe393720aeec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882319
Commit-Queue: Greg Thompson <grt@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709877}

This conversion has a very large app_interface. This is mostly due to
the heavy use of mocking and swizzling these tests use to interface
with the iOS camera status.

This also moves the CameraState enum into a separate file and gn
target so it can be included in test-side processes.

Bug: 987646
Change-Id: I5755ee1861de3ba74b9594e2c528d234b85feca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879249
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709876}

Bug: 966283, 1018438
Change-Id: I076a4daa612f6453b631d953baa26ac4f093d322
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883072
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709875}

MessageLoop is going away soon.

This CL was uploaded by git cl split.

R=jam@chromium.org

Bug: 891670
Change-Id: I224d419e31a6fb41156fed62bf856674fc69e6e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878372Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#709874}

NavigationClient is on by default, removing unnecessary branching.

Bug: 784904
Change-Id: I9024044ec53edd8776dda2427e59b754cd0f91ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1821179Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Arthur Hemery <ahemery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709873}

In crrev.com/c/1866520 the WebContextMenuData::MediaType was extracted to a
different file and renamed as ContextMenuDataMediaType. That alone required so
many changes (as the enum became an enum class) that an alias was added for the
old name in order to keep the changes under control and ease the review.

In this follow up patch the alias (using) is removed and the code starts to use
the new enum class name.

Bug: 1014517
Change-Id: I563fb0d6cc1a13a796988d6a66e995835b92c335
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872004Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#709872}

Bug: 1017213
Change-Id: I28221c29e3e69b50a97d47f0f8981e0a516d65b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878075
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709871}

Bug: 1001038
Change-Id: I08747c6a733ac42bd564f985e3f9ad52478ce210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879207Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709870}

RestartArcSession() can reuse the upgrade_params_ data that was
previousely set. Moving the content is not appropriate.

BUG=b:143439620
BUG=b:142144019
BUG=b:143092860
TEST=ArcSessionRunnerTest.Restart
TEST=`adb reboot` successfully restarts the ARC container.

Change-Id: Ie7a9254e03de29efde94a4a8918e80a1b871471c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883427Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Auto-Submit: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709869}

It turned out that some of SymbolDefinitionNodes need to be
followed by UnlikelyExitNode just like the following example,
so this patch makes SymbolDefinitionNode inherits from
SymbolScopeNode so that a definition can consist from
multiple CodeNodes.

Example:

  const auto& return_value = F(exception_state);
  if (exception_state.HadException()) {
    return;
  }

A symbol definition of |return_value| needs to be followed by
UnlikelyExitNode to return early if an exception is thrown.

Note that SymbolNode is just moved and should have no code
change.  SymbolDefinitionNode is updated accordingly.

Bug: 839389
Change-Id: I65e2f730084ad5018c2521ea0826c058910d153b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882253
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709868}

This is the third CL of several breaking crrev.com/c/1860025 into smaller
chunks.

This just plumbs a Browser into the signin promo classes.

Change-Id: Ie059a52ea81e801a1d5d1cfe59940b3faffed6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863026Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709867}