GitLab

Looks like this should be likely fixed too?

BUG=240165
R=tzik@chromium.org

Review URL: https://codereview.chromium.org/100883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
TEST=unit_tests --gtest_filter=ConflictResolverTest.*
NOTRY=true

Review URL: https://codereview.chromium.org/98053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238307 0039d316-1c4b-4281-b951-d872f2087c98

BUG=146989
R=joi@chromium.org, satorux@chromium.org, tzik@chromium.org
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/96413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238306 0039d316-1c4b-4281-b951-d872f2087c98

TBR=tonyg@chromium.org
NOTRY=True
BUG=None
TEST=None

Review URL: https://codereview.chromium.org/100603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238305 0039d316-1c4b-4281-b951-d872f2087c98

The current logic forces a BrowsingInstance swap when going to/from
hosted apps, which breaks postMessage.  Rely on RenderViewHostManager
to do a SiteInstance swap instead.

BUG=123007
TEST=postMessage works after navigating a hosted app popup cross-process.

Review URL: https://codereview.chromium.org/86973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238304 0039d316-1c4b-4281-b951-d872f2087c98

This will make it easier to do common setup work that requires having the
FileSystemContext, such as setting up Quota checking.

The new GotFileSystemContext method takes a callback to finish opening
each different kind of file system.

This change also renames some callbacks to be a little more consistent.

BUG=194304

Review URL: https://codereview.chromium.org/93403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238303 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238301 0039d316-1c4b-4281-b951-d872f2087c98

They are timing out.

TBR=tonyg@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/100653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238299 0039d316-1c4b-4281-b951-d872f2087c98

Linux is a casualty because we currently don't have a clean system to
differentiate the platforms.

TBR=tonyg@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/101043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238298 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/chromium/issues/detail?id=314945

Patch from Chris Harrelson <chrishtr@gmail.com>

BUG=314945
..


..


Plumbing for for layout rectangle debug information.

BUG=

Review URL: https://codereview.chromium.org/61883006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238297 0039d316-1c4b-4281-b951-d872f2087c98

- Mark Drive.EntryKind and Drive.FileFormat as obsolete. It's removed in r161277.
- Mark Drive.CacheDBOpenStatus as obsolete. It's removed in r219236.

- Mark Drive.InitialFeedLoadTime obsolete and introduce Drive.DirectoryFeedLoadTime.
  The metric is originally meant to measure the duration until
  we fetch partial result for showing quick UI response to the user.
  In the latest codebase, InitialFeedLoadTime no more is the point
  to trigger such role. Rather, DirectoryFeedLoadTime is.

- Use UMA_HISTOGRAM_LONG_TIMES for Drive.EntireFeedLoadTime and rename it
  to Drive.FullFeedLoadTime.
  It frequently goes beyond 10 seconds upperbound of UMA_HISTOGRAM_TIMES.
  (Despite the comment removed by this CL, I believe the location where
  this stat is taken is correct. The code survived several refactorings
  and at some point in history it was inappropriate...)

BUG=229407
NOTRY=true

Review URL: https://codereview.chromium.org/98253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238296 0039d316-1c4b-4281-b951-d872f2087c98

It fixes logging and in-process duplication counting in tools/linux/procfs.py
at the same time.

BUG=324194
TEST=None
NOTRY=True

Review URL: https://codereview.chromium.org/98423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238295 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
TEST=manual
R=nhiroki@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/98633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238294 0039d316-1c4b-4281-b951-d872f2087c98

- Pass clang-format to make the code more readable, better indentation.
- Better docs.
- Reorganize the code to make more sense of the code flow.
- Use GetImageSkiaNamed() instead of calling ToImageSkia() everywhere.
- append _center prefix to some variables.

BUG=None
TEST=content_shell still works
R=jamescook@chromium.org

Review URL: https://codereview.chromium.org/97633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238293 0039d316-1c4b-4281-b951-d872f2087c98

This change is part of adding chrome.identity.getAccountAndAuthToken.

The token cache in IdentityAPI and the IdentityMintRequestQueue both had
separate code for tranlating the same API parameters to a lookup key for
their internal maps. They now both use ExtensionTokenKey.

The ExtensionTokenKey includes an account_id field which will allow its
users to support multiple accounts in one profile. All callers currently
use the primary account ID, but will be updated in a future change.

This change also fixes a bug where getAuthToken would return tokens
for the wrong user after switching the account on the profile.

BUG=324874, 322284

Review URL: https://codereview.chromium.org/99173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238292 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the paddings were not considered in the check if the row was visible or not. This patch fixes this bug.

BUG=324819
TEST=manually tested

Review URL: https://codereview.chromium.org/96823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238291 0039d316-1c4b-4281-b951-d872f2087c98

Now that packaged apps are not quit when using wrench quit, there is no
way to completely shut down Chrome. While this is normally a good thing
as apps are intended to be separate from Chrome, for developers and
other power users, the ability to completely shut down Chrome can be a
useful function. This also blacklists chrome://quit and chrome://restart
from being saved to the user's session to prevent quit or restart loops.

BUG=317414

Review URL: https://codereview.chromium.org/84893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238290 0039d316-1c4b-4281-b951-d872f2087c98

If the first touch press happens on a touch-region, but then moves out of that
region, and the second press happens again on the touch-region, then the hit-test
for the second finger would fail because the code used to only look at the position
of the first touch point. Fix that to make sure the position of the new touch
point is used for hit-testing.

BUG=321457
R=jamesr@chromium.org, rbyers@chromium.org
TBR=jochen@chromium.org for content_tests.gypi

Review URL: https://codereview.chromium.org/76283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238289 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307622
TEST=ImmersiveModeControllerAshTestHostedApp.Layout
Manual Test:
1) Enable "Enable immersive fullscreen for non browser windows" on ChromeOS
2) Install a hosted app (I chose "Cut the Rope")
3) Hit <F4>. Make sure that the app goes fullscreen
4) Hover the mouse at the top of the display and make sure that the window header slides out
5) Hit <F4>. Make sure that the app returns to its formal state.
6) Go to popuptest.com/popuptest1.html in a normal browser window
7) Active one of the popup windows and hit <F4>.
8) Make sure that the popup goes fullscreen
9) Hover the mouse at the top of the display and make sure that the window header slides out
10) Hit <F4>. Make sure that the popup returns to its formal state

Review URL: https://codereview.chromium.org/83343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238288 0039d316-1c4b-4281-b951-d872f2087c98

Enable revealing the top-of-window views in immersive fullscreen when the mouse is hovered over the top edge of the fullscreen window but the fullscreen window is inactive. This is consistent to how hover works elsewhere on ChromeOS (e.g. the maximize/restore button's help bubble)

BUG=319959
TEST=ImmersiveFullscreenControllerTest.Inactive
R=jamescook
TBR=sky (For change to DragTabToImmersiveBrowserOnSeparateDisplay test)

Review URL: https://codereview.chromium.org/97943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238287 0039d316-1c4b-4281-b951-d872f2087c98

The files are almost exclusively touched by {hashimoto, hidehiko, kinaba, satorux}
in history, and among those hashimoto@ and I am mainly working on Drive currently.

BUG=none
R=satorux@chromium.org, zelidrag@chromium.org

Review URL: https://codereview.chromium.org/98233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238286 0039d316-1c4b-4281-b951-d872f2087c98

As of http://crrev.com/237473 we can finally have proper initialization of this code path (before we would have no way to tell the difference between a user who has never initialized and one which initialized to an empty list which was pruned out on write).

Review URL: https://codereview.chromium.org/92173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238285 0039d316-1c4b-4281-b951-d872f2087c98

This should tell the window its correct size, instead of the size expanded to be at least 64 pixels on each side.

BUG=286609,320974

Review URL: https://codereview.chromium.org/87383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238284 0039d316-1c4b-4281-b951-d872f2087c98

This changes the ownership model of infobars so that InfoBars are long-lived and
own their InfoBarDelegates directly.  The InfoBarService pseudo-owns the
InfoBars (instead of deleting them directly, it tells them when they're unowned
and expects them to delete themselves).

This fixes leaks when infobars are closed while not visible (e.g. in a
background tab) and in general makes the system clearer and easier to reason
about.

BUG=62154
TEST=none
R=erg@chromium.org, sail@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/22694006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238283 0039d316-1c4b-4281-b951-d872f2087c98

These IPCs correspond to Javascript IME API events
(oncandidatewindow*) defined in
https://dvcs.w3.org/hg/ime-api/raw-file/8c061ee19f99/Overview.html#inputmethodcontext-interface

They will fire when IME candidate window changes its appearance.

The Blink side of the change is already checked in:
https://src.chromium.org/viewvc/blink?revision=161139&view=revision

This is the Chromium part of sending IPCs to renderer and
a test for both Chromium and Blink code path, which is not
covered by blink r161139.

The whole change FYI is worked on at
https://codereview.chromium.org/80583002/
and other CLs (to generate actual events from IMEs etc.)
will follow.

BUG=238585
TEST=content_browsertests --gtest_filter="RenderViewImplTest.SendCandidateWindowEvents"

Review URL: https://codereview.chromium.org/84963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238282 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320450
TEST=nacl_io_socket_test + manual testing
R=binji@chromium.org, noelallen@chromium.org

Review URL: https://codereview.chromium.org/99813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238281 0039d316-1c4b-4281-b951-d872f2087c98

> BitmapContentLayerUpdater shouldn't reallocate bitmap smaller.
> 
> BitmapContentLayerUpdater was always allocating a new bitmap if the size of the region to be drawn changed, even if the new region was smaller. These unnecessary reallocations can be very expensive because they require page faults and for the operating system to clear out the memory.
> 
> BUG=296423
> R=ben@chromium.org, enne@chromium.org, vangelis@chromium.org
> 
> Review URL: https://codereview.chromium.org/24486002

BUG=296423,321937
TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/100923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238280 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238279 0039d316-1c4b-4281-b951-d872f2087c98

getenv() is used in libjpeg and libjpeg_turbo to get environment
variable JPEGMEM which overrides the default max_memory setting from
jpeg_mem_init. However, getenv() is not thread-safe. Now libjpeg may
be called from multiple threads when impl-side-painting is enabled.

BUG=322228
TBR=cpu

Review URL: https://codereview.chromium.org/100483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238278 0039d316-1c4b-4281-b951-d872f2087c98

R=enne
BUG=

Review URL: https://codereview.chromium.org/100373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238277 0039d316-1c4b-4281-b951-d872f2087c98

PNaCl bytecode is little-endian, but build_config.h didn't define
ARCH_CPU_LITTLE_ENDIAN.

BUG=276739
R=sehr@chromium.org

Review URL: https://codereview.chromium.org/69763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238276 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/100183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238275 0039d316-1c4b-4281-b951-d872f2087c98

NativeDesktopMediaList provides list of native screens and windows. Another
implementation of DesktopMediaList interface will be used for Ash screens
and windows.

BUG=295102
R=sky@chromium.org

Review URL: https://codereview.chromium.org/89683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238274 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the shared prefixes used a count which would (often) cause
multiple prefixes to end up within 2^16 of each other.  Modify the setup
to explicitly generate both denser and sparser clusters, to allow
reducing the overall number of prefixes required.

BUG=65151

Review URL: https://codereview.chromium.org/99883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238273 0039d316-1c4b-4281-b951-d872f2087c98

Added a verbose option so the rationality of the above can be checked.

BUG=None
TEST=local, and on non-static build.

Review URL: https://codereview.chromium.org/95903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238272 0039d316-1c4b-4281-b951-d872f2087c98

This makes cc::LayerAnimationController support animating scroll offset.
This is needed for implementing the CSSOM View smooth scroll API.

BUG=243871

Review URL: https://codereview.chromium.org/95763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238271 0039d316-1c4b-4281-b951-d872f2087c98

1. Introduce a platform API for video capture.
2. Implement that API for KitKat+ releases of Android.
3. Refactor speed index metric to have Paint Rect and Video impls. Use video
   when available.

BUG=323813

Review URL: https://codereview.chromium.org/93733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238270 0039d316-1c4b-4281-b951-d872f2087c98

Metrics themselves were added here:
https://chromiumcodereview.appspot.com/23245004

BUG=262567

Review URL: https://codereview.chromium.org/74943008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238269 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238267 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=162992:163007&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/93953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238266 0039d316-1c4b-4281-b951-d872f2087c98