GitLab

BUG=405441

Review URL: https://codereview.chromium.org/528333002

Cr-Commit-Position: refs/heads/master@{#294419}

R=engedy@chromium.org

Review URL: https://codereview.chromium.org/565673004

Cr-Commit-Position: refs/heads/master@{#294418}

This patch introduces a WebGL test that ensures we don't hit an
assertion failure in DrawingBuffer when the context is lost in a
background tab.

Depends on the Blink fix from https://codereview.chromium.org/556303002.

BUG=411372

Review URL: https://codereview.chromium.org/560023002

Cr-Commit-Position: refs/heads/master@{#294417}

Cr-Commit-Position: refs/heads/master@{#294416}

Which is what we do on the gyp side too. Going this route rather than a different BUILD.gn as there aren't a lot of files and we don't have separate components on the gyp side.

BUG=408648
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/552053005

Cr-Commit-Position: refs/heads/master@{#294415}

This code is only used by the Notification constructor, and doesn't have
to be a public method on a class that's otherwise unrelated to it.

Also get rid of caching the UI manager in the service. All callsites of
the constructor passed in NULL, and BrowserProcess::notification_ui_manager()
actually does the caching for us.

TBR=jochen
BUG=

Review URL: https://codereview.chromium.org/561813002

Cr-Commit-Position: refs/heads/master@{#294414}

The current ELF file rewrite alters both offsets and addresses.
Altering addresses affects debugging tools such as breakpad.

This change leaves addresses unchanged, and instead splits a single
LOAD segment into two, leaving a mapping hole at the point where
the hole was created in the ELF file.  It works by repurposing the
PT_GNU_STACK segment, unused on Android.

The split into two LOAD segments no longer requires relocation
packing to adjust relocations or the symbol table, and in particular
means the the call frame information extracted by Dwarf DIE data
extractors for breakpad from an unstripped (and not packed) library
will match the stripped and packed one.

BUG=385553

Review URL: https://codereview.chromium.org/535943002

Cr-Commit-Position: refs/heads/master@{#294413}

Ignore the context for process-wide incidents when waiting for the most
recent download finder to complete. Otherwise the service holds on to
state needlessly.

BUG=413253
R=robertshield@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562223002

Cr-Commit-Position: refs/heads/master@{#294412}

GN visibility currently allows either string or list types, but this is causing
some problems for some templates, which don't know if the invoker set the
visibility to a list or a string. Since there is no type reflection, templates
don't know how to handle visibility if they need to add to or replace the list.

Adds a missing error check in the config visibility checker.

R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/552843005

Cr-Commit-Position: refs/heads/master@{#294411}

https://chromium.googlesource.com/chromium/blink/+log/f0548820182fad9dd6c5f4b444e57d90d83eb605..f00fc1e323c6f7222c9a394187567b43e8589dc5
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/566633002

Cr-Commit-Position: refs/heads/master@{#294410}

BUG=None

Review URL: https://codereview.chromium.org/564643002

Cr-Commit-Position: refs/heads/master@{#294409}

Reland of -fno-exceptions only on .cc files https://codereview.chromium.org/560873003/ with fix for ASAN LSAN

libc++ build removed from cflags, so wasn't removed.

I don't see any other instances of doing this in https://code.google.com/p/chromium/codesearch#search/&q=fno-exceptions&sq=package:chromium&type=cs

R=earthdok@chromium.org, thakis@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/561063002

Cr-Commit-Position: refs/heads/master@{#294408}

In software mirroring mode, there is one X root window and it should
be associated with both displays (touchscreens).

BUG=chrome-os-partner:31466
TEST=tested on Big with clone mode.

Review URL: https://codereview.chromium.org/557073002

Cr-Commit-Position: refs/heads/master@{#294407}

This also fixes a resources regression (added extensions resources) that caused chrome not to run.

R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/554393009

Cr-Commit-Position: refs/heads/master@{#294406}

Prior to this patch, CallWhileUnlocked required its parameters' types to
be perfect matches to the types in the function pointer it's meant to
invoke. This is counter to programmers' usual expectations for function
calls, since the compiler will usually do safe casts like add const or
promoting integral types. This just adds template params to CallWhileUnlocked
so that any call with the appropriate number of parameters will be a template
match. The compiler will still decide if there is a valid implicit conversion,
so this is still safe in the sense that mismatched params still won't
compile.

BUG=160925

Review URL: https://codereview.chromium.org/552423003

Cr-Commit-Position: refs/heads/master@{#294405}

https://skia.googlesource.com/skia/+log/aa90d00f14414db39b3d990d8d5fd594d6eadc6e..33a30503d76fdd989358cedd78445ba96bb809dd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/563833002

Cr-Commit-Position: refs/heads/master@{#294404}

BUG=None
TBR=dpolukhin@chromium.org

Review URL: https://codereview.chromium.org/560293003

Cr-Commit-Position: refs/heads/master@{#294403}

To deprecate loading external resources in XML, e.g. external DTDs, measure its usage.

BUG=

Review URL: https://codereview.chromium.org/553233006

Cr-Commit-Position: refs/heads/master@{#294402}

Simplified the logic to save, set, and restore the command line used to
launch a browser. For efficiency, functions are implemented as single
shell commands to run on the device.

This reduces about 20% of the time taken to start a new browser, and
overall 5% of the total running time of telemety unit tests.

BUG=379378

Review URL: https://codereview.chromium.org/547623002

Cr-Commit-Position: refs/heads/master@{#294401}

BUG=411631
TEST=None
TBR=oshima,sadrul (TBR for changes to athena/content/DEPS)

Review URL: https://codereview.chromium.org/550643002

Cr-Commit-Position: refs/heads/master@{#294400}

BUG=399775

Review URL: https://codereview.chromium.org/555463002

Cr-Commit-Position: refs/heads/master@{#294399}

BUG=413233
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/564833002

Cr-Commit-Position: refs/heads/master@{#294398}

Change renderer_main_platform_delegate_win to set the device scale
factor for the renderer in PlatformInitialize. The blink text rendering
code requires on this value being set.

Depends on Blink change https://codereview.chromium.org/553163002/
which must land and roll before this can be landed.

R=cpu@chromium.org, creis@chromium.org

Review URL: https://codereview.chromium.org/561503002

Cr-Commit-Position: refs/heads/master@{#294397}

Recently, crrev.com/418423002 is landed, but it has a bug in Non-SFI mode.
It introduces CHECK for the file token in ManifestService::OpenResource().
However, in Non-SFI mode, there is no NaClIPCAdapter, so the token is passed
from the renderer directly. (Actually the IPC channel is connected directly
to the renderer).
As a result, if the renderer fills the file token properly, it crashes.
As far as I investigated, it happens, at least, when the fast-path is triggered
(i.e. OpenNaClExecutable works in DownloadFile in ppb_nacl_private_impl.cc).
Anyway, we can ignore file tokens in Non-SFI mode, because it is for
SFI NaCl's validation cache.

BUG=394130
TEST=Ran trybots. Patched locally and run our Non-SFI NaCl app.
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32

Review URL: https://codereview.chromium.org/560983003

Cr-Commit-Position: refs/heads/master@{#294396}

BUG=none
R=marja@chromium.org

Review URL: https://codereview.chromium.org/566603002

Cr-Commit-Position: refs/heads/master@{#294395}

BUG=352293
TBR=darin@chromium.org
darin@ TBR'd for dependency on third_party.

Review URL: https://codereview.chromium.org/541753004

Cr-Commit-Position: refs/heads/master@{#294394}

https://codereview.chromium.org/443393003 introduced code for service
processes that turns off RELRO sharing and retries a library load in
the event of an address clash or other failure to load a library with
shared RELRO.

This change adds the same back off and retry strategy to the libraries
loaded in the main browser process, for cases where low memory devices
aggressively share RELRO as widely as possible.

BUG=411928
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/551373004

Cr-Commit-Position: refs/heads/master@{#294393}

The CL provides reference counted ServiceWorkerCaches on ServiceWorkerCacheStorage::Get and Create.  Previously only CacheIDs were provided from those functions and there was no way for the client to access the ServiceWorkerCache itself.

This CL makes the following modifications:

1. Make ServiceWorkerCache refcounted
2. Return ServiceWorkerCache* instead of a CacheID from Create() and Put()
3. Removed CacheID from ServiceWorkerCache
4. Removed CacheContext from ServiceWorkerCache (since it really only existed to hold a CacheID)
5. Now keeps track of CacheIDs in ServiceWorkerCacheListener
6. Added memory unit tests

Related CLs:
1. https://crrev.com/542703002: Change ownership of the parameters to ServiceWorkerCache:: Put and Match.
2. https://crrev.com/545533002: Move ServiceWorkerCache backend creation to a lazy init function.
3. https://crrev.com/548533002: Make ServiceWorkerCacheStorage::CacheLoader::LoadCache synchronous
* 4. https://crrev.com/549493002: Expose ServiceWorkerCache objects to ServiceWorkerCacheStorageManager clients.

BUG=392621

Review URL: https://codereview.chromium.org/549493002

Cr-Commit-Position: refs/heads/master@{#294392}

BUG=408189

Review URL: https://codereview.chromium.org/557333003

Cr-Commit-Position: refs/heads/master@{#294391}

Now that Blink fully populates the |WebTouchEvent.touches| field when
offering events to plugins, we can safely stop using
|WebTouchEvent.changedTouches|.

This is part 3 of a 4-sided patch simplifying WebTouchEvent:
1) https://codereview.chromium.org/557863002/
2) https://codereview.chromium.org/558773002/
3) This change
4) https://codereview.chromium.org/560493003/

BUG=358132

Review URL: https://codereview.chromium.org/559693003

Cr-Commit-Position: refs/heads/master@{#294390}

AnalysisCanvas should be notified when drawing text using the new blob
API.

R=jbroman@chromium.org,reed@google.com,reveman@chromium.org
BUG=412445

Review URL: https://codereview.chromium.org/545203004

Cr-Commit-Position: refs/heads/master@{#294389}

Rather than poll for touchscreen devices in ui/display, centralize
X11 hotplug handling into ui/events and have TouchscreenDelegateImpl
reuse the cached device list.

In addition, DeviceDataManager will now cache all the touchscreen
devices and provides an observer pattern such that we can move input
event hotplugging out of ui/display entirely (this will be done in a
follow-up CL).

BUG=381326

Review URL: https://codereview.chromium.org/508303002

Cr-Commit-Position: refs/heads/master@{#294388}

https://skia.googlesource.com/skia/+log/26a4b514999dcbd8c6a4a2e85bcc5dbd55f02236..aa90d00f14414db39b3d990d8d5fd594d6eadc6e

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/560303003

Cr-Commit-Position: refs/heads/master@{#294387}

BUG=413215
TBR=zhaoqin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/545153003

Cr-Commit-Position: refs/heads/master@{#294386}

BUG=406014
R=sadrul@chromium.org

Committed: https://crrev.com/817ca9b5c2145d843f6ff154926db79535974778
Cr-Commit-Position: refs/heads/master@{#293781}

Review URL: https://codereview.chromium.org/538143002

Cr-Commit-Position: refs/heads/master@{#294385}

PersonalDataManagerTest should delete temporary directory AFTER WebDataServiceBackend stops using it.

Tests tried to delete temporary directory while it was still in use which
on Windows caused SHFileOperation to block for around 1 second and finally fail.

After this patch test runs at least 15 times faster on Windows.

Review URL: https://codereview.chromium.org/560093002

Cr-Commit-Position: refs/heads/master@{#294384}

This is to revision 7151.

TBR=hellner@chromium.org, sergeyu@chromium.org

Review URL: https://codereview.chromium.org/557223004

Cr-Commit-Position: refs/heads/master@{#294383}

The connection is only needed during sandbox warmup to initialize the default
color space. It was formerly needed by scrollbar NSAnimations, but that was
replaced via https://codereview.chromium.org/529103002/.

A similar CL was landed and reverted:
https://chromium.googlesource.com/chromium/src.git/+/53ffdf90f4646dbde8df72007fbdc97f3f0220de

BUG=397642, 306348
TEST=Manually tested on 10.6-10.10.

Review URL: https://codereview.chromium.org/561833006

Cr-Commit-Position: refs/heads/master@{#294382}

gnome-fallback sessions set XDG_CURRENT_DESKTOP to Unity,
DESKTOP_SESSION needs to be tested as well.

BUG=

Review URL: https://codereview.chromium.org/550173006

Cr-Commit-Position: refs/heads/master@{#294381}

Show paste option on right click of bookmark bar if some URL is copied from outside browser or from any page content

Paste option was not appearing when some URL is copied from outside browser
or web page content. But if some URL is copied from url bar the paste option
appears when right click is performed on bookmark bar. Added check in
CanPasteFromClipboard to handle this scenario.

BUG=400644

Review URL: https://codereview.chromium.org/437423005

Cr-Commit-Position: refs/heads/master@{#294380}