- 27 May, 2014 19 commits
-
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272910 0039d316-1c4b-4281-b951-d872f2087c98
-
mlerman@chromium.org authored
BUG=357693 Review URL: https://codereview.chromium.org/296023003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272909 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
context menu on long press if the events are targetted at a view which can show the context menu. If a different view is the gesture handler and the event was targetted at a different view (e.g. because the maximize button handled ET_GESTURE_TAP_DOWN) the parent view should not show a context menu on long press. Previously, we were assuming that events were in the coordinates of |PostEventDispatchHandler::owner_| and were sometimes passing an incorrect position to BrowserFrame::ShowContextMenuForView(). BUG=375232 TEST=RootViewTest.ContextMenuFromLongPress Review URL: https://codereview.chromium.org/291273007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272907 0039d316-1c4b-4281-b951-d872f2087c98
-
girard@chromium.org authored
BUG=376038 Review URL: https://codereview.chromium.org/302443005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272906 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Previously Android client was crashing because JingleThreadWrapper was not initialized for the networking thread. It was broken by crrev.com/271351, which removed JingleThreadWrapper initialization from LijbingleTransportFactory. TBR=lambroslambrou@chromium.org Review URL: https://codereview.chromium.org/298013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272905 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
Remove unused code in DesktopScreenPositionClient. In the cases that it is called DesktopNativeWidgetAura::ForWindow() always returns NULL BUG=None TEST=None Review URL: https://codereview.chromium.org/292583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272904 0039d316-1c4b-4281-b951-d872f2087c98
-
mmenke@chromium.org authored
It's been a couple years since anyone worked on it, and there are no plans to enable it by default. Cached pipelining-related server information will automatically be cleared when server information is next saved, so there are no issues on that front. BUG=364557 R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/275953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272903 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
This is to facilitate the addition of an app launcher example/demo app, separate from the browser, and to assist testing of the out-of-process compositor on mac. The change splits out from the current views_examples_with_content_exe target a new views_content_client target placed in ui/views_content_client. views_examples_with_content_exe is updated to use it. This will allow the app launcher to have its own example app, while reusing the logic to set up the multiprocess runtime environment for using views and content. Follow-up patches for the views_content_client runtime will: isolate aura dependencies, introduce the gpu_process UI compositor, and implement the runtime environment for mac. BUG=365977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272476 Review URL: https://codereview.chromium.org/284113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272902 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
This is needed for weird platforms that don't present the buffer without extra help. In particular gbm (from EGL_MESA_platform_gbm) has this requirement. TBR=kbr TEST=ozone build BUG=377497 Review URL: https://codereview.chromium.org/300023006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272901 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/296693013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272900 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
BUG=374183 Review URL: https://codereview.chromium.org/298953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272899 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
* Fixes GetHomeDir() for multi-profiles case on Chrome OS. * Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir. * Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there. This fix doesn't require checking for --multi-profiles switch since user_id hash is known even without it. Note: download_prefs.cc still uses GetHomeDir() in its DownloadPathIsDangerous() check. // Consider downloads 'dangerous' if they go to the home directory on Linux and // to the desktop on any platform. In this context correct behavior is to use "real" base::GetHomeDir() and not "virtual one" base::DIR_HOME. Since latter is remapped to some test dir in tests, in some subfolders in Chrome OS etc. BUG=331530 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270872 Review URL: https://codereview.chromium.org/200473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272898 0039d316-1c4b-4281-b951-d872f2087c98
-
flackr@chromium.org authored
BUG=377508 TEST=Manually verified this updated angle matches expectations. Review URL: https://codereview.chromium.org/293383004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272897 0039d316-1c4b-4281-b951-d872f2087c98
-
jif@chromium.org authored
This is an intermediary CL. The FaviconClient is moving towards being a KeyedService. BUG=377505 Review URL: https://codereview.chromium.org/303453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272896 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
We need to call ui::InitializeInputMethodForTesting. This is currently protected by USE_X11 but should not be. TBR=pfeldman BUG=none TEST=content_shell --ozone-platform=egltest Review URL: https://codereview.chromium.org/301603002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272895 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Fixed playout time calculations by relying on the sender reports in order to compute reliable capture timestamps in terms of the local clock. Added a ClockDriftSmoother to smooth out jitter/skew in the "NTP to local clock TimeTicks" conversions. Used the same to provide a gradual timeline shift in the case where a receiver had to "hack up" playout times before the first sender report was processed. As proof-of-concept, also added playout_time "smoothness" testing to the End2EndTest's. Both first and second order effects are tested. Miscellaneous clean-ups and fixes in timing code throughout media/cast. BUG=356942 Review URL: https://codereview.chromium.org/280993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272893 0039d316-1c4b-4281-b951-d872f2087c98
-
horo@chromium.org authored
In current code, EmbeddedWorkerDispatcher is deleted in the destructor of RenderThreadImpl. If EmbeddedWorkerDispatcher contains any WorkerWrapper in workers_, WorkerWrapper and EmbeddedWorkerDevToolsAgent will be deleted at that time. And the destructor of EmbeddedWorkerDevToolsAgent will call RemoveEmbeddedWorkerRoute of RenderThreadImpl which is being deleted. To avoid this we should delete EmbeddedWorkerDispatcher in RenderThreadImpl::Shutdown(). BUG=377258,358657 Review URL: https://codereview.chromium.org/297343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272892 0039d316-1c4b-4281-b951-d872f2087c98
-
fsamuel@chromium.org authored
BUG=364141, 330264 TBR=jam@chromium.org for code deletion in content/public/browser_plugin_guest_delegate.{cc|h} Review URL: https://codereview.chromium.org/295083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272889 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
Roll the script to 209116 to match a recent clang roll. BUG=375245 R=glider@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/301583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272888 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 May, 2014 21 commits
-
-
felt@chromium.org authored
This adds the image that Issue 294343004 is dependent on. BUG=331453 R=bauerb@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/293363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272887 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://fsp-internalsmtomasz@chromium.org authored
Similarly to chrome://drive-internals, this patch introduce a webui page showing what's going on in the system. Currently, only mounted file systems, and number of active requests are shown, however more is coming soon. TEST=Tested manually by invoking chrome://fsp-internals with a running providing extension. BUG=376095 Review URL: https://codereview.chromium.org/296003012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272886 0039d316-1c4b-4281-b951-d872f2087c98
-
earthdok@chromium.org authored
We used to declare sanitizer interface functions explicitly because we didn't have access to sanitizer interface headers. That has not been the case for a while. Also, a recent clang roll changed the signature of __sanitizer_sandbox_on_notify() causing conflicts with our own declaration. BUG=none TBR=jln@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/294093012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272885 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
Added automatic mode to FakeInputAudioStream to generate automatic beeps. This patch is to allow writing audio only tests using the fake input stream, also it changes the name of the fake device from "Default" to "Fake Audio, which I hope it will make things less confusing. Previously it broke the mac bots due to it somehow triggered crbug/288562, crbug/371271, which should have been fixed by https://codereview.chromium.org/274073002/ TBR=ananta@chromium.org, dalecurtis@chromium.org NOTRY=true BUG=358541 TEST=bots existing webrtc tests. Review URL: https://codereview.chromium.org/279223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272884 0039d316-1c4b-4281-b951-d872f2087c98
-
eustas@chromium.org authored
content Response::Parse doesn't match chrome Response::Serialize. BUG=373325 Review URL: https://codereview.chromium.org/300703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272883 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/291343004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272882 0039d316-1c4b-4281-b951-d872f2087c98
-
sammc@chromium.org authored
Review URL: https://codereview.chromium.org/301533002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272881 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
profile pref store may observe the validation of tracked preferences. BUG= Review URL: https://codereview.chromium.org/266553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272880 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272878 0039d316-1c4b-4281-b951-d872f2087c98
-
machenbach@chromium.org authored
Please reply to the V8 sheriff verwaest@chromium.org in case of problems. TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/302533006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272877 0039d316-1c4b-4281-b951-d872f2087c98
-
peria@chromium.org authored
- SyncWorker: Construct / Destruct - SyncWorker::Observer: Destruct BUG=347425 TEST=./unit_tests --gtest_filter="SyncEngineTest.*:DriveBackendSyncTest.*" Review URL: https://codereview.chromium.org/288193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272876 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
1) Fix a typo in ScoredHistoryMatch::GetFrequency name 2) Fix a cpplint warning BUG=370850 Review URL: https://codereview.chromium.org/300433003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272875 0039d316-1c4b-4281-b951-d872f2087c98
-
tsniatowski@opera.com authored
This avoids a GL error from a buggy glGetIntegerv(GL_MAX_SAMPLES_ANGLE) call. Based on patch by mkisilev@yandex-team.ru BUG=362435 R=sievers@chromium.org Review URL: https://codereview.chromium.org/296133007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272874 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@chromium.org authored
Introduced in https://codereview.chromium.org/294033002/ NOTRY=true BUG=None TBR=noms@chromium.org Review URL: https://codereview.chromium.org/297393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272873 0039d316-1c4b-4281-b951-d872f2087c98
-
kaznacheev@chromium.org authored
BUG=375679 Review URL: https://codereview.chromium.org/298873007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272872 0039d316-1c4b-4281-b951-d872f2087c98
-
calamity@chromium.org authored
This CL adds a unit test for the experimental app list that instantiates the app list in experimental mode and performs a series of very basic checks. BUG=349727 Review URL: https://codereview.chromium.org/291653003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272871 0039d316-1c4b-4281-b951-d872f2087c98
-
antrim@chromium.org authored
Phase one : introduce future screen classes before moving code from handler. BUG=373314 Review URL: https://codereview.chromium.org/293613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272870 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272869 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272868 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272867 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyv@chromium.org authored
Revert of Support "Pin to taskbar" for hosted app windows. (https://codereview.chromium.org/258243002/) Reason for revert: Suspect to cause failure on Vista machines: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40163 Original issue's description: > Support "Pin to taskbar" for hosted app windows. > > This CL allows hosted app windows to be pinned to the taskbar by > right-clicking the taskbar icon and pressing the "Pin to taskbar" button. > > This CL pulls out the code that sets the relaunch details of v2 app > windows into web::UpdateRelaunchDetails. > > BUG=368101 > TEST=Run a hosted app as a window. Pin it from the taskbar icon right click > menu. Relaunch the app from the pinned icon. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851 NOTRY=true NOTREECHECKS=true TBR=calamity@chromium.org Review URL: https://codereview.chromium.org/298003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272866 0039d316-1c4b-4281-b951-d872f2087c98
-