GitLab

Use PrerenderURLLoaderThrottle instead, which is now usable even without
network service.

Bug: 755921
Change-Id: Ib9e15e9e762c39c3e37052aa0c36f4711e00db5b
Reviewed-on: https://chromium-review.googlesource.com/c/1427540Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625702}

Since http://crrev.com/556458 there have been two (or three) completely
different ways of ‘returning’ events from an EventRewriter:

- The original output parameter on RewriteEvent(), with the clunky
  NextDispatchEvent() to produce multiple events.

- Calling SendEventToEventSource(source, event), when the replacement
  event must pass through later event rewriters. (This had the problem
  of not tracking the original source.)

- Several EventRewriters do an end run around the rewriter system in
  some cases, e.g. calling WindowEventDispatcher::OnEventFromSource()
  after a timeout, since the original RewriteEvent() interface could
  only produce events in response to incoming events.

This CL replaces all the above cases with a consistent return mechanism,
using Send…() functions. This is inspired by SendEventToEventSource(),
but has the caller provide the output functions explicitly, so that
multiple sources can correctly share an EventRewriter (as Ash does).

This CL contains the EventRewriter/EventSource revision, under
//ui/events, plus conversions of ‘trivial’ rewriters (essentially those
that only used RewriteEvent()). Other rewriters will be converted in
separate CLs for review by their respective OWNERS, because removing
NextDispatchEvent() or asynchronous dispatch generally requires some
logic change.

This CL includes a compatibility shim for the old API, which will be
removed once all rewriters have changed.

How to convert an EventRewriter:

How to convert an EventRewriter:

- When the incoming event is accepted unchanged, replace old API uses of
     return EVENT_REWRITE_CONTINUE;
  with new API
     return SendEvent(continuation, &incoming_event);

- When the incoming event is to be discarded, replace old API uses of
     return EVENT_REWRITE_DISCARD;
  with new API
     return DiscardEvent(continuation);

- When the incoming event is to be replaced, replace old API uses of
     *rewritten_event = std::move(new_event);
     return EVENT_REWRITE_REWRITTEN;
  with new API
     return SendEventFinally(continuation, replacement_event);

- When the incoming event is to be replaced, and the replacement event
  should pass through later rewriters, replace old API uses of
     return SendEventToEventSource(source, replacement_event);
  with new API
     return SendEvent(continuation, replacement_event);

- When the incoming event is to be replaced by multiple events, replace
  old API uses of
     *rewritten_event = std::move(new_event_1);
     // record new_event_2 … new_event_N
     return EVENT_REWRITE_DISPATCH_ANOTHER;
  with new API
     details = SendEventFinally(continuation, new_event_1);
     ⋮
     return SendEventFinally(continuation, new_event_N);

Bug: None
Change-Id: I4d217cee5aa1a2f2dbf178ce642ef1b6e2338c25
Reviewed-on: https://chromium-review.googlesource.com/c/1203882Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625701}

This will allow us to run an experiment comparing memory usage of the
no-op process vs memory usage of the network process to determine if
memory is being overcounted in the Memory.Total.PrivateMemoryFootprint
UMA.

Bug: 923101
Change-Id: Iac578d2367f2af176d096fbe00ee758f6e642bbd
Reviewed-on: https://chromium-review.googlesource.com/c/1417836Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625700}

This change disables the animation for the frame buttons when entering tablet
mode.  There was no actual animation before (the buttons would instantly
disappear), so the animation delay caused tabs to resize too late after entering
tablet mode.  Here's a before/after to clarify:

https://drive.google.com/open?id=1ogjl8lniXlqa6j7busvG3CtK_aizSKI6

BUG=881371
R=sky

Change-Id: I3eca2546fe3d3381c97d37bc40b57ede3d0f98c9
Reviewed-on: https://chromium-review.googlesource.com/c/1427247Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625699}

Bug: 924507
Change-Id: I837537c61a90b88933e980c1707dcd00746ad217
Reviewed-on: https://chromium-review.googlesource.com/c/1434515Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625698}

This CL adds the necessary plumbing to propagate
OnRemotePlayStateChange events back to WMPI.

This is used when the FlingingRenderer detects that a video playing
remotely was paused/resumed by an external device.

A follow up CL will add that adjusts WMPI's play/pause state to reflect
the current state of the remotely playing video

Bug: 790766
Change-Id: I6ddd4fb2ff273f095008e796e9d676c8e759dab2
Reviewed-on: https://chromium-review.googlesource.com/c/1413234
Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625697}

Add boolean histogram that gets logged every time the user tries to
enter the VR browser without the VR DFM installed. Logs true in case of
success, and false in case the VR browser is blocked or started in
2D-in-VR mode.

Bug: 923545
Change-Id: I804ef724fbf55ecdb161c1c6fdd2eb4c5bb34982
Reviewed-on: https://chromium-review.googlesource.com/c/1431481
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625696}

This CL removes provisionally saving when the credentials autofilled
which removes calling of ShowManualFallback for autofilled credentials,
and this is the right thing to do, because we don't need to show a manual
fallback until the user start typing something and anyway autofilled
credentials are already saved.

Bug: 831123
Change-Id: I2f9a84a81612e38878f1c772ca260efd933c620c
Reviewed-on: https://chromium-review.googlesource.com/c/1434194
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625695}

(and some related methods elsewhere)

Bug: 884159
Change-Id: I2b87b9fc9302f35e5fd3862035ef84418e5ffac8
Reviewed-on: https://chromium-review.googlesource.com/c/1432844
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625694}

This reverts commit 507521d5.

Reason for revert: We wanted this for testing prior to release, but we don't want it in the release branch until we've gone through security review.

Original change's description:
> Enable file upload by default.
> 
> Now that file upload has a cross-platform implementation, it should be
> safe to enable for testing and eventual rollout to the client. We
> decided we didn't need a Chrome policy for now, so enable
> unconditionally.
> 
> Bug: 679313
> Change-Id: I7abd23561d7c485191cfade854b0cfcc035e25be
> Reviewed-on: https://chromium-review.googlesource.com/c/1419097
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623947}

TBR=jamiewalch@chromium.org,joedow@chromium.org,rkjnsn@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 679313
Change-Id: I8479766fbdbfbca9a10c179c49cd745fe13904e2
Reviewed-on: https://chromium-review.googlesource.com/c/1434517Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Erik Jensen <rkjnsn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625693}

My fix for Issue 819798 involved a case where overview mode is triggered
on entering tablet mode (specifically, if the active window is snapped
on one side and the previous window is not snapped on the opposite
side), and after that, if you brought up the app list, you could not see
it. To solve that, now overview mode shall not be activated until after
TabletModeWindowManager::TabletModeWindowManager has finished and
OnTabletModeStarted has been sent out. This approach makes more sense
anyway, especially when you consider comments in TabletModeWindowManager
about the importance of overview mode ending before tablet mode starts;
it could easily fix some undiscovered bugs as well.

  TabletModeControllerTest.AppListWorksAfterEnteringTabletForOverview

Test: ash_unittests
Bug: 922284
Change-Id: I10c7f1da60d6e44ea76db3a1c7199f897fccc191
Reviewed-on: https://chromium-review.googlesource.com/c/1417124
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625692}

TaskScheduler.NumActiveWorkers histogram measures the number of scheduled tasks
in each WorkerPool 59min.

CL 1380965 recorded the histogram, but I forgot to add it to histograms.xml so it
never appeared on the dashboard. Here it is!

Bug: 847501
Change-Id: I394117872cbe05662c13b86b7688247fe08f999d
Reviewed-on: https://chromium-review.googlesource.com/c/1422119Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625691}

When the network is in large rows mode, the heading is larger. The
tabbed pane when a request is selected had a margin added to match the
larger heading. But that caused a strange white space to appear above
the tabbed pane.

Change-Id: I19bdf61509b2f14c80e06113228475759da9e7d2
Reviewed-on: https://chromium-review.googlesource.com/c/1387906Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625690}

UpdateMenuItemHelper is having multiple new states added to support
inline updates.  These states can also be dynamically set at runtime.
To support this, this CL does an initial refactor and changes the
following:
- Moves all update state calculation to a separate class that can
asynchronously query and push state changes to observers.
- Unifies the multiple UI property getters to a single method and
exposes UI state as a struct to all callers.
- Moves some UI-related static animation methods to the class that uses
them.

BUG=992709

Change-Id: I318ea6269482b2d685e601e2e65e1cce3c73705a
Reviewed-on: https://chromium-review.googlesource.com/c/1408130Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625689}

|use_reduced_number_of_allocations_| regressed a couple of performance
tests on old-ish CrOs platforms like Broadwell and Haswell (see newest
bug). This CL limits the use of said operational mode to SkyLake and
later.

FTR the CL that caused the regression is crrev.com/c/1387391.

Bug: 912295, 920510
Change-Id: Idb0a820bee3a714742af580e4ba7a0ea132a08ee
Reviewed-on: https://chromium-review.googlesource.com/c/1409353Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625688}

Enable Media Session API on desktop for all platforms
since we have features in M73 using this API. This
was previously enable for CrOS and Windows only but
we would like to enable it for consistency on all
desktop platforms.

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/xIpJ_303phw/6PoGcPIGFQAJ

Desktop PSA: https://groups.google.com/a/chromium.org/d/msg/blink-dev/EQVR9vOrP8o/NkAbV26sDQAJ

BUG=922630

Change-Id: I99f9972db64b08f10560b0a318f32a2d1470a3cc
Reviewed-on: https://chromium-review.googlesource.com/c/1432133Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625687}

This is a reland of 0ebabc86

Original change's description:
> Move NoTouchActivity to touchless package
>
> Move the NoTouchActivity to the newly created touchless sub-package in order to
> declutter and tidy up the browser package.
>
> Bug: 922047
> Change-Id: Ib7d9df3c89295e9e675b35a05e3613b390fbae5e
> Reviewed-on: https://chromium-review.googlesource.com/c/1432473
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Commit-Queue: Mehran Mahmoudi <mahmoudi@google.com>
> Cr-Commit-Position: refs/heads/master@{#625487}

TBR=tedchoc@chromium.org

Bug: 922047
Change-Id: If582fda52db7edbd3e4e510e98b4632ab64185a6
Reviewed-on: https://chromium-review.googlesource.com/c/1434296Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625686}

https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/909f0d3d31e7..ce7d92182b8c

$ git log 909f0d3d3..ce7d92182 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 fjhenigman Use the full spirv-cross dependency. (#550)
2019-01-22 corentin BUILD.gn: fix build error on is_component_build=true (#549)
2019-01-21 corentin BUILD.gn: Make libraries Chromium-style "components" (#548)
2019-01-17 fjhenigman Disable spvc build by default.  (#542) (#547)
2019-01-16 fjhenigman Fix build with exceptions off. (#546)
2019-01-16 dneto Fix MinGW: Format %lu must be unsigned long. (#544)
2019-01-16 dneto Fix leaks in tests (#545)
2019-01-15 fjhenigman Fix ASAN build. (#543)
2019-01-15 fjhenigman Add libshaderc_spvc interface to SPIRV-Cross. (#524)
2019-01-15 fjhenigman Fix NDK build. (#540)
2019-01-11 dneto Android.mk: better fallback for SPIRV-Tools dir (#538)
2019-01-09 dj2 Roll RE2 Dep (#537)
2019-01-07 dj2 Fixup source matching test (#534)
2019-01-03 fjhenigman Fix Windows test script return value. (#533)
2019-01-02 dj2 Switch GLSLang to upstream (#515)
2018-12-28 alex Generate source text debug info if requested (#455) (#532)
2018-12-27 ehsann [kokoro] Stop running tests on VS 2013 builds. (#531)
2018-12-21 fjhenigman Update Android NDK. (#530)
2018-12-17 dneto Test shader uniforms need descriptor set and binding (#523)
2018-12-17 kknb1056 Add git clone of re2 and effcee to the Dockerfile (#527)
2018-11-28 dj2 Update to use Android.mk from glslang (#520)
2018-11-22 dneto Add unit tests for mesh and task shaders
2018-11-21 arseny.kapoulkine Add support for NV_EXTENSIONS in #pragma shader_stage()
2018-11-19 dj2 Build file updates. (#514)
2018-11-15 dj2 Fixup shadowed variables (#513)
2018-10-11 dneto Unpin googletest. It has been fixed upstream
2018-11-13 dj2 Add effcee and re2 when building spirv-tools tests (#510)
2018-10-24 dj2 Only include third_party directories if needed. (#507)

Created with:
  roll-dep src/third_party/shaderc/src

TBR=dsinclair@chromium.org
BUG=dawn:29

Change-Id: I1c6c740bfa91404e9523769924d0bdbd7b4b9b46
Reviewed-on: https://chromium-review.googlesource.com/c/1434095Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625685}

Intent to ship:
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/LN92hkaKCzw/Y-ryVxu5AgAJ

Bug: 823744, 841224
Change-Id: Ic4d3d67facd0d717b929b9798650eb502057fea6
Reviewed-on: https://chromium-review.googlesource.com/c/1368826
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#625684}

This CL changes InitiateTranslation in 2 ways:
- It decouples the actual decision making from the triggering, metrics
  recording, and Ranker Event logging
- It avoids returning early, to enable some upcoming behavior that
  would have required inserting the same function call in multiple
  places in the function

Functionally, there should be no change introduced from this CL,
although the TranslateManager performs marginally more work on cases
that would previously return early.

Change-Id: Ib78f7f5d42c651c1089711e0f6e14f362fdddebd
Reviewed-on: https://chromium-review.googlesource.com/c/1431480
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625683}

A check was added to RenderWidgetHostImpl::SynchronizeVisualProperties in
https://chromium.googlesource.com/chromium/src/+/9746a213f859bf3ce39f73c20b57e3bd24f8c130

However we have found reproduction cases of this failing on Android.

I'm removing the check from Android until we can fix the root cause.

TBR: samans@chromium.org
Bug: 923742
Change-Id: I8aa9d524b1bc2f92bc6b6eb4ebfa4e32db07307a
Reviewed-on: https://chromium-review.googlesource.com/c/1433936Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625682}

video: https://drive.google.com/file/d/1rRJgtGsgFPsFgcoUCwqcYT-dHDKguuhk/view?usp=sharing

Starting from the leading edge, it features an icon followed by the source
and the target languages. Toggling between the languages results in the
page to be translated or the translation to be reverted. At the trailing
edge, the infobar features an options button that opens a popup menu that
allows changing translate preferences followed by a close button to dismiss
the infobar. The view hierarchy is as follows:
TranslateInfobarView ->
TranslateInfobarTabStripView ->
TranslateInfobarTabView

Bug: 910994
Change-Id: Icc9d06f43a4a91ba0ec967ce3e9b372b5e9b9bfb
Reviewed-on: https://chromium-review.googlesource.com/c/1426014
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625681}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/f580d4907862..c4f1acd86f1d


git log f580d4907862..c4f1acd86f1d --date=short --no-merges --format='%ad %ae %s'
2019-01-24 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@c4f1acd86f1d

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I8e169c971a49aba718efd02057d25e31459bb8eb
Reviewed-on: https://chromium-review.googlesource.com/c/1433914Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625680}

This was previously marked as flaky but the "webrtc-wpt-unified-plan"
virtual test suite does not exist anymore and has been replaced by
"webrtc-wpt-plan-b".

NOTRY=True
TBR=hta@chromium.org

Bug: 924990
Change-Id: I9a85dfeefe22c5a6596c447f8db6b23e30107386
Reviewed-on: https://chromium-review.googlesource.com/c/1434279Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625679}

CL to catch up chromecast's implementation of automation and
extension apis.  Chrome switched to native bindings for
extension/tabs apis.  Need to bring in the same native
binding init code to chromecast.  Automation classes also
updated to stay in sync with chrome impl.

Bug: None
Test: Manual build cast_shell and test on estelle
Change-Id: I01272b80c5123349d3e795c93e6fa758ceee03bf
Reviewed-on: https://chromium-review.googlesource.com/c/1431337Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625678}

https://android.googlesource.com/platform/external/perfetto.git/+log/970cd8e6beba..f68a7687983a


git log 970cd8e6beba..f68a7687983a --date=short --no-merges --format='%ad %ae %s'
2019-01-24 lalitm@google.com Merge "trace_processor: remove log spam when encountering unknown counters and unify swap"


Created with:
  gclient setdep -r src/third_party/perfetto@f68a7687983a

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ic4f4c8a9132f122ef2a550e00eba7ff0e17cfd20
Reviewed-on: https://chromium-review.googlesource.com/c/1434114Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#625677}

See also
https://fetch.spec.whatwg.org/#cross-origin-resource-policy-header

Bug: 853723
Change-Id: I1bafc0c75c84dc0fff36fcf92fab34ea4206d689
Reviewed-on: https://chromium-review.googlesource.com/c/1416813
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625676}

In sync_service.h, the methods are in a (mostly) sensible order, so
let's use that.
This only changes profile_sync_service.h but leaves the .cc as it is.
Reordering the methods there is probably not worth the churn and "lost"
history.

Bug: none
Change-Id: If96a9bc5a4fb0e9a7e4d7827dcfde0294e1dd697
Reviewed-on: https://chromium-review.googlesource.com/c/1433757Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625675}

Bug: 801985
Change-Id: I7f02c991e8407ffb30c49438bebddd03478bbe5e
Reviewed-on: https://chromium-review.googlesource.com/c/1433622
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625674}

Create a mock Mojo interface through which individual test cases can
modify behaviour of the call. This enables us to extensively test the
Web Exposed behaviour.

Bug: 860467
Change-Id: I90da5fb37e600466e488c49ef52b3d14b98d262f
Reviewed-on: https://chromium-review.googlesource.com/c/1431512
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625673}

Adding an assertion failure on a failed FindFamily DWriteFontProxy sync
IPC call to gather more information on failing clients. Sync IPC calls
should only be returning false in very rare cases, which would mean an
error here. More discussion on this on the bug.

Note to Crash reporting sheriffs: This will likely trigger
additional crash reports, which we assume to be a subset of the
crash reports collected for issue 561873.

Bug: 922403
Change-Id: I054e65e5f01ff646329a6174b908305519fef3d6
Reviewed-on: https://chromium-review.googlesource.com/c/1412029Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625672}

Bug: 850098
Change-Id: I454c77d5c47fcdc90ed7a4265cf4f268186a983b
Reviewed-on: https://chromium-review.googlesource.com/c/1431715Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625671}

Change-Id: I432a1eecefe1996bbb33b10f9d6309fad5a0f51b
Reviewed-on: https://chromium-review.googlesource.com/c/1415308Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625670}

Detects the ABI required by the apk (if any), and selects only devices
that support the ABI (when no devices are explicitly requested).

Main use-case for this is to have x86 tests run on emulators
without having to unplug local devices or passing "-d".

Bug: 853280
Change-Id: Iabd5002c185f4e370b3f7504d6d742eef38fb688
Reviewed-on: https://chromium-review.googlesource.com/c/1414490Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625669}

Particularly migrating away from calls to ReplaceDeviceSettingsProviderWithStub.
They are not ideal for the following reasons:

1. They are not straightforward calls to make - they need to be made after
initialization and should be matched with RestoreRealDeviceSettingsProvider.
Because of this, the stub cannot be used until initialization is finished.
So putting test data in the stub has to be done carefully: not too early,
before initialization is finished, and not too late, after it is already read.

2. Both a real and a stub DeviceSettingsProvider are initialized, even though
the real one is not be needed for the test. The real one depends on the local
state, which may also not be needed for the test. Test helpers that depend on local
state makes separating code into packages more difficult, since in test packages inside
chrome/browser, the local state used should be the browser local state, but in
packages outside the browser, there should be no dependencies on chrome/browser.

For more details, see the bug

Bug: 909635
Change-Id: Ia6c8c0f2f9b22f82aceed565158f050c9a6e4b9e
Reviewed-on: https://chromium-review.googlesource.com/c/1400684
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625668}

This adds a method to return the names of all policy-controlled
features supported by the browser. Because this list is determined by
the set of features implemented by Chrome, rather than conformance to
any particular spec, the tests are in /webexposed/ rather than WPT.

(Existing IDL tests in WPT cover the existence of the new method and
the data types that it returns, without depending on the exact values
returned.)

Bug: 917070
Change-Id: I35ccbdce794e236500d15afe5419057a8f162ae7
Reviewed-on: https://chromium-review.googlesource.com/c/1387151
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625667}

This also removes TrustedDOMTypes from workers since we had
difficulty bringing it into the origin trial. They will be re-added
later.

Bug: 739170
Change-Id: Iec6206f1c3c8121f30d7fbdb13054e4e30255fd2
Reviewed-on: https://chromium-review.googlesource.com/c/1411775
Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625666}

Bug: 660612
Change-Id: Ieea560a5fbd4118c69e31e24f37e2f80593ac842
Reviewed-on: https://chromium-review.googlesource.com/c/1417593Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625665}

This CL adds support for Priority Hints on the <script> element, gated
by the Priority Hints Origin Trial. It also adds the necessary tests.
The "importance" is only set for classic scripts and top-level module
scripts, as the effect of importance on a script's imports, if any,
has not been decided yet.

Furthermore, ResourceFetcher currently makes it difficult to
down-prioritize a ResourceRequest whose priority is already set.
https://crbug.com/882344 describes this problem. Since module scripts
already have their priority set to kHigh before reaching ResourceFetcher,
they are currently exempt from the effects of importance="low". It is
also true that importance="high" will not raise the priority of module
scripts any higher than their default, so after this CL, only top-level
classic scripts are affected by Priority Hints. This should enable us to
collect better data during the Origin Trial, as people are interested in
<script async importance="high">.

R=kinuko@chromium.org, kouhei@chromium.org, yoavweiss@chromium.org

Bug: 821464
Change-Id: If3665bddcbd10842071cd91627f18bfb67ba1e98
Reviewed-on: https://chromium-review.googlesource.com/c/1433393Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625664}

This CL adds a missing null check for GetBrowser in RenderViewContextMenu
when opening the emoji panel. If no browser is found default to opening
the emoji panel in the current process instead of crashing.

Bug: 924439
Change-Id: Idabcc6e4da022d1fbfee9e76260479b87953d2a9
Reviewed-on: https://chromium-review.googlesource.com/c/1433375
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625663}