- 02 Aug, 2017 40 commits
-
-
Alex Zhang authored
TestFrameSinkManagerImpl is an empty implementation of mojom::FrameSinkManager. It takes the place of FrameSinkManagerClientBinding in WindowServer in unit tests. TestGpuHost is an empty implementation of GpuHost. It takes the places of DefaultGpuHost in WindowServer in unit tests. TestWindowServerDelegate now creates a WindowServer with the test implementations so that there is no mojo connections in ws unit tests. Bug: 698026 Change-Id: Ie8682e15a624bcfca2856f07508051cfb4f19308 Reviewed-on: https://chromium-review.googlesource.com/594849 Commit-Queue: Xingyu Zhang <staraz@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#491213}
-
nednguyen authored
THis also fix the regex of finding .wpr files in json archives list Bug: 730036 Change-Id: Iea0d1cd53caa4a45d293940a345dfa9e66737e63 Reviewed-on: https://chromium-review.googlesource.com/596589 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491212}
-
Christopher Cameron authored
Add helper in gfx::ColorSpace to, given an output color space, compute - the space in which rasterization should be performed - the space in which blending should be performed. Remove a place in the ui::Compositor where we check the kHighDyanmicRange feature, and use the above helper functions instead. Add logic in display::Display to automatically update the bit depth for media queries based on whether or not the output color space is HDR. Allow forcing an scrgb-linear profile using the --force-color-profile argument. Add logic in display::ScreenWin to enable HDR mode. This currently queries the HDR feature, but will pull the logic out of the GPU process in the next patch. R=hubbe TBR=avi (for content/) Bug: 682416 Change-Id: Ieffca5a3e0fa01a98aea5558db251712989519e7 Reviewed-on: https://chromium-review.googlesource.com/596776Reviewed-by:
ccameron chromium <ccameron@chromium.org> Commit-Queue: ccameron chromium <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#491211}
-
Stuart Langley authored
Bug: 712963 Change-Id: I079d33a74817c384e69ff1009e15af72c4bb9c4f Reviewed-on: https://chromium-review.googlesource.com/596619Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#491210}
-
Devlin Cronin authored
With the new task scheduling system, there are no guarantees that different operations will not collide - each caller has to ensure that no conflicting tasks will be scheduled and executed synchronously. This means that for file tasks, we need to have a common task runner for any tasks that may touch the same files. Introduce a common SequencedTaskRunner for the extension system, and use it in the UserScriptLoader. Additionally, use it in ExtensionService, in lieu of the prior ExtensionService-owned task runner that's used for file tasks in installation. Finally, also make the GetFileTaskRunner() method in ExtensionService non-virtual, since it's not needed on any of the interfaces. Bug: 689520 Bug: 750122 Change-Id: I9d0b993689821e7aca9b2553283609cce796a162 Reviewed-on: https://chromium-review.googlesource.com/593854Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491209}
-
Scott Graham authored
This resolves e.g. base_unittests not being able to find operator new, string::string(), etc. in Debug (is_component_build=true) builds. This matches other platforms, but was missed in creating the Fuchsia test() template. Bug: 750392 Change-Id: I1a7ba2988e9d991f26d392eeab670f3a100de319 Reviewed-on: https://chromium-review.googlesource.com/596520Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491208}
-
Conley Owens authored
Currently, there are no browser-side geolocation permission checks. This change adds a GeolocationService, which performs this check in the browser. BUG=426384 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I40925adc1e18ff8549a6d9dd94f998e013ebf3a1 Reviewed-on: https://chromium-review.googlesource.com/558604 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491207}
-
Elliot Glaysher authored
Bug: 750642 Change-Id: Ibb22a58e8554916190e3e667d65740cf89d7be58 Reviewed-on: https://chromium-review.googlesource.com/596832Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491206}
-
Kevin Marshall authored
Fuchsia: enable MemoryMappedFile tests Fuchsia now supports mmap() for tmpfs, so these tests Just Work. Bug: 746051, 706592 Change-Id: I208c88852bcd22cec0b03f8c2578c71fd305c663 Reviewed-on: https://chromium-review.googlesource.com/596611Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#491205}
-
Ali Tofigh authored
Bug: 746987 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3397b1234aec605b93da8b8ffcddd03f121a9980 Reviewed-on: https://chromium-review.googlesource.com/588130 Commit-Queue: Ali Tofigh <alito@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#491204}
-
Weidong Guo authored
Changes: 1. Clicking/touching the x button should clear the text and keep the searchbox active. 2. Backspace clearing the last character should act the same as X button. 3. Add unit tests for this behavior change. BUG=749361 TEST= SearchBoxViewFullscreenTest.CloseButtonInvisibleByDefault SearchBoxViewFullscreenTest.CloseButtonVisibleAfterTyping SearchBoxViewFullscreenTest.SearchBoxEmptyAfterCloseButtonClicked SearchBoxViewFullscreenTest.SearchBoxActiveAfterCloseButtonClicked Change-Id: I6ad303bd222996c1aad343c17c08fb17f5667318 Reviewed-on: https://chromium-review.googlesource.com/595256 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#491203}
-
Adrienne Walker authored
In order to more easily refactor RasterSource's preamble generation (see https://chromium-review.googlesource.com/c/592237/) this moves out code that isn't supported by PaintCanvas up to where there's an SkCanvas. The SkCanvas::discard logic only applies to gpu raster and so is only replicated in the gpu raster buffer provider and not elsewhere. Bug: 671433 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0e006b78bb619b56e5db0a1d30c74e8de63547e1 Reviewed-on: https://chromium-review.googlesource.com/594661 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#491202}
-
Daniel Erat authored
Fix a bug where the note-taking app list spins forever due to intent filter changes not being observed for newly-added profiles. Bug: 748763 Change-Id: I094f989ef986d8a8eaf2f2492d46a3c18ea73159 Reviewed-on: https://chromium-review.googlesource.com/594893Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#491201}
-
Scott Graham authored
Bug: 738275, 735701, 750370, 750756 Change-Id: Ibaa143616ce60ae6d94854f9cadc8daf2d84a37c Reviewed-on: https://chromium-review.googlesource.com/596914Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491200}
-
Evan Stade authored
With c3b2602a these heuristics are deemed no longer useful/ necessary. They were only enabled behind a flag, so there should be no effective user-visible change. Bug: 734104 Change-Id: I4c22e7a638dad8d2ed36494663276ef47dbbb495 Reviewed-on: https://chromium-review.googlesource.com/596830Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#491199}
-
Jun Cai authored
This CL adds a "mojom::SensorType type" parameter to the PlatformSensor::Client::OnSensorReadingChanged() function to signal which sensor has changed its data. By doing this, fusion sensor algorithms may update different parts of their internal state depending on which sensor has changed. Bug: 750882 Change-Id: I26fad3e80c4a63337fd89d58ba6a62a6c1d5880a Reviewed-on: https://chromium-review.googlesource.com/594720 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491198}
-
Yuly Novikov authored
deqp/functional/gles3/shaderindexing/mat_00.html on Mac AMD BUG=751254 TBR=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I61f545a7f9af55b381affd55959a017c0f92c575 Reviewed-on: https://chromium-review.googlesource.com/596928 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#491197}
-
Wenzhao Zang authored
Login/lock screen related constants may be used from at least three places: views-based lock, WebUi based login/lock and wallpaper. So we want to move them together just as shelf_constants.h Bug: 732566, 733409 Change-Id: I791d5dfbd02f35cdcc6064b964b97b6978a376d2 Reviewed-on: https://chromium-review.googlesource.com/590483Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#491196}
-
Oleh Prypin authored
This is used for projects that rely on Chromium's build infrastructure after Chromium switched to C++14 https://chromium-review.googlesource.com/c/583635 Bug: 750683 Change-Id: Id673a2474a1b5c606ce17b1ce8e7faa4de0cb5b9 Reviewed-on: https://chromium-review.googlesource.com/596870Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491195}
-
Devlin Cronin authored
Migrate the system info API to use the new task scheduler API instead of using the worker pool. Note: also change the shutdown behavior to be SKIP_ON_SHUTDOWN, since there's no reason for it to be CONTINUE_ON_SHUTDOWN. Bug: 689520 Change-Id: I4c4fb9990123f6124948b12fc6cf580ec45c8da7 Reviewed-on: https://chromium-review.googlesource.com/591987Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491194}
-
Christopher Lam authored
This CL makes bookmark folders that are beneath the 2nd level of the hierarchy get hidden by default. They will then retain the open state after being explicitly opened or closed by the user. Bug: 727177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id53584e3c777a057e6a4f9536e0f1df01a242cd6 Reviewed-on: https://chromium-review.googlesource.com/583984 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#491193}
-
Dave Schuyler authored
This CL changes the <paper-icon-button> elements to <button> with is="paper-icon-button-light". Bug: 746584 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I045badb04115139ac3f624f9b6a57d161dafc55c Reviewed-on: https://chromium-review.googlesource.com/588012Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#491192}
-
Charles Harrison authored
This aligns the look more with the future Harmony UI. Additionally, this CL addds a .icon version of the "help-outline" svg image in chrome/browser/resources/settings/icons.html Bug: 736318 Change-Id: I41090a0ee5ed7e23490855213baf6b9d89b78629 Reviewed-on: https://chromium-review.googlesource.com/544199 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#491191}
-
Helen Li authored
system health mobile has been converted to wprgo. This CL removes the unused .wpr.sha1 files. Bug: 730036 Change-Id: Ib564dbfee91fa6c672882fff5ced8c54854d30ce Reviewed-on: https://chromium-review.googlesource.com/596708Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491190}
-
Nicholas Verne authored
In order to move WebFrameTest we allow gfx::ScrollOffset to be used from core/. Bug: 712963 Change-Id: I8234af1f7fed70947c278f759b710053034368d9 Reviewed-on: https://chromium-review.googlesource.com/595021 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#491189}
-
Shivani Sharma authored
Bug: 750725 Change-Id: I9a70b4fd03aec9a74bd76f3988442cd6e9f908d3 Reviewed-on: https://chromium-review.googlesource.com/596151 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491188}
-
Ulan Degenbaev authored
This is followup of 491087. BUG=chromium:730036 TBR=nednguyen@google.com NOTREECHECK=true Change-Id: I8cf4f1050073160b1c0e428e1f350f8bb9d0f0d5 Reviewed-on: https://chromium-review.googlesource.com/596871 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491187}
-
Helen Li authored
System health desktop has been migrated to wprgo. This CL is to remove the unused *.wpr.sha1 files. Bug: 730036 Change-Id: I8d8bb20f732c6c3fe18482847dcf5df1e2222720 Reviewed-on: https://chromium-review.googlesource.com/596707Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491186}
-
chrome://settingsTim Song authored
Screenshot: https://screenshot.googleplex.com/BV3uweR38fL.png See mocks at: https://docs.google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit#slide=id.g4af27b4ff_35243 BUG=748288 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6f8f0b92164d546c1670816a76d3289d648955f1 Reviewed-on: https://chromium-review.googlesource.com/582342Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#491185}
-
dpapad authored
Also removing jscomp_off=misplacedTypeAnnotation flag. It was originally introduced to work around a Closure compiler issue with cr.defineProperty(), but as of latest compiler version the issue has been fixed. Because of the flag's presence several other (unrelated to cr.defineProperty) invalid/misplaced type annotations appeared in the code. Bug: 421562 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id281ade4208149f6ea3bbcae8a99d28e0f282c9c Reviewed-on: https://chromium-review.googlesource.com/596834Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#491184}
-
zpeng authored
Our experiments show that Desugar, a Google-developed open-source tool, outperforms Retrolambda in both APK sizes and Java method counts. This CL replaces Retrolambda with Desugar in our experimental Java 8 support. BUG=730711 Review-Url: https://codereview.chromium.org/2985523002 Cr-Commit-Position: refs/heads/master@{#491183}
-
Scott Graham authored
c950cb0 Only disable export of libunwind symbols when libcpp is static CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_arm Bug: 750392, 593874 Change-Id: I420202d5c83663da56654009350206784c7f6bc5 Reviewed-on: https://chromium-review.googlesource.com/596668 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#491182}
-
Marti Wong authored
This CL is the followup fix for CL/569538/ which was reverted because it caused timeouts of egtests. This CL made some change on a egtest to prevent the timeout. Other than that, this CL is identical to CL/569538. [Patch set 1] is identical to CL/569538. [Patch set 2] added the fix to prevent egtest timeout. [Demo videos] - account with bookmarks: https://drive.google.com/open?id=0B1O0Z7eoZMuGeTBjVXdla0RPeFE - account with no bookmarks: https://drive.google.com/open?id=0B1O0Z7eoZMuGR0pGb2tYUHcyOWM TEST=Make sure it works when signed in user has no bookmarks or there is any sync error... Bug: 696893 Change-Id: I92af0f4a1c9f88f6595f8a851ff92f0b5215132b Reviewed-on: https://chromium-review.googlesource.com/587517 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#491181}
-
nick authored
Prior to this change, WebContentsTaskProvider would defer task creation if the PID was not known at RenderFrameCreated time. However, for a newly-cloned WebContents, no event ever occurred to re-create the Task once the process finished launching. This was bug 738169. Fix the problem by never deferring task_manager::Task creation; instead, create Tasks for all live, current RenderFrameHosts. If the PID is not known immediately, allow it to be set on the task at a later time (when RenderProcessHost::IsReady() becomes true). Because the TaskManagerImpl was written with the expectation that Tasks have a constant PID, PID mutation is implemented in terms of temporarily removing the task, mutating the PID, and re-adding it. In WebContentsTaskProvider, we no longer need to implement RenderProcessGone. In TaskGroup, don't waste time collecting stats for a null process ID. Tests are added exercising this bug, and its subframe equivalent. Test coverage is added for the PID==0 case, and we ensure that the "Memory" column is populated with something nonzero. BUG=738169 Review-Url: https://codereview.chromium.org/2961423002 Cr-Commit-Position: refs/heads/master@{#491180}
-
Erik Jensen authored
This is a reland of 26c8b12c BUG=751309 Original change's description: > Implement wait-for-logs functionality in user_session binary > > This ports the wait_for_logs method from the Python script, and forwards > the pipe write fd to the Python script. > > Change-Id: Ief54da136894cd13e0761b9755aa3c7d51fe17f8 > Reviewed-on: https://chromium-review.googlesource.com/594807 > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Erik Jensen <rkjnsn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491058} Change-Id: I9daf4957636a99b5179975cf1db33ba101bc179d Reviewed-on: https://chromium-review.googlesource.com/597087 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#491179}
-
Michael Giuffrida authored
This test creates its own TestBrowserContext, but it derives from ExtensionsTest, which also creates one. Making the test use the provided context instead of creating its own fixes the flake. The flake is fairly rare but becomes more frequent as we add new tests to app_shell_unittests. Read on for details on how this failure occurs, why it was flaky and why more tests make it fail more often. When run in combination with other tests, once in a while the new context happened to be created at the same address as a context used in a previous test, just by chance. The process-wide DependencyManager keeps track of the pointers to contexts that have already been shut down. ExtensionsTest is smart enough to register its own context as "live", so this flake doesn't normally happen, but this test didn't bother. A new context at an old address would be fine *if* the context was marked "live" again. When it isn't, accessing KeyedService with the new context will cause DependencyManager to identify it as a "dead" context (as seen in a previous test) and assert. If we really needed a separate TestBrowserContext, we could mark it live, but why bother? Bug: 750530 Change-Id: I094be7ea4c715a8316547fb2b9f06c081f963483 Reviewed-on: https://chromium-review.googlesource.com/592546 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#491178}
-
enne authored
This reverts commit e0faf622. Reason for revert: breaks debug compile Original change's description: > Validate rrects in PaintOpBuffer serialization > > Also, consolidate all PaintOp validation into new IsValid > functions. > > Bug: 749023, 750010 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I1f5b695fe71c50d5ae126937c15a8957285a5487 > Reviewed-on: https://chromium-review.googlesource.com/590749 > Reviewed-by: Vladimir Levin <vmpstr@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#491171} TBR=vmpstr@chromium.org,enne@chromium.org,khushalsagar@chromium.org Change-Id: I1dac9ee740450c29bd0a25f3923e0f047cda8250 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 749023, 750010 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/597070Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#491177}
-
Bence Béky authored
Change NetLogSpdyStreamErrorCallback() to stringify error. Example netlog output before this change: HTTP2_STREAM_ERROR --> description = "SPDY stream closed with error_code: 2" --> status = -337 --> stream_id = 59 After this change: HTTP2_STREAM_ERROR --> description = "SPDY stream closed with error_code: 2" --> error = SPDY_PROTOCOL_ERROR --> stream_id = 59 Change-Id: If58ad76f3b99dde7f22e8bf81c2251f6fba9d2e3 Reviewed-on: https://chromium-review.googlesource.com/594192 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491176}
-
Collin Baker authored
Implements PageRenovator which is responsible for picking renovations, injecting them into a page, and notifying the user of script completion. Design doc: https://docs.google.com/document/d/1WuwRJaxBKAwVpeAHG0xhq5uRxMTB-j4LFleT4QEqANU Bug: 736933 Change-Id: Icbd8b494d75298ed355f9666971ecf918b441d2e Reviewed-on: https://chromium-review.googlesource.com/585907Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Collin Baker <collinbaker@google.com> Cr-Commit-Position: refs/heads/master@{#491175}
-
Ned Nguyen authored
[toosl/perf] Extend tools/perf/validate_wpr_archives to check for missing SHA filesin archive json file This fixes does: 1) Change tools/perf/validate_wpr_archives to also keep track of missing sha files 2) Always invoke tools/perf/validate_wpr_archives in tools/perf/PRESUBMIT.py. Doing this also require changing validate_wpr_archives slightly so that when options.wpr_sha_files is empty, the script won't check any archive file in cloud storage (before this, the logic is check ALL archive files in cloud storage if options.wpr_sha_files is empty). Bug: chromium:730036 Change-Id: Id12bb07c2abe47428235e859fdde9339100a1525 Reviewed-on: https://chromium-review.googlesource.com/596504Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#491174}
-