- 07 Jan, 2021 40 commits
-
-
Xi Han authored
We disable StartSurfaceTest#testShow_SingleAsHomepage_BackButton__Instant_Return on Android o bots. The original CL description is: In this CL, we introduce a new flag "keepTab" for a Tab with launch type FROM_START_SURFACE. When this kind of Tab is selected from the carousel Tab switcher on the Start surface, or from grid tab switcher, the "keepTab" is set to be true. This guarantees the tab won't be auto deleted from the TabModel when the back button is tapped. More details see doc: https://docs.google.com/document/d/1mZXgQ0fi_b96vcwy1DkgWunl0FutkFwyt-7PrU-Pgjc/edit# Bug: 1155139,1163874 Change-Id: I2b0944c45a0273548d2da91a3def4db5c17f57e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614798Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#841103}
-
Julie Jeongeun Kim authored
This CL fixes up the issue caused by [1]. [1] https://crrev.com/c/2569167 Bug: 1163898, 1008939 TBR: rbpotter@chromium.org Change-Id: Ibfb19bc8f9d59a31ecb32f164deba610b0a32744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614249 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#841102}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7c54d0e3efb6..ddb981175c35 2021-01-07 jacktfranklin@chromium.org Migrate component_docs/data_grid examples to TS files 2021-01-07 mathias@chromium.org Include .avif and .webp images in *.grd files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion for all files 2021-01-07 tvanderlippe@chromium.org Enable no-implicit-coercion in front_end/ 2021-01-07 tvanderlippe@chromium.org Fix remaining no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Disable another test to unblock the Chromium roll. 2021-01-07 patrick.brosset@microsoft.com Make sure rulers appear when needed 2021-01-07 tvanderlippe@chromium.org Fix no-implicit-coercion errors in front_end/ 2021-01-07 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2021-01-07 bmeurer@chromium.org [e2e] Temporarily disable test to unblock Chromium roll. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1082789,chromium:1144106,chromium:1159309,chromium:1161667,chromium:1161701 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I56f53f2ad0d050f7c2d9078ebf0f03a0332286e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614134Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841101}
-
Ben Pastene authored
crbug.com/968262 recently added sharding support to the Tast runner. This adds support to plumb down the shard parameters as specified from the chromium recipe down to the Tast runner. This also adds 2 shards to chrome_all_tast_tests across every builder to start with. Some bots could likely do with even more shards, but that'll be left for a follow-up. And remove a bit of copy-paste from tests. Bug: 968262 Change-Id: Ic3539a6f39c9daab4429b687e142565a8c98f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610963Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#841100}
-
Robbie Gibson authored
When smooth scrolling is enabled, the tab strip background is set to black to block out the web content behind the tab strip. However, the tab strip snapshot should always have a clear background because the web content is moved when using the snapshot. Ths CL overrides the background color of the tab strip to clear when taking the snapshot and resets it afterwards. Fixed: 1163919 Change-Id: I945183e10633442ccf4f49c05ef6ceae85f3af59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614786Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#841099}
-
Robbie Gibson authored
Bug: 1123048 Change-Id: Ie24d51180a741fecf06e03da908cfb6042de087f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614781Reviewed-by:
-
Peter Kasting authored
Bug: 1159562 Change-Id: If07c17aa6b0045f40b3942f7a70f819d32089dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614847 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#841097}
-
Francois Doray authored
This CL removes unused background tracing category presets so we don't have to unnecessarily maintain them. This reduces technical debt. Bug: 1157487 Change-Id: I3d2c2eda3fa2ea730cf0cac46936733ea5f19862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586105 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#841096}
-
Mingjing Zhang authored
Jank reporter now uses |vsync_interval| to determine the frame length increment threshold, instead of directly using the frame interval reported by the presentation feedback; the latter could be zero and cause erroneous jank reporting. Bug: 1154492 Change-Id: I616a77d85bf91436ebc0b6982a278c5763225993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569794 Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#841095}
-
Dave Tapuska authored
Move Unload to be a message on the FrameNavigationController. Messages on an associated mojo interface are dispatched against the main task runner so they aren't really frozen. So this method can move to be just a normal associated interface. The result of unload is dispatched to the AgentSchedulingGroupHost because we need to return the result and the FrameNavigationController is disconnected when RenderFrameImpl is destroyed so any callback on that won't be called. Other approaches were considered but deemed too difficult: 1) We can't simply Unbind() the FrameNavigationControl AssociatedReceiver since that doesn't work if there are already pending reply callbacks. 2) We can't use a unique_ptr to own the FrameNavigationControl AssociatedReceiver, since the AssociatedReceiver also needs to be paused. 3) Deferring deletion of the RenderFrameImpl would be undesirable (as the associated WebLocalFrame is already gone) 4) Reporting it through an interface passed to the Unload() method would add a non-trivial amount of complexity BUG=993189 Change-Id: I4f8a29c09b34596e2d5d8d2595a04306ccb1e569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580002 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#841094}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccaf6dbd5c6e..5ff758df67da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie41b560b5f3aca0ba1051557c68415274b8c75a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614840Reviewed-by:
-
Scott Violet authored
This makes TabRestore use the new backend code that results in a new file rather than truncating the existing file. BUG=648266 TEST=covered by tests Change-Id: I066b369ee039786cc416e275b7be1e22d5214dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611908 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841092}
-
btolsch authored
These histograms have been unused for a while and are expiring so this change removes them instead of extending their expiration. Bug: 1160737 Change-Id: I757a067e33d7172be10a80b011123fa17d4658a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613510Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#841091}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/BrzlGtpSjp8quKJlBN8pxLiY0XfrgeDpvKGKAovPBTIC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/174321021,b/175636948,b/176853210 Tbr: help-app@grotations.appspotmail.com Change-Id: Id2f5682dc771e68146b50aad8a999a211e1766e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614765Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841090}
-
Stephen McGruer authored
This is a reland of 3482d6ea (reverted in 672e131e), with the SVG changes backed out. Bug: 997202 Change-Id: Id1a63ce0c2fd63b288135de007aab30449508a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611982 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#841089}
-
Nicolas Ouellet-Payeur authored
In unit-tests, g_browser_process->profile_manager() can return null. When the DestroyProfileOnBrowserClose flag is enabled (via ScopedFeatureList, or fieldtrial_testing_config.json), ScopedProfileKeepAlive causes a crash. Add a guard in ScopedProfileKeepAlive(), so it's a no-op if there is no ProfileManager. Bug: 88586 Change-Id: Ife9f198da3d7dc69f8cf59bed80aca9c57517a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614859 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#841088}
-
Ulan Degenbaev authored
Bug: chromium:1085129 Change-Id: Ia0d1968c97542a7ed0455b61aaf2558e9c81272c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613024Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841087}
-
Annie Sullivan authored
Bug: 1141739 Change-Id: Ia8fd23a17e85c8da88c8384c9f6ef43ddb992b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614408Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841086}
-
Sam Maier authored
The existing errors are using protected visibility when they could be using package-private visibility. Bug: 1029038 Change-Id: Iec1da0fed876d2d2abc68414bdb7175aab02db95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602890Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#841085}
-
Trent Begin authored
Screenshots should not be checked in to the codebase since they are uploaded to a gs bucket when the .png.sha1 files are created. Bug: none Change-Id: Ic2a2eb53b294957f5836837222ecdc9b341510f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612099 Auto-Submit: Trent Begin <tbegin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#841084}
-
David Van Cleve authored
As part of rolling out the Trust Tokens config change to use a third-party origin trial instead of the current nonstandard origin trial configuration, we're moving the main experiment group to serve the all-operations-require-origin-trial parameter instead of only-issuance-requires-origin-trial. To make this experiment config change, we first need to update the field trial testing config to use the new parameter value. (This should be a no-op, since tests that care about this value currently set the parameter manually.) Bug: 1154714 Change-Id: Iefcc10d9abd93bf924d27a1d2910defc8d5015f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610993Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841083}
-
Xiaocheng Hu authored
Since we are not going to use CSSKeyframesMemoryReduction, this patch removes all of its implementation. Bug: 1141814 Change-Id: If531461761974d236e6456cd5745356e0caecf11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614839Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841082}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5ff758df67da..603d14ec2a26 2021-01-07 lalitm@google.com Merge "tp: stop using magic constants in tests" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2ddc2900e7f65e25a7ccb9ca86c5323c68ddd072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614769Reviewed-by:
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/Cleared are deprecated. So this cl changes these calls to OnPrimaryAccountChanged(). Bug: 1158855 Change-Id: Ia5fbd1ca486465badad539093f18e5cf98bdccc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611739 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Jan Wilken Dörrie authored
This change prepares the codebase to handle different types for base::char16 and UChar. This is done by introducing a new base/i18n/uchar.h header, providing casts between those two character types and using it where required. Bug: 911896 Change-Id: I2774dd0642bb94c2e00f07ed4cdc85680b229562 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599088Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Jesse Schettler authored
The histogram records the time between sending a request for scanners and receiving capabilities for the selected scanner (i.e. the time that passes before being able to perform a scan). Bug: 1059779 Change-Id: I8be9453945054848d1b534bf43ba29e2653731da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597656Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/875b30eb4cdf..d4e0f040446f 2021-01-07 morg@google.com Mark grunt-arc-r as non-experimental for PFQ 2021-01-07 lamontjones@chromium.org api: Update python bindings. 2021-01-07 isaaclee@google.com zork: add factory branch builder 2021-01-07 sbelmon@google.com licensing: add "tainted" signal 2021-01-06 tcwang@google.com toolchain_util: Add function to modify kernel afdo metadata 2021-01-06 jhorwich@google.com Remove unittests from grunt-arc64 builders 2021-01-06 kimjae@chromium.org xbuddy: Handle chromiumos_base_image.bin 2021-01-06 chrome-bot@chromium.org Update config settings by config-updater. 2021-01-06 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Id5831227ac12c7d02005ffa82a932974d8a4bec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614766Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f39e76846d7f..be0b3b7363a9 2021-01-07 brianosman@google.com Strip down SkSL::ExternalValues, limit them to functions If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC johnstiles@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: johnstiles@google.com Change-Id: Ibd7e11265ff4cb2d8d6699ec37254e6e68786d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614764Reviewed-by:
-
Alex Ilin authored
AutofillAssistantTriggerScriptIntegrationTest#dontShowOnboardingIfAcceptedInDifferentTab is failing on builder "android-pie-x86-rel". Bug: 1163913 Change-Id: I93af1fee346650a370b28810111cbce51e860918 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614782 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841075}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/c493c6112021..5820c040a91a 2021-01-07 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from aa005e8bd435 to ad77ed7a8d52 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: Ia1b761c7fc44cb39e69ee70be8ddd170cf89fbef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614761Reviewed-by:
-
Brian Ho authored
When SkiaRenderer is enabled on Chrome OS, we see a spike of crash reports [1] in SkiaOutputDeviceBufferQueue from |current_image| and |submitted_image| both being null [2]. One way this can manifest is when an overlay promoted via the fullscreen strategy becomes unpromoted without any change in damage (e.g. through a test page flip failing). At a high level, the order of operations for rendering a frame in SkiaOutputDeviceBufferQueue is: BeginPaint/EndPaint -> SchedulePrimaryPlane -> PostSubBuffer. If the only quad displayed is promoted to a fullscreen overlay, |PostSubBuffer| will clear both |submitted_image_| and |current_image_| [3]. Normally, the next frame will invoke |BeginPaint| which in turn sets a new |current_image_| [4], but if there's no damage, this won't get called. As a result, in |SchedulePrimaryPlane|, Chrome crashes. This CL fixes this error by disabling the fullscreen overlay strategy when SkiaRenderer is enabled. Since this crash is difficut to repro deterministically, this is just a quick fix to see if the fullscreen strategy is actually the culprit we see in canary/dev. I expect to implement a full fix later. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1156182 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=209;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=343;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 [4] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display_embedder/skia_output_device_buffer_queue.cc;l=514;drc=cb3ff30296f61e6f66de70fa33bd9f5169a1ff88 Bug: 1156182 Change-Id: I3db7cf64cae0f5adadba160defb4c3353ef4a6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613685Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Brian Ho <hob@chromium.org> Cr-Commit-Position: refs/heads/master@{#841073}
-
Philip Rogers authored
This has fully launched and the experiment can be removed. Bug: 1079418 Change-Id: Ic06e85939829cce8ecf80fb0692b0b0d5e0595ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613129Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#841072}
-
Justin Cohen authored
There is some speculation that local state is not persisting properly in some cases. Add a histogram to also set the value in NSUserDefaults and to compare those two values. Bug: 1161529 Change-Id: I67f4caf8060f037151dcc6653825ec17b556dee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611966Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#841071}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/61a89564cea2..ac4d756a6626 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC clamy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: clamy@google.com Change-Id: Id0507e9b1a58eaaf83af42d2639af62ecbdf28ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614762Reviewed-by:
-
Rune Lillesveen authored
Fix lint failure. Change-Id: I89aa665a7d6b375abd8cba0a2768cb6be767d8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614818Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#841069}
-
Joey Arhar authored
Clusterfuzz found an interesting case where if a match is disconnected from the document, and there is another display locked element in the document, and the match is in shadowdom, an enclosing block for the match cannot be created because the tree has no layout objects. Fixed: 1160283 Change-Id: I1a2c9003b99d2dbe20344bd39b629c7427f11da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613952Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#841068}
-
Wenyu Fu authored
Remove HomepagePromoController and related flags & resources. Change-Id: I5f7183c8d93eded7cf9cb0ebbe10c32f0f70208e Bug: 1162522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613384Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841067}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101070600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/mqExY_CKGV64CkBK6pxd74QrlY0Ui90tdf5wIZPeB38C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540 Tbr: media-app@grotations.appspotmail.com Change-Id: Ic990ccda8d305951aa0089868c18f94dc848dacf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614763Reviewed-by:
-
David Jean authored
Another step towards ios12 deprecation. Bug: 1086521 Change-Id: I0bae084d19ee0f4673e59791a91c02d47823ff9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610093Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841065}
-
Owen Min authored
The profile list returned by the GetAllProfilesAttributes() is not sorted in any particular order and might be different in different test runs. Update the test case to make sure this can be handled. Bug: 1153593 Change-Id: Idf6b9c5f720a8285112dc17c1da7b31ddbd7978d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612526Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#841064}
-
