- 17 Aug, 2020 40 commits
-
-
Weilun Shi authored
Remove BUILD dependencies for merge_xml action and list all xmls that need to be merged in merge_xml.py instead because listing them in the sources is too verbose as we split up smaller xmls. Bug: 1116096 Change-Id: I1ba1e09feece3442a673d4ba41868f36e1135298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359231 Auto-Submit: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#798647}
-
Chris Sharp authored
"can only" was repeated twice. Change-Id: I9acf582750dc2f01d700f2c9bacb26c95376df4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358584Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#798646}
-
kylechar authored
There is a recurring issue where bugs in browser process code introduce deserialization errors on the main viz browser-to-GPU process message pipe. The message pipe is closed and the GPU process crashes trying to reinitialize the viz thread. Without a way to differentiate message pipe closure due to a deserialization error vs the other side closing it, the crash only happens when the browser tries to reinitialize the viz thread after what it thinks is a GPU crash. There is a very little information available in these crash reports, the message pipe is shared by multiple interfaces and figuring out what IPC message the error occurred in is a guessing game. There is a global error handler that triggers for any mojo deserialization errors which includes a string containing the interface name and a message identifier. This CL adds a handler which stores the error string. If the GPU process crashes due to reinitializing the viz thread within 5 seconds after the handler fired, it populates a crash key with that error message. While it's not guaranteed the last deserialization error was what caused the viz thread to get reinitialized, deserialization errors are infrequent enough it shouldn't be an issue. Bug: 1075495 Change-Id: I3a762fd5e9d50c0c1c301b3179f08ce892ff4912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356546 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#798645}
-
Rushan Suleymanov authored
After current CL SharingMessage data type will stop on any persistent auth error from the server. Previously, it would only stop on one specific type of error (web signout). Bug: 1097054 Change-Id: I917b20343b457e513004e5ad112bf6d42d0f42dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352743Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#798644}
-
Gayane Petrosyan authored
This is a reland of d43884e1 Fix memory leak issue by cleaning selection_range member in TextFragmentSelectorGenerator on DocumentDetached. Reverted version is in patchset 1. Original change's description: > [SH-Blink] Create TextFragmentSelectorGenerator with page. > > Create TextFragmentSelectorGenerator with page and set selection > information when context menu is shown. > This is done so that Java code can just call the GenerateSelector > function without any arguments and generation can happen for the latest > selected text. > > Follow-up CL > https://chromium-review.googlesource.com/c/chromium/src/+/2341662 > will connect to browser-side component. > > Bug: 1102382 > Change-Id: I5574f5b40e5a74bef56698e2de5a9b1fea17e0d0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340734 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797256} Bug: 1102382 Change-Id: If05b8e643627f4851dced45ce02cd78b7fa87fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354304Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#798643}
-
Naomi Musgrave authored
chrome/services/sharing/* - Introduced StopAllEndpoints to clean up all connections to remote endpoints chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of StopAllEndpoints. NearbyConnectionsManager uses StopAllEndpoints to clean up when shutdown is requested, or when the nearby process is stopped. Bug: 1076008 Change-Id: Ie5cc7dedf2accad91774217be87d9e5218116594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346673 Auto-Submit: Naomi Musgrave <nmusgrave@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798642}
-
Alice Wang authored
This CL adds a render test for the sign-in in progress screen in the web sign-in bottom sheet. Bug: 1090356 Change-Id: Ice77509c68b54c1090351ed7962850f98bdbdb50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356025Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798641}
-
Alice Wang authored
Change-Id: I26f79c147be2dcde083ac4f5be88267ccd2e236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359135Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#798640}
-
Gyuyoung Kim authored
This CL is to fix the regressions caused by r785154. r785154 has been causing two regressions. One is the context menu is opened at the wrong place once right click is used inside emulation window. The other one is a crash happens when performing a right click on 'Color selector' overlay in emulation view. The first regression caused by r785154 missed clearing |host_context_menu_location_| unlike the original behavior. So, it made RenderFrameImpl::ShowContextMenu() calculate the position of the context menu with |host_context_menu_location| instead of the current window position unlike the original behavior. And, the second regresion was caused by RenderWidgetHostImpl::ShowContextMenuAtPoint calls ShowContextMenu() through the Mojo message without checking if |blink_frame_widget_| is bound. This CL fixes those regressions. Bug: 1093960, 1113088, 1115440 Change-Id: I94c3c385caeacda5561d30e6fd7ced6e86d69201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354128Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#798639}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4245f475be7..866d2894ebd1 2020-08-17 djsollen@google.com Add android:exported values to all SkQP activities. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: stani@google.com Test: Test: successful install on device with AOSP build Change-Id: If67de613d99804be7f30f622b145844b07759b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798638}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I2125c7072fcc9295749ff04f514e1b13d8754143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355905Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798637}
-
Wez authored
This is a re-land with sanity-checks of the kill() outcome removed, so we can address the effects of process leaks separately from introducing leak-checking. Under Windows and Fuchsia the TestLauncher runs test batch processes in their own jobs, allowing any leaked sub-processes leaked by tests to be cleaned up. Under POSIX platforms each batch is run in its own process group, but the group was only being kill()ed if the test batch failed or crashed. TestLauncher now proactively kill()s each test batch's process group. Note that this will still miss processes launched into new process groups by tests. Bug: 1094369 Change-Id: I0880f08bd120fc5dd057a54efc3db63173feeca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359136 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#798636}
-
Friedrich Horschig authored
With this CL, the edit fragment retrieves the compromised credential from the start argument and fills them into the form. It also ensures that temporary destruction of the fragment keeps the password and the credential data. Screenshot in the bug. Bug: 1114720, 1092444 Change-Id: I8a0fe9a47f56b0af38465babd29c93afd8f669b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352901 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#798635}
-
Ewann authored
This CL removes ChromeGuard. Bug: 1063824 Change-Id: Iad1224482534ff7a0f04116852dbebcabf27adce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346806 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#798634}
-
Sundoo Kim authored
Explicitly remove the copy constructor and assignment operator with the delete keyword. R=atotic@chromium.org, svillar@chromium.org Bug: 1010217 Change-Id: I12a768919d9b5d5e4e9884a527296b2f7ad44b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358711Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#798633}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I223619ed17fccf52313810177e79761569ba8459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353169 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798632}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4bddba41. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I88dfc7319d5256c7c2f373c23ad005e9786e1e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358582Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798631}
-
Thiabaud Engelbrecht authored
This CL adds a way for ClientDiscardableSharedMemoryManager to discard unlocked discardable memory locally. To achieve this, it keeps track of all locked and unlocked, unpurged instances. These are then purged all at once when ReleaseFreeMemory() is called. This is guarded by a new feature which is disabled by default, and as such there is no behaviour change by default. Bug: 1109209 Change-Id: I7755d714ff354e831557627fda401751384392b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321400 Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#798630}
-
Vladimir Levin authored
This patch adds the capability to deliver notification synchronously in the post-layout stage. It uses this for the 'auto' content visibility case. During the notification, if this is the first time we have a notification, then it is done synchronously. Furthermore, if the notification causes a locked-ness change, then we request that the layout stage is re-run (to ensure that visible things are immediately visible. R=szager@chromium.org, chrishtr@chromium.org Change-Id: I59c94590a5dd0ec2398a06f3f03212a80b581fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348415Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798629}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bff6472b..0c2650ad Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I624177f3c764aa2b2075ba4a698b9b5a9cd33f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358583Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798628}
-
Tina Wang authored
Previously when passing nil to secondaryAttributedString while initiating a PopoverLabelViewController, the popover will show a large blank area under the primary message. That's because a blank secondary TextView has occupied the space. Fixed the issue by only create secondary TextView when secondaryAttributedString has a value. Bug: 1115925 Change-Id: Ic01ae94037aaae14b76194aca439b3677682b921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354519 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#798627}
-
Peter Kasting authored
* Inline temps * Combine conditions * Use min/max more * VideoPlaybackRoughnessReporter::kDesiredWindowDuration isn't needed Bug: none Change-Id: Ifbe23075f035df50e6bec4299802b6832c15d96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359000 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#798626}
-
sczs authored
When setting a new DiscoverFeedVC calling reloadData would sometimes not actually reload the Feed. Taking a look at a similar method I realized that there's a bug and workaround for that, which I added to our DiscoverFeedVC setter Here's where the workaround is also being used: https://source.chromium.org/chromium/chromium/src/+/master:ios/chrome/browser/ui/content_suggestions/content_suggestions_mediator.mm;l=504 Bug: 1085419 Change-Id: I9cf39edfe9da9006dc0b26bf1b27bb0f8c41d255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355439Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798625}
-
Anastasiia N authored
Remove "if defined(OS_CHROMEOS)" when setting default token_value in SetRefreshTokenForAccount in identity_test_utils. UserPolicySigninServiceTest was calling IssueOAuthToken with "refresh_token_for_" + gaia_id value because they expect the refresh token to have this value by default. Fix this test by calling SetRefreshTokenForAccount with custom token value and using the same token to issue OAuth token. Bug: 1115075 Change-Id: I92ca73b25b87131b9fb02dbae8bbea8a5707adb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353333Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#798624}
-
Adithya Srinivasan authored
This is a reland of d7f6a170. The only change since the reland was to disable some tests on android as they test code paths that won't be hit on android. Original change's description: > Portals: Make breakpoints inside portalactivate event handlers work > > Currently, we reset the DevTools session before portal activation and > create a new session with the activated portal's WebContents. We dispatch > the portalactivate event and run any event handlers in the interim while > there are no agents active, and as a result, existing breakpoints do not > work. > > This CL waits for DevTools to point at the portal WebContents before > actually swapping the WebContents, thus making sure that the > portalactivate is dispatched after the main target has been reattached. > > Bug: 1025761 > Change-Id: I930d5f7ec361cd594c60bcece0bd9450a94994e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295080 > Reviewed-by: Peter Boström <pbos@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Lucas Gadani <lfg@chromium.org> > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797727} Bug: 1025761 Change-Id: I16edcfe85f83fee5aee31624cbdc2c8a0a150a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355552 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#798623}
-
Rouslan Solomakhin authored
This patch adds a browser test for ignoring non-TWA payment apps when running inside of a TWA that provides app store payment capability to Chrome. The test is for Chrome OS only, which is using the cross-platform Android payment app factory. When this factory is ported to Android, then the same test will work on Android as well. Bug: 1061503 Change-Id: I8f366c0feca7604000e8efc5e47d57047ab68a37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347400 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#798622}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2137e8afdcc7..c2bd4cfa7063 2020-08-17 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-17 jobay@google.com [e2e] Fix flaky test If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1112692 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I50404da2db7ea1733628510caf87101afa9a6d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358402Reviewed-by:
-
Marc Treib authored
Bug: 1034915 Change-Id: I6fec4c0b51df3e3fc7e62c2ce1c5ac277584919d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359138Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#798620}
-
Andreas Papacharalampous authored
kUsePreferred likes to ignore text wrapping, making this view really long because of the long text present. along with this, the text was re-aligned to be even with the checkbox. Bug: 1071831 Change-Id: I40de122e40149de878794ea0c0a7409a1f858078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359732Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#798619}
-
Ioana Pandele authored
Bug: 1102025,1092444 Change-Id: Ic703c3b3cb730d7ce1d27507f9d1fb2232a9e60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353257 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Maksim Sisov authored
Atm, this class is X11 only. We need to make that work with Ozone/X11/Wayland in the future. Bug: 1085700 Change-Id: I69d7d7128c3fb4b18cbfd8890dc4a1c8e85b1ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352928 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#798617}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597574780-11032f77f0853e1d71f33728c0242d630bf5af1f.profdata to chrome-mac-master-1597665194-0d53ac1a851921d9b7ac1e88ae497b998bf9af0d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ifb344b72f63b727ea74c562127fc08590eaab83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358404Reviewed-by:
-
Michael Tang authored
Change-Id: I021f64713a2b19b9e40f5ddab7258a3fc97fd88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357454Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#798615}
-
Noel Gordon authored
Change the fileManagerPrivate API to use FileEntry, like all other API in that API group. Move the Blob handling code lower down into the file_manager_private_custom_bindings.js code. Since Blob reading could fail, use an errorUUID to represent the invalid blob and make the C++ generate a chrome.runtime.lastError when the errorUUID is seen. Attach the actual DOMError to that lastError in the return code in the custom bindings JS (to aid debugging). Update the apitest JS to use FileEntry instead of Blob. Update apitest C++ to copy more testing files to the "testing" volume. Add new files_manager test resource "empty.txt", which has no content, to apitest the "empty Blob" case. Bug: 1114622 Change-Id: Ie69c012ec23fac847ea19bbfcc09ad9b23c13c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359872Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#798614}
-
Samuel Huang authored
This CL adds adjustment to /build/config/compiler/BUILD.gn, to exclude ldflags += [ "-Wl,--no-call-graph-profile-sort" ] for WASM. The flag usage was added in http://crrev.com/c/2332591, but it's not yet supported by wasm-ld. Change-Id: I04b1e81569e23f6a0b6f44b5e5544e30a3b0433d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359401 Auto-Submit: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#798613}
-
Chris Sharp authored
Change-Id: Idb5111fb165d139be00cb26aab5f53154d5f3151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356186 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This change should not affect any behavior. This CL moves the change password code out of the coordinator. This keeps the coordinator clean from any logic and helper code so that it remains focused on assembling the component and forwarding events. Bug: 1092444 Change-Id: I2e380cf06403cfe91c39e02e9a65cc3352a44aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352920 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#798611}
-
Javier Ernesto Flores Robles authored
Adds ReauthenticationEvent for tracking reauth events. Logs ManualFallback reauth events. Bug: 1113120 Change-Id: Ia96dfabdbca40610a11f8467746b617f7c67e387 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346437 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798610}
-
Ewann authored
This Cl moves the implementation of the RecentTabsMenuProvider protocol in a separate helper. This helper is used to create context menu from the recent tabs and the tab grid coordinator. Bug: 1093302 Change-Id: I7c78adc6eded30f749b9a2dec8d159306452588a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351974Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#798609}
-
Naoki Fukino authored
This allows users to: - focus file-type filter buttons by TAB key. - toggle state of focused buttons by ENTER or SPACE keys. To do this, we use <button> element instead of default <div> and style them per the design, with html{.pointer-active,.focus-outline-visible} style to control <button> state activations and keyboard focus rings. And since <button> has in-built ARIA support, that comes for free too. Bug: 1114721 Test: Manual test with flag #files-filters-in-recents. Change-Id: Ib709f79d24ab8c3a41aabdae2be4cb237c1fad5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358947 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
