- 01 Aug, 2018 40 commits
-
-
Mounir Lamouri authored
This allows the submitter to update the LocalSurfaceId (by modifying the child component) before submitting a new frame. The SurfaceLayerBridge will be notified of the change and update its internal surface id. Bug: 868008 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee17f20c753cc236b9ccce5d5bdfe05fb655b08e Reviewed-on: https://chromium-review.googlesource.com/1157882Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#579812}
-
Ovidio Henriquez authored
This change updates the BrowserTestNonsecureURLRequest set up code to use a URLLoaderInterceptor to handle URL requests. Using URLLoaderInterceptor enables the test to work properly when using Network Service code. Bug: 778860 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I5898b166967bd8d54608b78444c0aa7c99429df5 Reviewed-on: https://chromium-review.googlesource.com/1150826 Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579811}
-
Christopher Thompson authored
This CL enables the previous HTTP-Bad condition "WarningAndDangerousOnFormEdit" by default, which shows a warning on all http:// pages and a dangerous warning if a form field is edited. This also updates security state tests accordingly. Bug: 868575 Change-Id: I6ec68a756b40e5cc312dc15e0df477891e85287a Reviewed-on: https://chromium-review.googlesource.com/1153828Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#579810}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/68afb50705f8..226b95461af2 git log 68afb50705f8..226b95461af2 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 perezju@chromium.org [telemetry] Remove android_platform_backend.IsAppRunning Created with: gclient setdep -r src/third_party/catapult@226b95461af2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:869573 TBR=sullivan@chromium.org Change-Id: I1522430003ba65bb5b8a8755d6fd19d067b45467 Reviewed-on: https://chromium-review.googlesource.com/1158326Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579809}
-
Ross McIlroy authored
Use As<Boolean>/<Integer>/<Number> instead of deprecated Value::BooleanValue/IntegerValue/ NumberValue. BUG=v8:7786 Change-Id: I4123b5e135b58d3b6a88da6eec3fa8634dd06b5c Reviewed-on: https://chromium-review.googlesource.com/1158406 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#579808}
-
Reilly Grant authored
This change ports ExternalPolicyDataFetcher from net::URLFetcher to SimpleURLLoader. Bug: 844951 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I4ec5dcc5904f3bb1f35ec5c8ba8c30865d5cc126 Reviewed-on: https://chromium-review.googlesource.com/1139229Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#579807}
-
Rune Lillesveen authored
Instead of doing this call inside RebuildChildrenLayoutTrees, wait until we have finished all pseudo element children as well. This is done in preparation for ::first-letter update changes and split out from [1]. The other call-site for RebuildChildrenLayoutTrees, ShadowRoot::RebuildLayoutTree, already cleared this flag afterwards. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1155591 Bug: 847218 Change-Id: I72816c5249bcb863fab906ffef90c026619d8165 Reviewed-on: https://chromium-review.googlesource.com/1156387Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579806}
-
Mark Cogan authored
This CL fixes the flash of grid visibility under the grid toolbars that happens during the grid transitions. The fix has two parts. The first is to fade the grid toolbar backgrounds to black (masking out the other grid cells) instead of fading them to alpha zero. The toolbar controls still fade out, however. The second part is to move the expanding tab in the view hierarchy so that it sits on top of the tab grid, while the rest of the animating cells are inserted inside it. The API for this is somewhat clumsy at this stage; the animation class (itself a UIView) exposes the animating cell as a property, and the animator reparents it to be above the presenting view during the animation. Bug: 865454 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9ced094dfc053233f0dcbb5adb856639528c5daa Reviewed-on: https://chromium-review.googlesource.com/1154974 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579805}
-
Ramin Halavati authored
Removes rhalavati@ from clang_update watch lists. Change-Id: Icf5b347249ce10faef5c4c40f971b8403bc20462 Reviewed-on: https://chromium-review.googlesource.com/1158690Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#579804}
-
Mitsuru Oshima authored
See bug for details. Bug: b/74845106 Test: manual. Change-Id: I079ab633524e8cbee7ff19abe1202a43b8b7edfe Reviewed-on: https://chromium-review.googlesource.com/1156864Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#579803}
-
John Chen authored
Chromium snapshots before revision 579575 are still archived using the old directory name. TBR=crouleau@chromium.org Change-Id: I4cc1e9ca51af9f8f21e22214af2110a6d8be8fe7 Reviewed-on: https://chromium-review.googlesource.com/1158709Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579802}
-
Christos Froussios authored
This reverts commit 9971f557. Reason for revert: Findit identified this as the culprit of crbug.com/869868 It breaks webexposed/global-interface-listing-shared-worker.html on Linux and Mac Original change's description: > [blink] Add a time limit to message processing in MessagePort > > In addition to existing limit of 200 messages in a single task also > limit it to 10 milliseconds to avoid starvation. > > This logic will be removed when message-per-task mojo dispatching > will be implemented. > > BUG=867133 > R=mek@chromium.org > > Change-Id: I397d60d06e62507e8a322ee9e68be36093fefa57 > Reviewed-on: https://chromium-review.googlesource.com/1152815 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579751} TBR=mek@chromium.org,altimin@chromium.org Change-Id: Id7f61009e4e944ec675d5ff9aa44b713dbfe902e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 867133, 869868 Reviewed-on: https://chromium-review.googlesource.com/1158745Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579801}
-
Hans Wennborg authored
It was bumped in LLVM r338537. R=thakis,rnk Bug: 869850 Change-Id: Ida95943088bdf8921b5974e7e80a80e2739db01b Reviewed-on: https://chromium-review.googlesource.com/1158580Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579800}
-
Christos Froussios authored
It is flaky. TBR=kenrb@chromium.org Bug: 869758 Change-Id: I6ac4db8ae505c3b40a3b3ce486833b82a0737ad9 Reviewed-on: https://chromium-review.googlesource.com/1158583Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579799}
-
Saman Sami authored
Video capture doesn't work on Android WebView, so don't instantiate video_consumer_ in PageHandler Bug: 813929, 865430 Change-Id: I09ecce34f1f2a50d23fc12e0907a0d27bf3bc9d8 Reviewed-on: https://chromium-review.googlesource.com/1157206 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#579798}
-
Bence Béky authored
Use CompletionOnceCallback in GenerateAuthToken() and related methods: GenerateAuthTokenImpl() and MaybeGenerateAuthToken(). Bug: 807724 Change-Id: I96b54b5fd0cf9068bb08a539a8e7725c6e71f4f0 Reviewed-on: https://chromium-review.googlesource.com/1154348 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#579797}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f4bf7fc35d83..fd98c2c87164 git log f4bf7fc35d83..fd98c2c87164 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 bsalomon@google.com Make some GrSurfaceProxy and GrTextureProxy methods easier to access Created with: gclient setdep -r src/third_party/skia@fd98c2c87164 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I0400e4ce33e0b866efd7e4035407cdbee6e109ab Reviewed-on: https://chromium-review.googlesource.com/1158346Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579796}
-
Yuqian Li authored
For https://skia-review.googlesource.com/c/skia/+/144412 Change-Id: I9c1f983bb7020a3335bf58739cdaf343a7f983db Reviewed-on: https://chromium-review.googlesource.com/1157516Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#579795}
-
Lan Wei authored
The below CL causes Mac10.12 bot fail on some content_unittests, some values were not set correctly, I made some changes to the unittest. https://chromium-review.googlesource.com/c/chromium/src/+/1136721 luci.chromium.try:mac_chromium_10.12_rel_ng TBR=tdresser@chromium.org,nzolghadr@chromium.org,meacer@chromium.org, lanwei@chromium.org Bug: 854354 Change-Id: I4a9b540b2951be4a1147e9f99088256b833fde2d Reviewed-on: https://chromium-review.googlesource.com/1157426 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#579794}
-
Gauthier Ambard authored
This CL adjusts the toolbar height in fullscreen. It also adjusts the vertical position of the location bar, in fullscreen and outside of fullscreen. This is needed to have something which looks visually balanced. Bug: 868901, 865820 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ib8da381737b4660554a5fb68a213b99860f117d0 Reviewed-on: https://chromium-review.googlesource.com/1156602 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579793}
-
stkhapugin@chromium.org authored
Disable URL clipping in the omnibox on iOS 12. The omnibox will just show an ellipsis in the end if the URL is too long. This only affects pre-UI Refresh and is considered a temporary workaround. Bug: 860790 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I879c24f8ba7602a9b7bb5816529d330b3e840b2c Reviewed-on: https://chromium-review.googlesource.com/1158566Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579792}
-
Aldo Culquicondor authored
Bug: 767282 Change-Id: Ie0a3951f454f8ee1d8df36d770b758d06d9a6826 Reviewed-on: https://chromium-review.googlesource.com/1157269Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#579791}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/313502391288..ebafd75a0c5d git log 313502391288..ebafd75a0c5d --date=short --no-merges --format='%ad %ae %s' 2018-08-01 treehugger-gerrit@google.com Merge "Simplify ftrace architecture and integration with traced_probes" 2018-08-01 primiano@google.com Simplify ftrace architecture and integration with traced_probes Created with: gclient setdep -r src/third_party/perfetto@ebafd75a0c5d The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If42114a00fd4d27c57c382c2d2e99001315814bb Reviewed-on: https://chromium-review.googlesource.com/1158325 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579790}
-
Christos Froussios authored
It is flaking. TBR=sky@chromium.org Bug: 869830 Change-Id: Id455349e683f1adda690457faffc40d12c977d38 Reviewed-on: https://chromium-review.googlesource.com/1158584Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579789}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c1e3354d..0d97057a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb7773a8be6418d9cdc073223cd039d609228dac Reviewed-on: https://chromium-review.googlesource.com/1158390Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579788}
-
Takuto Ikuta authored
This is to take stats of cache hit rate on swarming test execution. I will record stats to the issue few days later. I changed dummy value due to some test failure. Bug: 869348 Change-Id: Ied830d0e783065e3aad48f066ad6b471b735fe00 Reviewed-on: https://chromium-review.googlesource.com/1157737Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#579787}
-
Michael Lippautz authored
We can avoid draining the full marking worklist again by visiting them before initially draining the worklist. This also preserves the invariant the the epilogue should not find any new objects. Bug: chromium:843903 Change-Id: I178d7b564ad9aaf5a086183dad83adfcb5c7d5a1 Reviewed-on: https://chromium-review.googlesource.com/1158412Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579786}
-
Dominik Röttsches authored
Preparation for hooking up @font-face { src: local() } matching in Blink. For now adding an implementation that extracts full font name and postscript name from fonts given a set of directories to scan. Includes unit tests for basic functionality, compatibility with TrueType collections and for resilience against corrupted font files. For the general design see https://crbug.com/828317. Bug: 867877 Change-Id: I5f557d99a5be49671bd9aa13c1712b6f8a2aa96b Reviewed-on: https://chromium-review.googlesource.com/1151348Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#579785}
-
Bence Béky authored
I introduced some test expectations in https://crrev.com/c/1145129 which I believe might be unnecessarily strict. In particular, Net.ConnectionInfo.MainFrame and Net.ConnectionInfo.SubResource might be recorded in OnReceivedResponse() for favicon but RecordLoadHistograms() not called yet by the time test execution arrives to the expectations. This CL relaxes some expectations to prevent these tests from becoming flaky. Bug: 859546 Change-Id: Idbacc7d024176406c5eb1a4be6d190e168a7d432 Reviewed-on: https://chromium-review.googlesource.com/1156848Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579784}
-
Marc Treib authored
Without this change, there is a race condition where it's possible that an auth token gets requested from the native side (via OAuth2TokenServiceDelegateAndroid) for an account that was actually already removed, which causes an exception in FakeAccountManagerDelegate.getAccountHolder. https://crrev.com/c/1148392 uncovered this, but I believe the race condition is there independent of that CL (it's just much less likely to get triggered). Bug: 856179 Change-Id: I23bdf54aba90b1bbfd64f45963ea32d08b63c852 Reviewed-on: https://chromium-review.googlesource.com/1156688 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579783}
-
Maksim Sisov authored
Ensure that a native widget gets a destroying call to ensure a right destruction order and SiteProcessCountTracker can eventually decrement process count. Otherwise, a DCHECK in dtor of SiteProcessCountTracker is called. TEST: ./out/OzoneLinux/views_unittests --ozone-platform=wayland --gtest_filter=DesktopWindowTreeHostPlatformTest.CallOnNativeWidgetDestroying Change-Id: I82f39a8e9673b9737215cf85e7810dbb0af78ceb Reviewed-on: https://chromium-review.googlesource.com/1154530 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#579782}
-
Christos Froussios authored
It is flaky Bug: 869829 No-try: True No-presubmit: True Change-Id: I9f49e4c6c7d3457e967e964ee1f8e5e36402a258 Reviewed-on: https://chromium-review.googlesource.com/1158624Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579781}
-
Rayan Kanso authored
Change-Id: I81a0ce6ebb664ec993028f561729051884924a26 Reviewed-on: https://chromium-review.googlesource.com/1152948 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#579780}
-
Mathieu Perreault authored
Creates a new payments_section.html/js (credit cards for now). With Autofill Home disabled, will add a new row in the Advanced Passwords and Forms section to go to the credit cards section. There used to be one general Autofill row that had both addresses and credit cards. With Autofill Home enabled, the "Payments" row on the People page will now lead to a payments-only section, and the "Addresses" row will lead to its own section as well. This is one change of several that will also clean up the settings toggle to hopefully have a clearer story. Screenshots of the change: https://goo.gl/iZWkCE (internal) Bug: 860526 Test: browser_tests Change-Id: I7572ccc71633ee806b4a5db522a64e2b4f79d5dc Reviewed-on: https://chromium-review.googlesource.com/1152475 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#579779}
-
Oscar Johansson authored
When buidling using jumbo, files gets merged and functions with the same name may end up in the same namespace and conflict. This happens for the function IsCreditCardExporationType in: components/autofill/core/browser/form_structure.cc components/autofill/core/browser/autofill_manager.cc Since the functions are identical they are moved to a shared util file. Since the function needs components/autofill/core/browser/field_types.h it cannot be moved to components/autofill/core/common. Bug: 869381 Change-Id: I69492fbc8af0ed9289504cb6aba3e745acb17b24 Reviewed-on: https://chromium-review.googlesource.com/1158364 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#579778}
-
Vadym Doroshenko authored
PasswordFormManager fills multiple times on different events from the Renderer. That's not optimal from performance point of view, but it adds robustness. This CL implements the same behaviour in NewPasswordFormManager as in PasswordFormManager: to fill till 5 times. This is quick fix, that will be merged in M-69. The better more robust filling is more complicated and will be implemented later. Bug: 868948, 831123 Change-Id: I44c93c5358b0e6707c545001f5f1a1fb7b60eec3 Reviewed-on: https://chromium-review.googlesource.com/1155116 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579777}
-
Marc Treib authored
Setting the prefs has no immediate effect - they're only read during sync startup (and after that, there are many situations where the values are overwritten). https://crrev.com/c/1148392 exposed this as an actual problem; before that, things just happened to work out. Bug: 856179 Change-Id: I24a3c8a22c87a128238efb5d0b9dd2ef8a022c71 Reviewed-on: https://chromium-review.googlesource.com/1156600Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#579776}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d4906e83d313..3a40bed9d6e5 git log d4906e83d313..3a40bed9d6e5 --date=short --no-merges --format='%ad %ae %s' 2018-08-01 thestig@chromium.org Add a ScopedLocale for use within CXFA_LocaleValue. 2018-08-01 thestig@chromium.org Mark CFGAS_FormatString methods as const. Created with: gclient setdep -r src/third_party/pdfium@3a40bed9d6e5 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I407416ac3ea95b7e5e50d8cc7038d6f740c3e347 Reviewed-on: https://chromium-review.googlesource.com/1158345Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579775}
-
Rune Lillesveen authored
Layout tree rebuild and re-attachment now only matches selectors for ::first-letter. It's not worth populating the Bloom filter with ancestor attributes just for optimizing ::first-letter matching. Bug: 843520, 836126 Change-Id: I22c3a4d6518314ded66ef9b214db53c3ff16aac2 Reviewed-on: https://chromium-review.googlesource.com/1158230Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#579774}
-
Christos Froussios authored
Every test in the set is flaking. TBR=rouslan@chromium.org Bug: 869790 Change-Id: I0a1e5d1a9fa52188386a441d65748547ef9ee890 Reviewed-on: https://chromium-review.googlesource.com/1158367Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#579773}
-