- 31 Oct, 2019 40 commits
-
-
Mehran Mahmoudi authored
Change-Id: I9afd7e710eb00cb9e21b39213a8b6606de46dcd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893398Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711393}
-
rbpotter authored
Measured Polymer 3 optimized UI to have similar performance to the optimized Polymer 2 UI. The non-optimized version is ~25-30% faster than the non-optimized Polymer 2 page. Size: Previous bundled page: vulcanized.html: 194k crisper.js: 234k Total: 428k Polymer 3 bundled page: vulcanized.html: 2k extensions.js: 406k total: 408k (~20k smaller) Note that the size of extensions.js is larger than necessary because the Polymer license comments are included for every file, instead of only once for each distinct license year, as was the case when these comments were in HTML files processed by Polymer bundler, rather than in JS files processed by uglify. So further improvements may be possible in future. Fixed: 1004967 Change-Id: I50dd4223142424e7f12da71dbf2fe7c82ebd19f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817293Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711392}
-
Hazem Ashmawy authored
* Add a GN argument to whether show a launcher icon to open WebView developer UI main. This gn argument is off by default. * The shown icon will be another icon in addition to any icons added by WebView providers. * A launcher activity is defined as an activity-alias that links to developer UI main activity. * The manifest file where this activity-alias is defined is merged into WebView manifest only if the flag is true. Bug: 989831 Test: Manually inspect the new added launcher icon after installing system_webview_apk, monochrome_apk, trichrome with gn arg 'webview_devui_show_icon=true` Change-Id: I9e5b808f5e1f9491d2ed813ccf342207a7642b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863929 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#711391}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7d8b0be4542..bf5ec7271d5c git log f7d8b0be4542..bf5ec7271d5c --date=short --no-merges --format='%ad %ae %s' 2019-10-31 dburger@chromium.org Remove scheduling of master-chromium-pfq and children. Created with: gclient setdep -r src/third_party/chromite@bf5ec7271d5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I120d40beb261efebd4a46fa712c40f657d0f9f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893815Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711390}
-
Kevin McNee authored
Tbr: vasilii@chromium.org Bug: 1020257 Change-Id: I1b4ce66b695cc0f5c1f2f62bbbe02be18f6bde6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894052Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#711389}
-
Jacobo Aragunde Pérez authored
We get rid of a helper function, replacing it with a function with the same purpose provided by the Mojo bindings. Also add comments on the purpose of the function and why it's using FusePipes. Bug: 955171 Change-Id: I52aaa8a3b031fee0d39b11243d89627e5131f3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890036 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711388}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5e6be1d627e9..3ff097ff2055 git log 5e6be1d627e9..3ff097ff2055 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 jmadill@chromium.org Win: Add ANGLE_WAIT_FOR_DEBUGGER option. Created with: gclient setdep -r src/third_party/angle@3ff097ff2055 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I5c733915d7c34ce68c5b7b17fe8c27563f2d20e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893321Reviewed-by:
-
Robert Liao authored
BUG=5027 Change-Id: Ia828554114412a760cc3d6e5c768ce8202ccfa5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885509 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#711386}
-
Brandon Goddard authored
This temporarily disables 4 network tool tests that will be rebaselined and re-enabled after https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1881592 has landed and DEPS has rolled Bug: 963183 Change-Id: Ifb2607ffc690f7b8225bcb5635cecd28f112a58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893515Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711385}
-
Majid Valipour authored
Multiple scroll snap wpt tests use `scrollbar-width:none` css property to hide scrollbars. This property is only supported in Gecko. This CL adds the legacy webkit prefixed property [1] to enable the same functionality. This addition allows 8 existing tests to pass in Chrome (and potentially in Safari). [1] ::-webkit-scrollar { display: none; } Fixed: 10030555 Change-Id: Iefe5f5071d23cd40bab71a9d0e360b62e10e9c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884816 Auto-Submit: Majid Valipour <majidvp@chromium.org> Reviewed-by:Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#711384}
-
Oleg Davydov authored
And, while I'm here, also use ExtensionId where applicable. Replacing enum with enum class not only makes scope of their options narrower, but also allows allows more than one enum for histogram to be declared at the same scope without conflicting symbols (otherwise their technical field kMaxValue will cause the conflict). Bug: 1015817 Change-Id: Ic2136bcbf2bd59657ad464019b3dad0a51786567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868880 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#711383}
-
Eric Orth authored
Nothing differentiates anymore between initial and subsequent DNS config notifications from NetworkChangeNotifier, so merge them into a single notification. Fixed: 1001157 Change-Id: I1d67a7d7299d4a15307d2a68ca06d27caf3bef37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788241 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#711382}
-
Ana Salazar authored
Bug: 1018266 Change-Id: I4f8c301428a1f2009571a691b871eb1d760f0eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888402 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#711381}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/9ec47a0bca27..cdc22769d474 git log 9ec47a0bca27..cdc22769d474 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@cdc22769d474 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: If5fd9767402da2b622f15a2d11efe6c0d9349723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893320Reviewed-by:
-
Josh Nohle authored
Add Delegate classes to FakeCryptAuthFeatureStatusSetter and FakeCryptAuthDeviceNotifier that are alerted when SetFeatureStatus() and NotifyDevices(), respectively, are called. This is analogous to the behavior of FakeSoftwareFeatureManager. These delegates are used to make the DeviceSync service unit tests more robust to asynchronous behavior. Bug: 951969 Change-Id: Idcc1fe95a1b70fad0d99e67216bf40fd61af0ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893517 Commit-Queue: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#711379}
-
Findit authored
This reverts commit 5e7f2837. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711358 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVlN2YyODM3Mzg3YjZjY2YxNmMyM2UyYjQ4OTI4ZWRmMmZkYzg1NTMM Sample Failed Build: https://ci.chromium.org/b/8898059709119128832 Sample Failed Step: content_browsertests Original change's description: > Fix UIA Fragment Root Navigation in Inspect > > We discovered that the fragment root change that was recently submitted > here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 > regressed fragment root navigation in Inspect. This was not the case > when Kevin had first submitted it. I traced it down to the changes that > I made for Controller-For elements, so this change undoes those > modifications. > > In order to stabilize the content_browsertest that prompted the changes > (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it > was discovered that there were several issues in how we were > handling date-time popups. > > The first issue is that we were failing to return the proper parent > window for the fragment root. In > RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were > returning nullptr as the parent of datetime popups, which was > parenting the popup under the root desktop window in Inspect. This > change now returns the host's window, which places the popup under > the correct parent window in Inspect. > > The second issue is that there was a cardinality problem with datetime > popup windows. Since they share a BrowserAccessibilityManager with > the main window (but are under a different fragment root), > LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would > always return the main window's root kRootWebArea instead of the > popup window's kRootWebArea. So we'd have two different fragment roots > that map to the same gfx::NativeViewAccessible. This would cause > GetFragmentRootParentOf to return the incorrect parent most of the > time. This change fixes that issue by adding an extra step for popup > windows that traverses the root node and searches for the popup web > root via OneShotAccessibilityTreeSearch. > > Bug: 1019016 > Change-Id: I678425c8417334275727053243a39b1039e6f135 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 > Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711358} Change-Id: I9099f1deb1a5a641ab08d4114d6d7d0121e47101 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894174 Cr-Commit-Position: refs/heads/master@{#711378}
-
Clark DuVall authored
The test was getting the page height before the top controls were fully shown. Bug: 1020065, 1019948 Change-Id: Ide28825e5c4896421dc17fcc84e4da6714f25364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893516Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711377}
-
Jeff Yoon authored
ToTMac* were failing due to the deprecation of xcode build version config in Chromium. Adding xcode build version to the failing bots Xcode version 10b61 (Xcode 10.1 GM) * ToTMac * ToTMacCoverage * ToTMac (dbg) * ToTMacASan Bug: 1019931,1014539 Change-Id: I71ae4b6a340a089ead3146bfb265af4d4cbe3066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891795Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#711376}
-
haozhe authored
Chrome passed and firefox passed Bug: 900581 Change-Id: I0b63e9908d36c380e0f328c66c20b6687a0504aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887232Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Hao Sheng <haozhes@chromium.org> Cr-Commit-Position: refs/heads/master@{#711375}
-
Michael Spang authored
When a rotation is set, a very tiny error is introduced in the root window transform due to use of trig functions in computing the transform. This small error is later turned into a full pixel error in the root window size. This bug was just fixed for chromecast but also exists in TestScreen. Use a common fix for both chromecast and TestScreen, and add a unit test that ensures root window dimensions precisely match the display size when a display rotation in set in the root as part of the root window transform. Bug: 1019015 Change-Id: I930d09d5d079640b17040a721f4334c9cda0272a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1088126 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#711374}
-
Lily Chen authored
Bug: 1002052 Change-Id: I3dec0caf2b98b4b89124688386dba23d4f408ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890534Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#711373}
-
Rafael Cintron authored
This is a reland of 953678c5 Win7 tests are now correctly handled Original change's description: > Add WebGPU to about:flags on Windows > > Now that all of the work on the Chromium and Dawn side to support > Windows has been complete, we need to add WebGPU to about:flags > on Windows. > > Bug: 966580 > Change-Id: I41d9f892be0d849c5ece1d5569f98344a7a92a1e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873383 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#708405} Bug: 966580 Change-Id: I5cad4fbc9d7c1960a5d2b1b2c7e4e0e2f774c7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892156Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#711372}
-
Xianzhu Wang authored
Move tests under paint/dark-mode/* to virtual/dark-mode*, so that virtual/dark-mode*/paint/dark-mode/* now becomes virtual/dark-mode*. Also we no longer run paint/dark-mode/* test in non-dark mode. Bug: 1014162 Change-Id: I23b80e4a535356855f11aa2f47a517fbc455f171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892214Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711371}
-
Ian Struiksma authored
For some sites they overload console commands, so we create an iframe to log element info for debugging. We need to make sure to remove that iframe afterwards, or we build up a collection of them that might affect elements on the page, particularly on lower resolutions. Bug: 984664 Change-Id: I2f81cd8e563c4ca275f561efe94bb03027ee0d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884815 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#711370}
-
Yi Gu authored
[VizHitTesting] Disable SitePerProcessHitTestBrowserTest.CrossProcessMouseEnterAndLeaveTest on Linux The test Site.Cross/0 could not be caused by the suspected change crrev.com/c/1797092 which only affected Site.Cross/1. The test is only flaky (timeout) on ChromeOS. Occurences on other platforms (crash) are no longer present [1]. Disable the test on the affected OS only. [1] https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybAsSBUZsYWtlImFjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BTaXRlUGVyUHJvY2Vzc0hpdFRlc3RCcm93c2VyVGVzdC5Dcm9zc1Byb2Nlc3NNb3VzZUVudGVyQW5kTGVhdmVUZXN0DA&show_all_occurrences=1 Bug: 1006635 Change-Id: I5cc99c678e258846643d933a216575e5268ea9e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837712Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#711369}
-
minch authored
Bug: 1002733 Change-Id: Idfd3b12996e3a4942b07e2da6790129ee5469df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887747 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#711368}
-
Drew Fisher authored
This lets us remove ambient replace-as-executable from things that don't use V8. This includes: * cast_runner and web_runner, which simply provide fuchsia.sys.Runner glue implementations * http, which provides a legacy HTTP implementation that also doesn't need to directly execute memory. We can also remove the implied executability from some tests. As a start, convert the base unittests (which test LoadLibrary) to eschew the deprecated-ambient-replace-as-executable feature. Bug: fxb/37924 Change-Id: I461312972881a0e05d31834227e482c78b445ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881697 Commit-Queue: Drew Fisher <zarvox@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#711367}
-
Wei Li authored
The custom layout used by ComboxBox simply calls the parent's layout function and set up the arrow button's bounds. The latter can be replaced in OnBoundsChanged(). After that move, the custom layout is no longer needed. BUG=1005568 Change-Id: Ib3ea796fbaa6bf626ad5d07e00d6db8c2fbc31b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890976Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#711366}
-
RJ Ascani authored
Now that the soft transition of fuchsia.media/KeyId to a bytes field is complete for key_id, we can revert back to using key_id instead of key_id_temp in EncryptedFormat. Bug: fxb/38522 Change-Id: I86092467213964bed965561fe0b663bc7d5fc411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893677Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: RJ Ascani <rjascani@google.com> Cr-Commit-Position: refs/heads/master@{#711365}
-
Bill Budge authored
Bug: chromium:719172 Change-Id: I7d27bc66572c168607bd03ff6ee712fc6e863640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888741 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#711364}
-
Bo Liu authored
BrowserFragment has an explicit onDestroy which we rely on. There is no need rely on gc to check that embedder forgets to call this. Add methods to create a profile, and all live profiles. This and the fact that it's probably not catastrophic if embedder forgets to destroy profiles, it's deemed not necessary to rely on gc to check this. WebLayer is just the global factory that will never be destroyed, so remove the destroy method. This means weblayer currently does not rely on gc either to clean up or to warn embedder about forgetting to call destroy. Remove all finalizers. Other changes: * Inline and remove ProfileManager in the client library * Change static map for profile in the client library to be keyed by the path. Previous implementation is probably broken since getProfile returns a new object each time. Change-Id: Ic00ed31fda4445412913e6dbe81b7cf8d2205766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884661Reviewed-by:
-
Gabriel Charette authored
A git cl split will follow this CL to migrate BrowserThread::DeleteSoon(BrowserThread::ID, FROM_HERE, *); to base::DeleteSoon(FROM_HERE, {BrowserThread::ID}, *); and will ask owners to verify that this no-op change indeed matches the code's intent. R=fdoray@chromium.org Bug: 1019767 Change-Id: I83111c55ea713f50c46761cf4d83ff593f7d505b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890632Reviewed-by:François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#711362}
-
Richard Knoll authored
If we show help text in Click to Call dialogs, we can just embed the origin into the help text itself instead of showing it as a separate line. We keep showing it as a standalone label in the footnote if there is no help text. Before: https://imgur.com/PSIfHmz After: https://imgur.com/UXeUbmp Bug: 1019242 Change-Id: Id59ff2e53d2f3a5e7ab9da9a1ed876fb5d45641d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887617 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#711361}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 79-3904.19-1569836348-benchmark-79.0.3923.0-r1 to 79-3940.0-1572257069-benchmark-79.0.3945.20-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic023d40addde5a21cd4c56b46a4b48744cddc518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893324Reviewed-by:
-
Pavel Shmakov authored
The ShaderClearHelper never runs the callback if there is no cache to clear. Clearing shader cache is part of the BrowsingDataRemover's procedure when DATA_TYPE_CACHE flag is set. So this results in BrowsingDataRemover never reporting completion to its observers. Bug: 1020168 Change-Id: I23ba6ed2a99b6c44acf0b349dd398f26133369a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890310Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Kurt Catti-Schmidt authored
We discovered that the fragment root change that was recently submitted here: https://chromium-review.googlesource.com/c/chromium/src/+/1823822 regressed fragment root navigation in Inspect. This was not the case when Kevin had first submitted it. I traced it down to the changes that I made for Controller-For elements, so this change undoes those modifications. In order to stabilize the content_browsertest that prompted the changes (DumpAccessibilityTreeTest.AccessibilityInputDateWithPopupOpen/uia), it was discovered that there were several issues in how we were handling date-time popups. The first issue is that we were failing to return the proper parent window for the fragment root. In RenderWidgetHostViewAura::GetParentNativeViewAccessible, we were returning nullptr as the parent of datetime popups, which was parenting the popup under the root desktop window in Inspect. This change now returns the host's window, which places the popup under the correct parent window in Inspect. The second issue is that there was a cardinality problem with datetime popup windows. Since they share a BrowserAccessibilityManager with the main window (but are under a different fragment root), LegacyRenderWidgetHostHWND::GetOrCreateBrowserAccessibilityRoot would always return the main window's root kRootWebArea instead of the popup window's kRootWebArea. So we'd have two different fragment roots that map to the same gfx::NativeViewAccessible. This would cause GetFragmentRootParentOf to return the incorrect parent most of the time. This change fixes that issue by adding an extra step for popup windows that traverses the root node and searches for the popup web root via OneShotAccessibilityTreeSearch. Bug: 1019016 Change-Id: I678425c8417334275727053243a39b1039e6f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885102 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
-
Nick Harper authored
This was requested by the DotGov registry. Change-Id: I9e962fee89158d1f876ded6cb51c545c444761c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888536 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711357}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fb075d558d6d..8d65e9ab98d8 git log fb075d558d6d..8d65e9ab98d8 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 sprang@webrtc.org Fixes pacing interval dependency and race in BandwidthEndToEndTest 2019-10-31 gustaf@webrtc.org AEC3: Handle multichannel audio in single CNG instance 2019-10-31 srte@webrtc.org Removes RPLR based FEC controller. 2019-10-31 minyue@webrtc.org Update comments on Audio Level RTP header extension. 2019-10-31 danilchap@webrtc.org Do not stop SingleThreadedTaskQueueForTestingTest near the end of the tests Created with: gclient setdep -r src/third_party/webrtc@8d65e9ab98d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If21ae994235b5fffc4422a0be557754f9a6d8b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893675Reviewed-by:
-
Thomas Lukaszewicz authored
Fixed logic governing bounding box of the find bar in the browser layout view. Removed unnecessary insetting and fixed comments to better reflect its function. Bug: 871419 Change-Id: I89a341825508b1e088b0f10f449eb2c3a91fcc38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866969 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#711355}
-
haozhe authored
Chrome passes the tests and firefox doesn't support "to" in asssert_true. bug filed: https://bugzilla.mozilla.org/show_bug.cgi?id=1593036 Bug: 900581 Change-Id: I55df2d439c6c58665f1b1536def0b0b04635cf1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891758Reviewed-by:
-
