GitLab

Simplify the bubble showing procedure through browser view by 1)
move profile checking logic into Hats service; 2) move anchor view
handling logic into Hats bubble class.

BUG=979530

Change-Id: I6962f3904d575671f592ca0926edd214fe748c2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742511Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685400}

Bug: 934317
Change-Id: I054b539a39752582d6e44f1ac416bbc24be7c470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742371Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685399}

Calls to SetCookieWithOptionsAsync are replaced with the two-step
process of first making a CanonicalCookie via CanonicalCookie::Create,
then passing that to SetCanonicalCookieAsync.

At this point, there is only one non-test usage remaining, and that
call site already has a CanonicalCookie, so might as well just call
SetCanonicalCookieAsync there, and remove the entry point and its
implementations.

This does slightly change behavior, due to consolidation of all
cookie-line parsing logic into CanonicalCookie::Create.

In particular, the iOS CookieStore used to do its own cookie-line
parsing in SetCookieWithOptionsAsync. That used to differ from
CanonicalCookie::Create in whether trailing dots in URLs/domains
were preserved (and possibly some other subtle differences?). This
updates the relevant CookieStore unittests to reflect this change
in cookie creation behavior.

(Based on morlovich's https://crrev.com/c/1464131)

Bug: 989098
Change-Id: Ibbe2fb0a950af07e5df6811f6372a9dd8c88b5f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739491
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685398}

Reduce the work that's done while evaluating the query transform of a rule. This
is done by indexing escaped values for the query key value pairs. Also, sort and
remove duplicates before indexing the query keys to be removed.

BUG=983685

Change-Id: Ia6e72832253025c4a43b5852e00a7a064d3fcd6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742887
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685397}

Change-Id: If334d98e17657d81cb4241df3ebe25415be6514a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736700
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685396}

Java AwQuotaManagerBridge is now owned by Java AwBrowserContext.

Bug: 963875
Change-Id: I517b1d17f17f6bda9ce93de09baa4861a74bc179
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742171Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Anna Malova <amalova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685395}

https://android.googlesource.com/platform/external/perfetto.git/+log/0756495a26fb..65b41192b9a7

git log 0756495a26fb..65b41192b9a7 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 primiano@google.com Merge "Client library: Allow recursive acquire of data source lock"

Created with:
  gclient setdep -r src/third_party/perfetto@65b41192b9a7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: Ic326138e7014ac5c6df1758401ff20fb18575675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744967Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685394}

Bug: 937570
Change-Id: I069370a8574797c133c5660106b6cc74132b4cd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744927
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Auto-Submit: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685393}

BUG=989384

Change-Id: I899ff40c615f3fd5312199408f9aa93c32372530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745128
Commit-Queue: ssid <ssid@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Auto-Submit: ssid <ssid@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685392}

This CHECK is intended to catch when an IPC race around process shutdown
that leads to inconsistent state between the browser and the renderer.
Without the CHECK, there are likely instances where the bug is latent
but never triggered, so adding an explicit CHECK() likely increases the
number of overall crashes.

Due to how Android WebView crashes are attributed, and the fact that
Android seems to encounter this IPC race more, disable this CHECK()
there for now despite the fact that it doesn't actually fix anything...

Bug: 974173
Change-Id: I19bbbe0a0fdaffdc30cfdfbc1cf300d0de12839c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740332Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685391}

*** Note: There is no behavior change from this patch. ***

The PostTask APIs will shortly be changed to require all tasks to explicitly
specify their thread affinity, i.e., whether the task should run on the thread
pool or a specific named thread such as a BrowserThread. This patch updates all
call sites with thread affinity annotation. We also remove the "WithTraits"
suffix to make the call sites more readable.

Before:

    // Thread pool task.
    base::PostTaskWithTraits(FROM_HERE, {...}, ...);

    // UI thread task.
    base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...);

After:

    // Thread pool task.
    base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...);

    // UI thread task.
    base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...);

This patch was semi-automatically prepared with these steps:

    1. Patch in https://crrev.com/c/1635827 to make thread affinity a build-time
       requirement.
    2. Run an initial pass with a clang rewriter:
       https://chromium-review.googlesource.com/c/chromium/src/+/1635623
    3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \
           uniq > errors.txt
    4. while read line; do
         f=$(echo $line | cut -d: -f 1)
         r=$(echo $line | cut -d: -f 2)
         c=$(echo $line | cut -d: -f 3)
         sed -i "${r}s/./&base::ThreadPool(),/$c" $f
       done < errors.txt
    5. GOTO 3 until build succeeds.
    6. Remove the "WithTraits" suffix from task API call sites:

       $ tools/git/mffr.py -i <(cat <<EOF
       [
         ["PostTaskWithTraits",
          "PostTask"],
         ["PostDelayedTaskWithTraits",
          "PostDelayedTask"],
         ["PostTaskWithTraitsAndReply",
          "PostTaskAndReply"],
         ["CreateTaskRunnerWithTraits",
          "CreateTaskRunner"],
         ["CreateSequencedTaskRunnerWithTraits",
          "CreateSequencedTaskRunner"],
         ["CreateUpdateableSequencedTaskRunnerWithTraits",
          "CreateUpdateableSequencedTaskRunner"],
         ["CreateSingleThreadTaskRunnerWithTraits",
          "CreateSingleThreadTaskRunner"],
         ["CreateCOMSTATaskRunnerWithTraits",
          "CreateCOMSTATaskRunner"]
       ]
       EOF
       )

This CL was uploaded by git cl split.

R=carlosil@chromium.org

Bug: 968047
Change-Id: I7004c79f585e1e040609c3830c5a80286402f705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739812
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685390}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b062b2de99f..c1692cd34cc0


Created with:
  gclient setdep -r src-internal@c1692cd34cc0

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None,chromium:None
Change-Id: I3526fbf4e55ec74a1f3aac04ef51bcb107b23e7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744966Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685389}

Update the list of devices for Microsoft Edge. This includes:

 - Adding Microsoft Edge for all supported platforms
 - Clarified which ones are based upon EdgeHTML vs Chromium
 - Ensured that appVersion and Chromium version are patched similar to Chrome.

Change-Id: I59c5287799c6e9bd6950c76323a867c012951323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709693Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#685388}

Currently VectorBuffer allows the access of buffer[size]. This is
because callers are using buffer[size] to get buffer.end(). In order to
avoid this, use CheckedRandomAccessIterators in VectorBuffer. This
required creating iterator versions for the DestructRange and MoveRange
functions.

CheckedIterator's behavior now depends on the enable_checked_iterators
buildflag: when true, CheckedIterator will CHECK on spatial safety
violations; when false, CheckedIterator will merely DCHECK. This is
temporary, so that binary size regressions on Android can be studied
and explained: the eventual goal is to enable this universally and
remove the buildflag.

BUG=chromium:817982

Change-Id: I2037bdb542c4442011fc9ebffdc50e50ccfafa7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674746Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685387}

This CL adds a directory for upcoming reputation warnings
and the safety tip experiment. Otherwise, this CL
contains nothing interesting.

Bug: 981177
Change-Id: Ic5a4bfc7ce5f95ccdf04e8a9604aa6fe094b2411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688332Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685386}

Enable the GWP-ASan unit tests on Android and wire-in GWP-ASan in to the
crash handler and browser (for now it's still disabled by default and
not wired in to webview.)

Bug: 973167
Change-Id: I705bc3fcd4469c90099d91b9b2ae16f2a9c93fab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733567
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685385}

This CL switches the protobuf used for component updater to pass
patterns rather than raw URLs. This allows safety_tips to remain
consistent with the SB-style pattern matching. It also moves the
playbook for component updates to g3.

Change-Id: I9da231882cdb68fddd1d0b582006ed60e97fbe8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743247Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685384}

Since HoverButton was changed to no longer inherit from MenuButton, the
behavior has to be readded back into the controller.

Bug: 991877
Change-Id: I7d0987eb1b30423753560feee2d8a42bb6d71cc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745289Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685383}

This also fixes accessibility tree errors uncovered when running the
new test.

Bug: 989174
Change-Id: If362f808260fdcaaa4a0b64a6573ed6f3bc9d471
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744674
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685382}

virtual/disable-blink-gen-property-trees/animations/stability/animation-iteration-event-destroy-renderer.html
is flaky on linux, so marking it as such. See bug for more info.

https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/2822

TBR=ericwilligers@chromium.org

Bug: 992148
Change-Id: I803958493d9330e3a3383e74e1cae0621aeb5475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745026Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685381}

Now all Fuchsia owners will be scenic ozone platform OWNERS.

Change-Id: I8377878a56785602b600bfdcd40e894c9a37415c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744947Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685380}

WebAuthn contains the “appid” extension that allows WebAuthn to obtain
assertions for credentials that were registered using the old U2F API.
However, prior to this, there was no way when doing a WebAuthn
registration to exclude authenticators based on a U2F credential.

An “appidExclude” extension has now been added to WebAuthn to resolve
this and this change implements support for it.

[1] https://w3c.github.io/webauthn/#sctn-appid-extension
[2] https://w3c.github.io/webauthn/#sctn-appid-exclude-extension

Change-Id: I2eb1d6d0a574bc4d8cab95540de031329403581f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728724Reviewed-by: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685379}

This change converts document-scoped FileSystemManager client in
blink to use BrowserInterfaceBrokerProxy as a use case of a callback
dispatched on the IO thread.

Bug: 936482
Change-Id: I3afba1264396bb9b916efb75c6594797ad581407
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709723
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#685378}

Adding documentation to ev-to-page-info.md in src/docs/security/
to describe EV certificate UI changes in Chrome 77.

Bug: 992132
Change-Id: I1c614e0d7f66d6719f511740f18a5754561c9a35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742810
Commit-Queue: Devon O'Brien <asymmetric@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685377}

Prevent issues like crbug.com/985712 happening again.

Bug: 990472
Bug: 985712
Change-Id: I6cfa17ec39076f17b6a3bf35b0430f778c05d5ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736896Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685376}

Before this patch, the address editor on desktop would not require the
full name. However, Payment Request shipping addresses cannot be empty,
which is checked in several other places in the code. So the saved
address would immediately have a "Name required" error next to it in the
address selection screen.

In addition, desktop address editor placed the country selector between
the name and the rest of the address fields, whereas Android placed the
country on top, which makes sense, since changing the country can change
all fields, including the position of the name field.

This patch makes the name always required in the address editor on
desktop and places the country selector on top.

Bug: 992081
Change-Id: I028c296289e4635c9c5c12dc10c59102d321fa30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743094Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685375}

These tests have been flaking for a long time now, crashing with
segfaults occasionally on the linux-chromeos-rel bot for at least a week
now:

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel?limit=200

See the bug for more details.

TBR=antrim@chromium.org

Bug: 992022
Change-Id: I9074436363e6bbef0dfa838274a1343e9e333f84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745288Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685374}

https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f564874f4..21eb59531

$ git log f564874f4..21eb59531 --date=short --no-merges --format='%ad %ae %s'
2019-08-06 rnk@chromium.org Revert "Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics"
2019-08-06 rnk@google.com Fix extern_inline for MSVC and clang-cl
2019-08-01 rnk@google.com Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics

Created with:
  roll-dep src/third_party/nasm

R=dalecurtis@chromium.org, davidben@chromium.org

Bug: 989745
Change-Id: I26c19bce9bb4148154168732f2862cb0c7817686
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744200Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685373}

This is required to make this script work with Python 3, but even
in Python 2 open is preferred over file():
https://docs.python.org/2/library/functions.html#file

Bug: 941669
Change-Id: I4738fc9bad81464c9ca5c9c15a3c51e9ee3f945d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745488
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685372}

This only loads the filter in memory if the type is registered

Bug: 969558
Change-Id: I512b9d14cd41bb20bb5c767ff57b061c0725ca33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740890
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685371}

Bug: 988116
Change-Id: I046e4e17b4aa1e5b6741123e4585c4c82470815d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742658Reviewed-by: Sam Maier <smaier@chromium.org>
Reviewed-by: Yun Liu <yliuyliu@google.com>
Commit-Queue: Yun Liu <yliuyliu@google.com>
Cr-Commit-Position: refs/heads/master@{#685370}

Bug: None
Test: CQ
Change-Id: I4e1bafee0dc1ed98e57c307b82772c20bd7c742f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744525
Commit-Queue: Junbo Ke <juke@chromium.org>
Auto-Submit: Junbo Ke <juke@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685369}

It will still hit some DCHECKS when trying to decode jpg.

Bug: 991182
Change-Id: Ia899c85378992dd3b14bbf722499069b011d00e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742783Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685368}

The only surface for interacting with downloads in touchless chrome is
through the notification system. This patch makes paused and
in-progress download notifications persistent so they can be accessed
even after notifications are cleared.

Bug: 989293
Change-Id: I8041e0bcb54996cccb7bdc1d37c2fdc15615bcfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737486Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685367}

1. Implement AXInlineTextBox::IsLineBreakingObject to detect
   preserved newlines.

2. Adjust AXPosition<>::AbortMoveAtParagraphBoundary to be able to
   detect preserved newlines from ancestor anchors using the leaf
   text position.

Bug: 847971
Change-Id: I96e9eacd55cfdb4aa99ceb6460c530ee6d17a1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677553
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685366}

base::Time represents an absolute point in coordinated universal time (UTC).
base::TimeTicks which tracks the amount of time a task runs.
Watchdog V2 uses TimeTicks to check timeout. Adding clock time and analyzing
the difference between these two might help debugging V2.

Bug: 949839
Change-Id: I21e9250e67a02f4190d12d28d33c5c7a52a2168c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742440
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685365}

This change exposes a new method on the NavigationController that
commits an error page in a frame. This is necessary in
order to trigger error pages from the browser process, and to ensure
that they are committed correctly and in the correct process.

This error page navigation API is used in
https://chromium-review.googlesource.com/c/chromium/src/+/1744639

Change-Id: Idc3ff81219e1313c12c45a969c2099a68869f957
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731554
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685364}

Bug: v8:9509
Change-Id: I7a7da029e95edf845456673e7a776bf7ac5e1aed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743875
Commit-Queue: Yury Semikhatsky <yurys@chromium.org>
Auto-Submit: Yury Semikhatsky <yurys@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685363}

https://webrtc.googlesource.com/src.git/+log/940c2b500589..287bff32f45e

git log 940c2b500589..287bff32f45e --date=short --no-merges --format='%ad %ae %s'
2019-08-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 498f5876..9230e75a (685149:685264)
2019-08-08 srte@webrtc.org Adds struct parameters parser/encoder.

Created with:
  gclient setdep -r src/third_party/webrtc@287bff32f45e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None
Change-Id: I6ef941c367bde0db77902c18e1f5c0f2a9b4785b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744774Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685362}

Added comment and DCHECK showing why it didn't make sense.

No behavior change. Some code churn due to accommodating the DCHECK.

Bug: 845235
Change-Id: If159ec3d44821cf447563f60e8a25959c86c46a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744520
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685361}