- 03 Apr, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e06125cb520f..ad6d1b30e0f1 git log e06125cb520f..ad6d1b30e0f1 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 amaiorano@google.com Really fix Android build Created with: gclient setdep -r src/third_party/swiftshader@ad6d1b30e0f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Idb24445b6d1b20980267cb21a085b1b46b9a10ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136137Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756457}
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. In addition, this test uses <html class="reftest-wait"> as described in [1] to replace the code that was depending on testRunner in order to make sure that the screenshot is taking at the right time. Last, the original test relied on a green-256x256.jpg image that is exactly equivalent to the PNG version already in WPT, so this test has been migrated to use that one instead. [1] https://web-platform-tests.org/writing-tests/reftests.html?highlight=reftests#controlling-when-comparison-occurs Bug: 1063749 Change-Id: Idcd76fcf3b1e82fe14be602c120d8c105f5c658a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134258Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#756456}
-
Lukasz Anforowicz authored
This CL adds the FromBackgroundServiceWorker_NoSniffXml test. The new test complements the old FromRegisteredServiceWorker_NoSniffXml test, but the new test registers the service worker in a more typical way - via the following entry in the extension manifest: "background": {"service_worker": "sw.js"} Additionally, the new test covers not only a target URL that is covered by extension permissions, but also other-without-permission.com. The old test is still relevant for testing how a 'fetch' event handler of a service worker behaves. One aspect where this is important is where the 'fetch' event handler doesn't handle the fetch - I vaguely remember that I heard that the fallback might use a different URLLoaderFactory from the one normally used from within the service worker. Bug: 1051594 Change-Id: Ic9df888cd0799ce57131e6df93d9c6f39501aedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132938Reviewed-by:Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#756455}
-
John Delaney authored
Currently, ConversionStorageSql is instantiated and owned by a ConversionManager instance. ConversionStorageSql is solely accessed through a SequencedTaskRunner, and is deleted on the same sequence that it is accessed. ConversionStorageSql also holds a pointer to the manager which implements the ConversionStorage::Delegate. Because of this setup, it is possible for the ConversionManager to be destroyed when there are still storage tasks in the queue that require a StorageDelegate. Because the storage instance is deleted on the sequence, the pointer to the ConversionManager is no longer valid and it will still be accessed. This change fixes this potential behavior by moving the Delegate implementation off ConversionManager, and into a separate class that is only accessed on the storage sequence and owned by ConversionStorageSql. Because ConversionPolicy cannot be shared, storage related methods are pulled onto the DelegateImpl. Bug: 1059840 Change-Id: Ie0fdf7a07d3dbe75359bb29b0dfea8a973ca3db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095435 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#756454}
-
James Vecore authored
This flag can be used to enable or disable Nearby Sharing Change-Id: I7eb984f164affb98a4d8f9e3cfb1f462f981ed87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133053Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#756453}
-
Brandon Wylie authored
Bug: 1067716 Change-Id: I717bc16a22492dec3238bffc9e943c6be29f57ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134205 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#756452}
-
Sergey Ulanov authored
Updated PlayAudio test in web_engine_integration_tests to enable FuchsiaAudioConsumer and verify that the audio played as expected. It uses a fake implementation of fuchsia.media.AudioConsumer interface that's injected to the web context. Also updated the tests to play two files with different sample rate to verify that the audio renderer handles mid-stream config changes. Bug: 1027048 Change-Id: I14b0b63d9dc7444c749ee0da348b39df93c1242b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940726Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756451}
-
Sammie Quon authored
This is a regression from my previous cl crrev.com/c/2099291. I don't have access to a win7 but this speculative fix readds the MessageView specific HighlightPathGenerator which insets the ring a bit. On my cros-linux you can see the ring is now within the notification bounds. Test: manual Bug: 1067594 Change-Id: Iddaf378dc864f2a438d5a64174592faa4bf66c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136054Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#756450}
-
Michael Tang authored
- Ported Omaha 3's ExtraArgsParser into chrome/updater. - (At Sorin's request) Renamed ExtraArgs to something else (currently TagArgs, but I'm open to renaming it or any other item) - Ported the Omaha 3 ExtraArgsParser tests Change-Id: Ief76020716ae35fff26bacd19357847651acad5a Bug: 1050738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081332 Commit-Queue: Michael Tang <tangm@microsoft.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#756449}
-
Leonard Grey authored
Bug: 1066116 Change-Id: I4c77eb55d4288ab1ecf327875d37a1b8fe90d292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134778 Auto-Submit: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#756448}
-
John Lee authored
This CLs replaces all usage of the cr-section class with a new cr-row class. It also removes uses of the class where there isn't much benefit to using them and cleans up some of the HTML and CSS that were used to override the class. Bug: 973674 Change-Id: I1c33ca05626bde382bd7fbd0b54b4ab3b86089dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134197 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756447}
-
Charlene Yan authored
Updating the context menu for Tab Groups to show a submenu with the entry "Add to Group" if another group exists and the submenu to had "New group" as the first item followed by a separator and then the other existing groups. If there are no other groups, a submenu will not appear and the menu item will simply be "Add to new group". Bug: 1064674 Change-Id: I88b470171d4f44e6969201fea7e991d5cd2905c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133269 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#756446}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d6db0b9fdd5..7ff61c6fba28 git log 2d6db0b9fdd5..7ff61c6fba28 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 brcui@microsoft.com Add alt text to Screencast canvas element Created with: gclient setdep -r src/third_party/devtools-frontend/src@7ff61c6fba28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067074 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf41d49a66c51a3a461b7e8f2583e4ef16fe0441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136136Reviewed-by:
-
Saurabh Nijhara authored
The test was based on the assumption that the wizard controller is recreated in the login display host and hence, had the expectations according to that. If instead the wizard controller object is reused, this test fails the expectations set in the test class at the start. Hence, calling AdvanceToScreen(...) directly instead of going through login display host. Bug: 1064271 Change-Id: I12b11f0a08269d91d776ae0e438b7b0b8ce7262d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132382Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#756444}
-
rbpotter authored
This UI is shown on the main people page landing page, so to avoid flicker on load, it should be in the main rather than the lazy module. Size changes: vulcanized.html: 240k -> 247k (+2.9%) crisper.js: 313k -> 321k (+2.6%) lazy_load.vulcanized.html: 257k -> 249k (-3.1%) lazy_load.crisper.js: 304k -> 297k (-2.3%) Bug: 1026064 Change-Id: I809b8701ab3859561911980064bd84a4ded4a83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134779 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Jeff Yoon authored
- chromium_trybot recipe set in ci.star for both bots - mb configs set in mb_config.pyl for both bots, exactly the same as the builders Bug: 1055164,912681 Change-Id: Ib2235e9803ddafddbd7fc44be493ab06fcb74c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121429 Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#756442}
-
Dale Curtis authored
This reverts commit 6db10514. This did not work well so it's being reverted. R=tguilbert Bug: 1012063 Change-Id: Ia5faf1026921dab735ead8acaa8f4fdd80dc6fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135894 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756441}
-
Garrett Beaty authored
Consoles defined using ci.console_view instead of luci.console_view can specify a dictionary that controls how entries in that console are sorted. Calls to ci.builder can then specify the console_view_entry attribute with the category and/or short name for the builder and an entry for the builder will be added to the console corresponding to the builder's mastername. Bug: 1067057 Change-Id: Icbbb310bbf4434aeb2434ab930e8fb64fff85a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136107 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756440}
-
Alexander Cooper authored
Moves chrome/browser/vr/service and corresponding dependent metrics code into content. Also moves not-yet published statics into content/public. As a result of the move a few changes had to be made: * VRService needed to switch to PermissionControllerImpl * Swapped two "NULL"s to "nullptr" * Renamed usages of XRRuntimeManagerStatics to XRRuntimeManager * Deleted WebVRServiceProvider and directly hooked up VRServiceImpl in browser_interface_binders * Switched ChromeXrIntegrationClient::GetInstance usages to use ContentBrowserClient->GetXrIntegrationClient (and removed ChromeXrIntegrationClient::GetInstance) * Created GetXrDeviceServiceForTesting to manage dependencies for tests * ukm::GetSourceIdForWebContentsDocument replaced with WebContents::GetLastCommittedSourceId * XrRuntiemManagerUnitTest needed some singlethreaded task environments added due to changes in tests (requirements from using mojom) It seems like linking //device/vr into a source_set causes one of the static initializers from gvr_shim to get counted now (perhaps being optimized out when in a static library?) Bug: 1031622 Change-Id: Id856e6cb68471a9960f54c663ece417461067541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125016 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#756439}
-
Clark DuVall authored
This can now be shared between //chrome, //headless, and //weblayer. Bug: 1050722, 1049317 Change-Id: I3fdc6979926b7ba8d27a8543cace8909b5c3f75f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134691 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#756438}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/52ecbf88d69c..14215fbea0c8 git log 52ecbf88d69c..14215fbea0c8 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 jophba@chromium.org Add recipe engine servers to buildbucket cfg Created with: gclient setdep -r src/third_party/openscreen/src@14215fbea0c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I609f25078b3928b034c3e1e2dd54cc67368a3bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136052Reviewed-by:
-
Tom Anderson authored
The bot's config will be moved into linux-ozone-rel, so this temporary bot can be removed. BUG=1029240 R=agable Change-Id: Iff366bf66bbf8d4a04e3d88970199908e8e0f50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134692 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Peng Huang authored
glImportMemoryWin32HandleEXTFn and glImportSemaphoreWin32HandleEXTFn are added. It will be used for implementing Vulkan GL interop on Windows. Bug: 1067709 Change-Id: Ic6fa3e44ea5da64bd4f56491c97daee184e0f362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135420Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756435}
-
Arthur Eubanks authored
This reverts commit fd6e6ffb. Reason for revert: https://crbug.com/1067752 Original change's description: > Use urllib instead of curl > > Now that https://crbug.com/965937 is fixed. > Partial revert of https://crrev.com/c/1624331. > > Change-Id: I9e73fdff99984601182ec142723a9d3521a9eb6e > Bug: 897796 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134702 > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > Auto-Submit: Arthur Eubanks <aeubanks@google.com> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756285} TBR=hans@chromium.org,aeubanks@google.com Change-Id: Ia53d6e84a8e09d13d7935cfde3b9310d7bc06e93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136138Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#756434}
-
Orin Jaworski authored
This CL takes another step toward having selection change logic consider full selection instead of updating line and state separately with assumed NORMAL state default. The API is preserved for now but behavior changes slightly in a way that should, long term, be more efficient than doing event handling in duplicate. In particular, the goal is to have result views only update on selection change once instead of once on line change and then again on state change. Bug: 1046523 Change-Id: I6c94db73d4997241275e4a1b62b75272611c166a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134917Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#756433}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7803f6a504e3..d49a958f8fdf git log 7803f6a504e3..d49a958f8fdf --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rsavitski@google.com Merge "perfetto_cmd: if unique session is given, set comm to "p-session_name"" Created with: gclient setdep -r src/third_party/perfetto@d49a958f8fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id38cce4b2db2e6f76aab5656dc51a97b18121ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136133Reviewed-by:
-
Joey Arhar authored
This reverts commit ddcb2103. Reason for revert: The revert caused a compile error, so I am relanding it. I will then disable the test that was failing on msan instead. Original change's description: > Revert "media/video: Add SpatialLayer to VideoEncodeAccelerator::Config" > > This reverts commit ee98d31c. > > Reason for revert: > After the commit, SpatialLayerStructTraitTest.RoundTrip has been > consistently failing on msan. > > I was able to reproduce the failure locally on my linux machine by > building and running media_unittests with these gn args: > is_component_build = false > is_debug = false > is_msan = true > msan_track_origins = 2 > use_goma = true > > Original change's description: > > media/video: Add SpatialLayer to VideoEncodeAccelerator::Config > > > > This CL adds SpatialLayer to VideoEncodeAccelerator::Config so > > that a VEA client is able to configure a spatial layer encoding. > > The configuration is useful to configure temporal layer encoding > > too. Supporting temporal layer with vp9 hw encoder is a short > > term goal today. > > > > Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy > > > > Bug: 1030199 > > Test: media_unittests > > Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444 > > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > > Reviewed-by: Dominick Ng <dominickn@chromium.org> > > Reviewed-by: Dan Sanders <sandersd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#756300} > > TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org > > Change-Id: I6a86cb5a8f7d5fd2d1b7dbd4b3d6d99d2298c5dd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1030199,1067758 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136113 > Reviewed-by: Joey Arhar <jarhar@chromium.org> > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756427} TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org,jarhar@chromium.org Change-Id: If73b6e850248954c8709acc86b923d67dc11597a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030199, 1067758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136226Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756431}
-
Eric Roman authored
This reverts commit 89fd75a0. Original change's description: > Add quick check parameter to ConfiguredProxyResolutionService ctor > > Doing this cleans up an undesirable ConfiguredProxyResolutionService > usage pattern where code that primarily works with a > ProxyResolutionService must currently cast to the specialized class > before setting the right PAC quick check value. > > Bug: 1032820 > Change-Id: I777eb1c6097a604bf522e7d87f8806f4df0324b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113802 > Commit-Queue: Nicolas Arciniega <niarci@microsoft.com> > Reviewed-by: Eric Roman <eroman@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753426} TBR=eroman@chromium.org,jam@chromium.org,mmenke@chromium.org,niarci@microsoft.com Bug: 1032820 Change-Id: I6c68ef6eca61e76ae35ba62665b0c9e880d9c833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135984Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756430}
-
Yusuf Sengul authored
This change is a follow up to a previous Chrome SSO change[1]. Currently, Chrome SSO through GCPW would only work if the profile is the initial profile dir. That wouldn't work if initial profile dir is deleted and/or another profile is being used. This change addresses signing into profile through GCPW regardless of profile being initial profile. Note that signing into profile doesn't work: If the same GCPW user is authenticated in any other profile. If any other profile was used to sign-in with GCPW before. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1984474 Bug: 1038368 Change-Id: I8719d1dbea59eb31206f9c897331fcd9674aae9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084721 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#756429}
-
Thomas Guilbert authored
One of the versions of GMS core had a bug, where seeks timing out would cause a crash, leading to crbug.com/914072. The fix at the time was to send manually-crafted 'seek' messages, instead of using the API. The issue was in a single version of GMS core, and the roll in crbug.com/958461 should have fixed it. This CL removes the temp fix, and switches back to using the normal API. Bug: 918644 Change-Id: I335493d535166f5154f8127f4001192ffbebff53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134399Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#756428}
-
Joey Arhar authored
This reverts commit ee98d31c. Reason for revert: After the commit, SpatialLayerStructTraitTest.RoundTrip has been consistently failing on msan. I was able to reproduce the failure locally on my linux machine by building and running media_unittests with these gn args: is_component_build = false is_debug = false is_msan = true msan_track_origins = 2 use_goma = true Original change's description: > media/video: Add SpatialLayer to VideoEncodeAccelerator::Config > > This CL adds SpatialLayer to VideoEncodeAccelerator::Config so > that a VEA client is able to configure a spatial layer encoding. > The configuration is useful to configure temporal layer encoding > too. Supporting temporal layer with vp9 hw encoder is a short > term goal today. > > Design doc: https://docs.google.com/document/d/1yeCV36yhk9zna4qwngPiJGhSUkDyJHRlfEpziFgJfHo#heading=h.aeh6kjktcuzy > > Bug: 1030199 > Test: media_unittests > Change-Id: I1e0524a71b043ccfa0e41d08e8de4b86e9c17c9e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131444 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756300} TBR=sandersd@chromium.org,sprang@chromium.org,dominickn@chromium.org,hiroh@chromium.org,ilnik@chromium.org Change-Id: I6a86cb5a8f7d5fd2d1b7dbd4b3d6d99d2298c5dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030199,1067758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136113Reviewed-by:
-
Akihiro Ota authored
Before this change, ChromeVox compared locales using the language component. It treated zh-hant and zh-hans as the same, even though they are completely different. This change fixes this behavior; we now perform a strict comparison and alert the user if the locale has changed in any way. Bug: 1061222 Relnotes: N/A Change-Id: I1b1fe89c43d9fa9cec0a7b35a21798e937263754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101717Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#756426}
-
Alexandre Frechette authored
Bug: 1065431 Change-Id: Icd8d9dbb98b5408a2d3de383baa1d26c4134c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124737Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#756425}
-
dpapad authored
Need to double escape backslashes, since the JS parser parses the string before the Polymer bindings parser kicks in. Fixed: 1063530 Change-Id: I3a61824703cd5826920e347c82468d1ddf764cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117162Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#756424}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3b734860c9926296a874b5d9f648fd6e2979a600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136056Reviewed-by:
-
Abhijeet Kandalkar authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I458f85e0dbf767df4d858a116348be0de94618e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135649 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#756422}
-
Eric Orth authored
Start a 2 second timer on SystemNetworkContextManager creation. On fire, checks for parental controls and updates the network service DNS config if DoH needs to be disabled. Should be more performant to check after the delay because the actual underlying API calls with performance issues are already triggered off-thread in Chrome main(), so the check is only a performance issue if called too soon after startup. On all config retrievals, skips checking parental controls if it hasn't been checked yet and the otherwise-configured mode is AUTOMATIC. In this mode, DoH activation probes don't even start until 5 seconds after NetworkService creation, so delaying 2 seconds before disabling DoH should have no practical effect. If the otherwise-configured mode is OFF, it doesn't ever need to be checked, and if SECURE, it's acceptable to take the performance hit to always wait for the check. For UI retrieval of config, set a flag to force checking parental controls immediately to ensure the UI shows the correct state. If the check hadn't been made yet, this triggers an update to NetworkService to ensure the UI state matches the service state. Made some simple changes to pull the service update calls into GetStubResolverConfig() to simplify its ability to perform the service update. Also converted the type for retrieving DoH servers from the mojo type to DnsOverHttpsServerConfig now that the mojo update is handled internally to GetStubResolverConfig(), and moved the type to doh_provider_list.h to be more widely shareable. Little bit of code churn, but nothing significant. Bug: 1064346 Change-Id: I6505bd363d6c1fb88b255dd8c1dd1973b721bf97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130867Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#756421}
-
Owen Min authored
Disable the test on other platforms because the test is also timeout on them. Bug: 403325 Change-Id: I5e544c8392f69c251a9da6c327d6eadce9b53e76 Tbr: wjmaclean@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136030Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756420}
-
Anders Hartvoll Ruud authored
The properties defined by css-logical (and more generally surrogates) pose a hard problem for 'revert' in the StyleCascade, because declarations such as 'margin-bottom:revert' may actually need to revert to a different property in the previous origin (e.g. margin-block-end). An example is the h1 element, which is styled by html.css using css-logical properties. When the author then reverts using a corresponding physical property, we can't simply look up the cascaded value for that same physical property in the UA origin: we must be aware that the css-logical property won the cascade _at that level_. So when we we're applying an author declaration 'margin-bottom:revert', we have to find the *target property* for the revert, which is either margin-bottom (if that property won the cascade at the target origin), or the corresponding css-logical property. However, to find the target property, we need to know during the application of margin-bottom that a corresponding logical property (surrogate) needs to be taken into account. AutoSurrogateScope was created for this purpose, which sets (and resets) a "current surrogate" field on CascadeResolver. This current surrogate is used when resolving reverts, in order to find the correct target property. Also, we don't control the order in which physical/logical properties are applied. This means we could be applying the physical property first, which is unaware of any logical properties that should have been taken into account for revert. In other words, if we apply 'margin-bottom:revert' without the context of a "current surrogate" set, we'll fall back to unconditionally using margin-bottom as the target property, which may be incorrect if there also exists a logical property we'll get to later. This is why the force-reapply code exists: when both the physical and logical property exists in the cascade, the physical property must be applied (or re-applied) during AutoSurrogateScope, otherwise revert will not behave correctly. Bug: 579788 Change-Id: I864a4c9afdd94f130c42635d28d45c843d5fb617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130850 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756419}
-
Mustafa Emre Acer authored
This CL introduces the ability to observe mouse clicks when a page with a delayed SafeBrowsing warning is loaded. If the feature parameter "mouse" is enabled, the warning is immediately shown on mouse click. Otherwise, a metric is recorded the first time user interacts with the page. Bug: 1057157 Change-Id: If81e9c5867b7e72703a284b8226e2987f5edf3d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120428 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#756418}
-
