- 19 Aug, 2020 40 commits
-
-
Reda Tawfik authored
This Cl adds the controller and the model for AllPasswordsBottomSheet and sends the credentials from the bridge to the coordinator to the mediator. Adds a unit test for the controller. Bug: 1104132 Change-Id: I5a56ea9d3095cad29fed19a058805ed0121be47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317797 Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799649}
-
Xianzhu Wang authored
Only convert paint chunks if the layer bounds changed, we have invalidated raster or we are checking raster under-invalidation. Otherwise just keep the existing cc::DisplayItemList. Change-Id: I9ee584344ede6df8fb88af64b4347460389142e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363643Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799648}
-
Xianzhu Wang authored
This reverts commit 3fbd23bf. Reason for revert: Revert the temporary CL after several canary builds. Original change's description: > Temporarily disable text-on-opaque optimization > > This is to evaluate the performance improvement of the optimization in > 1 or 2 canary builds. Will revert after that. > > This disables the optimization for composited scrolling added in > crrev.com/771292 (based on the LCD-text on opaque optimization added > in crrev.com/768555). > > Bug: 1113269 > Change-Id: I20250169241d8f6d99e9bd917974aaf3fd0f675a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351400 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797498} TBR=wangxianzhu@chromium.org,pdr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1113269 Change-Id: I113d4b8b995796ccd105d61a252743bf0239f2e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363651Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799647}
-
Raymond Toy authored
In ProcessARateVectorKernel we forgot to mask v_read0 to contain the index in a valid range. v_read1 was handled correctly, and ProcessKRateVector also masked the indices. Apply the mask. Manually tested this agains the repro case from the bug and no issues occur. Previously, I could easily reproduce the issue. Added simple test case where detune overflows. Output should be zero. Bug: 1115907 Change-Id: Id7af713b935bd7cc14669630ddb1d04c3b1b2c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358593 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e90094abdc0a..69cb5514ee4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com,dullweber@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:10918587 Tbr: mcnee@google.com,dullweber@google.com Change-Id: I7f08cbdc5bbd5813861db85184a2fa506a7e6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364276Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799645}
-
Thiabaud Engelbrecht authored
This is a reland of 3558d80a, initially reviewed here: https://chromium-review.googlesource.com/c/chromium/src/+/2321400, and reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/2360121 The reverted commit was not responsible for the failure and is safe to reland, since the build was already passing by the time it was reverted. (see my comment below for details) Bug: 1109209 Change-Id: I2df2de93ca97e43044ecf27c40793274c07d9685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363396Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#799644}
-
Sebastien Marchand authored
Bug: 1111437 Change-Id: I20ed7be5fa1b15214b7db7f37527e54cbe101be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353492Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#799643}
-
Peter Kotwicz authored
BUG=None Change-Id: I9452e29c5e9c7a70a5e64cd8cbfecffa3c834bf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364074Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799642}
-
Andreea Costinas authored
Currently, if System-proxy requires credentials to authenticate to a remote proxy, it will send a request to the Browser to fetch credentials from the Network Service authentication cache. If the user didn't authenticate in the Browser yet, System-proxy will receive empty credentials. This CL changes the flow to notify the user that System-proxy requires credentials and allows the user to enter the credentials in a dedicated dialogue, without needing to go through the Browser. Bug: 1112722 Test: unittests, manually on DUT Change-Id: I0bb1e0e2d0a644b47dd022a87664cab1bb4e5205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356204Reviewed-by:
Andreea-Elena Costinas <acostinas@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#799641}
-
Nick Diego Yamane authored
Fast resize mode is set for web contents view every time tab dragging status changes for both window source and dragged browser window. Which was originally introduced as a performance optimization targeting ChromeOS' tablet mode, where both windows bounds change during the dragging session. This causes issues such as crbug.com/1114767, where the source window does not get correctly relaid out after a tab is dragged out of it into a new browser window, particularly when that tab dragging session started after a window resize or state change (eg: normal -> maximized). That said, this patch fixes it by not setting "fast resize" on Linux desktop builds. Where subtle bugs may happen, eg: tiling WMs not honoring bounds requested, etc. R=sky@chromium.org Bug: 1114767 Change-Id: Ic33fd2471fe6ddbb05af650e724106c6600319d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346795Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#799640}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I47aa52dc235f4f9f0cc63ecf32b4f3cb14fb1f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363756 Commit-Queue: Yunke Zhou <yunkez@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799639}
-
Andrei-Laurențiu Olteanu authored
Convert string from mojo handle. Create build target for mojo_utils. Change tests. Bug: b:162051831 Change-Id: I60017604fde2c55ca34165af3c5d10e16760ee8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352908Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Cr-Commit-Position: refs/heads/master@{#799638}
-
Alexander Cooper authored
Because a task is queued to call XRSession::OnFrame for any inline sessions during XRFrameProvider::ProcessScheduledFrame, it is possible for an immersive session to be created while we are waiting for the frame to be served. This creates an "interceptor" method "OnPreDispatchInlineFrame", which can ensure that there is still no immersive session when providing the frame to the XRSession. This "interceptor" method is needed, rather than simply adding the check in XRSession for two reasons: 1) It should not be the responsibility of the XRSession to verify that it should have received the frame. 2) Since the frame is being blocked, the session needs to be added back into the requesting_sessions_ list to prevent the frame loop from timing out. Fixed: 1116261 Change-Id: I61699b65ccb073f709321cbd9f812cf6931bd72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363704Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799637}
-
Jeroen Dhollander authored
Bug: b/165008609 Change-Id: I8d3c0e22b05f042d6d7506476947bfc0918c1d33 Tests: deployed manually Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360221 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799636}
-
Ian Kilpatrick authored
and LayoutTheme::AnimationRepeatIntervalForProgressBar, and moves them into LayoutProgress. There should be no behaviour change. Change-Id: I4e03085cd81810fde8f1a32f109af5a6b5861667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270862Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#799635}
-
Yunke Zhou authored
Bug: 1101318 Change-Id: I6776988895cde81963822c958cafa0d020f09404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362611Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799634}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b1eb63de..a64aed23 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6be30e9cf1370806a6312a50a96ce9069f756fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364552Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799633}
-
Nohemi Fernandez authored
TBR=yuweih@chromium.org Bug: 1117399 Change-Id: I72152e4d14ff627837edfc3ba98d2b120ca9ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362615Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#799632}
-
David Roger authored
The bubble is being simplified. This CL removes one of the avatars, and a follow-up will update the text. Screenshots with various combinations of colors and modes: https://screenshot.googleplex.com/b7edab3a-fbb3-482f-9c50-9e4704d20cc8.png https://screenshot.googleplex.com/af86cce2-0b4f-40d2-b521-4584883249a6.png https://screenshot.googleplex.com/f818aa03-62aa-4325-baef-d0ba3589c034.png https://screenshot.googleplex.com/9dace8af-7e2f-4b79-84a2-10207270509b.png Bug: 1076880 Change-Id: Ic36c42368d9820358fdb3b323b7e7dfd04fbef49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362929Reviewed-by:
Monica Basta <msalama@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799631}
-
Sigurd Schneider authored
Bug: chromium:1051466 Change-Id: If446b94c7626bc691cf456db1950e10224fd9a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323681 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#799630}
-
Justin Cohen authored
This reverts commit b05d8793. Reason for revert: Broke ios full_configs bot. See: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885 Doesn't look like this change triggered the full_config bots on try. Original change's description: > Rework generated_script handling in MB. > > It turns out the work I did on the "wrapped_*" targets in > gn_isolate_map was somewhat overlapping with the already-existing > iOS work to declare things as "generated_scripts". However, the > generated_scripts did not include test_env.py. > > So, this CL rearranges things so that the generated script will call > test_env.py, and then we can share logic between the generated_script > targets (and every target on iOS and LaCrOS) and use that as the > basis for the rest of the work going forward. > > Bug: 816629 > Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#799171} TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org Change-Id: I94597d58417f7aa76320579ca282293e6b643811 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 816629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799629}
-
Fred Mello authored
https://docs.google.com/document/d/1EW90R9jfRtBKZA8VHV2_EBqS1okLNmUxrbboCmVpNOk Bug: 1112872 Change-Id: Ie8966937049ae4d2c36b1e81e274df6b1260493b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364188 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#799628}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0795384a7997..e60f72f6801e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1695e9c87cb5b54de3972c2817422308dce998d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363973Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799627}
-
Frédéric Wang authored
This CL adds "cabal", "dat", "did", "dweb", "ethereum", "hyper", "ipfs", "ipns", "ssb" to the safelist of navigator.registerProtocolHandler. Chrome status entry is [1] and feature has been discussed in [2] [3] [4] [5]. Currently, the WHATWG and WPT changes are pending on the Mozilla position review [6]. [1] https://www.chromestatus.com/feature/4776602869170176 [2] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/29sFh4tTdcs/K4XroilVBAAJ [3] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/7nHTRUP1EGY [4] https://github.com/whatwg/html/issues/3935 [5] https://github.com/whatwg/html/issues/3998 [6] https://github.com/mozilla/standards-positions/issues/339 Bug: 651311 Change-Id: Iba45706e985015cf86bd80adef990abd0980a638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153064Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#799626}
-
Yi Gu authored
The SMSReceiver API has been renamed to WebOTP in specification [1]. We currently use SMSReceiverStart in Blink.UseCounter.Features to capture the API usage. To better align with the spec we should update the name. [1] https://github.com/WICG/web-otp Bug: 1117238 Change-Id: I982e5abf499ea0dc575163092769040d927a262f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360474Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799625}
-
Maksim Moskvitin authored
This CL adds high-level trusted vault key rotation logic. Once vault keys are marked as stale, following FetchKeys() call will trigger attempt to download fresh keys from the vault server. This makes StandaloneTrustedVaultBackend::FetchKeys() asynchronous, but result is populated immediately if preconditions aren't met (e.g. device isn't registered, device somehow misses old vault keys or current account isn't syncing one). StandaloneTrustedVaultBackend allows only one ongoing request to the vault server and only one ongoing fetch keys attempt at the time (following TrustedVaultClient::FetchKeys() documentation). In case of abandoning download keys request, ongoing fetch keys fulfilled immediately. Bug: 1102340 Change-Id: I2413176f03b07e67a72315a549add16f5e328678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340977 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799624}
-
Mark Brand authored
This change cleans up the CodeCacheHost fuzzer, moving the per-testcase code into the CodeCacheHostTestcase object and removing CodeCacheHostFuzzerContext since this was redundant. Bug: 1076336 Change-Id: I8736106edadb4a88c9d46a007ed5404fec6d4d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329571 Commit-Queue: Mark Brand <markbrand@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799623}
-
Anatoliy Potapchuk authored
To organize the ownership better, let's move these files into a new folder -- chromeos/login/app_mode/. Change-Id: Iae18edd7bba7fb6d762e26a320db4597524a6a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362647 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799622}
-
Roman Aleksandrov authored
Add new update progress calculation which is based on total time left expectation. New update progress is gradually changed during the update. Bug: 1117036 Change-Id: I11478e06af64137ebc7643495d198537d1031657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358681Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#799621}
-
Greg Daniel authored
Skia is trying to remove the use of ctors and instead just have clients set the values on the structs they need. Change-Id: I7a934b256068bbbfcffab06490f1178cfbd2fca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363712Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Greg Daniel <egdaniel@google.com> Cr-Commit-Position: refs/heads/master@{#799620}
-
Nicolas Ouellet-Payeur authored
Following the change that adds the grouping.xml check: https://chromium-review.googlesource.com/c/chromium/src/+/2303313 Also updates grouping.xml to make sure the test passes on CQ. Bug: 1107860 Change-Id: Icb4eea6540c6ddeb95dcd5efa9ea86ccec2afc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362988Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#799619}
-
Fred Mello authored
The Clank team is reviewing the ownership of all `/android` directories and adding/updating OWNERS as part of an effort to normalize code health metrics across different data sources. https://docs.google.com/document/d/1IYe0TIGAsJl-gZL39l31a2zUa_YasmcyfOIC-zllU_s Bug: 1112872 Change-Id: I71fedd33bb14cb4a449db71c253bd48f23c20097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362632 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799618}
-
Marijn Kruisselbrink authored
Implements the changes from https://github.com/WICG/native-file-system/pull/219. Change-Id: Ic785f0362b5c73a843145c5384f063cf24770b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360597 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799617}
-
Peter Kasting authored
* Shorten code * Use const more * Inline temps * Use safe conversions for float -> int * TimeDelta::InMicrosecondsF() returns a double Bug: none Change-Id: I798ee7107bcbda863f95ee7921c4ddfd76768183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359008 Commit-Queue: Cait Phillips <caitkp@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799616}
-
Elly Fong-Jones authored
This infobar will be used (via field trials) to display updated info about current OS support and provide users with a link to more info. The infobar receives both activation info (which configs to show for) and the actual strings to display via field trials, so it can be updated for deployed Chrome instances without an update cycle. This change adds: * The infobar itself * A feature MacSystemInfobar that controls whether the feature is enabled and if so which configs (Arm or Rosetta) it's enabled in * A switch --force-mac-system-infobar which causes the infobar to act as though it was running on a specified system, for both manual and automatic tests * A variety of IDS_MAC_SYSTEM_INFOBAR_* constants to customize the infobar's message, link, and link text * Unit tests for the logic to interpret the feature and the enable/disable configs Bug: 1116578 Change-Id: Ie7fd6e772a0112a17e794d1b8fcb009c57ebed4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360479 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799615}
-
Matthias Körber authored
Although not rolled out yet, some tests fail when structured names are globally enabled. This CL proactively fixes most remaining issues. Change-Id: I0f0a54612be8118cf472987cd022b702416b21be Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362734 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#799614}
-
Alexander Dunaev authored
The functionality had been available for non-Ozone path. This CL moves the necessary enum and utility function to the component so Ozone can use it. Bug: 1097007 Change-Id: Id7070dc7a87e4efc36d3611f072b89c4ce9e4da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359040Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#799613}
-
Dominique Fauteux-Chapleau authored
Turns out the fix in https://crrev.com/c/2346914 doesn't work. This adresses the problem at the root cause: RenderWidgetHostViewAura::OnWindowFocused only ignores gaining focus but not losing it, meaning clicking on the page while the scanning dialog is open loses focus but the page doesn't get it back from calling Focus() in WebContentsImpl::IsClipboardPasteAllowedWrapperCallback since host()->IsIgnoringInputEvents() still returns true at that point. The fix is to not lose focus in the first place by moving the IsIgnoringInputEvents call at the top of OnWindowFocused. Bug: 1100902 Change-Id: I0cfc0d79436514eac50a81df803abac10f71f430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363692Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#799612}
-
Stephen Lin authored
R=pkasting@chromium.org Bug: 1117548 Change-Id: I9cf42b1e3c866f51a36feceb6186929c92a36ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362975 Auto-Submit: Stephen Lin <stephenlin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799611}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I855f54afdbf00736904f83fdba074473f0b7b057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362346Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799610}
-