GitLab

* All Mac bots use Mac-10.13 as os.
* Android device bots use id:<bot name> as dimensions

Bug: 840631
Change-Id: I0ea523e0b4f1f91f20c7f32333ec2db6ab486b03
Reviewed-on: https://chromium-review.googlesource.com/1100070Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567055}

Change-Id: Ia31b9004b57f6dff97f93d2280e3b9a23ca6919c
Reviewed-on: https://chromium-review.googlesource.com/1100079Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567054}

There's updated spec that moves the position of the current wallpaper
info bar to the top of the image list.

https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8

Bug: 824453
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I414fb92f75f5b2ffa1b6b732c9be577ed4838107
Reviewed-on: https://chromium-review.googlesource.com/1083138Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567053}

https://webrtc.googlesource.com/src.git/+log/789221f1101a..aeb0a6475bcc


git log 789221f1101a..aeb0a6475bcc --date=short --no-merges --format='%ad %ae %s'
2018-06-13 peah@webrtc.org AEC3: Increase the range of reported echo path delay metrics
2018-06-13 magjed@webrtc.org Android: Fix VideoTrack behavior for adding/removing VideoSinks
2018-06-13 nisse@webrtc.org Replace all use of rtc::Pathname in generator_unittest.cc.
2018-06-13 danilchap@webrtc.org Introduce list of fields to put into codec agnostic descriptor
2018-06-13 devicentepena@webrtc.org AEC3: Changes to how the reverberation decay is applied.
2018-06-13 jonasolsson@webrtc.org Remove "webrtc_rtp" traces.
2018-06-13 yura.yaroshevich@gmail.com Add ow2_asm license


Created with:
  gclient setdep -r src/third_party/webrtc@aeb0a6475bcc

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:850538,chromium:852257
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I96d3ed7b7c4bd9a705edda10c15a74623ce6505c
Reviewed-on: https://chromium-review.googlesource.com/1099915Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567052}

The code now provides as a run action command line argument the Chrome
app guid registered with Omaha, as returned by the configurator, like this:

--appguid={8A69D345-D564-463c-AFF1-A69D9E530F96}

Bug: 687231
Change-Id: I22125e434ffbd4e98de9c3373dcb54ac7f98799a
Reviewed-on: https://chromium-review.googlesource.com/1100088Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567051}

This CL hides the radio button when there is only default download
directory option.

Also tweaks the layout a little bit, so the radio button and the text
can align with the "Download location" title in the preference UI.


Bug: 850586
Change-Id: Id686ee8e8d06bd477606f62741386095fa11c31c
Reviewed-on: https://chromium-review.googlesource.com/1098296Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567050}

Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70

Bug: 806109
Change-Id: I3dfc9477e6cd79358656119628ba660d36bf7e70
Reviewed-on: https://chromium-review.googlesource.com/1098030Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567049}

This CL changes the rich layout images to be centered in a box to the
left of the text lines. This allows for answer images and entity images
to be different sizes without doing a lot of less readable math.

Bug: 798631
Change-Id: I882305ca09353266f02115446f481bff00b00e12
Reviewed-on: https://chromium-review.googlesource.com/1094263Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567048}

This change aims to reduce code duplication in the implementations of
BluetoothTest::SimulateLowEnergyDevice for BlueZ and Windows. In order
to do so it adds a utility struct and method to BluetoothTestBase, that
implementations of SimulateLowEnergyDevice make use of.

Bug: 821766
Change-Id: I5283a1eb55e50d68dce2c9810994cf6c4ed80212
Reviewed-on: https://chromium-review.googlesource.com/1096675Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567047}

crrev.com/c/1090151 moved the null-pointer-arithmetic warning too far back.
It's supported by Xcode 10, but not Xcode 9.3.

Bug: 850333, 843234
Change-Id: I21935c592ca7b3ba75cb6fc7b7c0686564dd3ec4
Reviewed-on: https://chromium-review.googlesource.com/1099649Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567046}

Previously, if a clip was between two transforms, and the clip result
was not tight, and the combination of the two transforms didn't change,
we missed raster invalidation for the changed effective clip.

Now check for change of LocalTransformSpace for clip and effect nodes.

Bug: 848782
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1b60ecc2bc79cba69c667e188053b024de670361
Reviewed-on: https://chromium-review.googlesource.com/1094202
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567045}

In the BottomContainer, in order to handle sitting on top of multiple
different UIs, the setTranslationY function is overridden to apply
offsets independently of the view's original translation. This was
broken because the initialization logic also attempted to apply this
offset. This patch updates the incorrect call in the init function
and updates the math in setTranslationY.

Bug: 851182
Change-Id: Id4955aed45b91cd55a3baf4c70f8087a65123f24
Reviewed-on: https://chromium-review.googlesource.com/1099772Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567044}

Gesture pinch events have |needs_wheel_event| and |zoom_disabled| as
browser side implementation details. There is no need to include these
fields when sending the event to the renderer.

Bug: 787924
Change-Id: I2a2e4f9376f384801bb2ca73b5a0e20d589e92e1
Reviewed-on: https://chromium-review.googlesource.com/1087433Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567043}

Android does not support partial swaps. Instead, when an empty swap
is requested we're supposed to commit overlay planes.

Bug: 850546
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: If77156732b4f43872855a8ad676c42a5e9842678
Reviewed-on: https://chromium-review.googlesource.com/1099266Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567042}

Move CastCommandLineHelper.java from internal to upstream and let CastBrowserHelper use it to initialize command line.

Bug: b/110021629

Test: cast_shell_junit_tests

Change-Id: I9940e95e26be072bc1762e60f6c6ae541277d34c
Reviewed-on: https://chromium-review.googlesource.com/1097548Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Cr-Commit-Position: refs/heads/master@{#567041}

https://pdfium.googlesource.com/pdfium.git/+log/4c48b107c6d1..571053a44f87


git log 4c48b107c6d1..571053a44f87 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 hnakashima@chromium.org Mark modified content streams as dirty in CPDF_PageObjectHolder.
2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from cpdf_renderstatus.cpp
2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from cpdf_colorspace.cpp
2018-06-13 npm@chromium.org Remove almost all usages of CFX_FixedBufGrow from cpdf_dibsource.cpp
2018-06-13 npm@chromium.org Make CJBig2_Context::GetHuffmanTable return const
2018-06-13 npm@chromium.org Remove CFX_FixedBufGrow from fx_codec_icc.cpp
2018-06-13 art-snake@yandex-team.ru Merge the offset calculation logic within  CPDF_HintsTable.


Created with:
  gclient setdep -r src/third_party/pdfium@571053a44f87

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I28c83054cdeb3c8977f25384a0a9fdcfaba05834
Reviewed-on: https://chromium-review.googlesource.com/1099815Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567040}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e09b6845cf72..31d539486159


git log e09b6845cf72..31d539486159 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@31d539486159

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I36cd8ade79f1655bde894b6200092132072e55a8
Reviewed-on: https://chromium-review.googlesource.com/1099537Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567039}

This reverts commit 8dbc0c82.

Reason for revert: broke https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/32416

Original change's description:
> Remove absolute paths from build files
> 
> This CL removes all absolute paths to src and all usages of the out directory
> name from all ninja files on most Linux builds.
> 
> This means it's possible to mount your src directory at different locations and
> still have incremental builds work.  You can also rename your out directory.
> 
> BUG=None
> R=​dpranke,caitkp,rockot
> 
> Change-Id: I5ff5b0d2d60110755dde64e876c7f1a09d814b1a
> Reviewed-on: https://chromium-review.googlesource.com/1091457
> Reviewed-by: Cait Phillips <caitkp@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567020}

TBR=caitkp@chromium.org,rockot@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org

Change-Id: Iec959adc2e8c82dd191f382c0cfb197aea406fc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/1099979Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567038}

Bug: 852512
Change-Id: Ie118dcafd7dd46f62f03dbbd95091db24cb7ef26
Reviewed-on: https://chromium-review.googlesource.com/1099646Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567037}

Move the proto parsing utilities into the WeeklyTime classes to make
them reusable by policies that use the WeeklyTime protos. Added unit
tests for the proto parsing.

BUG=chromium:849506
TEST=WeeklyTimeInterval and WeeklyTime unit tests

Change-Id: Ic6b327e9b75f6bf9f2c1d1d1a949ed30ec8f18f7
Reviewed-on: https://chromium-review.googlesource.com/1097698
Commit-Queue: Adolfo Higueros <adokar@google.com>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567036}

password_manager_test_base includes chrome_password_manager_client but
wasn't previously depending on it, meaning that the latter's mojo
dependencies sometimes weren't built in time.

Change-Id: I6b40d771d5744bd3e5975e47857e88b974a1d43a
Reviewed-on: https://chromium-review.googlesource.com/1099493Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567035}

Failing on Mac10.10.

TBR=thakis@chromium.org

Change-Id: I906d7ffe323f10630a21ec93f953b40c33fb0182
Bug: 852536
Reviewed-on: https://chromium-review.googlesource.com/1099715Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567034}

Implements GetShares using an in-memory map to simulate a D-Bus call to
SmbProvider daemon

Bug: 757625
Change-Id: Icb655328ac0f4b766ecd6a05cb2d6439c15d9ac0
Reviewed-on: https://chromium-review.googlesource.com/1089851
Commit-Queue: Allen Vicencio <allenvic@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567033}

An infinite (or actually kTableMaxWidth, which is 1000000px) max logical
width doesn't work well inside flexboxes, because
LayoutFlexibleBox::ComputeInnerFlexBaseSizeForChild() will use a child's
MaxPreferredLogicalWidth() as main axis extent if it's auto.

Grid containers have similar issues with such tables, so avoid it for
them as well.

Don't apply this to deprecated flexbox, as that would cause two tests
failures:
* fast/block/block-size-integer-overflow.html
* fast/deprecated-flexbox/box-size-integer-overflow.html

Bug: 850566
Change-Id: I9984459801ac229575e8177a9d683088e723db6c
Reviewed-on: https://chromium-review.googlesource.com/1095220
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#567032}

Bug: 829272
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I79f0be1b2c5751cf62a5c4cfed1dad30fe1f6358
Reviewed-on: https://chromium-review.googlesource.com/1096285
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567031}

This CL fixes two bugs with background-attachment:fixed computation:

1. Since CL 827671 we switch root layer in PaintInfo whenever the
current transform node changes. This has a side effect that the painting
root layer is no longer guaranteed to be a containing block ancestor of
the current layout object, and AccumulatedScrollOffsetForFixedBackground()
may skip over the painting root all the way to the root. This CL adds
the skipping check to ensure we only collect scroll offsets up to the
painting root.

2. FixedAttachmentPositioningArea() converts the viewport rect to the
space of the current paint context. Prior to SPv175 the border box space
of the painting root is always equivalent to the space of the current
paint context, so FixedAttachmentPositioningArea() did just that. In
SPv175 the painting root may not always create a paint offset
translation in case of a squashed layer, thus can induce an offset from
its transform node. This CL ensures the paint offset taken into account.

BUG=529963,849854

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib2f84a619235ab4ec6a9bfc695b57aae9d41b808
Reviewed-on: https://chromium-review.googlesource.com/1098313
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567030}

Using mixins

Bug: 840631
Change-Id: I3f71eeb780897338bc6137594e8a0c76b77d6538
Reviewed-on: https://chromium-review.googlesource.com/1099969Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567029}

iOS 12.0 introduced "Unable to build chain to root certificate." error.
This error is mapped to CERT_STATUS_INVALID and CERT_STATUS_AUTHORITY_INVALID.

Bug: 843236, 852534
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I90e4f9f97084c2ce06d4560b7e2d695f9b5454ae
Reviewed-on: https://chromium-review.googlesource.com/1094700
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567028}

Only a few WebUI pages need eval() and Function(). Explicitly allow
those functions on such pages, instead of having it as the default
for all WebUI pages.

Specifically those pages are:

chrome://appcache-internals
chrome://components
chrome://conflicts
chrome://domain-reliability-internals
chrome://download-internals
crhome://dummyurl (only exists in tests)
chrome://flags
chrome://flash
chrome://gpu
chrome://indexeddb-internals
chrome://invalidations
chrome://nacl
chrome://net-internals
chrome://ntp-tiles-internals
chrome://serviceworker-internals
chrome://signin-internals
chrome://snippets-internals
chrome://supervised-user-internals
chrome://sync-internals
chrome://system

which either use third_party/jstemplate/ in prod, or use Mock4JS during testing
causing them to depend on eval/Function.

Note that this CL does not affect iOS WebUI, since it currently provides no
mechanism for overriding CSP for certain pages.

Bug: 525224
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iaa3cbbca52a35dbd60e4d6fa42c5f324869859d9
Reviewed-on: https://chromium-review.googlesource.com/1065497
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567027}

Credit card assets already have a border, so adding a solid border
around the icon on the UI is not needed.

Bug: 852379
Change-Id: Ifb11db8a27e4914b9c7f373ae4bc35d2780358b2
Reviewed-on: https://chromium-review.googlesource.com/1099760Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567026}

Without the label, screen readers just say "button".
Please advise on how to internationalize this.

R=keishi@chromium.org

Bug: 835365
Change-Id: I9fc4586df9d69387470b6c96313fb1eabdc66ab5
Tested: manually with input type=date
Reviewed-on: https://chromium-review.googlesource.com/1094305Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567025}

- Collect DOM storages from all targets.
- Instantiate InspectorDOMStorage agent for local roots, make
  it work with InspectedFrames.
- Add a test which dumps storage security origins.
- Do some origin checks on the frontend to avoid listing
  "opaque" security origins which do not support storage.
- Check storage capabilities on the backend to avoid
  crasing renderer later.

Bug: 850978, 844377
Change-Id: Ib4e2b444473638d896eb716fb7d9c587f5560335
Reviewed-on: https://chromium-review.googlesource.com/1096283
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567024}

https://boringssl.googlesource.com/boringssl/+log/5267ef7b4aa6385c0351ae10ce3092828cca4909..6ff2ba80b758025fdb137d9357dcbba0a9c04dbf

BUG=none

Change-Id: I0ed82f0919a02f8e8f57f67ff4fbdef8ea74f998
Reviewed-on: https://chromium-review.googlesource.com/1099422Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567023}

R=dpranke@chromium.org

Bug: 831171
Change-Id: I3e0614d5cdd8fcfc4e7377c4865e4b8bb9deafda
Reviewed-on: https://chromium-review.googlesource.com/1095614Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567022}

In jumbo experiments in chrome/browser/ui, one of the problems
is that there are many kBackgroundColor variables in anonymous
namespaces that become the same anonymous namespaces in jumbo.

This patch gives those constants unique names, matching their
individual use.

Bug: 773275
Change-Id: I8746a88a32f64a0645fd88e850e39d22bc635e19
Reviewed-on: https://chromium-review.googlesource.com/1078814
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567021}

This CL removes all absolute paths to src and all usages of the out directory
name from all ninja files on most Linux builds.

This means it's possible to mount your src directory at different locations and
still have incremental builds work.  You can also rename your out directory.

BUG=None
R=dpranke,caitkp,rockot

Change-Id: I5ff5b0d2d60110755dde64e876c7f1a09d814b1a
Reviewed-on: https://chromium-review.googlesource.com/1091457Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567020}

Captions: Use Enable/Control instead of Enables/Controls for consistency.
Description: Use enabled/disabled instead of "set to true" and "set to false".

Bug: 834939
Change-Id: Ie6552e87a9977046164874e981dde8e0725b1b6c
Reviewed-on: https://chromium-review.googlesource.com/1088872
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567019}

We can do better than just dropping the DB, by dropping just the older
versions of the duplicate cookie --- this is how M65 would behave when
loading the store, so it preserves old behavior.

This is probably too late for Chrome, but may help other embedders.

Bug: 835990
Change-Id: I25bf87d46574346a47c05b35152fa3c42f9aa7a9
Reviewed-on: https://chromium-review.googlesource.com/1097204Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567018}

//extensions/common/api/schema.gni defines extensions_api_uncompiled_sources
During review, this variable was added to the common build file, but the error
only occurs for clean builds, otherwise you would get a working build with flaky
runtime behaviour

The compiler attempts to find the common subdir between
chromecast/common/extensions_api and extensions/common/api and puts
the generated file in the root

Merge-With: eureka-internal/171973
Bug: 852454
Test: Local clean build works
Change-Id: Ic18a4a94c8c52b19a33750772fe855ce486eeec8
Reviewed-on: https://chromium-review.googlesource.com/1099373
Commit-Queue: Albert Chaulk <achaulk@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567017}

This allows compilers targeting the MS ABI to select the correct
inheritance model for the member function pointer types ReaderFactory
and WriterFactory using the complete type of Disassembler. It will
allow us to enable the new Clang flag -fcomplete-member-pointers
globally.

Bug: 847724
Change-Id: Iead5fd97da5f67c336d8904a7a305a34df37065b
Reviewed-on: https://chromium-review.googlesource.com/1098470
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567016}