GitLab

BUG=440843

Review URL: https://codereview.chromium.org/1015933004

Cr-Commit-Position: refs/heads/master@{#321823}

Add a field trial, currently disabled (i.e., 100% control group) for allowing
users to report abuse on extension uninstallation.

BUG=441377

Review URL: https://codereview.chromium.org/1025613006

Cr-Commit-Position: refs/heads/master@{#321822}

This fixes flickering when switching the X11 input focus between non-chrome
windows, but having the pointer be above the chrome window (you need to use
keyboard shortcuts to switch focus to trigger this).

The reason for the flickering is that OnActiveWindowChanged() is called with
state ACTIVE, even though the window was not activated. Before my change, the
code called OnActiveWindowChanged() even for FocusIn/FocusOut events with
mode==NotifyGrab, which is not intended. For details on the events, see:
http://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html

Review URL: https://codereview.chromium.org/1027883003

Cr-Commit-Position: refs/heads/master@{#321821}

This removes the ability to pass in a custom CookieStore to a URLRequest. It's
a small change to net/url_request which then balloons to everything in the
project that ever makes a URLRequest.

This reverts the rest of https://codereview.chromium.org/188693003 (and then
does a whole lot more because URLRequest constructors were unified recently to
always require passing in the fourth argument).

BUG=457344

Review URL: https://codereview.chromium.org/1003953008

Cr-Commit-Position: refs/heads/master@{#321820}

The default Robolectric testrunner has some behaviors we want to override. By
default the Robolectric testrunner will download the Robolectric runtime
dependencies from the Maven central reposoitory. In addition, Robolectric won't
run at all if the API level in the AndroidManifest isn't officially supported by
Robolectric which isn't what we want.

BUG=448030

Review URL: https://codereview.chromium.org/942083003

Cr-Commit-Position: refs/heads/master@{#321819}

PagePopups used for <input type=date>, <datalist>, etc. should have same input
grab behavior as <select> popup.
Also, <select> popup is going to be switched to blink::WebPopupTypePage.

BUG=346582

Review URL: https://codereview.chromium.org/1028893002

Cr-Commit-Position: refs/heads/master@{#321818}

This pulls in the following Native Client changes:

fc4d498: (dpranke@chromium.org) Fix a stray reference to ${os} in build/toolchain/nacl/BUILD.gn.
5076f66: (mtrofin@chromium.org) Use the newly introduced CMake LLVM option, LLVM_INSTALL_UTILS, to install binaries such as FileCheck, as part of the install target.
97cf946: (hidehiko@chromium.org) Non-SFI mode: Implement clone() syscall wrapper.
8171867: (jvoung@chromium.org) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS
9e28d08: (jfb@chromium.org) PNaCl: Update LLVM and Clang revisions in pnacl/COMPONENT_REVISIONS
cf674f2: (petarj@mips.com) Do not print nan sign for results with undefined nan sign
75c402b: (shinyak@chromium.org) Check object file size before archiving.
cc3597c: (hidehiko@chromium.org) Non-SFI mode: Implement {get,set}rlimit() syscall wrappers.

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/cc78fa093218f9a9a5e576002e197e17da379023..cc3597c9c13978079ef85a31d78dc4bf7f18000c

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1027283002

Cr-Commit-Position: refs/heads/master@{#321817}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c4eeb52..bda107a

TBR=dglazkov@chromium.org,alph@chromium.org

Review URL: https://codereview.chromium.org/1029603003

Cr-Commit-Position: refs/heads/master@{#321816}

BUG=469763

Review URL: https://codereview.chromium.org/1022983003

Cr-Commit-Position: refs/heads/master@{#321815}

BUG=467165

Review URL: https://codereview.chromium.org/1026803003

Cr-Commit-Position: refs/heads/master@{#321814}

Since most most gn users come from gyp and that apostrophe
works as a string delimiter in both gyp and python, it is pretty common
that they use an apostrophe (') instead of a double one (").

So lets try to give them a more helpful error message that could save people
some time the first time.

BUG=469097
TEST=edit any BUILD.gn and change any " by '. regenerate the ninja files
by running gn gen out-gn. See the error message.
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/1024333002

Cr-Commit-Position: refs/heads/master@{#321813}

BUG=457091

Review URL: https://codereview.chromium.org/1023213002

Cr-Commit-Position: refs/heads/master@{#321812}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dc3d968..b8a1d30

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1019183003

Cr-Commit-Position: refs/heads/master@{#321811}

Review URL: https://codereview.chromium.org/1027893002

Cr-Commit-Position: refs/heads/master@{#321810}

R=phajdan.jr@chromium.org
BUG=468335

Review URL: https://codereview.chromium.org/1020243003

Cr-Commit-Position: refs/heads/master@{#321809}

Users must now write "defined(foo) && defined(foo.bar)" if they want
the old semantics.  No Chromium BUILD.gn files were harmed in the
making of this CL.

Review URL: https://codereview.chromium.org/1025153002

Cr-Commit-Position: refs/heads/master@{#321808}

Chromium side of the implementation of tracking profile stats (number
of profiles, number of signed in profiles) through the Omaha channel
for Mac.

Was reverted: https://codereview.chromium.org/974423002

BUG=409895
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/1024533002

Cr-Commit-Position: refs/heads/master@{#321807}

Revert of Instrumented libraries: add a target for pre-built libraries. (patchset #2 id:20001 of https://codereview.chromium.org/1017053003/)

Reason for revert:
Broke tree.

Original issue's description:
> Instrumented libraries: add a target for pre-built libraries.
>
> With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now
> unpacked from archive and placed into output dir.
>
> BUG=462636
> R=glider@chromium.org
> TBR=thakis@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/744256e2f3933feaa05c967541afac36825056fa
> Cr-Commit-Position: refs/heads/master@{#321804}

TBR=glider@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462636

Review URL: https://codereview.chromium.org/1029103003

Cr-Commit-Position: refs/heads/master@{#321806}

BUG=437508

Review URL: https://codereview.chromium.org/1022463002

Cr-Commit-Position: refs/heads/master@{#321805}

With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now
unpacked from archive and placed into output dir.

BUG=462636
R=glider@chromium.org
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1017053003

Cr-Commit-Position: refs/heads/master@{#321804}

This change give the SandboxedZipAnalyzer the power to extract archived
binaries into a temporary file and extract features from them.

BUG=462584

Review URL: https://codereview.chromium.org/999003003

Cr-Commit-Position: refs/heads/master@{#321803}

Update a path following a recent change in directory structure.

BUG=none
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1018043007

Cr-Commit-Position: refs/heads/master@{#321802}

BUG=469593

Review URL: https://codereview.chromium.org/1030553002

Cr-Commit-Position: refs/heads/master@{#321801}

g_wallpaper_manager was never destroyed before the fix. It should explicitly be destroyed.

BUG=171694

Review URL: https://codereview.chromium.org/1010443003

Cr-Commit-Position: refs/heads/master@{#321800}

This roll picks the fixes for the unit test failues which was causing
irritating "Aw Snap!" crash of unit test renderer process in the latest
ToT of chromium and trace-viewer repos.

BUG=None
R=nduca,dsinclair,qyearsley
TESTS=None

Review URL: https://codereview.chromium.org/1025953002

Cr-Commit-Position: refs/heads/master@{#321799}

BUG=469591

Review URL: https://codereview.chromium.org/1031683002

Cr-Commit-Position: refs/heads/master@{#321798}

BUG=465855

Review URL: https://codereview.chromium.org/1023823002

Cr-Commit-Position: refs/heads/master@{#321797}

TEST=*ImportControllerTest
TBR=cpu  // for strings changes

Review URL: https://codereview.chromium.org/1022213002

Cr-Commit-Position: refs/heads/master@{#321796}

The bubble itself steals no focus. It's very important to show it for the new Credential Manager API. The user can be presented with the account chooser or the auto sign-in toast. The auto sign-in toast should stay visible while the browser isn't activated. Then it can be closed by timeout.

BUG=468281

Review URL: https://codereview.chromium.org/1016003002

Cr-Commit-Position: refs/heads/master@{#321795}

BUG=469249

TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/1027833006

Cr-Commit-Position: refs/heads/master@{#321794}

instead of listening to prefs::kGoogleServicesLastUsername

Review URL: https://codereview.chromium.org/1015013003

Cr-Commit-Position: refs/heads/master@{#321793}

TEST=
1. Launch chrome, create two users and Relaunch browser in Win 8 mode from wrench menu.
2. Right click on avatar bubble at top right corner and observe.
3. Fast User Switcher should be shown.

BUG=467895

Review URL: https://codereview.chromium.org/1011233002

Cr-Commit-Position: refs/heads/master@{#321792}

BUG=461032

Review URL: https://codereview.chromium.org/1011393004

Cr-Commit-Position: refs/heads/master@{#321791}

BUG=455409
TEST=run content_browsertests --gtest_filter=OutOfProcessPPAPITest.VideoEncoder

Review URL: https://codereview.chromium.org/956893002

Cr-Commit-Position: refs/heads/master@{#321790}

Revert of Change default code flag to NewAvatarMenu. (patchset #29 id:580001 of https://codereview.chromium.org/845373002/)

Reason for revert:
Broke Linux Valgrind tests on the waterfall. I'll need to do more testing / work on this CL before it's ready to land.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/34330

Original issue's description:
> Change default code flag to NewAvatarMenu. Flags or Finch Configs still take priority, but all else being equal we should direct the user to NewAvatarMenu.
>
> This CL fixes a few issues that arise when the flag's on:
> - Missing alt text on chrome://settings
> - Unit tests for old components (OldAvatarMenu) need to force that state
> - The ProfileAvatarDownloader works automatically with NewAvatarMenu on - this needs to be accounted for so it doesn't leave images hanging around.
> - BookmarkBubbleSigninDelegate now triggers the User Menu, not a Sign in tab, on Desktop. (note this can't be easily tested in Cocoa)
>
> BUG=287883
>
> Committed: https://crrev.com/e4d285b050ab3429f7d937fde6234fcba07a360e
> Cr-Commit-Position: refs/heads/master@{#321770}

TBR=rogerta@chromium.org,shess@chromium.org,dbeam@chromium.org,noms@chromium.org,sky@chromium.org,mukai@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=287883

Review URL: https://codereview.chromium.org/1020863007

Cr-Commit-Position: refs/heads/master@{#321789}

This CL introduces a CC texture compression API and adds an ETC1
encoder that will be used for compressing tile textures.

BUG=434699

Review URL: https://codereview.chromium.org/1015373003

Cr-Commit-Position: refs/heads/master@{#321788}

This change converts between DIP and pixels in a few places that were
not converted before, but are necessary for drag & drop of tabs to work
correctly.

R=sadrul@chromium.org
BUG=458804,143619

Review URL: https://codereview.chromium.org/1003863005

Cr-Commit-Position: refs/heads/master@{#321787}

Sort fixed_keys[] properly and improve the name of the
crash keys to make it easy for someone not familiar
with discardable memory to understand what they are.

Also use TRACE_COUNTER1 instead of TRACE_COUNTER_ID1
for TotalDiscardableMemoryUsage as there should never
be more than one of these per process.

BUG=

Review URL: https://codereview.chromium.org/1028853002

Cr-Commit-Position: refs/heads/master@{#321786}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/3e5c2b1..dc3d968

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1025283002

Cr-Commit-Position: refs/heads/master@{#321785}

BUG=469260
TEST=Site Isolation FYI bots go green

Review URL: https://codereview.chromium.org/1025613005

Cr-Commit-Position: refs/heads/master@{#321784}