- 07 Oct, 2020 11 commits
-
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie1a222cd154985d67aadca185de4c6c016be2851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814471}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //native_client_sdk. R=sbc@chromium.org Bug: 1113033 Change-Id: I6624ab46edbee706de8f0fcbab959b366e12fa40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454495 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by:
Sam Clegg <sbc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814470}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: I8972870aab6d8bd87c8b4233c0f53240bc904aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2445481 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814469}
-
Brandon Wylie authored
Only used like a regular Android activity. Bug: 1123209 Change-Id: I3d68e4a3b9e984fa565249c40f03ea239c850b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453797 Auto-Submit: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#814468}
-
Sergey Ulanov authored
web_tests use headless windows, i.e. they create windows, but never call Show(). The tests expect the window to report the initial size specified in PlatformWindowInitProperties.bounds passed during initialization. ScenicWindow wasn't using PlatformWindowInitProperties.bounds, as result the compositor wasn't running so the pixel tests were timing out. This change updates ScenicWindow to report the size requested by the caller until Show() is called. Bug: 1067477 Change-Id: Ieaf0757b0a90e3582d4ffd8fadb2db73e9ddd076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446539Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814467}
-
Sean Topping authored
Including the WebContents header fails when a target doesn't depend on content. Instead, we should only forward declare these classes in the Cast web primary interfaces (CastWebContents, CastWebView, CastContentWindow). Merge-With: eureka-internal/461423 Bug: None Test: CQ Change-Id: Id18c669c7d39f4ed847a8c4970f5d6c8847a234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454370Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#814466}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010060700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/GbpR7xJNVich1jbMRLPopW3O8mPtdmhWFHDEbcl4H2cC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/169630668 Tbr: media-app@grotations.appspotmail.com Change-Id: I558e064a775b89b82b538a6290bab975ae6c2c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#814465}
-
David Bertoni authored
The SelfUninstall and SelfUninstallNoPermissions test are flaky when run by a SW-based extension. This CL moves them to the base class, so they are only run as legacy extensions. Bug: 1132581 Change-Id: Iec1fce201f58d833b7d9b124e658d0ae0219db1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446836Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#814464}
-
Joel Hockey authored
In Chrome OS, GetDefaultBrowser() runs in ChromeAppDelegate::NewWindowContentsDelegate::OpenURLFromTab() where it will either navigate internally when it detects that the current running chrome is the system default, else it calls platform_util::OpenExternal(). The current implementation of CrOS OpenExternal() does an internal navigation, however as part of b/168506505, we are changing this to use guest_os::Launch() to launch VM apps. Since chrome is always the default browser in Chrome OS, we can change GetDefaultBrowser() to return IS_DEFAULT, which ensures OpenExternal() is no longer called for internal navigations and it can be used solely to launch VM apps. Bug: b/168506505 Bug: 1132535 Change-Id: If9ba4d065c9b01b1c9afd180b833a04f50c5cebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454769 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#814463}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //ipc. R=tsepez@chromium.org Bug: 1113033 Change-Id: I94e0ae5d58bec857d39a95c1c4d580466cc14bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453874 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#814462}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //gin. R=jbroman@chromium.org Bug: 1113033 Change-Id: I45578bd0888045471f4e8e4edcb6b65b4138ed8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453753 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#814461}
-
- 06 Oct, 2020 29 commits
-
-
Takumi Fujimoto authored
Establish a strong virtual connection in the following cases: - Launching a session without the invisibleSender field set in its presentation URL - Making a connection to receiver-0 Otherwise create an invisible virtual connection, including cases where we're requesting media status to show in the global media controls. This is consistent with the behavior in virtual_connection_manager.js and presentation_url.js in the component extension. Bug: 1133502, b/168566028 Change-Id: I9b7c9c3937bb4ac1f2a95fa2f8aa42a16616971a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439012 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#814460}
-
Sinan Sahin authored
This is the second attempt at fixing the NPE. Bug: 1133172 Change-Id: Icff7ecd432adcd7f8ccd85da0b0ab9558e028103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453442Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#814459}
-
Sylvain Defresne authored
Remove deprecated_default_sources_assignment_filter and replace it with explicit is_win, is_mac, etc. sections. Bug: 1018739 Change-Id: Ic7306c6f227ce0193402fe919a7a7a281fe9f927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446049 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Charlene Yan authored
Bug: 1129675 Change-Id: I9897758b712c3d4d2473c00ec8d89bb060f5ea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436593Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#814457}
-
Robert Sesek authored
Accessing that Mach service is crashing the mac-10_13_laptop_high_end-perf bot. Bug: 1135413, 1126350 Change-Id: I866ff9bc8265eb91ff8a08b7957e48e3c277939f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454494 Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#814456}
-
Eric Lawrence authored
Replace a TODO comment with a bit of information about cross-browser compatibility of the character encoding used in HTTP Basic credentials. Change-Id: I91160cd3c1d7401044fddd7a03c7a42d71bb4f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453470Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#814455}
-
Scott Violet authored
As the test html has a border-right-width, so should the reference. BUG=1134184 TEST=test only change Change-Id: I7dc96193feae66b743160af33c572a24bd1c45e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2447090Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814454}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //fuchsia. R=fdegans@chromium.org Bug: 1113033 Change-Id: Ic16fee164424a34b4dd77c65aba1befce3a482bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454303 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#814453}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ica69cdfa0325461711373bef5258284ade11b841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434147Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#814452}
-
Sammie Quon authored
Test: none Bug: 1134390 Change-Id: I9d1333178f2b006fec25dcc69e30708df68e5b78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454373 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#814451}
-
Scott Violet authored
This way embedders have API to know when they can take action based on whether restore has completed. BUG=1135278 TEST=covered by tests Change-Id: I72d804a86d8c4eeafdc3b72bbcf16875a78eb477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2451550 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#814450}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //jingle. R=thestig@chromium.org Bug: 1113033 Change-Id: I8a6fa48aae3ea742fb4092fafe1250f5710fc067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454090 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Rachel Carpenter authored
These don't currently work the way we expect them to, so turn off for now. Bug: b/169711884 Change-Id: I4f248220623f6ad74fafd7ef9948cdefba56dc30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449614Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#814448}
-
Joel Hockey authored
Second attempt to fix - see crrev.com/c/2408595 Bug: 1077722 Change-Id: Iab4baf26ce1c477bfa7d023a65e2cdbf2956911a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452031 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#814447}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //infra. R=ynovikov@chromium.org Bug: 1113033 Change-Id: I8883bbdc839a8acc3fe6608f309ce9755550d95f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454072 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#814446}
-
Bao-Duy Tran authored
Besides being general cleanup, this also reduces usage of kInputMethods, global const autogen'd from deprecated input_methods.txt config file. Bug: 1134526,1134465 Change-Id: If6b9cf19944bb622bb58d56580b229c0bed530d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444673Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#814445}
-
Toby Huang authored
The FamilyUserMetricsProvider will filter the Family Experiences team's metrics by family user type of interest. The categories represent various combinations of supervised and EDU user types as primary and secondary accounts. Bug: 1103077 Change-Id: Id1f1aab04a17ce7cb42febc42bc1e971033e5e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417451 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
chrome://gpukylechar authored
The page text is setup for a white background, which is normally the case, but on Fuchsia the background defaults to black and chrome://gpu is unreadable. Bug: none Change-Id: I803ff40a3e9e3a54fc606332537a0685c92388a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453435 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#814443}
-
Peter Kasting authored
Bug: 772945 Change-Id: I37a96a2d68d72a3aba691ce073f9841a36b5e3c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454403 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#814442}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //remoting. R=garykac@chromium.org Bug: 1113033 Change-Id: I07c4ec338f03fb7498f620e2c4b0eed37754ef24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454589 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#814441}
-
Sean Topping authored
This dep increases the OTA size by 600kB, which exceeds the size allowance for debug builds on some devices. Cast likely needs a different mitigation for Y2038 as a proper long-term fix. Bug: internal b/167763382 Test: CQ Change-Id: I71d1834be09e070a6816731b17e0ae8fb7831676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399452 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#814440}
-
François Degros authored
This allows to use the new ZIP mounter in ChromeOS Files App by default. BUG=chromium:912236 Change-Id: Idc907993df3e2e984d8b5d580eb34be1fb88c637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449853Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#814439}
-
Scott Violet authored
This is the most recent version we have for 86, and all tests should pass with it. BUG=1131958 TEST=test only change Change-Id: I07abdd32a2ab86bbcb54e34c1737c17fd1f62745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454381Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#814438}
-
Ben Pastene authored
This expands the full set of GN args for every builder in mb_config and dumps them into json files under a //tools/mb/mb_config_expectations/ Once this lands, presubmit will fail if someone makes a change to mb_config.pyl and doesn't retrain the expectations. Theoretically this will make reviewing mb_config.pyl changes a bit easier. But we can always revert if it proves to be a hassle. No-Try: true Bug: 1117577 Change-Id: Ia9149c08a7718f3dd499c47fbd08231dd9de4660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453502 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //pdf. R=thestig@chromium.org Bug: 1113033 Change-Id: I24847c6ec98e1e708db26590686f25b179521a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454299 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Kartik Hegde authored
Introduce the FakeTCPConnectedSocket resolver class, used by unit tests, to avoid duplication across multiple routines. BUG=chromium:956783 TEST=none Change-Id: I1ab4161de6a23790f8b6f8b3bb652701c6ad422b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448652 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#814435}
-
Garrett Beaty authored
Change-Id: Ia271f8e1ffffb2fd2114ceff7965254b4444525b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2453805Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#814434}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //printing. R=thestig@chromium.org Bug: 1113033 Change-Id: Id266a640fb2f4139cd0eb7713796c355e749b3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454402 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metatada from OWNERS files for //crypto. R=davidben@chromium.org Bug: 1113033 Change-Id: I04e31cd9d87948a735b8cf96bac9525c0fbffffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454300 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#814432}
-
