GitLab

This also resurrects the CookiesTreeModelObserverBridge (now called
CookiesTreeControllerBridge) that I removed in r77477 along with the rest of
the native preferences. The class is used to dynamically update the tree view
in response to model changes.

XIB changes:
* Made the "Blocked" tab buttons use the constrained window style.
* Matched the height of the NSOutlineView between the allowed and blocked tabs.

BUG=168996
TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane.

Review URL: https://codereview.chromium.org/128673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243633 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove GetLoaderPath, GetHelperPath, GetIrtBinPath from getos.py.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/118553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243629 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=332440

Review URL: https://codereview.chromium.org/129093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243628 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309720
TEST=covered by test. Also tested manually
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/106673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/102973008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243626 0039d316-1c4b-4281-b951-d872f2087c98

This should fix the 100% regression due to
https://src.chromium.org/viewvc/blink?revision=164213&view=revision

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/129083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332271
R=thestig@chromium.org,joi@chromium.org

Review URL: https://codereview.chromium.org/128413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243624 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310934
TEST=Let's see what the chrome-rel-mac6 bot has to say about this.

Review URL: https://codereview.chromium.org/128413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243623 0039d316-1c4b-4281-b951-d872f2087c98

This gets more to compile.

R=ben@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/128343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243622 0039d316-1c4b-4281-b951-d872f2087c98

For some reason stl for android has problems with these lines,
tweaking for loop makes the compiler happy.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/127043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243621 0039d316-1c4b-4281-b951-d872f2087c98

A contact at ARM mentioned that their recent Mali-T7xx line of GPUs
doesn't guarantee flush ordering either (and there seems little reason
to assume future models will break this trend).

So instead of enabling use_virtualized_gl_contexts for GPUs starting
with "Mali-T6", we should check for e.g. "Mali-T[6-9]", or more simply
just "Mali-T" since older Mali GPUs didn't have a "T".

BUG=154715
TEST=manual

Review URL: https://codereview.chromium.org/128163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243620 0039d316-1c4b-4281-b951-d872f2087c98

Fix QUIC faster stats reporting memory leaks and crashes by changing
lifetime once again.  Now QuicAckNotify::DelegateInterface, one of the
base classes of QuicFasterStatsGatherer, is ref-counted so
QuicFasterStatsGatherer is guanrateed to be around until either faster
stats reporting happens or the last ack is delivered by the
QuicConnection.

Merge internal change: 59228960
https://codereview.chromium.org/126543005/


Add a test requested by rch@ in cr/59053386 to replicate a potential
DCHECK failure.

Merge internal change: 59147972
https://codereview.chromium.org/127563002/


QUIC - Syncing with internal source code. Fixing the include
order. Added missing OVERRIDE.

Merge internal change: 59061118
https://codereview.chromium.org/127553002/


Make TimeWaitListManager use PacketWriter's socket writability state.

Merge internal change: 59058066
https://codereview.chromium.org/127523002/


Make QuicPacketWriter keep track of socket writability; expose the
underlying writer's state instead of keeping a separate variable in
Dispatcher.

Eventually we'll thread this to session/connection as suggested in
a TODO.

Merge internal change: 59055651
https://codereview.chromium.org/127503002/


Fix a QUIC DCHECK flakiness caused by not checking if a packet is
pending before asserting that it's in the sent_packet_map.

Merge internal change: 59053386
https://codereview.chromium.org/127003002/


QUIC Cleanup to remove pending_packets from QuicSentPacketManager and
use a flag in unacked_packets_.

Replaced FindOrNull and FindOrDie with find() call.

Merge internal change: 59015729
https://codereview.chromium.org/126983002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/127633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243619 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally checked this in.

TBR=scottmg

Review URL: https://codereview.chromium.org/129023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243618 0039d316-1c4b-4281-b951-d872f2087c98

Prerender browser tests are currently sensitive to prerenders occurring
synchronously. Already we require an ad-hoc content::RunMessageLoop() in
PrerenderPageNewTab because that one is asynchronous. Instead, introduce
a NavigationOrSwapObserver so NavigateToURL always waits for either the
swap or a normal navigation. This allows removing the
content::RunMessageLoop() call and is necessary for fixing beforeunload
handling.

Also split off DidDisplayPass and DidPrerenderPass into helper functions.

BUG=307592,304932
TEST=PrerenderBrowserTest.*

Review URL: https://codereview.chromium.org/102433010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243616 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: http://crbug.com/332434

TBR=benm@chromium.org,mnaganov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332089

Review URL: https://codereview.chromium.org/128933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243615 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332218

Review URL: https://codereview.chromium.org/126513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243614 0039d316-1c4b-4281-b951-d872f2087c98

New methods to perform an undo and redo of bookmark changes, as well as
obtaining i18n labels and whether there are actually changes to undo or
redo.

undo()
redo()
getUndoInfo()
getRedoInfo()

This commit is only one part of a multi-level undo/redo system for the
bookmark model and there will be an additional commit to take advantage
of these new function in the bmm.

BUG=126092

Review URL: https://codereview.chromium.org/119233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243613 0039d316-1c4b-4281-b951-d872f2087c98

This searches the local system for Visual Studio versions like GYP. It enables specifically requesting one version, as well as overriding the directory like GYP.

BUG=
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/126073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243612 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243611 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243610 0039d316-1c4b-4281-b951-d872f2087c98

1831 - Don't try to match mixed source/dir gyp order on MSVS prior to 2010

BUG=none
TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/128473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243609 0039d316-1c4b-4281-b951-d872f2087c98

Screenshot on the bug.

BUG=276956

Review URL: https://codereview.chromium.org/128033004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243608 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164682:164685&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/126753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243607 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331831

Review URL: https://codereview.chromium.org/118633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243606 0039d316-1c4b-4281-b951-d872f2087c98

SearchResultView's |result_| could be NULL and should be handled properly.

BUG=332012

Review URL: https://codereview.chromium.org/120553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243602 0039d316-1c4b-4281-b951-d872f2087c98

CastStreamingAPITest.Basics has been failing on OSX bots, so disable it.

BUG=332427
TBR=hclam@chromium.org

Review URL: https://codereview.chromium.org/128853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243601 0039d316-1c4b-4281-b951-d872f2087c98

This will be used by the VariationsService to simulate newly
received variations seed, to evaluate whether there's sufficient
new changes to badge the UI to suggest a restart (similar to
what happens during auto updates).

This is the initial version of this class and still
has some missing pieces, left as TODOs.

BUG=315807
TEST=Unit tests.
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/41623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243600 0039d316-1c4b-4281-b951-d872f2087c98

BUG=276675

Review URL: https://codereview.chromium.org/110863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243592 0039d316-1c4b-4281-b951-d872f2087c98

Also improves the tests to check that audio muting doesn't mute video
and vice versa.

BUG=328196,331045

Review URL: https://codereview.chromium.org/120773003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243591 0039d316-1c4b-4281-b951-d872f2087c98

It is actually what this is doing in practice but only because
SHOW_STATE_INACTIVE implementation is broken and usually creates active
windows.

BUG=None

Review URL: https://codereview.chromium.org/118283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243590 0039d316-1c4b-4281-b951-d872f2087c98

Removed the old VideoEncoderController interface and
made video_encoder a pure virtual class that
ExternalVideoEncoder and VideoEncoderImpl implements. 
This CL also remove the possibility to send in
pre-encoded video frames.

BUG=325998

Review URL: https://codereview.chromium.org/116623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243589 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/128223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243587 0039d316-1c4b-4281-b951-d872f2087c98

Widget::InitParams: Added override_show_in_taskbar value to force popup
and bubble windows (including the App Launcher) to appear in the taskbar
when they otherwise would not.

BUG=332007
TEST=Launch App Launcher. It should appear in the Unity launcher.

Review URL: https://codereview.chromium.org/122353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243585 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243583 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
http://crbug.com/308843

Review URL: https://codereview.chromium.org/126513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98

Usages of AwSettings.LayoutAlgorithm need to be replaced with
WebSettings.LayoutAlgorithm.

This change also fixes a couple of trivial presubmit warnings in
existing code.

BUG=332089

Review URL: https://codereview.chromium.org/115253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243576 0039d316-1c4b-4281-b951-d872f2087c98

Relying on local-auth is not sufficient because locking can be enabled when no local credentials are present.  Also, changing the password outside of this instance of Chrome would require using the old password to unlock, now no longer the case.

This affects only new-profile-management.

BUG=328017

Review URL: https://codereview.chromium.org/99373008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243575 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243573 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164663:164681&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/128263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324166

Review URL: https://codereview.chromium.org/127663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243571 0039d316-1c4b-4281-b951-d872f2087c98