- 11 Jan, 2019 40 commits
-
-
Kevin McNee authored
HitTestAsyncQueriedDebugRegion is currently defined in an anonymous namespace in hit_test_manager.h, so each translation unit gets a seperate definition of it with internal linkage. I presume the intent here was to have HitTestAsyncQueriedDebugRegion be private to HitTestManager, so we now define it accordingly. Bug: None Change-Id: Ic546f42f6808ae25ed7f948677e6304c04ef43ec Reviewed-on: https://chromium-review.googlesource.com/c/1405698Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#622142}
-
Renjie authored
Change-Id: Ide9efc469c6ec80c18b864579015a1dae9f75c9b Reviewed-on: https://chromium-review.googlesource.com/c/1384987Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#622141}
-
Victor Vasiliev authored
Merge internal change: 228810977 R=rch@chromium.org Change-Id: Iaa05eb7fe97ea0c3d326c8530d52be8a2a7573cd Reviewed-on: https://chromium-review.googlesource.com/c/1406162Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/d01e28f41f88..1e7a8f30c231 $ git log d01e28f41..1e7a8f30c --date=short --no-merges --format='%ad %ae %s' 2019-01-08 apodtele [psaux, type1] Align tracing. 2019-01-08 chris.liddell [psaux] Fix closepath (#55414). 2018-12-30 ramakrishnan.nikhil Minor documentation fix. 2018-12-29 wl * src/autofit/aflatin2.c: Some fixes from `aflatin.c' (#55310). 2018-12-26 mpsuzuki * builds/mac/README: Fix a hyperlink to defunct www.gyve.org. 2018-12-25 wl Fix links (mostly http -> https). 2018-12-25 wl * src/psaux/cffdecode.c (cff_operaor_seac): Fix numeric overflow. 2018-12-12 wl [gxvalid] Fix compiler warnings. 2018-12-12 wl Fix documentation of TrueType bytecode interpreter debug hook. 2018-12-12 wl Minor documentation fixes. 2018-12-11 wl * src/truetype/ttgload.c (TT_Hint_Glyph): Remove useless test. 2018-12-10 wl Minor documentation updates and fixes. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Roll: https://pdfium-review.googlesource.com/c/pdfium/+/48170 Change-Id: Ia3c02f363acbe30785ec27c5123fd8bf6ffd1279 Reviewed-on: https://chromium-review.googlesource.com/c/1407039Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#622139}
-
Chase Phillips authored
An upcoming change will use CreateAllBlobs() from outside the callbacks interface. Bug: 717812 Change-Id: I8292e0e7471c00d89fc7df5392e9a0a4dcd33173 Reviewed-on: https://chromium-review.googlesource.com/c/1399501 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#622138}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ef92f656a86e..caf2cd67df84 git log ef92f656a86e..caf2cd67df84 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 thestig@chromium.org Remove a NOTREACHED() in CPDF_Font::GetAdobeCharName(). Created with: gclient setdep -r src/third_party/pdfium@caf2cd67df84 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:920636 TBR=dsinclair@chromium.org Change-Id: I3f07671a4a213fa1d50c7b6d5f568a53d57db0a7 Reviewed-on: https://chromium-review.googlesource.com/c/1407100Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622137}
-
Siddhartha authored
Refactor Stack unwinder code to use a class instead of various functions with lot of arguments. Functional changes for case of current thread unwind, which is never used. 1. Handling of nullptr for the case of TraceStack for current thread api. This function called TraceStackWithContext with stack_segment_base=0, which is wrong and unwind will fail. So, set a maximum limit on stack size for unwind. 2. If stack was never copied (trace stack for current thread), then do not replace registers with 0 offset. Change-Id: I1ee96e05dcba4c658398b29e1caec96b4d733bb1 Reviewed-on: https://chromium-review.googlesource.com/c/1404262 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#622136}
-
Aaron Leventhal authored
Bug: None Change-Id: Ica82adbc7dbb37a00ce0a2b603e2d720edb6d015 Reviewed-on: https://chromium-review.googlesource.com/c/1403520Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#622135}
-
Steven Bennetts authored
src/chromeos/accelerometer is only used in src/, and it has a //ui dependency, so move the code to src/ash. Bug: 918682 Change-Id: Ic87abd39d494628d747d7b97da009a3e2fa8b70c Reviewed-on: https://chromium-review.googlesource.com/c/1406270 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#622134}
-
Oksana Zhuravlova authored
This change adds information from the old wiki guide that was missing from the current one. Bug:917201 Change-Id: Ibfee4b8518e4e328dd3c4e1346d6ee729f4c0bfc Reviewed-on: https://chromium-review.googlesource.com/c/1387457Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#622133}
-
kylechar authored
Remove usage of deprecated base::Bind, base::Callback, base::Closure and base::CancelableClosure types from cc/*. Where possible convert to the corresponding once type. Otherwise replace with the repeating type which is equivalent to the deprecated type. This is the first of multiple CLs to cleanup callback types in cc/*. ImageController::ProcessNextImageDecodeOnWorkerThread() has a slight implementation change. This is necessary to accomodate ImageDecodeRequest becoming move-only due to use of OnceCallback. The implementation change should be a no-op functionality wise. Bug: 714018 Change-Id: I16c4ad368a4865557406f8a64630ae14b61fecac Reviewed-on: https://chromium-review.googlesource.com/c/1401368Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#622132}
-
Matthew Mourgos authored
Bug: 919939 Change-Id: I4fcda789a4859dc826072fd8979ebce355a606ce Reviewed-on: https://chromium-review.googlesource.com/c/1401661 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#622131}
-
Jun Mukai authored
Bug: none Test: interactive_ui_tests Change-Id: I382e39abce0654186a8ba4c277d5cde3b20998d3 Reviewed-on: https://chromium-review.googlesource.com/c/1401849Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#622130}
-
Evan Stade authored
- make it a collection of statics instead of a singleton object - move to //ash/public - use it in BrowserNonClientFrameViewAsh to match ash::WorkspaceEventHandler Bug: none Change-Id: I64f290e63f6f729239b52a67f84c39e62f04c4f1 Reviewed-on: https://chromium-review.googlesource.com/c/1406301Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622129}
-
Brandon Jones authored
Remove as many references to XRDevice as possible without completely removing the interface itself. All functionality previously contained in XRDevice is shifted into the XR interface. Done purely as a method of reducing the size of the XRDevice removal CL. Bug: 916299 TBR: mcasas Change-Id: I01696972a7e56e196eedfc6ffe248789520a8f9e Reviewed-on: https://chromium-review.googlesource.com/c/1405880 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#622128}
-
David Bertoni authored
This CL is part of the effort to unify the LazyBackgroundTaskQueue and the ServiceWorkerTaskQueue. Bug: 915814 TBR: dmazzoni@chromium.org (Removed a header file in accessibility_extension_api.cc) Change-Id: I067bc70b4ed047a0466d70b7d976e01806e7bf98 Reviewed-on: https://chromium-review.googlesource.com/c/1404577 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Anand Mistry <amistry@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#622127}
-
Kyle Horimoto authored
Once multi-device setup is completed, the "Messages" PWA is installed, but further setup is required before the app can be used. Specifically, the Chromebook needs to be paired with the user's phone via a QR code displayed in the PWA. However, this pairing is broken the PWA is migrated from messages.android.com to messages.google.com (see https://crbug.com/917855. This CL alerts the user that the devices need to be re-paired when this situation arises. Bug: 918943 Change-Id: Ib662edf42ba01320cc12e6f3955b80c390d4493e Reviewed-on: https://chromium-review.googlesource.com/c/1406159 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#622126}
-
Dave Tapuska authored
It is no longer used. All other classes have mitigated to using CancelableTasks and ContextLifecycleObservers directly. BUG=907125 Change-Id: I9bfa406836e842b1dfc2b14a9144758e3edd55d1 Reviewed-on: https://chromium-review.googlesource.com/c/1407094Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#622125}
-
Jamie Madill authored
The drivers have been upgraded. Try running the test suites again to see if the device lost problems have gone away. Bug: 917046 Change-Id: I8a8b92e5cdb0f26f7b6f502cbd99c52308767ecd Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1407089Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#622124}
-
Stephen McGruer authored
This relands the commit b0eab4a3 from https://chromium-review.googlesource.com/c/chromium/src/+/1372173 The only change is to mark virtual/threaded/animations/skew-notsequential-compositor.html as flaky; it has been decided that it is worth landing the CL anyway and investigating the flakiness afterwards. TBR=majidvp@chromium.org,pdr@chromium.org Bug: 912574, 921105 Change-Id: I93dfc5db4056e3567f99254f28b1072a66c4f532 Reviewed-on: https://chromium-review.googlesource.com/c/1407385Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#622123}
-
Miguel Casas authored
This CL adds "Measure" to the html_media_element_capture idl file, so we can track its usage -- it was probably overlooked before. Change-Id: Ic70ebb689386f22ff134b4296fd79f13b53b3670 Reviewed-on: https://chromium-review.googlesource.com/c/1407031 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#622122}
-
Miguel Casas authored
This CL moves MediaRecorder-events-and-exceptions.html to the wpt/ folder, and refactors it to use canvas.captureStream() (ISO the Chrome-specific blink_test_runner.cc thing). It also fixes partially MediaRecorder-error.html: a new method drawSomethingOnCanvas() is introduced and called to guarantee that the canvas produces some captured VideoFrame, kicking the event(s) generation. This fix is partial because Chrome doesn't have MediaRecorderErrorEvent, but at least we verify that an error event is thrown. Bug: 919951 Change-Id: Ie9d7cfeeb2bf4452f4b5928eb2a7c644778751a7 Reviewed-on: https://chromium-review.googlesource.com/c/1406150Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#622121}
-
Christopher Cameron authored
Just flushing before and after DoRasterCHROMIUM was not enough to prevent crashes. In fact, it appears that DoRasterCHROMIUM's behavior is unrelated to crashes. Flush after every segment of decoded commands. If this limits crash rates (it likely will because that worked for non-OOP raster), then we can start examining the actual commands that were run to find patterns. Remove old no-longer-needed instrumentation. Bug: 906453 Change-Id: Ic5faa5a07dbb4223219a3e88a97b5afaeb65d6b7 Reviewed-on: https://chromium-review.googlesource.com/c/1400772Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#622120}
-
Johann authored
https://chromium.googlesource.com/webm/libvpx.git/+log/57f7c6f19144..759d1de9d0d2 $ git log 57f7c6f19..759d1de9d --date=short --no-merges --format='%ad %ae %s' 2019-01-08 jianj vp8 dec: Add flag to bring up threads. 2019-01-07 johannkoenig vp8 idct dequant: resolve missing declarations 2019-01-07 johannkoenig vp8 overlaps: resolve missing declaration 2019-01-07 johannkoenig vp9_get_blockiness: resolve missing declaration 2019-01-07 johannkoenig vp8 blend: resolve missing declarations 2019-01-07 johannkoenig vp8_copy32xn: resolve missing declaration 2019-01-07 johannkoenig arm neon: resolve missing declarations 2019-01-07 johannkoenig vpx_filter: resolve missing declarations 2019-01-07 johannkoenig vpx_clear_system_state: resolve missing declaration 2019-01-07 johannkoenig vp9 intra pred test: resolve -Wuninitialized warning 2019-01-07 johannkoenig vp8 multi dimensional search: resolve missing declarations 2019-01-04 kyslov Fix OOB memory access on fuzzed data 2019-01-07 johannkoenig fix vp9 fdct_quant 2019-01-03 urvang VP9 firstpass: Bugfix when mi_col_start/end is odd 2018-12-31 angiebird Increase memory size in non-greedy-mv 2018-12-22 angiebird Build pyramid motion field 2019-01-02 jianj vp9: psnr diff thres for single vs multi threading. 2018-12-21 yunqingwang Adaptively choose block sizes in temporal filtering 2018-12-22 jzern test-data: add missing test data entries 2018-12-22 jzern Revert "Add Tile-SB-Row based Multi-threading in Decoder" (...) Created with: roll-dep src/third_party/libvpx/source/libvpx BUG=webm:1573 Change-Id: I6488543cc2773fb02a2f8ba508d50f246789237d Reviewed-on: https://chromium-review.googlesource.com/c/1400959Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#622119}
-
Hector Carmona authored
Bug: 920685 Change-Id: Ibbb068b85f5bd3a94b5823dbece9409ea68bcb36 Reviewed-on: https://chromium-review.googlesource.com/c/1406180 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#622118}
-
Nate Fischer authored
When the app targets at least Q, we should return a dedicated integer constant. Otherwise, we should return UNKNOWN for backwards compatibility. Bug: 887186 Test: run_run_webview_instrumentation_test_apk -f=SafeBrowsingTest#*Billing* Change-Id: Ifcab24c33469d3c5ce31dafa3b947a60cf6a82ed Reviewed-on: https://chromium-review.googlesource.com/c/1406317Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#622117}
-
Chase Phillips authored
IndexedDBCallbacksImpl was originally an implementation of the Mojo IDBCallbacks interface hosted by the renderer process defined in content/renderer/. In onion souping IndexedDB, all of the Mojo interfaces moved to be hosted in blink/renderer/modules/indexeddb/, which made the extra layer of IndexedDBCallbacksImpl redundant with WebIDBCallbacks. This commit removes the redundant layer, moving the Mojo IDBCallbacks interface from IndexedDBCallbacksImpl to WebIDBCallbacks. Bug: 717812 Change-Id: I076002f019f2cf9e5ddb965c504615c8ed60fcf9 Reviewed-on: https://chromium-review.googlesource.com/c/1395558 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Samuel Huang authored
This CL adds new files for ARM support. The code is not yet integrated into Zucchini, but are only used by the added tests. The high-level goal is to support rel32 reference read / write via: (data bytes) <-> |code| <-> |disp| <-> |target_rva|, where |code| is ARM machine code value (read-write), and |disp| is a PC-relative displacement. Details: * Add template class ArmAddrTraits as API to process rel32 references. It is specialized for each rel32 address type, and aggregates selected low-level static functions from an ARM *Translator class. * Add class Arm32Rel32Translator for 32-bit ARM (ARM32) * ArmAddrTraits is specialized to {A24} encoding for ARM mode, and {T8, T11, T21, T24} encodings for THUMB2 mode. * Complication: |code| can affect |disp| <-> |target_rva|, since the the BLX instruction dictates whether |target_rva| should be 2-byte or 4-byte aligned! * The BLX special case makes |disp| <-> |target_rva| unsuitable for ArmAddrTraits. This led to the API to be defined as: * Fetch() for (data bytes) -> |code|. * Store() for |code| -> (data bytes). * Decode() for |code| -> |disp| & alignment spec (ArmAlign). * Encode() for |disp| -> |code|: Modifies existing |code|. * Read() for |code| -> |target_rva|: Needs |instr_rva|. * Write() for |target_rva| -> |code|. * Needs |instr_rva|; modifies existing |code|. * Add class AArch64Rel32Translator for 64-bit ARM (AArch64). * ArmAddrTraits is specialized to {Immd14, Immd19, Immd26} encodings. Bug: 918867 Change-Id: Ie20935e391ed0ac85c408aa9c8959305dc8bba42 Reviewed-on: https://chromium-review.googlesource.com/c/1394397Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#622115}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f7f13a85db94..4f3f4e172145 git log f7f13a85db94..4f3f4e172145 --date=short --no-merges --format='%ad %ae %s' 2019-01-11 achuith@chromium.org chrome_stages: Add cros_run_vm_test. 2019-01-11 gbiv@google.com SimpleChrome: use lld in branded+official builds 2019-01-11 dgarrett@google.com generic_stages: Use active buildroot for portage lookups. Created with: gclient setdep -r src/third_party/chromite@4f3f4e172145 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3f743848a100f6e6393a1d757b99466a967607b9 Reviewed-on: https://chromium-review.googlesource.com/c/1407097Reviewed-by:
-
Sergey Ulanov authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f8374cf..24e7192 Bug: 778467 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I4617e82b69a9b2de877c63f735d8ea461c960e57 Reviewed-on: https://chromium-review.googlesource.com/c/1406132Reviewed-by:
Alexis Hétu <sugoi@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622113}
-
Liquan(Max) Gu authored
We introduced a bug in https://chromium-review.googlesource.com/c/chromium/src/+/1380193. When image paint detector finds the largest paint candidate with null time, it passes in to the trace, which will cause a crash. To fix it, we skip the candidate if the candidate's time is null. Bug: 920627 Change-Id: Ie39ac9fbc1d09fc88e09851497a80610969bd527 Reviewed-on: https://chromium-review.googlesource.com/c/1407088Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622112}
-
Mustafa Emre Acer authored
We currently fetch the list of engaged sites on every navigation on the UI thread. This is slow. We also do this separately for each tab. This CL introduces a profile keyed service called LookalikeUrlService. This service fetches the list of engaged sites every 5 minutes in a background thread and stores the results until the next update. It also gets rid of the need to do a fetch for each tab separately. Bug: 913647 Change-Id: I9f7080c45834de576eb081243778f2f17c3e4ccd Reviewed-on: https://chromium-review.googlesource.com/c/1389167 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622111}
-
Hector Carmona authored
Also fix some const references surfaced by presubmit. Bug: 912026 Change-Id: If18dc61d8284c86cbec9f23e09286e9c5f666824 Reviewed-on: https://chromium-review.googlesource.com/c/1405459Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#622110}
-
Jeremy Roman authored
This reverts commit 02090026. Reason for revert: Causing crashes in canary. Original change's description: > [Reland] webaudio: Always delete handlers in a non-nestable task on the main thread. > > Deleting handlers does considerable non-trivial work that requires the > graph lock. Allowing this to happen during finalization introduces > considerable complexity because it can happen during any GC heap allocation, > including ones that occur while the graph lock is already held. > > Instead, when the last reference is dropped, the handler is not deleted > immediately, but a non-nestable task to delete it is enqueued. Since the > task is non-nestable, it will not run while the graph lock is held by the > main thread (and if it is held by another thread, it will block on it). > > This slightly extends the lifetime of audio handlers, during which time > it is illegal to take a new reference (and RefCounted checks this in > debug builds). So a flag is set in the destructor (though it could be > sensibly set as early as the ref count reaches zero) that prevents the > handler from adding itself to the tail processing queue if it is already > being destroyed. > > The cycle collection layout test is updated to handle the fact that the > handler count does not go to zero immediately on GC, but shortly thereafter. > This has been done by merging with another recently added unit test, which > tests something very similar (a cycle of one element). > > The leak detector has been augmented to wait for audio handlers that are > awaiting deletion, if there are any. > > Bug: 884059 > Change-Id: I818bcdbf87dc3e83359ad7a62aa56547dea2d7a5 > Reviewed-on: https://chromium-review.googlesource.com/c/1392109 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621840} TBR=jbroman@chromium.org,haraken@chromium.org,hongchan@chromium.org Change-Id: Ib13b613f6fa696935f64362f65eb94cba50acdfd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884059,921018 Reviewed-on: https://chromium-review.googlesource.com/c/1407501 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622109}
-
Tom Anderson authored
The copied test fonts are inputs to generate_fontconfig_caches, so must be listed in deps, not data_deps (https://crbug.com/919422). generate_fontconfig_caches creates test_fonts/.uuid, but fontconfig deletes .uuid when there are no fonts [1], so if generate_fontconfig_caches runs before test_fonts are copied, .uuid will be deleted and the build will be dirty (and the cache file will be incorrect). [1] https://cs.chromium.org/chromium/src/third_party/fontconfig/src/src/fcdir.c?rcl=ba206df9b9a7ca300265f650842c1459ff7c634a&l=429 BUG=919422 R=thakis CC=erikchen,tikuta Change-Id: I94057b8035510a122e379249f9f8c60c9e526a57 Reviewed-on: https://chromium-review.googlesource.com/c/1406228 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#622108}
-
Katie D authored
Also adds a bubble to confirm that a user wants the setting on. This copies the behavior of the spelling suggestions service. Context menu change is only added when the feature flag is enabled. Bug: 905419 Change-Id: I171f21a9766d150b113e15a0f95238ed435fda5e Reviewed-on: https://chromium-review.googlesource.com/c/1404156Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Dana Fried authored
Client area of views is now caluclated from GetInsets(), and the old way dialogs were using GetInsets() to mean something completely different has been fixed/changed, so there is no reason to override GetInsets() to return zero. Removing the override fixes the layout of the dialog. Bug: 916479 Change-Id: I586236a3cfadd08805a5df4f737c982102850077 Reviewed-on: https://chromium-review.googlesource.com/c/1405874Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f7793ef4be2e..6daa05d3185a git log f7793ef4be2e..6daa05d3185a --date=short --no-merges --format='%ad %ae %s' 2019-01-11 fmayer@google.com Merge "profiling: Allow script to not start / stop heapprofd." 2019-01-11 fmayer@google.com Merge "profiling: waitpid(2) for children spawned in test." 2019-01-11 treehugger-gerrit@google.com Merge changes I00fcf098,I244a6879 2019-01-11 primiano@google.com Merge "Add traced_probes to log group" 2019-01-11 treehugger-gerrit@google.com Merge "WASM: Enable clamp mode on float -> int conversion" Created with: gclient setdep -r src/third_party/perfetto@6daa05d3185a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idfcc6b15c617138e607e3b0712f6a948a9810a10 Reviewed-on: https://chromium-review.googlesource.com/c/1407114Reviewed-by:
-
Kyle Milka authored
Bug: 904565 Change-Id: Ibe5112bb6a0b938c24315606ae5647a5ae6913fd Reviewed-on: https://chromium-review.googlesource.com/c/1338122 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#622104}
-
Peter Kotwicz authored
This CL changes the splash screen hiding logic to not hide the splash screen while the network error dialog is up. BUG=920729 Change-Id: Ifa4659b2e97c70b5d4dde83ba52b3bd41a80ea29 Reviewed-on: https://chromium-review.googlesource.com/c/1405985 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
