- 03 Mar, 2020 40 commits
-
-
Eric Roman authored
Change-Id: I83281dbedf4d24c40f3b72858ea7f7a43b3e09ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085833 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#746550}
-
Jon Mann authored
Previously the observers are only notified of configuration removal events. This adds support for a new OnConfigurationModified hook. Bug: 966270 Change-Id: I9a02c345f88dd8bbade62a5314beba043cb2a09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085397Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#746549}
-
Yulun Wu authored
Bug: 1056913 Change-Id: I1f6b719deb6f6c91e8569ae08f240149f5c346c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083868Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746548}
-
Yi Gu authored
Bug: None Change-Id: I88d1a220e20f1de630cd34b2483a6c0fcdb9b71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085713Reviewed-by:
Olga Gerchikov <gerchiko@microsoft.com> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746547}
-
Reilly Grant authored
This change adds two new Blink runtime feature flags, ScreenWakeLock and SystemWakeLock. These can be used to control support for the "screen" and "system" WakeLockType enum values. These checks need to be implemented by hand in wake_lock.cc since the bindings generator does not support adding the [RuntimeEnabled] attribute to an enum value. A webexposed test has been added to check that only the desired wake lock types are exposed. Bug: 257511 Change-Id: If9e94eb39bfd98d91c08da89340ff541f471abb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081618 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#746546}
-
Sergey Ulanov authored
Now cast_runner receives list of web permissions as part of the app config and passes the list to the corresponding frame. This will be used to enable microphone & camera access for apps that need it. Bug: 922833 Change-Id: Ibae772c483a0389d3dee04722aeeb9e8c1b51015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084728 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#746545}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/683c198380db..e3e152bd3a29 git log 683c198380db..e3e152bd3a29 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 gabriel.luong@gmail.com Migrate Object, Progress, StringOutputStream, TextDictionary, and Throttler tests into Ninja build 2020-03-03 joselea@microsoft.com Typecheck ResourceType.js with Typescript Created with: gclient setdep -r src/third_party/devtools-frontend/src@e3e152bd3a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I31f6604e177a31f7e8d5f7db326c5123bb05b6a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082329Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746544}
-
Jose Lopes authored
This is a repeating callback because it's both executed by the FrameProcessor class: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=398 * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=464 But a copy of it is also passed to the MseTrackBuffer class, which takes ownership of the copy: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=7b80418808ca7fc5cb2440969f72923065456c8e&l=496 and called later for every enqueued processed frame: * https://cs.chromium.org/chromium/src/media/filters/frame_processor.cc?rcl=365fdc7e79f2cb2bd09d9be3c9dfc5e4d2ffb866&l=255 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I5f8d1ad96b71601cc7355bf348187d3cf7a816bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080476 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Cr-Commit-Position: refs/heads/master@{#746543}
-
Mason Freed authored
The [1] CL added support for scrolling="noscroll" and scrolling="off", but it did not add any testing of these two values. These two values are explicitly called out in the spec [2], so this CL adds testing. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2083595 [2] https://html.spec.whatwg.org/multipage/rendering.html#the-page Bug: 1057454 Change-Id: I457e22ecbe28c4b0a50ec70ba62d2c32a6c348ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085396 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#746542}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65b70d61..f796ed84 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idff28b5e288a0a1d8aa57ebb1459007c1ef2aa97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085511Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746541}
-
Maks Orlovich authored
Needed since it sometimes need to be parsed on browser as well, not just renderer. This also makes it uses structured headers parsing, which is what it is spec'd as. This changes parsing behavior somewhat; for example accepting (and ignoring) parameters. It is also supposed to not accept non-space whitespace (which tests are updated for), but the parser doesn't match the spec yet. Bug: 1050726 Change-Id: Ib3953ba74efd2ae74d9003cb59edcba9bb49010f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079295 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#746540}
-
Clemens Arbesser authored
Without this CL, UI and model can go out-of-sync when tapping the radio button directly (see screenshots in linked bug). This is a hotfix for this issue. A proper fix requires a refactoring of the FormAction to make the selection state part of its model (same as was done for the T&C selection state in the CollectUserDataModel). Bug: b/150201921 Change-Id: Ifa0a2839c532a1862358bc68e6d0537dee93b49c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083489 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746539}
-
David Tseng authored
Fixed: 1057983 TBR=anastasi@google.com Change-Id: I50185e3bf875caec41ced281c10ff308eca08824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085151Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746538}
-
Weilun Shi authored
Add a new field called client_uuid to system profile to help simulate field trial randomization on the server side. Bug: 1058124 Change-Id: I098f9fe31f3d88a78d5e7d784c2edc498dc1e0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085631 Commit-Queue: Weilun Shi <sweilun@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#746537}
-
Eugene But authored
These flags are respectively passed from WillCloseWebStateAt and WebStateInsertedAt callbacks. Previously mentioned callbacks used CHANGE_REASON_USER_ACTION flag. Also rename CHANGE_REASON_USER_ACTION to CHANGE_REASON_ACTIVATE to better reflect the meaning of the flag. This change is needed by Breadcrumbs feature which attaches steps to reproduce to crashlogs. This way Breadcrumbs can log WebStateActivatedAt events only for user triggered activations (all other activations are not useful and only create noise in Breadcrumbs logs). This CL does not have any functional changes to other features and all clients of WebStateActivatedAt were updated to use new flags in addition to CHANGE_REASON_USER_ACTION. Bug: 1046231 Change-Id: Idc5685ee052e8f056200ea9e94b397a2909b4afa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084152 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#746536}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/964aa91580b6..4036cb1f0b6e git log 964aa91580b6..4036cb1f0b6e --date=short --first-parent --format='%ad %ae %s' 2020-03-03 borenet@google.com [recipes] Re-disable SKPs on iOS and images on GPU in nanobench 2020-03-03 robertphillips@google.com Switch member destructor order in SkDeferredDisplayList 2020-03-03 senorblanco@chromium.org Dawn backend: update to onBindBuffer() changes. 2020-03-03 mtklein@google.com have each program own LLVMContext 2020-03-03 mtklein@google.com Program::LLVMState Created with: gclient setdep -r src/third_party/skia@4036cb1f0b6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I5e1c77b4bb9db09bc9050dee68583dbd7b9d8004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082328Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/6432bb46ab44731567ec923e6c8fc182f13d0070..1e859054c31ec7b974e998373e85fadea56d93ad The following commits have update notes: 1e859054c Revise QUIC encryption secret APIs. Bug: none Change-Id: Ie8b96b49e7b6b7347f6276fd3171f0ca701ed878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085153 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#746534}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4317d1955e2bb61438393968dca7ce5b9ff4922a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085393Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#746533}
-
Anastasia Helfinstein authored
This CL takes another step towards encapsulating action behavior in the node classes. Bug: None Change-Id: If709c22606016930ce715168d50a7a2f7176788c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076443 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5e1ea251895c..ccefde95b3bb git log 5e1ea251895c..ccefde95b3bb --date=short --first-parent --format='%ad %ae %s' 2020-03-03 natim@webrtc.org VoIP interfaces API enhancement (continuation of 169000) Created with: gclient setdep -r src/third_party/webrtc@ccefde95b3bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia660619f4db25239346f1eefb20229e56661361a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082330Reviewed-by:
-
Mike Reed authored
Bug: skia:9984 Change-Id: Ib6e455522db9c73e9bba95ec28a96e4f6a92c8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085119Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#746530}
-
Paulo Warren authored
This CL begins the work of adding the ability to pass a SurfaceHandle to the SharedImageInterface. In some circumstances, we previously got around this by first creating a gpuMemoryBuffer, and using the CreateSharedImage that uses the gpuMemoryBuffer. This is problematic because the BufferQueue needed to keep track of the gpu memory buffer, instead of the gpu process doing it for us. This CL modifies four interfaces: SharedImageInterface, SharedImageFactory, SharedImageBackingFactory, and ImageFactory. They have all been modified to accept and pass through a SurfaceHandle. This allows us to remove the |buffer| from BufferQueue::AllocatedSurface, as well as the |gpu_memory_buffer_manager_| from BufferQueue. This is a mechanical change that is not intended to change behavior. I followed these rules when modifying the interfaces: 1. Any previous call to CreateSharedImage or CreateAnonymousImage was passed a SurfaceHandle if applicable, gpu::kNullSurfaceHandle if not. 2. The implementations of SharedImageBackingFactory were modified to accept a SurfaceHandle. Only SharedImageBackingFactoryGLTexture passes the SurfaceHandle to ImageFactory::CreateAnonymousBuffer BUG=958670 TEST=autoninja -C out/Default components/viz:viz_unittests Change-Id: I5f1263a6421761c8a2805d4ab087c35f848cfe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070820 Commit-Queue: Paulo Warren <pwarren@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746529}
-
Rakib M. Hasan authored
This CL follows up on crrev.com/c/2070672. It adds necessary changes to the Chromium repo in order to create Android Weblayer CI and Try bots. It also configures the bots to run the WPT test suite. Bug: 1050760 Change-Id: I395f6ad6edd9939c49dd4ee3c511173be60aecde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071063 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746528}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a3b6fd06f9d7..67cabcd71f8a git log a3b6fd06f9d7..67cabcd71f8a --date=short --first-parent --format='%ad %ae %s' 2020-03-03 ehmaldonado@google.com gclient: Remove syntax validation flags. Created with: gclient setdep -r src/third_party/depot_tools@67cabcd71f8a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8023ed269bbcd80037a037b9e63d811fa0c0808b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082326Reviewed-by:
-
Hailey Wang authored
A trace is uploaded via "slow reports" when a long first input delay is detected (for opted-in clients). This trace event will make it easier to identify the location of the long delay when analyzing the trace. Bug: 1055890 Change-Id: I479406c3c78accbc4c06ccaeab14f699bf8ccdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078775Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Hailey Wang <haileywang@google.com> Cr-Commit-Position: refs/heads/master@{#746526}
-
Andrew Luo authored
Bug: 1021665, 765833 Change-Id: Ie3ff57c7f78cf451f4ee72e9d73c044ca39f2ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080577 Auto-Submit: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#746525}
-
Kelvin Jiang authored
This CL adds documentation which states that the quota for getMatchedRules calls does not apply if the call is associated with a user gesture. Bug: 1044702 Change-Id: I2a2ed5deacc674ba86aef744094b3c1935c4ab91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085591 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746524}
-
zhaoyangli authored
Please refer to the bugs below for why this change is needed. The similar util issue within "ios/chrome/test/earl_grey" was fixed in crrev/c/2006260. Bug: 1036578, 1057752 Change-Id: I917fe2aedf0cd82e3597a751744064c189b0f64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082899Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#746523}
-
zhaoyangli authored
This change is fixing an internal test suite which isn't running because bundle image isn't found. It also enables other test suites add bundle library they need in the future. Bug: 1057694 Change-Id: I125ceaece80a852506b9ae9414bf9b3d084d5bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081241 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch renames the property and updates the valid values per spec: https://wicg.github.io/display-locking/ Note that it also adds hidden-matchable behind a separate flag, since it's not a part of the initial spec, but is a proposed enhancement: https://github.com/WICG/display-locking/issues/110#issuecomment-588309247 Note that this retains the activation signal while the beforematch event is being implemented. R=chrishtr@chromium.org TBR=cbiesinger@chromium.org, bmcquade@chromium.org Change-Id: I6f4f4aeb2e7d743786d09bda71027f994c94792d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078839 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#746521}
-
Xing Liu authored
This reverts commit 91ac1e45. Reason for revert: Breaks downstream test IntentHandlerWithInternalUrlsTest. It still calls static version of the function. https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8886822837374455840/+/steps/compile/0/stdout Original change's description: > Android: Speculative crash fix for DelayedScreenLockIntentHandler > > Stack is: > Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? > at android.app.ContextImpl.startActivity (ContextImpl.java: 952) > at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) > at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) > at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) > ... > > From history on DelayedScreenLockIntentHandler, repro steps involve > launching a page via NFC while locked. > > This restriction is listed as a new one in Android P: > https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required > > Bug: 1034440 > Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746442} TBR=tedchoc@chromium.org,agrieve@chromium.org Change-Id: Ie8a5c401509df389f4a9cefe9b66b54df2cdad2d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1034440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085699Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746520}
-
Alex Cooper authored
This broke in crrev.com/c/2003869, the fix here is to switch to using the cached rather than passed in content offset when in VR. showAndroidControls assumes that the top content offset should be the same as the controls height, but the controls are hidden in VR. Fixed: 1055619 Change-Id: Ife34937ddb06baa0be254b7265181e165781144b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079516 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#746519}
-
behdad authored
Representative perf tests have been running on chromium.gpu as experimental. This change removes the experimental tag: Stats of recent runs on chromium.gpu: 14 flakes in the last 920 runs (1.5% flake rate) Bug: chromium:1000837 Change-Id: Ie6f6d85733f8b63d5cd69636976c1eab93f38250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081190Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#746518}
-
ckitagawa authored
The callbacks passed to PaintPreviewClient were getting run on an arbitrary thread via PostTask. This is a problem as they should be run on the calling thread such that WeakPtrs bound to them are valid. Fix - Make the callbacks run on the same thread that called capture. - Explicitly run CapturePaintPreviewInternal on the UI thread. Follow-up - Make a dedicated SequencedTaskRunner for executing captures. Bug: 1058079 Change-Id: I1dfa969de613112b4bd1650051e394094dffda5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083567 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#746517}
-
Rodney Ding authored
- Add parser/serialization for dictionary type. - SH dictionary is implemented as a custom class containing a std::vector - Add test cases from https://github.com/httpwg/structured-header-tests/blob/master/dictionary.json - Follows Draft 15 of Structured Headers for HTTP - https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html - Replace OWS with SP when skipping whitespace in headers Bug: 993790 Change-Id: If9ae207a7c79e3be70fe0f340adbb51fb3383753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033583 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#746516}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/abc7a30a06c7..126720bd2e57 git log abc7a30a06c7..126720bd2e57 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 jrprice@google.com Use LINK_FLAGS for -BSymbolic in CMake build Created with: gclient setdep -r src/third_party/swiftshader@126720bd2e57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ibdada5aab49cc795e2c9649128096c17513c6f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085024Reviewed-by:
-
Mugdha Lakhani authored
This componentizes both Java and C++ implementation of SecurityStateModel. The dependency on security_state_tab_helper is resolved by adding a SecurityStateModelDelegate interface. Bug: 1052375 Change-Id: Ie6754d27c2c8e6edb1e06ab9b43b840131bee7b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072740 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#746514}
-
Kurt Horimoto authored
This modality can be used in tests rather than choosing an arbitrary modality for the test, reducing the coupling between overlay functionality and specific implementations for the web content area or infobars. This CL adds support for contained and presented overlay UI to test overlay UI code. A follow-up CL will add tests to OverlayPresentationContextImpl that leverages these classes. Change-Id: I648f95a6af1fc78c007fb8d96a7c6ca295928bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068254 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746513}
-
Jeffrey Cohen authored
Bug: 1058073 Change-Id: I97e4c8c135ace3135df3b0cf4880e37c08939460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085159 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#746512}
-
Koji Ishii authored
When r728175 <crrev.com/c/1963597> supported traversing items, it failed to add the size of child inline boxes. The size of an inline box is different from the union of its descendants when it has padding. Bug: 982194 Change-Id: Id2e35cf4136cc0342f509c676f7a678ffcbece80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079775Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#746511}
-
