- 21 Dec, 2019 30 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/988db63351c4..2723af6a6d43 git log 988db63351c4..2723af6a6d43 --date=short --first-parent --format='%ad %ae %s' 2019-12-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2723af6a6d43 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I15353fa613fede632e3c02f83d7050daae70ee3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979599Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727018}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2cb76ab598e5..87d31381588b git log 2cb76ab598e5..87d31381588b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 enga@chromium.org Revert "fuzzing: Add supportsErrorInjection option to DawnWireServerFuzzer" Created with: gclient setdep -r src/third_party/dawn@87d31381588b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id57ba22aa1a07ef4ba52ac39506ef393eabc7dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979507Reviewed-by:
-
Peter Kasting authored
The biggest change here is removing the idea of load success callbacks, which are never used. Bug: none Change-Id: I31c1790e2c7e3bb1c3275327893ddee32533c808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962610 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#727016}
-
chrome://flagsMoe Ahmadi authored
Adds an option to chrome://flags/#omnibox-on-focus-suggestions to enable zero-prefix suggestions on the extension NTP. Bug: 1035711 Change-Id: I5e327828d9b0d7c2895262b00d221f49af0b256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978043 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#727015}
-
Caleb Rouleau authored
I copied the existing win-10-perf shard map since we don't have test runtime data for this yet. That is also why I used only 26 shards for this for now. We can add more shards in later. TBR'ing John since I have Haiyang's non-committer review and this change is low-risk (it only adds a new perf builder and does not affect Chrome.) TBR=johnchen@chromium.org Bug: 998161 Change-Id: I98ab934614380bf5a9678f1765c7f67001a3c7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979094Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#727014}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ic0add2d836abd30fb2ef89afcce3e2b1ac3d9a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979597Reviewed-by:
-
Regan Hsu authored
This is a follow up to https://chromium-review.googlesource.com/c/chromium/src/+/1967803, addressing more complicated cases of using the settings-localized-link element. Bug: 1015924d Change-Id: I38d64731511f8fd64ec474db47327ff4241b4841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971056Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#727012}
-
Evan Stade authored
TBR=avi@chromium.org Bug: 1025256 Change-Id: I2cdc1c86559e3c9217326a452563946fcff149ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972137Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#727011}
-
Connie Wan authored
Changes in this CL: Theme updates: - Refactored TabGroupVisualData to take a TabGroupColorId as the color rather than an SkColor. This required creating a TabGroupColor enum and refactoring restore. - Updated all tab group UI elements to paint a theme-appropriate color (dark or light). ^ This is the source of most of the wide-reaching changes here. Everything below is isolated to 1 or 2 chunks of code, pointed out in comments. Color set updates: - Changed the color values according to crbug.com/1005502 - Changed the hard-coded labels to localized ones. Group updates: - Changed groups to be initialized with the next unused color, rather than a random or default color. - Added tests for group color initialization. Bug: 1030737, 1005502, 1003165 Change-Id: I6c4f8f4df03b6d42a380b38d02334cd90ea4fc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968039 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#727010}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/abc8f2777133..84f45f105bce git log abc8f2777133..84f45f105bce --date=short --first-parent --format='%ad %ae %s' 2019-12-20 cnorthrop@google.com Use checkout_angle_internal for non-public files Created with: gclient setdep -r src/third_party/angle@84f45f105bce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1032708 Tbr: jmadill@google.com Change-Id: Ib3ce9e398b9161b0506c1b61d922e24cfea8a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979405Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/16caad77d2b7..79f568e2863e Created with: gclient setdep -r src-internal@79f568e2863e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ifde1035308493255599573c321f026a6e2f4adc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979589Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727008}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8b876bd4074b..44134341fa8b git log 8b876bd4074b..44134341fa8b --date=short --first-parent --format='%ad %ae %s' 2019-12-20 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@44134341fa8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I85b7ceb7932186c56c8009d7326a19d214f2f6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979593Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d98b8aed. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." 779c13f2 "[IndexedDB] Adding web platform test for File object in IndexedDB." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3085d67f4f3925aaa0f75864e4432785b89f5217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979086Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727006}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/129defb3..3b458621 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If53deb3e5a08c4dd71ff4bc2b16309b58cfa8dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978423Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#727005}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/28b0c5d4b3bb..988db63351c4 git log 28b0c5d4b3bb..988db63351c4 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 khushalsagar@chromium.org gpu: Disable dual source blending support on buggy driver versions. 2019-12-20 bsalomon@google.com Disable advanced blend equations on Imagination driver 1.10 and earlier 2019-12-20 robertphillips@google.com Add BC1_RGB8_UNORM support Created with: gclient setdep -r src/third_party/skia@988db63351c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027981 Tbr: borenet@google.com Change-Id: I62a59943b16c7f7701a95daec820004709568fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979506Reviewed-by:
-
Nathan Zabriskie authored
More work to remove GLInterface from the shared GPU context on the main thread. This updates CopyRenderingResultsFromDrawingBuffer to use the CopySubTexture API on RasterInterface. Bug: 1023252 Change-Id: I2bbc047362fa38bce5a6f698710acdaad95bfadf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960184Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nathan Zabriskie <nazabris@microsoft.com> Cr-Commit-Position: refs/heads/master@{#727003}
-
Yue Li authored
Currently we check if the keyboard has the 'Assistant' key to enable Assistant. It seems some external wireless keyboards report they do have the 'Assistant' key. Since the reason we were checking the keyboard is for nocturne, we decide to only special case board 'eve', 'nocturne' and 'atlas' instead of doing the keyboard layout check. For more background, see discussion in crbug/1025961 Bug: 1025961 Test: Manual Test Change-Id: Iacb42a6b8bfc01b662002f0d93258642b6976ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978838 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#727002}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-foundation/material-font-disk-loader-ios/+log/93acc021e303..8e30188777b0 git log 93acc021e303..8e30188777b0 --date=short --first-parent --format='%ad %ae %s' 2017-02-17 willlarche@users.noreply.github.com [Docs] Clarity in README (#1) Created with: gclient setdep -r src/ios/third_party/material_font_disk_loader_ios/src@8e30188777b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/material-font-disk-loader-ios-chromium Please CC bling-p10-rolls@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:ios-internal-mdc Bug: None Tbr: bling-p10-rolls@google.com Change-Id: I63b7292b633762c3dcbab53498e9cc99bd0ba569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979151Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1e430429c148..254ce3f8dfb0 git log 1e430429c148..254ce3f8dfb0 --date=short --first-parent --format='%ad %ae %s' 2019-12-20 comoody@microsoft.com Add undefined check in contentAsDataUrl to prevent unhandled exceptions 2019-12-20 tmathmeyer@chromium.org Redesign Media properties view Created with: gclient setdep -r src/third_party/devtools-frontend/src@254ce3f8dfb0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:794255 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I048c9e34393e50ace6600a892333f2268b3d27b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979419Reviewed-by:
-
Vincent Scheib authored
TBR=scheib@chromium.org Change-Id: I2b665cc24dea17e3b585df1f925262121f577b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978915Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#726999}
-
rbpotter authored
Remove manage input section from the browser settings resources and move the files to the OS settings. Bug: 990139 Change-Id: I5feac5828b964ee51afae48f6064ae41169ffc76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977840 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Address zmo's comments on the earlier change: https://chromium-review.googlesource.com/1885636 which were published after the CL landed. Bug: 681341 Change-Id: Ib89967cc4f6b7f11371e7694689445d8afc34883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977739 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#726997}
-
Brandon Wylie authored
This reverts commit 24eca4b9. Reason for revert: Crashing Tot Original change's description: > Reparent the current Tab when the theme is changed > > * Creating a class which handles reparenting the current tab when the > theme is swapped. > * Hooking that class into ChromeActivity. > * Adding plumbing to a few ReparentingTask/TabReparentingParams to > facilitate the process. > > Bug: 944302 > Change-Id: I2801eba979b3acafa02856a9053bc474bf2f581c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931763 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Commit-Queue: Brandon Wylie <wylieb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726136} TBR=fgorski@chromium.org,yusufo@chromium.org,wylieb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 944302 Change-Id: If032ff5e4cf61f4047e4cf146c8ae6a03a78aa77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979398Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#726996}
-
Marijn Kruisselbrink authored
Instead of going through mojom::blink::FileUtilitiesHost and passing a path from the renderer back to the browser, add a new method to mojom::blink::Blob to do the same thing. Since the blob already knows what file a blob is referencing, this both makes things slightly more secure (or at least gets us closer to a place where we can get rid of things like ChildProcessSecurityPolicyImpl::CanReadFile) and makes this work in a couple more cases after a File is for example postMessaged to a worker or frame in a different process as well. Additionally this gets us closer to unifying what the renderer and browser processes consider to be "the" snapshot state of any particular blob. In a follow-up CL the browser side code will change to return its snapshot state (if any), rather than always returning the current state on disk. This is part of a series of changes to improve consistency surrounding how snapshot state of files/blobs is implemented. Bug: 844874 Change-Id: Ia05cfd21a3d78955ff70933995e93bbe59e3bb3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970301 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#726995}
-
Khushal authored
If the frame count of an image decreases after appending more data to it, the image is assumed to be broken. Avoid painting such images. This can result in fatal errors in the downstream code. And also miscellaneous cleanups. R=pdr@chromium.org Bug: 867479 Change-Id: I90b5c7030f80076fdc44beb88910667c6182cb8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972904 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#726994}
-
Nate Fischer authored
This CL completes the basic implementation of the flags UI. During startup, the embedded WebView implementation will check if the user has enabled developer mode, and if so, fetch the flag overrides from the service. This uses a ContentProvider instead of an aidl method on the service interface for the sake of a simple synchronous IPC. Although aidl itself supports synchronous IPC, the Android framework only supports binding to the service asynchronously. We require fully synchronous IPC so we can block startup while we fetch the flags. Now that we've settled on using a ContentProvider to plumb information from the developer UI to embedded WebViews, this changes "developer mode" to be defined by the ContentProvider's state rather than the Service's state, which has the side benefit of simplifying some of the Activity/Service code. We rely on PackageManager APIs to check if developer mode is enabled. The check itself should have very little impact to startup time, since PackageManager caches its state in RAM. I benchmarked this check (when developer mode is disabled) at 0ms on my Google Pixel 2 device. For simplicity, we do not care about performance when developer mode is enabled, as this is not the usual user experience. Bug: 981143 Test: Manual - toggle debug border flag, start WebView shell, see borders Test: Benchmark isDeveloperModeEnabled() with System.currentTimeMillis() Test: run_android_webview_junit_tests -f *ServiceNamesTest* Change-Id: I7cc67d1bdf8f0f2ce0fce714fb359160899354a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977828 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#726993}
-
Jordan Bayles authored
https://chromium.googlesource.com/openscreen/+log/2c5e3d4c9d60..8b5e9a4830ef $ git log 2c5e3d4c9..8b5e9a483 --date=short --no-merges --format='%ad %ae %s' 2019-12-20 jophba Fix build issues in Chrome causing unit tests build to fail 2019-12-18 rwkeane mDNS: Add Known Answer Suppression to Querier 2019-12-20 rwkeane mDNS: Responder Known Answer Suppression 2019-12-19 btolsch Clear fqdn in mDNSResponder setup Created with: roll-dep src/third_party/openscreen/src TBR=mfoltz@chromium.org Change-Id: Ic815d00d8e490271c395b9caaba56e454471fa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978845Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org> Cr-Commit-Position: refs/heads/master@{#726992}
-
Balazs Engedy authored
These histograms were recorded under the incorrect name: Permissions.Prompt.Disposition.* Bug: 986737, 1036520 Change-Id: I6d27725257bbc96d1b18ec20c67d7e28533b6ac4 TBR: andypaicu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978692 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#726991}
-
Chris Harrelson authored
Previously, they could be invoked directly by load events (which would sometimes force layout first, and sometimes not). This is problematic because layout may not be clean, and forcing layout is not straightforward or desirable in these cases. Now the fragment anchors can only be invoked during the main lifecycle or a forced layout (*), and in both cases after layout is done. In order to make sure that one of these occurs during page load, queue an animation frame after finishing load of the document (this is where previously it would have synchronously invoked the fragment anchor), or setting a fragment anchor. (*) We still need fragment anchors to be invoked by forced layouts, because script is allowed to change anchors and read back their results synchronously, and this is necessary for web compatibility. Bug: 1018632 Change-Id: I6121962e12e50913a58a80330a3b5de96fef5f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935508 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#726990}
-
Manas Verma authored
This will allow to replace ".is_dict()" or ".is_none()" checks to ".has_value()" checks. Bug: 949269 Change-Id: I5cfd37515cdbed4f765b80bfc213877a2458d0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972948 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#726989}
-
- 20 Dec, 2019 10 commits
-
-
David Black authored
This is a reland of 7511f14a Original change's description: > Remove animator implementations from UiElementContainerView. > > This is part of a multi-CL effort to clean up the Assistant UI element > modeling/rendering pipeline. This CL simply moves the ElementAnimator > implementations that were previously in UiElementContaienrView into > AssistantUiElement. In the future, UiElementContainerView will have no > concept of AssistantTextElementView or AssistantCardElementView, it > will only understand AssistantUiElementView. > > More details of the effort in the bug. > > Bug: b:145003512 > Change-Id: I0228556d5837f5466ca8fd5f9fc59c6ffd1239a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954666 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726636} Bug: b:145003512 Change-Id: I833ca7d8c4713a1d13f4db6ba36911fd486f1ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979401Reviewed-by:
-
Nikita Podguzov authored
Bug: 964919 Change-Id: I2122c17fac16f0ba01995402cf4a00fca15a31a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978010Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#726987}
-
John Lee authored
This CL updates the New Tab button to have fixed positioning. This CL also updates the scroll animation so that it takes the edge of the New Tab button as the right-most boundary, instead of the edge of the viewport. Bug: 1032650 Change-Id: If656545b5d4b4a50197a5f0d94baeb26b6f7df09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977841Reviewed-by:
-
Mark Schillaci authored
Re-enabled the mark.html and ins.html DumpAccessibilityTreeTest's on Android platform with updated expected output. Bug: 413531 Change-Id: I52fbe1c3ec05be2507eaeab6ffd680bbbeccdecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979352 Commit-Queue: Mark Schillaci <mschillaci@google.com> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#726985}
-
Donn Denman authored
Updates the "Long-press Resolves" Feature to only have one experiment arm. We had a few others, but when talking with privacy it became pretty clear that we only need one. BUG=956277 Change-Id: I7404fd87656f144b36e44671a17f03546979fb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971226 Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#726984}
-
Mustaq Ahmed authored
This CL gets rid of the classes WebScopedUserGesture (WSUG) and WebUserGestureIndicator (WUGI), by introducing the following new methods on WebLocalFrame: - NotifyUserActivation for WSUG ctor, - HasStickyUserActivation for WUGI::IsProcessingUserGestureSinceLoad, - HasTransientUserActivation for WUGI::IsProcessingUserGesture, and - ConsumeTransientUserActivation for WUGI::ConsumeUserGesture. Other related changes done here are: - rename {Frame,FrameTreeNode}::HasBeenActivated() to HasStickyUserActivationrelated for consistent names across the board, - rename Frame::ClearActivation to ClearUserActivation for overall clarity, - move LocalFrame::HasTransientUserActivation() to Frame hide the state from subclasses. dvadym@chromium.org, jbroman@chromium.org, rdevlin.cronin@chromium.org Bug: 959850 Change-Id: I8f38bfd1a219e952225de533a53ddf9caf0e994c TBR: alexmos@chromium.org, chcunningham@chromium.org, dcheng@chromium.org, Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968967 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#726983}
-
James Cook authored
Show the existing browser sync consent dialog when the first browser window opens. Long-term we will add a first-run "welcome" WebUI, which will instantiate the helper. For now this unblocks development on other browser sync settings UI. Basically, the parts that observe the browser list are speculative, everything else we will probably keep. Screenshot: http://screen/CLjXCGd5SQn Bug: 1013466 Test: added to unit_tests Change-Id: I8510527b692daf42e3a87e40f4fc5ca36c7f8993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930946Reviewed-by:
-
Peter Kotwicz authored
This CL moves SyncAndServicesPreferencesTest#waitForActivityState() to ApplicationTestUtils where it can be shared with WebApkActivityTest, BookmarkTest and ApplicationTestUtils#finishActivity() BUG=1015449 Change-Id: I929b308722e8c575ca8dcf5e82a33ace4afa6200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977742Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#726981}
-
Eric Karl authored
We had a number of different test SharedImageBackings. Centralize these in one file. Bug: 1003686 Change-Id: I09897394248a4aa560dffb84ce96f459db8d6821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974605 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#726980}
-
Andreas Haas authored
This reverts commit dd88bcce. Reason for revert: There was a bug in the CL, that I can only fix after my vacation. Original change's description: > [webgl] Introduce ExtraceDataLengthIfValid helper function > > As discussed in https://crrev.com/c/1970172, this CL introduces a helper > function to check the size of an ArrayBuffer and creates an error if it > exceeds the maximum supported size. > > R=kbr@chromium.org > > Bug: chromium:1008840 > Change-Id: If8eaa8686f9f787484e094e78deaf741cdc436d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972145 > Commit-Queue: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#726341} TBR=kbr@chromium.org,ahaas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1008840 Change-Id: Ic1a96bd8266a898f9f840cb26c55cfacd368af97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978691Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
