- 10 Dec, 2019 40 commits
-
-
Maksim Moskvitin authored
This reverts commit 45b7e665. Reason for revert: compile failure Original change's description: > Roll src/third_party/perfetto 49d99fe889d2..78598b90be18 (3 commits) > > https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..78598b90be18 > > git log 49d99fe889d2..78598b90be18 --date=short --first-parent --format='%ad %ae %s' > 2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping" > 2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ... > 2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables > > Created with: > gclient setdep -r src/third_party/perfetto@78598b90be18 > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/perfetto-chromium-autoroll > Please CC perfetto-bugs@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > Bug: chromium:135177627 > Tbr: perfetto-bugs@google.com > Change-Id: Ifb16485d12c872534e9c9947a333bc1b338a3ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960386 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#723356} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com Change-Id: I432ac756993a2a663b9b8ef22d8dbdf83fdc0d99 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:135177627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960452Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#723367}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ce38cc10b0ba..f880a70cb757 git log ce38cc10b0ba..f880a70cb757 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 tvanderlippe@chromium.org Reland "Migrate test_runner/ to ESM" 2019-12-10 aerotwist@chromium.org Adds migration script for refs Created with: gclient setdep -r src/third_party/devtools-frontend/src@f880a70cb757 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1019182,chromium:1032477 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idc6cbb5895363e25b0e609ff02e12c644f696c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723366}
-
Gauthier Ambard authored
This CL stops the NTP coordinator when the NTP should be hidden. This is necessary because crrev.com/c/1953764 remove the call to -stop in dealloc for the coordinators. Fixed: 1032191 Change-Id: Ibcd22388b0759ca1ba87cb302dbadb3f3a2277f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959002Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#723365}
-
Mohammad Refaat authored
SessionService has a savesession method which used to take a code block that creates a session and execute with a delay. The problem with that is it depended on TabModel existence to check if it can create a session for saving or not. Instead create a real SessionIOSFactory for now it's owned by TabModel, but later it will be owned by SessionRestorationAgent. The SessionIOSFactory will have a webStateList and will create a sessionIOS object serializing this webStateList when it's asked for. It's assuming that as long as the object for the SessionIOSFactory is alive, then the member webStateList will be alive. So it can use it directly to create a session whenever it needs to. SessionService now takes the factory as a weak pointer and it doesn't retain it. So if the owner is deallocated (now it's the TabModel, and it will be SessionRestorationAgent later) then the factory will be nil and it will not create a session. Bug: 1010164 Change-Id: Ie168fc26a57997be59e123f4ac449d063a3de929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953084Reviewed-by:
-
Christopher Grant authored
Bug: None Change-Id: Ied465ba1ddd300685376b8bded596cbcb7ba757f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958710 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#723363}
-
Hajime Hoshi authored
R=yuzus@chromium.org NOTRY=true Change-Id: I1fe2e132c4f582fae0e33b450d1f31765d8a4b63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954812Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#723362}
-
W. James MacLean authored
We can create a spurious MimeHandlerViewContainerManager (MHVCM) if we try to destroy a frame container where none exists (e.g. the AssociatedInterfaces framework instantiates a new MHVCM in order to dispatch the DestroyFrameContainer message). While this ideally should not happen (https://crbug.com/1027198), if it does we should remove the spurious MHVCM to avoid causing problems with print dialogs. Bug: 1013635 Change-Id: Iba6c1d8eaf1970b3bcdcb9e96c834ada7c0ed0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929399Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#723361}
-
Elly Fong-Jones authored
This change breaks deps on: * ExtensionInstalledBubble::options() * ExtensionInstalledBubble::browser() * ExtensionInstalledBubble::GetAnchorPoint() The options one is annoying - there is a function called `GetOptionsForExtension` that computed a bitfield here to be passed into the view itself. This change replaces that function and that bitfield with a bunch of free functions, each of which compute one of the option values. I think the overall result is easier to reason about. The browser one is straightforward. The GetAnchorPoint one was dead code in Views anyway - the implementation actually lives in this file in //cbui/v and not with the rest of the class, and it simply does: gfx::Point ExtensionInstalledBubble::GetAnchorPoint( gfx::NativeWindow window) const { NOTREACHED(); // There is always an anchor view. return gfx::Point(); } So the code now checks and relies on that assumption. Bug: 496955 Change-Id: Ic5d32d33bb6f50a02d95e46c4d937605f2aa88b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958827 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723360}
-
Raphael Kubo da Costa authored
set_permission.html was renamed to set_permission.https.html in https://crrev.com/c/1958825, but for some reason this old expectation file was not removed. TBR=smcgruer Change-Id: Iba55d41cf45c3b15af1d2d0d7bd10e572bbefe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959972Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#723359}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4cf92db35cb9..bb7c3388a50c git log 4cf92db35cb9..bb7c3388a50c --date=short --first-parent --format='%ad %ae %s' 2019-12-10 capn@google.com Remove Visual Studio Vulkan project files Created with: gclient setdep -r src/third_party/swiftshader@bb7c3388a50c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: If32ba7c8d4a8bd0c52b1740bc542d78ad171014e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960387Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7dab0d16f191a89f955203c779bd4882a66594eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956971Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#723357}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/49d99fe889d2..78598b90be18 git log 49d99fe889d2..78598b90be18 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 lalitm@google.com Merge "trace_processor: fix null dereference in ref_type mapping" 2019-12-10 khokhlov@google.com Merge changes I93bf64ce,Ib30d867e,Iab2e2b59,I4b7109d2,I511b1782, ... 2019-12-09 lalitm@google.com trace_processor: migrate slice table to new database tables Created with: gclient setdep -r src/third_party/perfetto@78598b90be18 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:135177627 Tbr: perfetto-bugs@google.com Change-Id: Ifb16485d12c872534e9c9947a333bc1b338a3ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960386Reviewed-by:
-
Maksim Moskvitin authored
This reverts commit f2da03d5. Reason for revert: likely culprit for compare_build_artifacts failures on Deterministic Linux (dbg). See crbug.com/1032241 (#20-#23). Original change's description: > Roll clang n332890-c2443155-1 : n333441-a3839693-1. > > Ran `tools/clang/scripts/upload_revision.py a38396939c548f9ad8e94c9baa7198fdb26dedc2`. > > Bug: 1030664 > Change-Id: I75c3a43c4f66fe8d850902c60eead4ff6991fba1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958044 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#723039} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Iefc4ab5e5b0afe379e3fabd174703baf57f8e3d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1030664, 1032241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960270Reviewed-by:
-
Justin Miron authored
This change introduces a new histogram, HeavyAds.NetworkBytesAtFrameUnload, which records a frame's network bytes when it is unloaded by the heavy ads intervention for network usage. This enables monitoring the discrepancy in network byte usage from the intervention limits due to asynchrony between the browser and renderer processes. BUG=985890 Change-Id: Ibf0cc400ada3423459e29a07d374e8a8b7ff33bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954736Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#723354}
-
Internal Frameworks Autoroller authored
TBR=eugenebut@google.com Change-Id: I223cd0bf8be6b301f78bc431f594887a6aa1a0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960405Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723353}
-
danakj authored
The callback is called more than once, so it is a RepeatingCallback. Changes all callers from Bind() to BindRepeating() as well. R=avi@chromium.org, wjmaclean@chromium.org TBR=wjmaclean Bug: 1007763 Change-Id: Ia64cbefbbaadb63f502f44711ffb05bc4df50e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957849 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#723352}
-
Alice Wang authored
This CL adds a test for the integration of AccountPickerDialogFragment in SigninFragmentBase. Bug: 967374 Change-Id: I1808711c23dfa4e29e9fd98789499a2d11aeda6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954514 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#723351}
-
danakj authored
This converts single use callbacks for histograms, flash, quotas and push messaging. R=avi@chromium.org TBR=halliwell Bug: 1007763 Change-Id: I2ace97cfeba4d66294636cfe34d81b03ce332d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958691 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
enum and dictionary definitions in Web IDL are string and string-to-something map, and thus it doesn't make sense to limit accesses. This CL removes [Exposed] on CSSNumericBaseType (enum) and CSSNumericType (dictionary) to make them consistent with their current spec. Because of the reason described first, this CL doesn't change actual behaviors. Bug: 839389 Change-Id: I6bb9212f648a6e2345a46eb14ea1a12c46d530a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960089 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#723349}
-
Michael Crouse authored
This change adds metrics to record when the prediction manager determines if a navigation should be targeted. The metric records status of the model needed for the optimization target when an evaluation is made. The metric will inform how often the manager and store cannot make a decision because of a model not being available/loaded. Bug: 1001194 Change-Id: I020718f4a669e620af39b2cda3ae97536e880fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954331Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#723348}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 53a1c85f. With Chromium commits locally applied on WPT: a50e7e60 "Move `Sec-Fetch-User` to SetSecFetchMetadataHeaders." eb00b4d6 "LazyLoad: move invisible-image.html test to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Idbbc22540be21a86360d7be40e6c5177b78007a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959609Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723347}
-
Jan Wilken Dörrie authored
r696337 created a //chrome/browser/touch_to_fill component containing most of the classes related to the Touch To Fill feature. So far a notably hold-out is the TouchToFillController, which currently still lives in //chrome/browser/password_manager. This change fixes this by moving the controller to the touch_to_fill component as well. TBR=dvadym Bug: 957532 Change-Id: I949627e2154af4499c28ef4ec18d8e932434807b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960150 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#723346}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/808d9949c3eb..ce38cc10b0ba git log 808d9949c3eb..ce38cc10b0ba --date=short --first-parent --format='%ad %ae %s' 2019-12-10 yangguo@chromium.org Sync webtests with upstream 2019-12-10 yangguo@chromium.org Roll upstream changes Created with: gclient setdep -r src/third_party/devtools-frontend/src@ce38cc10b0ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I405215839aef7f9794b10741dc5b986a3cea953b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960385Reviewed-by:
-
Vikas Soni authored
Re-enable AImageReader on Imagination and Nvidia GPUs since few bug fixes related to memory regressions have been landed and we expect those fixes might have also fixed the crashes we were seeing. Will need to revert this CL if it causes crashes. Since the crashes are not reproducible locally, there is no other way to test this expect removing the GPU family from the blacklist and hence enabling it on ToT. Bug: 1013797 Change-Id: Iec2c1b60d7e106e77011c65c260d49bead0edf54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956279 Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#723344}
-
Maria Kazinova authored
Bug: 875768 Change-Id: Ic8b4a7c655da4689ea1d032215477bb5a0945a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959967 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#723343}
-
Andrew Grieve authored
This reverts commit 284e5b27. Reason for reland: Added data_dep Original change's description: > Revert "Android: Use JDK11 for java_binary() targets" > > This reverts commit d58a64ea. > > Reason for revert: bin/java_deobfuscate missing jdk11 data dep. > E.g.: https://chromium-swarm.appspot.com/task?id=4905043f5f95d410 Change-Id: Ic998a1ea7f2d8fbd6f24617eb3146f09914d9bf8 Bug: 693079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959529 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#723342}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4984ca9a203f..6ee0ceeba07c Created with: gclient setdep -r src-internal@6ee0ceeba07c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99ace910a4a1c04ca298e1d163965d7a415d667c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960134Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#723341}
-
Jérôme Lebel authored
Fully splitting ":test_support" and ":fake_chrome_identity". ":test_support" should never be included in eg_test_support+eg2 targets. Updating all targets using "browser/signin" to choose either ":test_support", ":fake_chrome_identity", or both if needed. Bug: 987646 Change-Id: Ie90f4a73283fc1e2fe9b231a3f6de9a2e15e52c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954482 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#723340}
-
Mikel Astiz authored
displayKeyRetrievalDialog() is now implemented in the most basic form. It relies on a backend (embedder-specific) providing an Intent that will upon completion expose the newly-fetched keys via fetchKeys(). In this simplest form, key retrieval will only take effect after the browser is restarted, which is suboptimal, but TODOs have been added to improve such behavior in the future. Bug: 1012659 Change-Id: I6b1974916f5d94cfcdc0507e0dcdf5746ccf2314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951006 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Matt Menke authored
URLLoaderInterceptors take net error codes, not URLRequestStatuses (which is deprecated, and shouldn't be used anywhere). Both, unfortunately have values of 0. Bug: 651119 Change-Id: Ic0bc52c1f1c338b18449f2c684ad481f526d72e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955904Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#723338}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/d00dfe493098..4cf92db35cb9 git log d00dfe493098..4cf92db35cb9 --date=short --first-parent --format='%ad %ae %s' 2019-12-10 bclayton@google.com Vulkan/Debug: Add ID Created with: gclient setdep -r src/third_party/swiftshader@4cf92db35cb9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I617e9bc9649f3b29c6e2c2f97ccb48c2ee5a965c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960131Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3e4e569cd257..808d9949c3eb git log 3e4e569cd257..808d9949c3eb --date=short --first-parent --format='%ad %ae %s' 2019-12-10 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update Devtools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@808d9949c3eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia24ceb173a2110ef2cd63f76a3304f94946ba799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960133Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00d0f178c2e0..ded86c1ad80b git log 00d0f178c2e0..ded86c1ad80b --date=short --first-parent --format='%ad %ae %s' 2019-12-10 peah@webrtc.org Remove remaining settings for using legacy AEC 2019-12-10 jonasolsson@webrtc.org Ensure loss-based controller is always enabled. 2019-12-10 yvesg@webrtc.org [UBSan] Remove suppression for opus. 2019-12-10 daniel.l@hpcnt.com Fix nullablity on CameraCapturer 2019-12-10 anderskl@microsoft.com Remove MessageBoxA UI API call from socket code 2019-12-09 mellem@webrtc.org Add VideoTimingExtension to kFecOrPaddingExtensionSizes. 2019-12-09 anderskl@microsoft.com Don't try to load kernel32.dll in RWLockWin class 2019-12-09 yvesg@webrtc.org Roll chromium_revision 34a43a35..59395671 (722057:722888) 2019-12-09 kron@webrtc.org Revert "Distinguish between send and receive video codecs" 2019-12-09 kron@webrtc.org Distinguish between send and receive video codecs 2019-12-09 yinwa@webrtc.org Add directive to make webrtc metrics optional. Created with: gclient setdep -r src/third_party/webrtc@ded86c1ad80b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737,chromium:941413 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1f76257a2d3a37f0e26ff5e4b6d88f53797a0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960132Reviewed-by:
-
Balazs Engedy authored
Even if displaying notification permission requests using the quiet UI is enabled on all sites, the NotificationPermissionUiSelector should still check the crowd deny state. If crowd deny prescribes triggering, QuietUiReason::kTriggeredByCrowdDeny should be returned instead of kEnabledInPrefs, so that the less-prominent version of the UI and the correct string is shown. Bug: 1032043 Change-Id: I29f6b1773131f74952ef5816ffd2518c0d91fc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958137 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#723334}
-
Bartek Nowierski authored
This change adds use counters for counting V8 function calls in detached windows. They aren't emitted the usual way, because the use counter infrastructure doesn't work on detached windows. Instead they're plumbed through instance counters to be emitted via UKM. NOTE! This re-introduces the following change (but without web feature definitions, which were redundant): https://chromium-review.googlesource.com/c/chromium/src/+/1925839 TBR=rkaplow@chromium.org,asvitkine@chromium.org rkaplow or asvitkine: Please approve changes to ukm.xml and process_memory_metrics_emitter.cc; these files haven't changed since 1925839, which Robert approved before. Bug: chromium:1018156 Change-Id: If16c3a85bfe539c202561d435576f1df80f060bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958487 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#723333}
-
Philipp Hancke authored
visualizes headerBytesSent/Received similar to bytes sent/received BUG=webrtc:10525 Change-Id: I0b7d4b52b00c8fc0b6a4b11244fd08e313a4f823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953741 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#723332}
-
Jeremy Roman authored
Without this, the Portal could be notified of its owned WebContents' destruction while it is running its own destructor, causing to to reenter its destructor, leading to all manner of badness. Bug: 1031677 Change-Id: I89d8737e2c30ffb0d67c04ea0ccad577575d9a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958597 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#723331}
-
Alex Chau authored
Bug: 1029747, 1029483 Change-Id: I21df2348104a96771cbce39065a430c48bca734b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960268Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#723330}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/43e0973176a3..4984ca9a203f Created with: gclient setdep -r src-internal@4984ca9a203f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9578e19c0dd45dda38de9c3d36b5773327e45a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960129Reviewed-by:
-
Xianzhu Wang authored
- Paint VisualViewport after all other contents, to make sure the scrollbars appear on the top; - When device emulation transform node exists, the scrollbars' transform space should be the device emulation transform; - Should repaint VisualViewport when its paint property nodes are created or removed. Device emulation transform node is the only case. One android render test is rebaselined: chrome/test/data/android/render_tests/ReturnToChromeTest.10_web_tabs-select_last.Nexus_5-19.png.sha1 See https://storage.cloud.google.com/chromium-result-details/b1cb5fb6fee47559ba4cac31a006bc6c2cdc40eb for the difference. The new result has scrollbars in the thumbnails in the tab grid view. Bug: 1028079 Change-Id: Ic52179014e2538025c74ba47112a2b307dd2943e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956968 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#723328}
-
