GitLab

Revert of Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks. (patchset #4 id:80001 of https://codereview.chromium.org/2181553003/ )

Reason for revert:
Speculative revert to see if this caused crbug.com/631190. App banners use methods touched by this CL to check if a service worker is registered; this is the only relevant-looking CL in the blamelist for the app banner data fetcher tests starting to fail on the Win7 SP1 bot.

This CL will be relanded if re-enabling the disabled app banner data fetcher tests still causes failures on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

Original issue's description:
> Stop passing const-reference of SWRegistration in all GetRegistrationsCallbacks.
>
> BUG=616502
>
> Committed: https://crrev.com/36986071183bdb219186aa9f63f9ee4b162d91b9
> Cr-Commit-Position: refs/heads/master@{#407487}

TBR=nhiroki@chromium.org,peter@chromium.org,dgozman@chromium.org,mmenke@chromium.org,jkarlin@chromium.org,horo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=616502

Review-Url: https://codereview.chromium.org/2183783002
Cr-Commit-Position: refs/heads/master@{#407715}

This reverts commit 2cba6671.

Reason: Speculative revert so that crrev.com/2181553003 can be reverted.
This may have caused crbug.com/631190.

This CL will be relanded if reverting the dependent CL and re-enabling
the disabled app banner data fetcher tests still causes failures on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29

TBR=horo@chromium.org,jochen@chromium.org,nhiroki@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=631190

Review-Url: https://codereview.chromium.org/2181983002
Cr-Commit-Position: refs/heads/master@{#407714}

Reland of current program can be null in ES2/ES3 contexts. (patchset #1 id:1 of https://codereview.chromium.org/2181193002/ )

Reason for revert:
I don't think this is related.  See crbug.com/631316 and here the conversion between me and Mark.

Original issue's description:
> Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ )
>
> Reason for revert:
> Caused webkit test failure on WebKit Win7 (dbg)
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624
>
> unexpected_failures:
> printing/webgl-oversized-printing.html
> virtual/threaded/printing/webgl-oversized-printing.html
>
> https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html
>
> ---
> --- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
> +++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
> @@ -1,5 +1,5 @@
> -PASS successfullyParsed is true
> +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
> +FAIL successfullyParsed should be true. Was false.
>
>  TEST COMPLETE
> -PASS Printed without crashing.
> ---
>
> ---
> --- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
> +++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
> @@ -1,5 +1,5 @@
> -PASS successfullyParsed is true
> +CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
> +FAIL successfullyParsed should be true. Was false.
>
>  TEST COMPLETE
> -PASS Printed without crashing.
> ---
>
> Original issue's description:
> > current program can be null in ES2/ES3 contexts.
> >
> > They are only required to be non null in WebGL.
> >
> > This also did some clean up and a minor optimization.
> >
> > BUG=630802
> > TEST=fuzzer case in the bug
> > R=piman@chromium.org
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> > Cr-Commit-Position: refs/heads/master@{#407659}
>
> TBR=piman@chromium.org,yunchao.he@intel.com,zmo@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630802
>
> Committed: https://crrev.com/e9c2cd979c8114b75bbc2640a43a1371d64f502b
> Cr-Commit-Position: refs/heads/master@{#407711}

TBR=piman@chromium.org,yunchao.he@intel.com,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802

Review-Url: https://codereview.chromium.org/2186473002
Cr-Commit-Position: refs/heads/master@{#407713}

Move Node::*editable* functions to core/editing/EditingUtilities

TEST=No change in behavior

Review-Url: https://codereview.chromium.org/2177783003
Cr-Commit-Position: refs/heads/master@{#407712}

Revert of current program can be null in ES2/ES3 contexts. (patchset #2 id:20001 of https://codereview.chromium.org/2174173002/ )

Reason for revert:
Caused webkit test failure on WebKit Win7 (dbg)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6624

unexpected_failures:
printing/webgl-oversized-printing.html
virtual/threaded/printing/webgl-oversized-printing.html

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win7__dbg_/6624/layout-test-results/results.html

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

---
--- E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-expected.txt
+++ E:\b\rr\tmpymgexl\w\layout-test-results\virtual/threaded/printing/webgl-oversized-printing-actual.txt
@@ -1,5 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE ERROR: line 13: Uncaught TypeError: Cannot read property 'clearColor' of null
+FAIL successfullyParsed should be true. Was false.

 TEST COMPLETE
-PASS Printed without crashing.
---

Original issue's description:
> current program can be null in ES2/ES3 contexts.
>
> They are only required to be non null in WebGL.
>
> This also did some clean up and a minor optimization.
>
> BUG=630802
> TEST=fuzzer case in the bug
> R=piman@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/14ef40159115ca5059907835a34bcd1667af7631
> Cr-Commit-Position: refs/heads/master@{#407659}

TBR=piman@chromium.org,yunchao.he@intel.com,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630802

Review-Url: https://codereview.chromium.org/2181193002
Cr-Commit-Position: refs/heads/master@{#407711}

R=tsergeant@chromium.org
BUG=630619
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2182863002
Cr-Commit-Position: refs/heads/master@{#407710}

Add blink::WebInputElement::filteredDataListOptions(), and it implements the
filtering logic which was in GetDataListSuggestions().
The logic should be in Blink because it affects a web-platform behavior.

This CL doesn't have behavior changes.

BUG=153991

Review-Url: https://codereview.chromium.org/2174303002
Cr-Commit-Position: refs/heads/master@{#407709}

Revert of Hack to fix settings-checkbox mixin for 1.6.0 (patchset #2 id:20001 of https://codereview.chromium.org/2168383003/ )

Reason for revert:
Not required if we disable useNativeCSSProperties for 1.6.0.

Original issue's description:
> Hack to fix settings-checkbox mixin for 1.6.0
>
> BUG=
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/8f718e9ac7ba2194633a6a827a0dbc57570714a7
> Cr-Commit-Position: refs/heads/master@{#407347}

TBR=dbeam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

Review-Url: https://codereview.chromium.org/2179053002
Cr-Commit-Position: refs/heads/master@{#407708}

I didn't see these failures in the original lists I checked.

TBR=dominickn@chromium.org

BUG=631190

Review-Url: https://codereview.chromium.org/2183743002
Cr-Commit-Position: refs/heads/master@{#407707}

- highlight errors in snippet source;
- fix location of Syntax Errors in console messge;
- fix location of Snippet result in console message

BUG=479712
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2173233002
Cr-Commit-Position: refs/heads/master@{#407706}

Review-Url: https://codereview.chromium.org/2180853003
Cr-Commit-Position: refs/heads/master@{#407705}

Cast device certificates may be revoked through two ways:
1. The hash of the public key.
2. A serial number range for an issuer identified by the hash
   of its public key.

A customized proto is used as the medium for this information.

This change contains the implementation for verifying the custom CRL
and verifying a certificate's revocation status based on that CRL.

BUG=618463

Committed: https://crrev.com/698608f28ed2df276f920c9691cbfcb8f9069337
Review-Url: https://codereview.chromium.org/2050983002
Cr-Original-Commit-Position: refs/heads/master@{#407492}
Cr-Commit-Position: refs/heads/master@{#407704}

Currently Tab is consuming the device BACK key even when suggestion window
is visible and doing page navigation instead of dismissing suggestion
window. Added changes to consume BACK key at suggestion window, so that
it can consume BACK key and execute respective actions.

BUG=630633

Review-Url: https://codereview.chromium.org/2174633004
Cr-Commit-Position: refs/heads/master@{#407703}

This only affects the Linux build.

BUG=607968

Review-Url: https://codereview.chromium.org/2158753003
Cr-Commit-Position: refs/heads/master@{#407702}

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Review-Url: https://codereview.chromium.org/2167383003
Cr-Commit-Position: refs/heads/master@{#407701}

Reland of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #1 id:1 of https://codereview.chromium.org/2183433003/ )

Reason for revert:
The CL was blamed for compile failures it didn't cause, re-landing.

Original issue's description:
> Revert of HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes. (patchset #4 id:60001 of https://codereview.chromium.org/2170133004/ )
>
> Reason for revert:
> Speculative revert for bug 631246.  Have no better ideas.
>
> Apologies if this wasn't the cause.
>
> Original issue's description:
> > HttpChunkedDecoder: Support chunks longer than 2^31-1 bytes.
> >
> > We were using HexStringToInt to parse chunk size, which returns a
> > 32-bit int.  This CL switches to using HexStringToInt64, which uses
> > 64-bit ints, so we can now support chunks up to 2^63-1 bytes.
> >
> > That should be enough for anybody. [Cue dramatic music]
> >
> > BUG=630680
> >
> > Committed: https://crrev.com/8ea249f8b70f154f9995ed538fc853fe9cf46503
> > Cr-Commit-Position: refs/heads/master@{#407549}
>
> TBR=eroman@chromium.org,mmenke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=630680
>
> Committed: https://crrev.com/2321e8a45603ca595296b67e4d064c070f2b3591
> Cr-Commit-Position: refs/heads/master@{#407651}

TBR=eroman@chromium.org,mpearson@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=630680

Review-Url: https://codereview.chromium.org/2180063002
Cr-Commit-Position: refs/heads/master@{#407700}

This patch updates the code to prevent auto deducing to a raw pointer.

R=dalecurtis@chromium.org
BUG=554600

Review-Url: https://codereview.chromium.org/2181163002
Cr-Commit-Position: refs/heads/master@{#407699}

WebUI URLRequest source data is (on desktop) backed by a memory-mapped
file. Copying that data in CompleteRead can trigger jankiness due to
potential file IO caused by the read.

This CL moves the memcpy on the file thread.

R=dbeam@chromium.org
BUG=455423

Review-Url: https://codereview.chromium.org/2158123003
Cr-Commit-Position: refs/heads/master@{#407698}

Cr-Commit-Position: refs/heads/master@{#407697}

Per-request from rkaplow

BUG=

Review-Url: https://codereview.chromium.org/2168233002
Cr-Commit-Position: refs/heads/master@{#407696}

1/5: Introduce NavigationHintSender.
     https://codereview.chromium.org/2043863003/
2/5: Pipe NavigationHints from NavigationHintSender to ChromeRenderMessageFilter
     https://codereview.chromium.org/2043083002/
3/5: Call StartServiceWorkerForNavigationHint() from ChromeRenderMessageFilter
     This CL.
4/5: Measure the precision of the speculative launch of Service Workers for
NavigationHints
     https://codereview.chromium.org/2045153003/
5/5: Add flags to enable SupeculativeLaunchServiceWorker
     https://codereview.chromium.org/2053573002/

When ChromeRenderMessageFilter receives NavigationHint IPC message, it calls
ServiceWorkerContextWrapper::StartServiceWorkerForNavigationHint().
ServiceWorkerContextWrapper will try to start a Service Worker for the document
which is linked from the anchor element.

This CL depends on https://codereview.chromium.org/2181553003/

BUG=616502

Review-Url: https://codereview.chromium.org/2052613003
Cr-Commit-Position: refs/heads/master@{#407695}

This patch converts "editing/insert-text-with-newlines.html" to use w3c test
harness to simplify test files.

This patch is a preparation of getting rid of grammar checking feature.

BUG=619452
TEST=n/a; this patch changes a test file

Review-Url: https://codereview.chromium.org/2180863002
Cr-Commit-Position: refs/heads/master@{#407694}

TBR=michaelpg@chromium.org
BUG=none
NOPRESUBMIT=true  # crisper.js
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2171073002
Cr-Commit-Position: refs/heads/master@{#407693}

R=michaelpg@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Review-Url: https://codereview.chromium.org/2172833002
Cr-Commit-Position: refs/heads/master@{#407692}

https://chromium.googlesource.com/skia.git/+log/0f7748ab388c..b8113780c3cf

$ git log 0f7748ab3..b8113780c --date=short --no-merges --format='%ad %ae %s'
2016-07-25 bungeman Update typeface serialization style.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2177413002
Cr-Commit-Position: refs/heads/master@{#407691}

This change implements a tweak to the Web Animations spec:
https://github.com/w3c/web-animations/commit/a9ba51338ed09170d16c47317f8e4e2eef122a82

Negative end delay now affects the progress used in the after phase.

Review-Url: https://codereview.chromium.org/2030843002
Cr-Commit-Position: refs/heads/master@{#407690}

R=michaelpg@chromium.org
TBR=michaelpg@chromium.org
BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOPRESUBMIT=true  # crisper.js

Review URL: https://codereview.chromium.org/2158913007 .

Cr-Commit-Position: refs/heads/master@{#407689}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/139402a9056e..47a907219954

$ git log 139402a90..47a907219 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2179013003
Cr-Commit-Position: refs/heads/master@{#407688}

The metric is recorded by Chrome OS session manager:
https://chromium-review.googlesource.com/#/c/361042/

BUG=b/28815532

Review-Url: https://codereview.chromium.org/2175423002
Cr-Commit-Position: refs/heads/master@{#407687}

If user navigates forward and then immidiately back the following
sequence of events happens:

1.) ForwardURL is registered for load
2.) BackURL is registered for load
3.) Loading is stopped and current web view URL is ForwardURL
4.) Did Finish Loading is called and current web view URL is BackURL

On step 3 web should not signal didFinishLoad if
current web view URL != last registered URL, because telling embedder
that load has finished for ForwardURL is false information.

BUG=629565

Review-Url: https://codereview.chromium.org/2169703002
Cr-Commit-Position: refs/heads/master@{#407686}

BUG=598180

Review-Url: https://codereview.chromium.org/2182813002
Cr-Commit-Position: refs/heads/master@{#407685}

Review-Url: https://codereview.chromium.org/2183683002
Cr-Commit-Position: refs/heads/master@{#407684}

he problem of an iterator is that it will be invalid when the vector
reallocates buffer. An index won't be invalid as long as we don't
add/remove any item before the index.

An examples that we had used indices before this CL is
DisplayItemIndicesByClientMap which maps DisplayItemClient to indices
of display items. Iterators don't work because the map is built when we
are adding items into the list. Once the list reallocates the underlying
buffer, all existing iterators might become invalid.

Another example is
m_underInvalidationCheckingBegin/m_underInvalidationCheckingEnd.
Before this CL we had to reset them in appendDebugDrawingAfterCommit()
when the list changes. (I had a hard time debugging a flaky crash caused
by an invalid iterator before adding the reset code.)

Because we have to use indices, if we use iterators we have to convert
between them.

The main purpose of this CL is for https://codereview.chromium.org/2176573004/
which requires us to find a cached chunk by index of a display item.
Otherwise we would add another place converting iterator to index.

This CL doesn't expose indices across public api boundary.

Run 1093 of ct (https://ct.skia.org/chromium_perf_runs/) showed no performance
impact.

BUG=596983

Review-Url: https://codereview.chromium.org/2176683003
Cr-Commit-Position: refs/heads/master@{#407683}

Since HistoryBackend would remove username/password in an url
when write it into DB, Chrome Sync would ignore such url.
But ignore that url won't lost the url since HistoryBackend
will send username/password removed url to sync later.

BUG=629170

Review-Url: https://codereview.chromium.org/2176893002
Cr-Commit-Position: refs/heads/master@{#407682}

This will give content embedders (such as Chromecast) a way to override
supported video codecs logic.

BUG=477103

Review-Url: https://codereview.chromium.org/2153643002
Cr-Commit-Position: refs/heads/master@{#407681}

https://pdfium.googlesource.com/pdfium.git/+log/e283e47..d8cc503

BUG=629919
TBR=thestig@chromium.org

Review-Url: https://codereview.chromium.org/2177383002
Cr-Commit-Position: refs/heads/master@{#407680}

Revert of Remove NativeThemeWin::PaintIndirect (patchset #3 id:40001 of https://codereview.chromium.org/2090003003/ )

Reason for revert:
Directly causes crbug.com/628574, which is ship-blocking; we'll have to find another way to clean up the mess.

Original issue's description:
> Remove NativeThemeWin::PaintIndirect
>
> We don't seem to actually use this complicated codepath in practice.
>
> In particular:
>
> 1. // This block will only get hit with --enable-accelerated-drawing flag.
> That flag is obsolete, and its replacement also seems to no longer exist.
>
> 2. // Scrollbar components on Windows Classic theme (on all Windows versions)
>    // have particularly problematic alpha values, so always draw them
>    // indirectly.
> Turning on the Windows Classic theme on 64b Windows 7, I can't cause the block
> to be hit today.
>
> 3. // In addition, scrollbar thumbs and grippers for the Windows XP
>    // theme (available only on Windows XP) also need their alpha values
>    // fixed.
> We're no longer supporting XP and have been cleared to remove relevant code.
>
> Once it's gone, so are several copies of functions that paint the
> same UI element in different ways depending on whether they're drawing
> to HDC or SkCanvas: Gutter, MenuSeparator, MenuBackground, and
> MenuItemBackground.
>
> R=pkasting@chromium.org
> BUG=543755,579196,622692
>
> Committed: https://crrev.com/83a3c26417896b207efe22b116a03a9a162c0ca5
> Cr-Commit-Position: refs/heads/master@{#404155}

TBR=pkasting@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543755,579196,622692

Review-Url: https://codereview.chromium.org/2181153002
Cr-Commit-Position: refs/heads/master@{#407679}

This refactoring decouples storage models from the ResourceTreeModel.

BUG=624494
R=dgozman, pfeldman

Review-Url: https://codereview.chromium.org/2172753002
Cr-Commit-Position: refs/heads/master@{#407678}

This reverts commit 010e9500.

I set this workaround flag based on misreading a crash report, and
there's actually no evidence that Adreno 5xx has any bugs with
framebuffer discarding.

BUG=612474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2177393003
Cr-Commit-Position: refs/heads/master@{#407677}

R=dgozman@chromium.org
BUG=none

Review-Url: https://codereview.chromium.org/2181453002
Cr-Commit-Position: refs/heads/master@{#407676}