GitLab

They come out looking a little different than the png assets we were
using, which is intentional. Screenshots at 1x and 2x are sgabriel-
approved.

BUG=649545
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2364163002
Cr-Commit-Position: refs/heads/master@{#421266}

This makes the following changes:

- Tweak ERR_BAD_SSL_CLIENT_AUTH_CERT's text be suitable for both
  invalid and missing client certs. net_error_list.h actually already
  documents it for this case, but the user-visible error does not.

- Since TLS lacks a dedicated alert for missing client certificates,
  servers often send a generic handshake_failure alert. Detect this case
  and map to ERR_BAD_SSL_CLIENT_AUTH_CERT.

- One of the many bad client cert alerts is access_denied.
  Unfortunately, that was badly named so firewalls sometimes send it,
  giving users a confusing error page. Detect this case too and map it
  to ERR_SSL_PROTOCOL_ERROR, the same error we would use for an unexpected
  alert.

Add a bunch of tests for these cases.

Screenshot of the new ERR_BAD_SSL_CLIENT_AUTH_CERT:
https://drive.google.com/file/d/0Bz14lOW5Hke4ZzRPLXZwUUlzOFk/view?usp=sharing

BUG=630883,646567

Review-Url: https://codereview.chromium.org/2350483002
Cr-Commit-Position: refs/heads/master@{#421265}

We lacked these ids in OnNewLiveVersion and there were no updates when they changed.

BUG=648775

Review-Url: https://codereview.chromium.org/2365053002
Cr-Commit-Position: refs/heads/master@{#421264}

By default Oilpan has a limit on stackFrameDepth while tracing
HeapVector. Wrap NGPhysicalFragment into TraceEagerlyTrait class to fix that.

BUG=635619

Review-Url: https://codereview.chromium.org/2372573006
Cr-Commit-Position: refs/heads/master@{#421263}

This fixes ChromeOS MSAN bots.
Also do some nitty cleanup.

TBR=yamaguchi@chromium.org

Review-Url: https://codereview.chromium.org/2376733002
Cr-Commit-Position: refs/heads/master@{#421262}

This patch changes the order of shutdown from clearing orphans then
completing tasks to first complete the tasks then clean orphans, since
task completion causes more orphans to be generated.

Also, this adds debugging information to ImageManager to narrow down
the time when crash in the referenced bug happens.

R=ericrk@chromium.org
BUG=650234
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2365303003
Cr-Commit-Position: refs/heads/master@{#421261}

Remove usage of BalsaHeaders from QuicClient. Also move QuicDataToResend from QuicClient to QuicClientBase

Merge internal change: 134215647

Review-Url: https://codereview.chromium.org/2363393004
Cr-Commit-Position: refs/heads/master@{#421260}

This CL significantly cleans up and makes consistent the suborigin
LayoutTests. It updates them to match the service worker style
(https://www.chromium.org/blink/serviceworker/testing#TOC-Layout-Tests-Style)
as best as possible. However, this does leave in place uses of the old
js-test framework, leaving updating to testharness for a later
exercise).

R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2370843003
Cr-Commit-Position: refs/heads/master@{#421259}

This CL merges component.css files into respective component.html files.

This reduces Download's use of the deprecated <link type="css"> syntax
and more closely resembles other MD pages.

While I was at it: shared_styles.css had basically outlived its
usefulness, so I put some --vars in the top-level page and duplicated
a couple of small [hidden] { display: none !important; } rules across
components (because it seems better than making a shared CSS module).

Depends on both of these lovely changes:
https://codereview.chromium.org/2362633002/
https://codereview.chromium.org/2370653002/

R=tsergeant@chromium.org
BUG=650504
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2374473003
Cr-Commit-Position: refs/heads/master@{#421258}

The current decompression code uses the maximum packet length as a
convenient upper bound for the maximum decompressed packet length.
When the length was raised to 20MB, this lazy convenience morphed
into a RAM suck.

This CL grows the decompression buffer across multiple calls to
inflate() until the entire input has been decompressed.

R=scf@chromium.org,lethalantidote@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2363013003
Cr-Commit-Position: refs/heads/master@{#421257}

There was a race condition between Android tests calling
Application#onCreate and TestRunner#runTests which caused flakiness
in some of the UrlManagerTest* and other instrumentation tests.

Initialize the application object earlier so that it is always ready
when tests are run.

BUG=649224,637448

Review-Url: https://codereview.chromium.org/2363323003
Cr-Commit-Position: refs/heads/master@{#421256}

This adds a simple status to show if the task scheduler is instantiated
or not to set up the infrastructure. More information will be added in
subsequent CLs.

BUG=553459
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2349623003
Cr-Commit-Position: refs/heads/master@{#421255}

BUG=614037

Review-Url: https://codereview.chromium.org/2323553002
Cr-Commit-Position: refs/heads/master@{#421254}

https://chromium.googlesource.com/skia.git/+log/6ad6ba44ce3e..53c7bbfaaf80

$ git log 6ad6ba44c..53c7bbfaa --date=short --no-merges --format='%ad %ae %s'
2016-09-27 csmartdalton GN: match shell behavior for cc and cxx in is_clang.py
2016-09-27 mtklein OverAlignedTest: use sk_ malloc and free.
2016-09-27 egdaniel Update vulkan varying locations to correctly handle arrays
2016-09-27 egdaniel Add command buffer submits before copy calls in vulkan.
2016-09-27 borenet Fix dm/nanobench uploads for Gerrit-based trybots
2016-09-27 mtklein Turn on -Wnewline-eof.
2016-09-27 caryclark another attempt to fix nonrectangular
2016-09-27 reed need to apply CTM to clip rect in arithmetic imagefilter
2016-09-27 borenet [task scheduler] Add uploads to tasks.json
2016-09-27 borenet Remove gen_bench_expectations_from_codereview

BUG=617658

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=fmalita@google.com

Review-Url: https://codereview.chromium.org/2372243002
Cr-Commit-Position: refs/heads/master@{#421253}

Currently creating empty range (0,0) triggers it, judging by
the comment it was intende to check null range only.

Review-Url: https://codereview.chromium.org/2373613005
Cr-Commit-Position: refs/heads/master@{#421252}

MessageLoop::QuitWhenIdle() is deprecated. RunLoop should be used
instead.

BUG=616447

Review-Url: https://codereview.chromium.org/2376693002
Cr-Commit-Position: refs/heads/master@{#421251}

SpdySessionPool::CreateAvailableSessionFromSocket() is always called with a
hardcoded OK value for its |certificate_error_code| argument, so this can be
removed.  SpdySession::InitializeWithSocket() is only called from
SpdySessionPool::CreateAvailableSessionFromSocket() with |certificate_error_code
== OK|, so that argument can be removed as well.  Then
SpdySession::certificate_error_code_ member is always OK, so that can be removed
as well.  This makes SpdySession::TryAccessStream() always return OK, so that
can also be removed.

Metrics show that
SpdyProtocolErrorDetails::PROTOCOL_ERROR_REQUEST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION
is almost never (1e-11 of all counts) logged in Net.SpdySessionErrorDetails2.

BUG=624073

Review-Url: https://codereview.chromium.org/2371943003
Cr-Commit-Position: refs/heads/master@{#421250}

Just a cleanup, no added code.
Also added smaller bugs for TODOs in the idl.

BUG=518807

Review-Url: https://codereview.chromium.org/2372163003
Cr-Commit-Position: refs/heads/master@{#421249}

These will tell how often file scheme exceptions have a non-empty
path vs. a wildcard path, and which content settings types use them.

BUG=628759, 621724

Review-Url: https://codereview.chromium.org/2367683002
Cr-Commit-Position: refs/heads/master@{#421248}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b9d66e1fc00f..384efea3161c

$ git log b9d66e1fc..384efea31 --date=short --no-merges --format='%ad %ae %s'
2016-09-27 petrcermak [tracing] Heap dump UI overhaul

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2372183003
Cr-Commit-Position: refs/heads/master@{#421247}

    https://chromium.googlesource.com/chromiumos/chromite.git/+log/0123f4124441..368c3e5db9c9

    $ git log 0123f4124..368c3e5db --date=short --no-merges --format='%ad %ae %s'
    2016-09-23 stevenjb Add --gn-args parameter to deploy_chrome for future use by the chromeos-chrome ebuild.
    2016-09-27 stevenjb SimpleChrome: deploy_chrome: Make libwidevine optional
2016-08-25 nxia Send PUT request for each CQ slave builder to buildbucket.
2016-09-15 pprabhu cbuildbot: Handle stage failures while skipping / waiting uniformly.
2016-09-26 bhthompson Disable vmtests for buddy
2016-09-22 stevenjb cros_chrome_sdk: Elim no longer needed (and incorrect) USE parsing
2016-09-21 vapier lint: handle more section typos
2016-09-21 vapier lint: fix section header detection to avoid arguments
2016-09-20 dgarrett chromeos_config: Add remove_images.
2016-09-20 dgarrett config_lib: Assert if duplicate configs added.
2016-09-19 dgarrett chromeos_config: Discover IS_RELEASE_CHANNEL.
2016-09-19 dgarrett chromeos_config: Use an instance of HWTestList.
2016-09-16 dgarrett chromeos_config: Move per-board configs into new method.
2016-09-19 dgarrett chromeos_config: Move toolchain configs to new method.
2016-09-23 bhthompson Disable VMTests for systems inheriting cheets
2016-09-23 akeshet chromeos_config: temporarily mark guado_moblab-paladin experimental
2016-09-19 akeshet third_party: add gcloud-0.18.1
2016-09-19 akeshet metrics: use seconds units for SecondsDistribution metrics
2016-09-22 chrome-bot Update config settings by config-updater.
2016-09-15 dgarrett chromeos_config: Verify waterfall_layout_dump.txt is current.
2016-09-19 dgarrett Revert "sync_stages: Disable buildbucket."
2016-09-15 dgarrett chromeos_config: Remove smaug-kasan and smaug-kasan-kernel-3_18.
2016-09-15 dgarrett chromeos_config: Remove dead boards.
2016-09-14 dgarrett chromeos_config: Clean up a few more template oddities.
2016-09-14 dgarrett chromeos_config: add CreateBuilderTemplates()
2016-09-14 dgarrett config_lib: Give SiteConfig.Add an explicit template arg.
2016-09-14 dgarrett config_lib: Simplify AddWithoutTemplate.
2016-09-16 sadrul deploy_chrome: Fix deploying mash.
2016-09-14 dgarrett chromeos_config: Remove local config instances.
2016-09-09 nxia Change cache-dir for gclient  inside chroot.
2016-09-20 vapier gerrit: fix submit helper to work with string ids
2016-09-14 nxia Do not mock parallel_unittest.ParallelMock
2016-09-13 kevcheng chromite: Add tags to swarming command and output task id.
2016-09-19 nxia Add --git-cache-dir option in cbuildbot.
2016-09-20 laszio chromeos_config: use 'veyron_jaq' as the arm toolchain builders.
2016-09-20 vapier cros_setup_toolchains: improve logging output
2016-09-15 davidriley report_stages: Add link to Viceroy build details page
2016-09-08 ayatane [chromite] Add system monitor service
2016-09-21 vapier lint: properly handle last line indentation
2016-09-20 chrome-bot Update config settings by config-updater.
2016-09-20 akeshet virtualenv: add a timestamp check for virtualenv updating
2016-09-19 dgarrett sync_stages: Disable buildbucket.
2016-07-11 akeshet ts_mon: update to latest
2016-09-16 akeshet metrics: add SecondsTimer and SecondsTimerDecorator
2016-09-14 akeshet retry_util: make it silent
2016-09-14 dgarrett config_lib: Stop saving unused templates.
2016-09-13 dgarrett chromeos_config: Switch to SiteConfig.templates.
2016-09-13 dgarrett config_lib: Create site_config.templates.<name>.
2016-09-08 dgarrett config_lib: Make it easier to update BuildConfigs.
2016-09-12 dgarrett chromeos_config: Remove unneeded derive.
2016-09-16 chrome-bot Update config settings by config-updater.
2016-09-11 vapier cros_mirror: handle non-manifest branches
2016-09-13 vapier loman: fix subcommand parsing
2016-09-08 dgarrett chromeos_config: Break out default values methods.
2016-09-08 dgarrett chromeos_config: Move GE parsing out of global space.
2016-09-01 vapier fix old optparse references in docstrings
2016-09-14 norvez commands.py: run ctest in verbose mode
2016-09-12 akeshet third_party: add protobuf-3.0.0
2016-09-09 akeshet venv: a simple prototype of virtualenv deployment
2016-09-07 akeshet cidstore: first scaffolding for gcloud datastore wrapper
2016-09-08 akeshet oauth2client: upgrade from 1.5.2 to 3.0.0
2016-09-08 akeshet requirements: add bare-bones starter requirements.txt file
2016-09-13 chrome-bot Update config settings by config-updater.
2016-09-13 chrome-bot Update config settings by config-updater.
2016-09-12 chrome-bot Update config settings by config-updater.
2016-09-09 yueherngl Add pbody builder configuration
2016-09-08 dgarrett chromeos_config: Start split up of GetConfig() method.
2016-09-10 vapier paygen: utils: purge unused funcs/symbols

BUG=

Review-Url: https://codereview.chromium.org/2377503002
Cr-Commit-Position: refs/heads/master@{#421246}

This bit is only used to separate DNS requests in histograms.

BUG=650693

Review-Url: https://codereview.chromium.org/2377683002
Cr-Commit-Position: refs/heads/master@{#421245}

Webview does not have tabs so it cannot be backgrounded in the same way as other browser types.

BUG=650458

Review-Url: https://codereview.chromium.org/2370913003
Cr-Commit-Position: refs/heads/master@{#421244}

BUG=646842

Review-Url: https://codereview.chromium.org/2362323002
Cr-Commit-Position: refs/heads/master@{#421243}

No functionality should change with this change.

BUG=637095

Review-Url: https://codereview.chromium.org/2319293006
Cr-Commit-Position: refs/heads/master@{#421242}

This improves documentation for the macros in the file, moves LOCAL_* to a seperate file, and hides the internal macros that do not need to be exposed to histogram users into an internal file. This doesn't require any client changes as both files are includes in histogram_macros.h

BUG=649410

Review-Url: https://codereview.chromium.org/2361933002
Cr-Commit-Position: refs/heads/master@{#421241}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a13f63c6..6888cbc1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2373493004
Cr-Commit-Position: refs/heads/master@{#421240}

Rationale: The WebRtcLoggingHandlerHost class is currently quite large (over 800 lines) and does many different things including looking up system information, writing the text log, receiving and sending IPC messages and passing finished logs to the LogUploader. In addition to the original text log, the WebRtcLoggingHandlerHost also creates and manages the rtp dump through a WebRtcRtpDumpHandler object, and we would like to add a WebRtcEventLogHandler object.

Proposal: We propose to split out the parts that are specific to the text log into a new WebRtcTextLogHandler class. The WebRtcTextLogHandler will own the actual text buffer, keep track of the logging state and fetch the system information that's written at the start of the log. The new  WebRtcLoggingHandlerHost will have ownership of the WebRtcTextLogHandler, WebRtcRtpDumpHandler and WebRtcEventLogHandler objects, receive and send IPC messages, propagate API calls to the right log, and pass the finished logs to the LogUploader.
Review-Url: https://codereview.chromium.org/1978183003
Cr-Commit-Position: refs/heads/master@{#421239}

This way it can be shared by the integration tests and they become more
readable.

BUG=643269

Review-Url: https://codereview.chromium.org/2369103002
Cr-Commit-Position: refs/heads/master@{#421238}

Currently a stream was treated as having no errors even if an error occurs after reading starts. This change plumbs the error through.

This fixes the following tests with PlzNavigate:
ChromeURLDataManagerTest.LargeResourceScale
ChromeURLDataManagerTest.UnknownResource

BUG=426162,508957,504347

Review-Url: https://codereview.chromium.org/2368913002
Cr-Commit-Position: refs/heads/master@{#421237}

Revert of Rendering text to a canvas in a frame-less document. (patchset #4 id:100001 of https://codereview.chromium.org/2336693002/ )

Reason for revert:
Causes some crashes on Canary.

https://bugs.chromium.org/p/chromium/issues/detail?id=650264#c1

Original issue's description:
> Rendering text to a canvas in a frame-less document.
>
> Committed: https://crrev.com/93dd565e17f9ad8e630bfb668e5c83536af50a0f
> Cr-Commit-Position: refs/heads/master@{#418400}

TBR=esprehn@chromium.org,junov@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.

BUG=650264,350091

Review-Url: https://codereview.chromium.org/2370283002
Cr-Commit-Position: refs/heads/master@{#421236}

In a previous CL: https://codereview.chromium.org/2365653005/, we fixed
gpu pixel test for WebGL's commit API on Mac, so we mark those tests as
failure. We have also added two tests to transferToImageBitmap API in the
same CL. Now that the CL has been picked up by all GPU bots, and I have
checked all reference images, it is time to remove the failure entry.

TBR=kbr@chromium.org, zmo@chromium.org, bajones@chromium.org
BUG=649668
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2376533003
Cr-Commit-Position: refs/heads/master@{#421235}

BUG=648536
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2369833003
Cr-Commit-Position: refs/heads/master@{#421234}

The change had a bug because previously WebContentsObserver::DidNavigateMainFrame was listened to which is only called for main frame successful navigations. It was switched to WebContentsObserver::DidFinishNavigation so that it can work with PlzNavigate. However that method is called in more situations, so restrict it to maintain the old behavior.

BUG=650472

Review-Url: https://codereview.chromium.org/2369923003
Cr-Commit-Position: refs/heads/master@{#421233}

This  adds a .scroll-container class which adds a 1px min-height
to ensure that scrollable iron-list elements update.

It also updates search_engines_page to use CrScrollableBehavior.

Note: Even though we are now using scrollable-behavior for search
engines, since we do not enforce a max height on the page or the
container, the containers will never actually scroll (but if we
do set a maximum page height they will, which is nice).

BUG=639795
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338133011
Cr-Commit-Position: refs/heads/master@{#421232}

https://chromium.googlesource.com/skia.git/+log/7bfc08b9fb42..6ad6ba44ce3e

$ git log 7bfc08b9f..6ad6ba44c --date=short --no-merges --format='%ad %ae %s'
2016-09-27 mtklein remove more stray semicolons from Vulkan code
2016-09-27 egdaniel Add GrVkCopyPipeline to handle vulkan copies as draws
2016-09-27 borenet Delete unused upload_*_results.py
2016-09-27 branimir.vasic Add mips dsp arch variants to gyp_to_android.py.
2016-09-27 mtklein We really shouldn't pass SkFontStyle to printf as %d.
2016-09-27 mtklein Remove stray semicolons.
2016-09-27 borenet Add swarming task for upload_dm_results

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=fmalita@google.com

Review-Url: https://codereview.chromium.org/2377613003
Cr-Commit-Position: refs/heads/master@{#421231}

Direct access to LayoutPart is deprecated and being removed soon. The
replacement is LayoutPartItem, which routes methods through the new
block layout API. (See linked crbug for details.) This means the
ownerLayoutObject() method is also deprecated, to be replaced with
ownerLayoutItem().

There are no functional changes.

BUG=499321
TBR=eae@chromium.org

Review-Url: https://codereview.chromium.org/2367253005
Cr-Commit-Position: refs/heads/master@{#421230}

This CL moves the helper class DelayLoadStartAndExecuteJavascript used in
WebNavigationApiTests to use the new navigation APIs. This allows
WebNavigationApiTest.CrossProcess and WebNavigationApiTest.CrossProcessHistory
to pass with PlzNavigate enabled.

BUG=575230

Review-Url: https://codereview.chromium.org/2272243002
Cr-Commit-Position: refs/heads/master@{#421229}

PS permissions have been updated (part pertaining to manifest feature).
Permission features will be updated in a seperate CL.

BUG=649726

Review-Url: https://codereview.chromium.org/2367363002
Cr-Commit-Position: refs/heads/master@{#421228}

On M+, web developers can provide the icon for notifications to use in the
status tray via the Notification.badge property
(https://notifications.spec.whatwg.org/#dom-notification-badge)

This CL sets the icon to be used by notifications originating from a WebAPK
- When the Notification.badge property is not set
- On Pre M Android OSes

BUG=604204

Review-Url: https://codereview.chromium.org/2362423002
Cr-Commit-Position: refs/heads/master@{#421227}