- 25 Jan, 2020 30 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4cce3fa50ee..2329da078aca git log b4cce3fa50ee..2329da078aca --date=short --first-parent --format='%ad %ae %s' 2020-01-24 ethannicholas@google.com add SkSLInterpreter vector instructions Created with: gclient setdep -r src/third_party/skia@2329da078aca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I5cc8f0e9aa3613374d2a7554dda2864fff2c2207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020519Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735192}
-
Evan Stade authored
This reverts commit 019a8580. Reason for revert: memory regression found by pinpoint Original change's description: > WebLayer: add FindInPage API > > New methods are added to Tab: > - beginFindInPage > - activateNextFindInPageMatch > - endFindInPage > > And a new FindInPageCallback interface is introduced with one method: > - onFindResult > > Also add very basic FIP controls to shell to partially exercise the > new API. > > Notes: > 1. The embedder provides the main find in page UI (the text input). > 2. The embedder is responsible for ending the find session as > appropriate (i.e. when the main find in page UI is dismissed), > which cleans up the in-page UI, consisting of a results sidebar and > text highlighting. Commonly this would happen if the user cancels the > find session or if a navigation occurs. > 3. When the active tab loses focus, the find session is ended and the > result bar is removed. > 4. It is generally expected that the embedder-provided find in page UI > will be hosted in the top view. > > TODO: > 1. The top controls should be forced visible when the new web contents > overlay view holds children. That will definitely be desired for > tab modal dialogs, and is probably desired for find in page as well > (at least judging by what Clank does). > 2. Write tests. > > Bug: 1038415 > Change-Id: I6183172dc3944157aae2db5ebb0aed983a34bffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004072 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734691} TBR=sky@chromium.org,estade@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1038415 Change-Id: I18896dbf3bf9c65e4ff801cb6061fc955be8809c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020478Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#735191}
-
Alexei Svitkine authored
For each one, I code searched the feature name which returned no results outside of the testing config. This is not an exhaustive list of what can be cleaned up, just an initial set that I found to unbreak Windows telememtry that's broken due to command line limit. Bug: 1045636 Change-Id: Ib2ac57218481321678cdc7b82ce8df8ffd871723 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020424 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735190}
-
Joe Downing authored
TBR: davidben@chromium.org Bug: 1045656 Change-Id: I709806abf7b4918f64a93156b01c9406c8520b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020540Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#735189}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 23e3babc. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: If7d829f7237b6e4fd2938d4215e1065111bd66a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020492Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735188}
-
Omer Katz authored
This changes simplifies the tracing logic and avoid needing to manually call the write barrier on assignments. Bug: 986235 Change-Id: I2ae7b43241e1777dce4efcba5586ef2e1b0b1143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019282 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735187}
-
Marijn Kruisselbrink authored
This splits of the permission specific parts from ChromeNativeFileSystemPErmissionContext and adds a base::Feature to enable picking which implementation to use. This is in preparation of implementing a new origin-based permission model, while still shipping the old tab-based permission model. Bug: 984769 Change-Id: Ib969278396135bb6da620e70cffdc25f13684d7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017668 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#735186}
-
Carlos IL authored
This CL adapts webview tests to run with committed interstitials enabled, and fixes WebViewClient callback invocation issues with CI. All SafeBrowsing CTS tests pass with CI as of this CL, except for android.webkit.cts.WebViewClientTest#testOnSafeBrowsingHit which is fixed in the follow-up CL. Tests will be enabled for committed interstitials using fieldtrial_testing_config.json once the blocking bugs are fixed. Bug: 1031315, 1022477 Change-Id: Iadf1848cd91c29fd3b841429f74fb4e3464a055f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909276 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#735185}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9403c3fc39e8..bf4e7a722ba4 git log 9403c3fc39e8..bf4e7a722ba4 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 agable@chromium.org [lucicfg] Update v1.11.17 -> v1.11.18 Created with: gclient setdep -r src/third_party/depot_tools@bf4e7a722ba4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1035470 Tbr: agable@chromium.org Change-Id: I2b133bddf1cfc8b27d670b0a5b94231c9c09c71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020678Reviewed-by:
-
Daniel Murphy authored
This change removes IndexedDB's custom writing of blobs to IndexedDB in lieu of the new WriteBlobToFile API in BlobStorageContext. That API has way more tests than what IndexedDB is doing, and allows IndexedDB to de-couple from using file paths at all. This change also modifies the blob storage WriteBlobToFile code to: 1) Handle the case where the Blob entry has an 'unknown size' length, 2) Add tests for a directory not existing R=mek@chromium.org Bug: 1024966,1015214 Change-Id: Ib7c33ecafd4821203d62654c941b9879ef77db25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#735183}
-
Darwin Huang authored
sqlite 3.31.0 upgrade changes: https://sqlite.org/releaselog/3_31_0.html Bug: 1045591 Change-Id: I564c970c58688acc04af6e3ad578704390180fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020531Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735182}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/955353d9a221..a033371f89e8 Created with: gclient setdep -r src-internal@a033371f89e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1045005 Tbr: jbudorick@google.com Change-Id: I108b65648f1ad90d7cffe2bc749bb674727896e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020675Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735181}
-
Eric Karl authored
When we started evicting SW discardable image decodes, we regressed the cache hit rate in low-end, where the GPU discardable limit is very low. Bump this by 512KB, which should be fine as the earlier change reduced SW discardable by ~1MB. Bug: 1029875 Change-Id: I8bcbbd57a4c58f045966aee83993a05f6e302db5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020612 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#735180}
-
Ryan Sturm authored
This feature allows us to experiment on Google without possibly creating issues with non-Google DSEs. This will hopefully prevent problems or regressions with other search engines. Bug: 1036489 Change-Id: I688338981460ab3b532577b1bc176fde89fd3e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020534Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#735179}
-
Fredrik Söderquist authored
Moves svg/stroke/pathlength-* and svg/dom/path-queries-pathLength.html to WPT, splitting the latter into two while converting the former to SVG. Change-Id: I04d404dc5f074d4278e5d081a12b960cf1ec98fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019366 Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#735178}
-
Michael Forney authored
https://chromium.googlesource.com/linux-syscall-support.git/+log/7bde79cc274d..f70e2f1641e2 $ git log 7bde79cc2..f70e2f164 --date=short --no-merges --format='%ad %ae %s' 2020-01-22 mforney Avoid conflict with pread64/pwrite64 defined by libc Created with: roll-dep src/third_party/lss Change-Id: I5d9d0dbecd7f1ce1f8beb74eb5a5d7b3dec246ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020542Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#735177}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27ebf37d26a7..1ea8fb7e2ef3 git log 27ebf37d26a7..1ea8fb7e2ef3 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 dberris@chromium.org E-Divisive: Widen Range of Candidates Created with: gclient setdep -r src/third_party/catapult@1ea8fb7e2ef3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1041688 Tbr: oysteine@google.com Change-Id: I97de1a1dcc5314669d8d8e9d6d6f2433e645220e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020672Reviewed-by:
-
Lukasz Anforowicz authored
This CL removes the |reverse_on_redirect| out parameter from the //content-public version of the BrowserURLHandler::RewriteURLIfNecessary method. This is justified by the fact that outside of //content all callers of that method would ignore this out parameter. The CL keeps the |reverse_on_redirect| in the //content-internal overload of the method in BrowserURLHandlerImpl, because the |reverse_on_redirect| out parameter is used from the NavigationControllerImpl code. This CL is intended to be pure refactoring and should introduce no behavior changes. This is followup from discussion in r735048. Bug: 1029161 Change-Id: I4d4322495604d7d67ddf22668eeab33c70fe0cf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993724 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#735175}
-
wutao authored
This is a preparation to allow access assistant_client in ash directly. It will be called in assistant_context_controller to cache/clear assistant structure. Bug: b/145218971 Test: manual Change-Id: I1b3aa16cd7859ff42366776622d2cee6549c5085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013488 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735174}
-
David Black authored
In conversation starters V2, conversation starters are fetched from the server using the dedicated ConversationStartersClient. When the server call fails to result in a set of conversation starters, we fallback to locally provided conversation starters. Note that this CL fetches as the UI is becoming visible to maximize freshness. This logic may need to be changed once we assess latency. Bug: b:148246719 Change-Id: Icc978d95588cb2088fd7aa7df83be69ded9cb22a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017916 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/53faba1c7d1d..5f86e050c2e8 git log 53faba1c7d1d..5f86e050c2e8 --date=short --first-parent --format='%ad %ae %s' 2020-01-24 cjamcl@chromium.org Add MotoG4 images to BUILD Created with: gclient setdep -r src/third_party/devtools-frontend/src@5f86e050c2e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:924693 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf9a0ee95a76e586a8319a7c6a80a70961a65353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020673Reviewed-by:
-
Regan Hsu authored
Copies strings that are used by both OS language page and browser language page top level polymer component, and moves strings used exclusively by OS from browser string provider to OS string provider. Bug: 967888 Change-Id: Ibcba8359e29fa81380ab152e1b7eba6dad27e3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020325 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#735171}
-
Sergey Ulanov authored
Previously fuchsia.media.cdm didn't support unencrypted blocks in secure media streams. See fxb/38253 . To workaround that issue FuchsiaSecureStreamDecryptor had to wait for a valid key_id. This issue is fixed now: CDM API now supports ENCRYPTION_SCHEME_UNENCRYPTED, so the workaround is no longer needed. Updated FuchsiaSecureStreamDecryptor to use the new encryption scheme and removed the workaround. Bug: 1012525 Change-Id: I079948a63c53d7fecdbd877452d1aaa1ec7477e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020537Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735170}
-
Ahmed Fakhry authored
The shelf config needs to be updated at the "starting" phase of the tablet mode transition, so that they remain stable during the animation. Otherwise, if the shelf bounds change during the animation, the display work-area bounds will change leading to many re-layouts, which will hurt the animation smoothness. BUG=1044316 TEST=Run the tast test: ui.TabletTransitionPerf and make sure the animation smoothness is back to its normal value. Change-Id: Ia376cba2d9ca624ee762da18e1bbe11a70257dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020616Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#735169}
-
rajendrant authored
We need to be able to disable just the redirect part of the feature, so that the users will still see the original image, but other coverage metrics will be recorded for analysis. This CL also removes detecting images based on file extensions. Bug: 1042869 Change-Id: I6842a09386664d9ce61e364bbba2b2aef9000195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017671 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
-
Oriol Brufau authored
The LayoutNGListItem used to hold some information about the marker: the kind of marker, whether the marker text was up-to-date, etc. With the addition of the ::marker pseudo-element, markers have become independent and are no longer created and destroyed by LayoutNGListItem. However, this made it more difficult to keep the information in sync. For example, dynamically applying 'content: none' to a symbol marker destroys it, but LayoutNGListItem didn't notice that marker_type_ was supposed to change from kSymbolValue to kStatic. This caused a DCHECK failure and a null deref in SymbolMarkerLayoutText(). To avoid these problems, this patch moves all the code regarding markers from LayoutNGListItem to ListMarker. This is a new class that contains generic methods for the LayoutNG markers (LayoutNGListMarker or LayoutNGInsideListMarker). BUG=1043478, 457718 TEST=external/wpt/css/css-pseudo/marker-content-020.html The test fails in legacy since 'content' is not properly supported yet. Change-Id: I2d7b424bbaf2487a8fbc49303d5114187d8c1fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007754 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735167}
-
Jeffrey Kardatzke authored
This reverts commit 7d82db05. Reason for revert: This crashes. The frame pointer referenced on line 256 was std::move'd on line 240 so it is invalid. Original change's description: > media/gpu/chromeos/MailboxVFConverter: Set visible size to SharedImage > > MailboxVideoFrameConverter sets coded size to SharedImage. It > causes that a green line is shown at the bottom and right edge > when playing a video. > > This fixes the issue by setting visible size to SharedImage so > that GPU doesn't access non visible area. > Note that MailboxVideoFrameConverter needs to recreate > SharedImage if the visible rectangle of the current video frame > is changed, which should be rare though. > > Bug: 1043582 > Test: Play a 1080p video on soraka with --enable-features=ChromeosVideoDecoder > Change-Id: I76878a27fa92d755380d9b92b94d20e765056fac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011586 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734795} TBR=mcasas@chromium.org,hiroh@chromium.org,acourbot@chromium.org Change-Id: Ieea5d53c3deb5aae963da4f6cdb82cc9648f8f44 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1043582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020409Reviewed-by:
Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#735166}
-
Khushal authored
We assume this value to be min row bytes based on what the image cache uses for decoded images. But this is not true for bitmaps that come from the embedder directly (UI compositor). R=ericrk@chromium.org Bug: 1041477 Change-Id: I21fa8c8a60c2a71604a0aeeed1253ab199aee6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020806 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#735165}
-
Fritz Koenig authored
Bug: 1038671 Change-Id: Ifb1fed6c3cca7badf85df8df92b1afbdf83bb614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020529 Auto-Submit: Fritz Koenig <frkoenig@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735164}
-
Darwin Huang authored
Implements ReadAvailablePlatformSpecificFormatNames, which exposes all formats available to platform clipboards and native applications. This includes formats that Chrome does not normally sanitize, and excludes pickled formats not normally exposed to underlying platform clipboards. This functionality will begin behind a flag, and will not initially be exposed to the web. Design Doc: https://tinyurl.com/raw-clipboard-access-design Bug: 897289 Change-Id: I6a93e89d01fa1412b61ec45f4dca881496b92c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001752Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#735163}
-
- 24 Jan, 2020 10 commits
-
-
Sahel Sharify authored
With this change only the app selected for the initial "pay" attempt will be available during retry. Bug: 1028098 Change-Id: I13815f19e86c2ca3413867ce17d04dc48862b98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015826 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#735162}
-
Demetrios Papadopoulos authored
This reverts commit 216a16f9. Reason for revert: See https://bugs.chromium.org/p/chromium/issues/detail?id=1044378#c5 Original change's description: > mojo-js: Use bound generic type for PendingReceiver > > The Closure version used in Chromium now supports bounded generic types. > > Bug: 1015726 > Change-Id: I14c080b6e3cd67cbdf564312fc1c1686f3adb1e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906691 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#714744} TBR=rockot@google.com,ortuno@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1015726,1044378 Change-Id: Ic08c9baa69db14d9abf7a6f0ca64e4f9720b7cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017902 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#735161}
-
Alexei Svitkine authored
Bug: 912320 Change-Id: I44eceafae715ccedfb258b86d53728efb401d28e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020783 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#735160}
-
Michael Spang authored
Since fefeda7b ("[Fuchsia] Remove unused services from test sandbox CMX fragment."), we can't run any graphics tests because the sandbox does not allow access to the requisite services. Add a new sandbox config for these cases. Bug: 766360 Change-Id: Ic09d3ce09947a348830d95827e965e7b8b7a442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756386 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735159}
-
Gil Dekel authored
Certain chromebooks now come with panels that have integrated privacy screens on them. This CL exposes an API in DisplayConfigurator to set the KMS property, privacy-screen, to the desired state. Bug: b/147451643 Test: tested locally on a test device Change-Id: Iafa61365ce20c147eaa672cf33d8d3c6104bcb89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015648 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
-
David Black authored
Follow up CLs will wire the fetch API up to a loader as well as invoke the fetch API from AssistantSuggestionsController at the appropriate points in the Assistant lifecycle. Bug: b:148239201 Change-Id: I8eb816aab3eff180b90d4eb21371d81b6219ce0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018443 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Darwin Huang authored
Change-Id: I82c593c48c33259e561fc03e0ff0657aadebdde3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021007 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
Tested: Locally Change-Id: I1684b5336b039ba0d742489aba65fb8bfc3a5421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020560 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#735155}
-
Martin Kreichgauer authored
Windows appears to send two BluetoothAdapter::StateChanged events whenever a Bluetooth adapter is powered up. At least the first such event races against Windows-internal adapter initialization, such that calls to BluetoothLEAdvertisementWatcher::Start can fail with "device not ready for use" for some time after the first StateChanged. Additionally, calling BluetoothAdapter::RegisterAdvertisement() twice in a row appears to send things into a wonky state where callbacks stop firing. In combination, these quirks do not cause noticeable issues in most environments: When the first StateChanged event following an adapter power-on arrives, starting BLE discovery fails because starting the advertisement watcher fails. By the time the second StateChange event arrives, sufficient time has passed for discovery to start successfully. As a result, RegisterAdvertisement() is only called a single time. On some machines however, the first attempt to start discovering does *not* fail (perhaps because the machine is slow, or because post-power- on adapter initialization is fast), resulting in two calls to RegisterAdvertisement(). Work around all this by doing the following: (1) Make FidoCableDiscovery remember the adapter power state and ignore AdapterPoweredChanged() calls that don't really change state, in order to avoid calling RegisterAdvertisement() multiple times. (2) Hold off on starting discovery for 500ms after the first power-on event. This is admittedly a bit of a hack. The 500ms are somewhat arbitrary and I don't really know if adapter initialization perhaps takes even longer in other environments. A more sound strategy would perhaps be to retry the calls that are known to fail spuriously, preferably at the //device/bluetooth layer; and also to fix whatever makes multiple calls to RegisterAdvertisement() break everything. Bug: b/145224971 Change-Id: If5ec45ec2b964c28f480d2e24a41a4c9a292c0a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018498Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Cr-Commit-Position: refs/heads/master@{#735154}
-
Hesen Zhang authored
Bug: 1043237, 1013685 Change-Id: Ie089eef59d7fdd0ad0d5f4defff1abeac6a07aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008612 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#735153}
-
