- 26 Sep, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts AccountStatusChangeDelegatePtr and AccountStatusChangeDelegateRequest to new Mojo types using PendingRemote, Remote, and ReceiverSet. It also update SetAccountStatusChangeDelegate from multidevice_setup.mojom. Bug: 955171 Change-Id: I2493c44e041b53a76c6fe4e1f7870bd395cc69d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824724Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#700093}
-
Tsuyoshi Horo authored
To support loading bundled exchanges local files, this CL do the following changes: (1) Change ContentURLLoader::Start() and FileURLLoader::Start() to set mime_type to "application/webbundle" when BundledHTTPExchanges feature is enabled, and the extension of the file ".wbn". (2) Change NavigationRequest::OnStartChecksComplete() not to create a BundledExchangesHandle when the URL scheme is not "file:" (or "content:" on Android). This is because currently we don't support loading bundled exchanges from network. (3) Introduce |will_return_unsafe_redirect| parameter in NavigationLoaderInterceptor::MaybeCreateLoaderForResponse() which is set to true when the interceptor will return an unsafe redirect response. We need this to skip IsRedirectSafe() check in URLLoaderRequestController::OwnReceiveRedirect() while redirecting the original request to the URL which can indicate the URL in bundled exchanges file. (eg: From "content://org.example.FileProvider/wbn/test.wbn" to "content://org.example.FileProvider/wbn/test.wbn?https://example.com/") (4) Change::URLLoaderRequestController::MaybeCreateLoaderForResponse() not to early return when |default_loader_used_| is false if the response is likely to be a bundled exchanges file. This is because while loading file, |default_loader_used_| is false. But we need to call InterceptorForFile::MaybeCreateLoaderForResponse(). (5) Change BundledExchangesHandle to be able to handle bundled exchanges local files. InterceptorForFile will handle the navigation request to the bundled exchanges file. This interceptor returns a synthesized redirect to the URL which can indicate the URL in bundled exchanges file (eg: "file:///tmp/test.wbn?https://example.com/") in OnMetadataReady() and handles the redirected request in StartResponse(). InterceptorForTrustableFile will handle the navigation request to the trustable bundled exchanges file. This interceptor returns a synthesized redirect to the bundled's primary URL (eg: "https://example.com/") and handles the redirected request in CreateURLLoader(). Bug: 995177 Change-Id: I049336322bc503026699df2fe8ffd26a86309dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792220 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700092}
-
Julie Jeongeun Kim authored
This CL converts SimpleTestDriverPtr and SimpleTestDriverRequest to new Mojo types using AssociatedRemote, AssociatedReceiver, and PendingAssociatedReceiver. It introduces AddAssociatedInterface and BindPendingAssociatedReceiver in ipc_channel.h. Bug: 955171 Change-Id: I2b75876cb27698364aff618b0c3be13dc92847e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824505Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
hyunjune authored
This patch fixes up a crash relied on line break with 'white-space'. Because After HandleOverflow is called, the current style is changed into |HandleOverflow|. So When |TextBreak|'s result is Overflow, this patch restores the current style as the old current style. Bug: 999863 Change-Id: I787d80abac66599671fd6cb19cb19eebb2110852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806616Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#700090}
-
Hirokazu Honda authored
This CL introduces a class that enables to pixel format conversion and scaling with VA-API. The interface of the class is ImageProcessor. Bug: 898423 Test: image_processor_tests on atlas Change-Id: I275b4dec50594ca6328743bb5a3532e0a8d25ba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1367389Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700089}
-
Alexey Baskakov authored
Support creation and deletion of apps as a part of single update. RegisterApp, UnregisterApp and UnregisterAll methods now can be expressed within one WebAppRegistryUpdate (one transaction). Report kWriteDataFailed in InstallFinalizer if commit fails. WebAppRegistryUpdate CreateApp/UpdateApp/DeleteApp is now the only writable database API (as in Database CRUD: Create/Update/Delete). Bug: 860583 Change-Id: Ia2e23a4d4a0d47e62b815abd55803616a204e813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824043Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#700088}
-
Istiaque Ahmed authored
IPCs to WorkerThreadDispatcher arrive initially on main thread via WorkerThreadDispatcher::OnControlMessageReceived() [1]. This IPC is forwarded to worker thread, via WorkerThreadDispatcher::OnMessageReceivedOnWorkerThread() [2]. If the worker destruction (Dispatcher::WillDestroyServiceWorkerContextOnWorkerThread) happens on worker thread between [1] and [2], IPC forwarding succeeds (b/c the worker is alive at [1]), but IPC handling doesn't (as worker data is already cleared while we run [2]). Fix this by checking worker data's existence while handling the IPC on worker thread and bailing out. Bug: 1008143 Test: Locally running ServiceWorkerTest.Update*Extension thousand times. Change-Id: Id5dd1b4c3d24995228aeb0f1fdd72edc1b77f747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825169Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#700087}
-
Alexandre Courbot authored
The introduction of a sequence checker in V4L2Devices means that we need to be more careful about who destroys (i.e. who "owns") a given V4L2Device. Make sure the IP device is destroyed by the IP thread, and the decoder device by the decoder thread. Bug: 1003223 Test: vdatests passing on Kevin. Change-Id: I21d55163d5830b45afb882fcced2bd8cef069151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826300 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#700086}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e00ffeb79abc..b3ae56238672 git log e00ffeb79abc..b3ae56238672 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 abennetts@google.com Skip Catapult Android Tryserver for CLs that only touch the dashboard. Created with: gclient setdep -r src/third_party/catapult@b3ae56238672 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:985223 Change-Id: I2c32bf794b1d553082e0d54f125e05b5b59b1239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825632Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700085}
-
Kenichi Ishibashi authored
It existed for on-the-main-thread script fetch. We can replace it with FailedToFetchClassicScript(). It's consistent with module script fetch callback (FailedToFetchModuleScript). Bug: N/A Change-Id: I6cf5ccba53ea73d48bfbecef42864b88484da341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826059 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#700084}
-
Fergal Daly authored
It's flaky on those builders. TBR=droger@chromum.org Bug: 1008238 Change-Id: I090ba713404d9853df74761d4c09ac646b01507e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824055 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#700083}
-
Miyoung Shin authored
This change converts VibrationManager mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Iab5ad8845989ec8a1c8c885f2d347feb6f0f2de3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824042 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#700082}
-
siyua authored
The loading indicator will be a circle throbber on top of the icon. It will be shown when a upload save is in progress. The icon will be disabled (not clickable) during the animation. If upload save succeeded, dismiss the icon and shows the avatar highlight, otherwise stop the animation and shows the failure bubble/icon (credit card icon with a failure badge). The failure bubble will be shown only once. Once the bubble is dismissed, the icon will be as well. Bug: 932818 Change-Id: I305a5998d216546c697f35ffae18ec80ded05292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808168 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#700081}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/56c87856cd03..d64438c0787f Created with: gclient setdep -r src-internal@d64438c0787f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:988217 Change-Id: Icc2c3087fa91a39ea51c85ee2127ae65b8e735be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825493Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700080}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces below ones with matched IDS_FOO. - WebLocalizedString::kMediaRemotingCastText, - WebLocalizedString::kMediaRemotingCastToUnknownDeviceText, - WebLocalizedString::kMediaRemotingStopByErrorText, - WebLocalizedString::kMediaRemotingStopByPlaybackQualityText, - WebLocalizedString::kMediaRemotingStopNoText, - WebLocalizedString::kMediaRemotingStopText, This CL needs to change the argument type of MediaRemotingStopped() and Hide() functions according to the change. Lastly, this CL adds kMediaRemotingStopNoText constant to WebMediaClient because there was no matched IDS_FOO for WebLocalizedString::kMediaRemotingStopNoText. Bug: 995644 Change-Id: I6daed3fe10145290a21b5bc9d4797eb5ca5f9e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818007Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#700079}
-
John Z Wu authored
1. Use new sync and autofill APIs. 2. Introduce a sync menu. 3. Autofill data menu. 4. Consent/Unlock menu. Change-Id: I283b6087c09a2688ed7ea3fdf53d44fe72b63e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823724 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#700078}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c5bc9d6da851..d6eab9edafe8 git log c5bc9d6da851..d6eab9edafe8 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 489dde9b..1fa0f66d (699869:699974) Created with: gclient setdep -r src/third_party/webrtc@d6eab9edafe8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: If2f5077d9316b744e41c80ccb546eb867aab53e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826203Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f0faf48ddb89..9a5bb612e624 git log f0faf48ddb89..9a5bb612e624 --date=short --no-merges --format='%ad %ae %s' 2019-09-26 ehmaldonado@chromium.org git-cl: Make Ctrl+C work again. Created with: gclient setdep -r src/third_party/depot_tools@9a5bb612e624 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:961724 Change-Id: I32dd482c3596ac91f9114a33d7841cce8d5058f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825664Reviewed-by:
-
John Z Wu authored
The intermediate "ChromeWebView" folder was never created, so writes to files in that folder just fails. Change-Id: I2d0880fd9ce600fab08f4e23ed116febdaf76b95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825735 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie75dcaff77f5ee2a7ade334b2e4f2498f38a45da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825383Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700074}
-
Jay Harris authored
In incognito and guest profiles, the BadgeManagerFactory does not create a BadgeManager. As there are no apps in incognito/guest profiles this would not normally be a problem. However, in BadgeManager::BindRequest, we were attempting to add the null BadgeManager to a mojo reciever set, causing a crash. Note: This does not affect the API exposed to the, so this cannot be used to detect incognito mode. Bug: 1004122 Change-Id: I5024665257a67aaaf28aa7f3bb8cd9cfcdef2d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824041Reviewed-by:
-
Darren Shen authored
These files are only compiled for chrome os, so no need for the checks. Bug: 1005619 Change-Id: I15cd1c3000223bf8aa1c2656389b3e32fbfaee71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1811404 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#700072}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6f282594. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I0233205edf18670ca44ecb5d98a794b280670b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825405Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#700071}
-
Gyuyoung Kim authored
As a step to remove all uses of WebLocalizedString::kFooBar, this CL replaces all uses of WebLocalizedString::kFooBar with IDS_FOO in QueryLocalizedString functions in TestBlinkWebUnitTestSupport. This CL replaces below ones with matched IDS_FOO. - kCalendarClear - kCalendarToday - kFileButtonNoFileSelectedLabel - kOtherDateLabel - kOtherMonthLabel - kOtherWeekLabel - kSelectMenuListText - kThisMonthButtonLabel - kThisWeekButtonLabel - kValidationRangeOverflow - kValidationRangeUnderflow - kValidationStepMismatch - kValidationTooLong - kValidationValueMissing - kValidationValueMissingForSelect - kWeekFormatTemplate Bug: 995644 Change-Id: I1873b90d26c2f86f09fd9aa66e9cb65196f8333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1820500Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts ContentTranslateDriverPtr and ContentTranslateDriverRequest to new Mojo types using PendingRemote or Remote, ReceiverSet and PendingReceiver. Bug: 955171 Change-Id: I85bea0c14c8537a57bdd43d1157c16e441a01126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816483 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#700069}
-
Chih-Yu Huang authored
The UnwrapFrame() method is only used between PlatformVideoFramePool and MailboxVideoFrameConverter implementation. It is not a general method. This CL moves the method from DmabufVideoFramePool interface to PlatformVideoFramePool implementation. BUG=b:136716638 TEST=run video_decode_accelerator_tests on kevin Change-Id: Icfd5d99fb2319ec904e0d8c298572cb0af1031b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824500 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
-
Mark Pearson authored
TBR=nikunjb Change-Id: Icdba90b45dfe414afcf3a977e1476253774d47ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825665Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#700067}
-
Kouhei Ueno authored
Before this CL, we required the pages to reach "load" event to be put into BFCache. This CL relaxes the constraint to have the page: - reach DOMContentLoaded, and - have no inflight subresource network requests. Bug: 1002345 Change-Id: Ibfb5d8b73162261aa1d5e0e98d3345ae40ef23b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809192 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#700066}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8aa759f0bb96..56c87856cd03 Created with: gclient setdep -r src-internal@56c87856cd03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Iba5948705825ddf2fad09d656f5a23e411202422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825934Reviewed-by:
-
Shakti Sahu authored
Bug: 850608 Change-Id: Ia68fed867cea8c7d175b29dfaaa25f03579fec9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804384 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#700064}
-
Hiroki Nakagawa authored
WorkerGlobalScope, not WorkerThread, is responsible for script fetch and evaluation. Therefore it would be clearer to place InstalledScriptsManager in WorkerGlobalScope, not in WorkerThread. Bug: 938219 Change-Id: Iee76b943ef435326ea055e65fb75e579dd7d75ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824522 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#700063}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: I980489adbce321402af8d6ce93009af1c38ecf6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815991Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#700062}
-
Sunny Sachanandani authored
Make DCLayerOverlayProcessor keep track of output rects of each child render pass that has filter operations and compare that with the quad target rect when deciding whether to promote to overlay. Bug: 997517 Change-Id: Iee6cc6acfea1ae00ce1aa676138440949cfabd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817269Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#700061}
-
Steven Bennetts authored
In C++ mojo uses StructPtr for embedded structs, regardless of whether they are required, so it is possible to pass 'nullptr' for required properties, causing a runtime error when the properties are received. This CL: * Ensures that required ManagedString properties are provided in the C++ code, and fixes the set of properties provided for VPNs based on type. * Fixes some CSS causing incorrect indicators, and cleans up some logic in the JS. Bug: 1008230 Change-Id: I51484fc74e672b7b8434228abd219428461b92f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824320 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#700060}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/30c2b66fbabe..c5bc9d6da851 git log 30c2b66fbabe..c5bc9d6da851 --date=short --no-merges --format='%ad %ae %s' 2019-09-25 qingsi@webrtc.org Treat wlan as a WiFi adapter name on all platforms. Created with: gclient setdep -r src/third_party/webrtc@c5bc9d6da851 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I2dac97cad9b3d941e4e3ba1dedea48466ab323af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826009Reviewed-by:
-
Andrii Shyshkalov authored
R=jbudorick Bug: 988217 Change-Id: I380cca75ce78086e5768b2c4dfa5e5464487d8d1 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826055 Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#700058}
-
Brandon Wylie authored
Bug: 1006939 Change-Id: I80660992d19533dde83f47fb24ed358ef3a58669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824065Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#700057}
-
Miyoung Shin authored
This change converts ShareService mojom interface client in blink to use BrowserInterfaceBroker. Bug: 936482 Change-Id: I26f60a0ae23e851bc19b8a157a2f3923005d822e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824049Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#700056}
-
Sam Maier authored
The plan was to migrate everything over to this, but it didn't happen. Since there are no users of this, it's better to not support this anymore. See https://chromium-review.googlesource.com/c/chromium/src/+/1803394/2 for an example of confusion with using compress = true. Change-Id: Ib6d666c2a937c3e024ca5fde6b59eddbd560a13c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825919 Auto-Submit: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#700055}
-
Kenichi Ishibashi authored
We can remove the IPC from FailedTo{LoadClassic,FetchModule}Script() because: * After crrev.com/c/1819282 ServiceWorkerGlobalScope calls close() when top-level script fetch failed. Close() eventually invokes ServiceWorkerContextClient::WorkerContextDestroyed() which sends the IPC. * The reason we sent OnStopped IPC from FailedTo{LoadClassic,FetchModule}Script() was to support on-the-main-thread script fetch. We no longer support it. This CL also ensures that we have test coverage of the linked bug. Following browsertests fail without crrev.com/c/1819282 when this CL is landed. * ServiceWorkerVersionBrowserTest.StartNotFound * ServiceWorkerBlackBoxBrowserTest.Registration Bug: 1005650 Change-Id: Ie61b633b213ca4e8646c009d2f5a0569c55820a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824727Reviewed-by:
-
