GitLab

BUG=24622,24597

Review URL: http://codereview.chromium.org/330029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/333045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30328 0039d316-1c4b-4281-b951-d872f2087c98

a max of 19px square.

BUG=25626

Review URL: http://codereview.chromium.org/342012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30327 0039d316-1c4b-4281-b951-d872f2087c98

The old name is also aliased for backwards compat.

This lands:
http://codereview.chromium.org/224012

BUG=21433

Review URL: http://codereview.chromium.org/339041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30326 0039d316-1c4b-4281-b951-d872f2087c98

Disable a test that frequently crashes on Mac 10.5 Tests (dbg) bot (and I've seen it crash on the try servers as well).

TBR=lzheng
BUG=26035
TEST=None

Review URL: http://codereview.chromium.org/338060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30325 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25947
TEST=Not easily testable until we have the strings localized.

Review URL: http://codereview.chromium.org/329039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30324 0039d316-1c4b-4281-b951-d872f2087c98

The bug originates from extensions being treated case sensitive on Windows and Mac OSX, where they shouldn't be. 

Therefore I added generic static methods to FilePath to compare strings in the same way the file system does, and changed the relevant parts of the code to make use of them.
I tested the methods under Windows and Mac OS X. I also wrote a basic version for Linux/Posix that behaves the same way as the original code, so there should at least be no regression.

Also, while fixing this I found some confusion in the code about whether extensions are used with or without leading dot. For this reason I changed some functions that were taking an extension as parameter to instead take the whole file path. This makes calling these functions easier and the caller doesn't need to know whether the extension is supposed to be with or without dot.

In the same vein, I split DownloadManager::IsExecutable into IsExecutableFile, where one again passes in the whole file and doesn't have to worry about getting the extension right, and IsExecutableExtension, which corresponds to the original functionality. Ideally only the former method should be public, but that again would have required further code scrubbing that was (even more) outside of the original bug fix.

Finally, fixed a wrong comment in the file path tests.


BUG=10876
TEST=FilePathTest.MatchesExtension, .CompareIgnoreCase

Review URL: http://codereview.chromium.org/149796

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30323 0039d316-1c4b-4281-b951-d872f2087c98

According to http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html,
these tests didn't crash after webkit rolls.

BUG=25399
TEST=these layout tests doesn't crash

Review URL: http://codereview.chromium.org/342013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30322 0039d316-1c4b-4281-b951-d872f2087c98

Fix warning: comparison between signed and unsigned integer expressions
in base/pickle.cc

TBR=thesig
BUG=none
TEST=build sucess

Review URL: http://codereview.chromium.org/342014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30321 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/297011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30320 0039d316-1c4b-4281-b951-d872f2087c98

If X509Certificate is created in URLRequestAutomationJob or
URLRequestInterceptJob, cert_handle_ is NULL.
So if such certificate is being to be verified (not sure it happens), it would cause crash or some
problem.

BUG=15614
TEST=none

Review URL: http://codereview.chromium.org/329036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30319 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=25538
Review URL: http://codereview.chromium.org/315008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30318 0039d316-1c4b-4281-b951-d872f2087c98

Also don't show empty browser action tooltips.

BUG=26023

Review URL: http://codereview.chromium.org/341016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30316 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/338058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30314 0039d316-1c4b-4281-b951-d872f2087c98

Original: http://codereview.chromium.org/325001/show

TEST=ExtensionsActivityMonitorTest

Review URL: http://codereview.chromium.org/333041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30313 0039d316-1c4b-4281-b951-d872f2087c98

packaging them.

We also special case the common OS X zip dropping "__MACOSX" when
loading extensions.

BUG=23004

Review URL: http://codereview.chromium.org/340018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30312 0039d316-1c4b-4281-b951-d872f2087c98

This asks the toolbar (BrowserActionContainer.GetParent()) to paint when a browser action view has been added & removed.

TEST=Load browser action. Go to chrome://extensions, click "reload". The omnibar should visibly flash large & small as the browser action is loaded and unload, but it should not leave behind any visible "cruft" around the browser action.

BUG=24642

Review URL: http://codereview.chromium.org/341015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30310 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner,kbr
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/339036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30308 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25934
TEST=none
R=darin

Review URL: http://codereview.chromium.org/340016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30306 0039d316-1c4b-4281-b951-d872f2087c98

It looks for binaries built with /NXCOMPAT and /DYNAMICBASE, two important security features for Windows binaries.

BUG=25952
TEST=try running it on the output of /src/chrome/Debug

Review URL: http://codereview.chromium.org/338052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30304 0039d316-1c4b-4281-b951-d872f2087c98

The cause is really subtle.  When I added a db_thread() in BrowserMain, that changed the order that threads were created at.  Since interactive ui tests don't run atexitmanager (I filed a bug to make them do), this cascaded into file_posix.cc's InFlightIO singelton caching the first IO MessageLoop pointer.  By fluke, previously each IO ML would have the exact same pointer value (must be a unique size for the allocator).  My change modified the construction order, so the second run would have a different ChromeThread (file) get the previous IO thread's ML pointer.  That led to the asserts.  I have added code to start the threads in a predictable manner for now.

BUG=25354
TEST=interactive_ui_tests in Linux stop crashing
Review URL: http://codereview.chromium.org/340017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30303 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/345002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30302 0039d316-1c4b-4281-b951-d872f2087c98

The race was specific to unit-test code (see r29826) and should be fixed now.

BUG=22272

Review URL: http://codereview.chromium.org/293042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30301 0039d316-1c4b-4281-b951-d872f2087c98

The load event was changed to canplaythrough.

Review URL: http://codereview.chromium.org/345004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30294 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rolandsteiner
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/341010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30293 0039d316-1c4b-4281-b951-d872f2087c98

Also, re-arranged code to have a class per platform.

Review URL: http://codereview.chromium.org/341009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30292 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/341006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30291 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove several instances of Chrome Frame using wstrings instead of FilePaths.

The main goal of this patch is to move towards ensuring that Chrome Frame and Google Chrome share binary-identical exes and dlls except for setup.exe and mini_installer.exe.

Review URL: http://codereview.chromium.org/338025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24746

Review URL: http://codereview.chromium.org/339033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30289 0039d316-1c4b-4281-b951-d872f2087c98

This patch changes the call to enableResourceTracking on InspectorController to not trigger a page reload in the enabling of the APU agent.

Patch by Jaime Yap (jaimeyap@google.com)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/334022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25826
TEST=none

Review URL: http://codereview.chromium.org/338049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30287 0039d316-1c4b-4281-b951-d872f2087c98

This is a direct copy of the Views fix from r29949.

BUG=24866
TESTED=verified that minimized browser window gets restored under metacity

Review URL: http://codereview.chromium.org/334048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30286 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24355
TEST=NONE

Review URL: http://codereview.chromium.org/337054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30284 0039d316-1c4b-4281-b951-d872f2087c98

added by the merge.  There's no pixel checked in upstream, but we match
except for not showing image placeholders.  The test has the following
images:

<img src="http://">

With GURL, the URL is rejected and it doesn't try to load the image.
In KURL, the URL is "valid", but it fails to load an image so the place
holder image is shown instead.  Since that's not what the test is trying
to test, just rebaseline.

Review URL: http://codereview.chromium.org/342006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30283 0039d316-1c4b-4281-b951-d872f2087c98

FWIW, I tracked down why our tests didn't find this. We do
have coverage for the code path that was getting executed,
but the sandbox is disabled in our browser tests, so it did
not expose this issue.

BUG=25865
TEST=Install any extension that has a content script or icons (test/data/extensions/good.crx is one example). Go to chrome://extensions/. You should see the extension successfully installed.

Review URL: http://codereview.chromium.org/337041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30282 0039d316-1c4b-4281-b951-d872f2087c98

Open all bookmarks in a bookmark menu folder according to the window disposition derived from the event flags. This is currently only possible with a middle click on the top level bookmark bar button. 

BUG=19597
TEST=Control click a folder on your bookmark bar, and thorougly test
bookmark bar, especially with folders.

Review URL: http://codereview.chromium.org/334047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30281 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/330027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30280 0039d316-1c4b-4281-b951-d872f2087c98

LayoutTests\http\tests\security\frameNavigation\xss-DENIED-plugin-navigation.html is no longer timing out.  Rebaseline to match win/linux expectations

BUG=none
TEST=green build

Review URL: http://codereview.chromium.org/345003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30279 0039d316-1c4b-4281-b951-d872f2087c98

These are mostly minor syntax / missing header fixes.

Review URL: http://codereview.chromium.org/338037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30277 0039d316-1c4b-4281-b951-d872f2087c98

Also added underline capability to linux fonts.

Review URL: http://codereview.chromium.org/338029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30276 0039d316-1c4b-4281-b951-d872f2087c98