- 13 Aug, 2013 24 commits
-
-
dbeam@chromium.org authored
R=estade@chromium.org BUG=271431 TEST=git try -b linux_heapcheck Review URL: https://chromiumcodereview.appspot.com/22911004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217150 0039d316-1c4b-4281-b951-d872f2087c98
-
jbroman@chromium.org authored
As described in http://www.viva64.com/en/b/0205/. BUG=271533 Review URL: https://chromiumcodereview.appspot.com/22831006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217149 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
BUG=none TEST=Files.app runs, the volume list on the left works. R=asvitkine@chromium.org, mtomasz@chromium.org Review URL: https://codereview.chromium.org/22634008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217148 0039d316-1c4b-4281-b951-d872f2087c98
-
chrisgao@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/19773012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217147 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
$./build/sanitize-png-files.sh -o2 chrome/browser/resources chrome/renderer/resources Processed 54 files (out of 564 files) in 02:39:45s Result : 261637 => 261221 bytes (416 bytes : 0 %) BUG=271299 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/22991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217146 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/22452002/mallinath@chromium.org authored
which is LGTMed by @sergeyu and @juberti. Adding TLS support to the TCP Client sockets. In case of WebRTC TLS socket will be created when application passes TURNS url. TurnPort will request for creating TLS sockets. In other instances TLS will be done using Pseudo-TLS, i.e. when TCPPort creates ssltcp, it's actually a pseudo-tls. TBR=vrk@chromium.org,jln@chromium.org,sergeyu@chromium.org,juberti@chromium.org Review URL: https://codereview.chromium.org/22990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217145 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
./build/sanitize-png-files.sh -o2 webkit/glue/resources 1 files (out of 151 files) in 01:59:56s Result : 299061 => 296898 bytes (2163 bytes : 0 %) BUG=271299 TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/22987002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217144 0039d316-1c4b-4281-b951-d872f2087c98
-
mukai@chromium.org authored
BUG=270200 R=oshima@chromium.org, stevenjb@chromium.org TEST=new test case covers Review URL: https://chromiumcodereview.appspot.com/22908004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217143 0039d316-1c4b-4281-b951-d872f2087c98
-
miu@chromium.org authored
Crash fix: Remove MessageLoop from AudioPowerMonitor and instead use MessageLoopProxy in AudioOutputController. Root cause: AudioPowerMonitor held a reference to the audio thread's MessageLoop and erroneously assumed it would be valid until after the audio stream is closed. However, at browser shutdown, it's possible for audio streams to be closed by the correct thread, but *after* the MessageLoop associated with the thread is destroyed. BUG=268629 TEST=media_unittests and manual confirmation by running a browser with the --enable-audible-notifications command-line flag. Review URL: https://chromiumcodereview.appspot.com/22339024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217142 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
We used to hide the web contents view in such case but it seems to trigger some bad effect occasionally. BUG=265932 TEST=existing tests R=ccameron@chromium.org, dimich@chromium.org Review URL: https://codereview.chromium.org/22629009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217139 0039d316-1c4b-4281-b951-d872f2087c98
-
paulgazz@chromium.org authored
This patch uses single BytesInstruction Courgette ops to point to long stretches of the binary file, instead of using one ByteInstruction op, which copies one byte at a time. This reduces memory usages for very large files, since less data is copied, and fewer Instruction classes are constructed. BUG=266068 Review URL: https://chromiumcodereview.appspot.com/22728002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217138 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
older STREAM frames. Merge internal CL: 50558774 Add the QuicVersionMin() function. Change some unit tests to use QuicVersionMin(). Merge internal CL: 50630692 R=rch@chromium.org BUG=none TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/22311013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217137 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
[Reason for revert: compile failure on Win Aura (maybe due to merge conflict)] > On uninstall, delete shortcuts first, and then remove directory only if empty. > > Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are: > - Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu). > - If the directory becomes empty, then remove it; otherwise do nothing. > > The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior. > > BUG=235857 > > Review URL: https://chromiumcodereview.appspot.com/22870004 TBR=huangs@chromium.org Review URL: https://codereview.chromium.org/22983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217134 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
The new network connect code does not handle hidden networks correctly. This fixes that, which also fixed the associated issue. BUG=270936, 166999 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/22674011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217133 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
Better logging to help debug a problem with non-asci ssids. BUG=chrome-os-partner:18659 R=gauravsh@chromium.org Review URL: https://codereview.chromium.org/22908005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217132 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
See http://www.viva64.com/en/b/0205/#ID0EXRFM R=rsleevi@chromium.org BUG=271530 TEST=none Review URL: https://chromiumcodereview.appspot.com/22883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217131 0039d316-1c4b-4281-b951-d872f2087c98
-
huangs@chromium.org authored
Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are: - Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu). - If the directory becomes empty, then remove it; otherwise do nothing. The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior. BUG=235857 Review URL: https://chromiumcodereview.appspot.com/22870004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217130 0039d316-1c4b-4281-b951-d872f2087c98
-
boliu@chromium.org authored
NULL check all access to RenderWidgetHost in ImeAdapterAndroid since RWH can be null after destruction. BUG=internal b/10143869 Review URL: https://chromiumcodereview.appspot.com/22764006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217129 0039d316-1c4b-4281-b951-d872f2087c98
-
rlp@chromium.org authored
[InstantExtended] Update chromeactions.txt to correspond with the added actions for detecting a SRP on nav entry committed. See https://codereview.chromium.org/21395002/ for the CL which adds the actions. Note: this also includes any other updates to actions since the last time chromeactions.txt was updated. BUG=263644 Review URL: https://chromiumcodereview.appspot.com/22493016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217128 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@chromium.org authored
This adds the client plumbing needed to get an arbitrary JSON message from client to host, or vice versa. This will allow us to extend the protocol at short notice, without needing to wait for client plugin changes to be promoted to Stable. BUG= Review URL: https://chromiumcodereview.appspot.com/22477006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217127 0039d316-1c4b-4281-b951-d872f2087c98
-
simonjam@chromium.org authored
This shares most of its code with the startup_warm measurement. You must now specify either --warm or --cold to run the new startup measurement. Due to splitting up the original patch for this into many pieces, some of the earlier changes didn't all work together. There are also a couple of fixes for those in here. BUG=None Review URL: https://chromiumcodereview.appspot.com/22300013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217126 0039d316-1c4b-4281-b951-d872f2087c98
-
justinlin@chromium.org authored
BUG=263951 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22940002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217125 0039d316-1c4b-4281-b951-d872f2087c98
-
jbroman@chromium.org authored
Previously, a separate constant (kNumPainters) was used. This constant was incorrect (there were only two elements in the array). As described in http://www.viva64.com/en/b/0205/. BUG=271533 Review URL: https://chromiumcodereview.appspot.com/22920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217124 0039d316-1c4b-4281-b951-d872f2087c98
-
mvrable@chromium.org authored
I had a copy-paste error in some of the recently-implemented parts of the extension activity log. This fixes that. I believe the bug is harmless because update_statement isn't used again before it goes out of scope (so it's fine that it was clobbered) and SQLite defaults to a null value for unbound parameters (so it's fine that insert_statement wasn't initialized). Still, I should get the code right and this fixes it. Review URL: https://chromiumcodereview.appspot.com/22901002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217123 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Aug, 2013 16 commits
-
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217121 0039d316-1c4b-4281-b951-d872f2087c98
-
mallinath@chromium.org authored
R=ronghuawu@chromium.org Review URL: https://codereview.chromium.org/22817004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217120 0039d316-1c4b-4281-b951-d872f2087c98
-
yoshiki@chromium.org authored
This is the relanding of crrev.com/216611. BUG=266714 TEST=manual TBR=mtomasz@chromium.org Review URL: https://codereview.chromium.org/22405006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217119 0039d316-1c4b-4281-b951-d872f2087c98
-
DHNishi@gmail.com authored
Provides the ability to generate error messages within schema-compiled code for ease of debugging. Error messages may be disabled by adding a 'generate_error_messages' property to json schema, e.g. "generate_error_messages": false Error generation mostly written by Aaron Jacobs (https://codereview.chromium.org/16462004/). BUG=234834 Review URL: https://chromiumcodereview.appspot.com/22228002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217118 0039d316-1c4b-4281-b951-d872f2087c98
-
sugoi@chromium.org authored
BUG=164084 Review URL: https://chromiumcodereview.appspot.com/21271002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217117 0039d316-1c4b-4281-b951-d872f2087c98
-
gab@chromium.org authored
BUG=None Review URL: https://chromiumcodereview.appspot.com/22867002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217116 0039d316-1c4b-4281-b951-d872f2087c98
-
juanlang@google.com authored
BUG=270192 Review URL: https://chromiumcodereview.appspot.com/22702003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217115 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
When we don't switch the process, the renderer takes care of updating the policy. However, when we switch the process, the redirect is handled in the browser, and we need to update the policy there. BUG=262860 R=simonjam@chromium.org Review URL: https://chromiumcodereview.appspot.com/22904002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217113 0039d316-1c4b-4281-b951-d872f2087c98
-
elijahtaylor@chromium.org authored
Add another extension to the whitelist for Shared Modules on stable and supporting Pepper interfaces BUG=234789 Review URL: https://chromiumcodereview.appspot.com/22407017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217112 0039d316-1c4b-4281-b951-d872f2087c98
-
merlin@google.com authored
Highlights: - packages now have version numbers, some are listed more than once with different version numbers and different licenses. - many missing licenses and mis-handling of AND/OR licensing cases are fixed. - latin1 is converted UTF-8 in a few licenses. - common stock licenses are now only listed once at the end. The resulting file is now almost 5 times smaller than it would otherwise be with the new licenses it was missing until now. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217111 0039d316-1c4b-4281-b951-d872f2087c98
-
dgozman@chromium.org authored
BUG=270055 Review URL: https://chromiumcodereview.appspot.com/22630011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217110 0039d316-1c4b-4281-b951-d872f2087c98
-
sail@chromium.org authored
This CL changes how omnibox popup results are truncated. Previously content text would be truncated at 70% which might leave empty space if the description was short. I've made the following changes to the truncation code: - move the truncation logic to the button cell - have the content text fill up unused space when truncating - use a fade effect to truncate instead of ellipses BUG=9977, 252988 Review URL: https://chromiumcodereview.appspot.com/17774002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217109 0039d316-1c4b-4281-b951-d872f2087c98
-
jiayl@chromium.org authored
Fixes a leak of WebRTCIdentityRequestHandle when WebRTCIdentityStoreBackend::FindIdentity returns false. BUG= Review URL: https://chromiumcodereview.appspot.com/22888002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217108 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
This ensures that both sides' flow control states stay in sync even if one side resets a stream. BUG=269873 R=rch@chromium.org Review URL: https://codereview.chromium.org/22610006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217107 0039d316-1c4b-4281-b951-d872f2087c98
-
sehr@chromium.org authored
BUG=none R=bbudge@chromium.org, bradnelson@chromium.org, bradnelson@google.com, darin@chromium.org, jhawkins@chromium.org, jvoung@chromium.org Review URL: https://codereview.chromium.org/22839005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217106 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217105 0039d316-1c4b-4281-b951-d872f2087c98
-