- 11 Sep, 2020 40 commits
-
-
Mario Sanchez Prada authored
This CL migrates this legacy IPC message out of frame_messages.h to the LocalFrameHost mojo interface from Blink, by using the newly defined method SelectionChanged() in that interface. As part of the migration of the MessageOrderInDidChangeSelection test in render_view_browsertest.cc, this CL also updates that test to rely on gmock to ensure that the two messages are sent and that they happen in the expected order, allowing to refactor some code in that file. Bug: 993189, 1047379 Change-Id: Ia7f51a690fa45ba43e2016081d42c0381359c589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398618Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#806091}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599781911-7dd6ce5c7bf44a9e9e915c505640214d1e509445.profdata to chrome-linux-master-1599803297-c5d0441082dd5a8fa2a2c84cdf40fe1c77138c5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I34a6e1da23e746c01d10e42d68edd0e352350b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405972Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806090}
-
Gauthier Ambard authored
This CL removes the description of the error in the URL. Bug: none Change-Id: I2cfdbce6eddc1876c7ecf46d5bd2a7d395c0ba26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398498 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#806089}
-
Gauthier Ambard authored
This CL makes sure that the last committed item is trusted when it has a file scheme. I think this was the intend when the code was written as the check for the about scheme is here twice. Bug: 991608 Change-Id: I5b2f44351e8b73ccf3804c173db944d49557c477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401022 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806088}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7214110d995d..4bb03bb4b22d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:816629 Tbr: rakina@google.com Change-Id: I39fc271d42e249d7084a884043433b66ee355278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404674Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806087}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0cad688801c9..bbe69951b416 2020-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 87f25134a8c1 to 948b3a05550b (3 revisions) 2020-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 29b1f07f4ab2 to 0c8f66c7169c (15 revisions) 2020-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from b24900a1aa39 to 41974f57973e (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1091364,chromium:1110266,chromium:1122844 Tbr: reed@google.com Test: Test: Test: Build locally.Test: Test: Test: Built locally. Tryjob.Test: Test: CQ Change-Id: I0da01865e2620f2185c77baf66af34ba0713a111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404676Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f2cf0fb5. With Chromium commits locally applied on WPT: d3d1f16b "Visited background-color alpha channel in Forced Colors Mode" 612ba1ba "CookieStore: Remove matchType" da055314 "Revert "CookieStore: Remove matchType"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I9969b28d69e5f682b1af75af77f59d246993d8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405912Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806085}
-
Henrik Boström authored
The current default is YUVY, which despite not being supported by any cameras we've tested, is preferred[1] over the currently recognized YUY2, which IS supported by most cameras we've tested. See [2] and https://crbug.com/1124647. This CL changes the default to NV12 and makes it a recognized format. This pixel format is more preferred (according to [1]) than both YUVY and YUY2. An alternative would be to default to YUY2 instead, and YUVY wouldn't be picked because it isn't in the list of supported formats, but we have reason to believe that NV12 is a better choice for future WebRTC patches and that this format is supported by the Chrome rendering pipeline. NV12 is a planar pixel format, it has 2 planes and is contiguous in memory. To support this, this CL adds support for planar (along with the old nonplanar) contiguous buffers. We don't care how many planes there are, as long as the buffer remains contiguous. [1] https://source.chromium.org/chromium/chromium/src/+/master:media/capture/video_capture_types.cc;l=18;drc=9e9c1706881c9a04f124ade622c10460d14fd9f5?q=media::VideoCaptureFormat::ComparePixelFormatPreference&originalUrl=https:%2F%2Fcs.chromium.org%2F [2] https://docs.google.com/document/d/1kcJ0Km5kAvrNFB6o7RG89bpvjOhgEo-0qorg5qm7KyA/edit?usp=sharing Bug: chromium:1124647 Change-Id: I5c92e1de73922fd9ee87d8a5892438f61f2f56bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391064Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806084}
-
Henrik Boström authored
Per https://crbug.com/1116241, always instantiating and adding the AVCaptureStillImageOutput to the capture session does, in some cases, result in high CPU load due to the macOS process VTDecoderXPCService converting pixel formats and producing MJPEG. But this work is only needed if the ImageCapture.takePhoto() API is invoked, which most MediaStreamTrack-using web pages never use. This CL lazily instantiates _stillImageOutput when takePhoto() is called and keeps it alive until 60 seconds of time has passed without another takePhoto() call. We keep it alive like this because instantiation involves noticeable delays that is avoided if takePhoto() is called after instantiation. The delays are due to two reasons: 1. Delays inherent to instantiating AVCaptureStillImageOutput. 2. This CL introduces a async delay of 3 seconds after instantiation. If we don't wait before taking the photo, the 3A has not stabilized and the photo is too dark. Because performance is critical to the success of WebRTC applications, the pros are believed to outweigh the cons. To achieve its goal, this CL: - Makes it possible to mock the frame receiver. - Adds helper utils. - Adds video_capture_device_avfoundation_mac_unittest.mm. - Replaces a thread checker with a task runner to allow posting tasks. - Introduces MOCK_TIME in the tests. Bug: chromium:1124652, chromium:1116241 Change-Id: I91ebcb45d44fda3fcdb613b8907a10dfa89a9615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388100Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
-
Alice Wang authored
This CL batches AccountPickerBottomSheetRenderTest. Bug: 1120258 Change-Id: Ie4a33489909794fe82dca2427bca5530ea4ffa3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379710Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806082}
-
Eric Willigers authored
Various *ExtensionAppsSync* integration tests have experienced flakiness on *san and debug builds. We reduce the number of apps each test installs to 2. Bug: 1124986,997634 Change-Id: I144bbd143cc34c28fb603b81709f2c25d20d137c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404229Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper::FindReadyRegistrationForId to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: Ib34f0f9063f5ade1029b96d3d5a1eb6ea9ef6757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389201 Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806080}
-
Yoshisato Yanagisawa authored
Bug: b/157436234 Change-Id: I1e15d5eb0164952eb23193c546246340f28bf595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404418 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806079}
-
Maksim Sisov authored
This CL is based on previous Nick's work (https://crrev.com/c/2051187) and fixed modality for gtk file dialogs by leveraging xdg-foreign protocol extension. XdgForeignWrapper has been added to ease usage of the protocol. Bug: 963419, 1008755 Change-Id: I68eb5818a6bb8e7dbf28a13f46e86926dc4cfdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397575 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#806078}
-
Alex Danilo authored
Dates and times should be formatted according to the correct locale and language. Changes the instantiation of Intl.DateTimeFormat to use the current language version. Bug: 1076309 Change-Id: I27793a379899b8d1d1e3734d72b849436de62909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404228 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#806077}
-
Eric Willigers authored
UpdateWebAppInfoFromManifest is updated to copy the share target. https://w3c.github.io/web-share-target/level-2/ web_app_install_utils.cc standalone method SetWebAppManifestFields() is extracted from WebAppInstallFinalizer::SetWebAppManifestFieldsAndWriteData() and updated to copy the share target. Bug: 1125880 Change-Id: I897c2c25e73ea99f358d06a03df38381262222ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398046Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806076}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I66a4cb78f035a6da0c46e1bb799d272dafd12d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404669Reviewed-by:
-
Charles Zhao authored
(1) The HandwritingModel is loaded based on commandline flag "ondevice_handwriting" which is passed from chromeos USE flag. (2) "use_rootfs" means loading HandwritingModel from rootfs, which will simply pass the call to chromeos. (3) "use_dlc" means loading from dlc; which will take 3 steps: (a) verify that dlc already exists on device, return error otherwise. (b) mount the dlc, return error if mount fails. (c) pass LoadHandwritingModel to chromeos. (4) unit tests are added to test the Loader behaviour as described. Bug: 1054628 Change-Id: I3e06fd748573632a7207dc7d9de560f754598466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367257 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#806074}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cfaa2dfc7f..617d3f67c3d9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I677fd4eb0068ab9015d1bfe8195b2ea986b2f023 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405625Reviewed-by:
-
Mariam Ali authored
This CL removes the transparent border around the guest avatar icon in the chip menu. Background: Guest mode avatar had a transparent border which made the image size in the menu 60x60, while expected to be 64x64. After removing the transparent border, the image is resized to its original intended size 64x64. Screenshots: https://screenshot.googleplex.com/BRMVUP8VuSo7wnk.png Bug: 1123472, 1105763 Change-Id: I4b28840f68685e6667c61f18ea8278f3d4e62ecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403463Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Mariam Ali <alimariam@google.com> Cr-Commit-Position: refs/heads/master@{#806072}
-
Samuel Huang authored
This CL adds target to make it easier to build 32-bit Trichrome: * "trichrome" creates: TrichromeChrome.aab TrichromeLibrary.apk TrichromeWebView.aab * This is available even without "is_official_build". * "trichrome_minimal_apks" creates: TrichromeChrome.aab TrichromeChrome.minimal.apks TrichromeLibrary.apk TrichromeWebView.aab TrichromeWebView.minimal.apks * This is used by "resource_sizes_trichrome". Bug: 1040645 Change-Id: Id9b8feabd54303b999ec436fa3d52e6986d1200f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404407 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#806071}
-
Maggie Cai authored
This CL adds the share to drive action in sharesheet for files in Google Drive. Currently, for files in the Google Drive folder, there is an option to "Share with others" to give permission to others to access the file in the drive. Now we are migrating this functionality to sharesheet by adding a drive_share_action. This action should show in sharesheet with the same condition that the Share with others option available. To get the required drive information, we need to get drive properties from file system URL, therefore, I moved the private SingleEntryPropertiesGetterForDriveFs class to util so that both private_api_drive and private_api_sharesheet can use this getter to get the drive properties. BUG=1097623 Change-Id: I5701ddd6fdd17c21497061dd2755e92d7616369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400580Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806070}
-
Dominic Mazzoni authored
Approved for stable launch in http://crbug.com/1085600 Bug: 607777 Change-Id: I0cfd0f5da8d1850e24ca07dfbadd6c1b71b05cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404149Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806069}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9d6f955f52e9..0cad688801c9 2020-09-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from b68279c2 to d14e6a0b (413 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I10f245cc257ad1d11738fc90f07151c505bf914c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404667Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/73cb15011c12..7214110d995d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: rakina@google.com Change-Id: I453ec58be645b85cf7a8c2dd2e4eccb0f1815893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405876Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b6525ec96573..a163e26c8305 2020-09-11 thestig@chromium.org Use CheckedNumerics to calculate size in CalculatePitchAndSize(). 2020-09-11 thestig@chromium.org Funnel all CFX_DIBitmap::Create() allocations through FX_TryAlloc(). 2020-09-11 thestig@chromium.org Use CheckedNumerics to calculate pitch in CalculatePitchAndSize(). 2020-09-10 tsepez@chromium.org Add missing move operators for CFX_BinaryBuf 2020-09-10 thestig@chromium.org Check for potential integer overflows in CFX_DIBitmap::Create(). 2020-09-10 tsepez@chromium.org Add missing |const| to CXFA_FMExpression classes 2020-09-10 tsepez@chromium.org Add missing |noexcept| keyword to our move-constructors. 2020-09-10 nigi@chromium.org Enable FPDFFlattenEmbedderTest.BUG_896366 for Skia. 2020-09-10 nigi@chromium.org Fix CPDFSecurityHandlerEmbedderTest.PasswordAfterGenerateSave for Skia. 2020-09-10 tsepez@chromium.org Make CFXA_TextParser a GCed class. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124660 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ic82d1227e3e3f976b4256252a6889f79cee414b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405879Reviewed-by:
-
Yoshifumi Inoue authored
This lets us control EditingNG rollout via Finch. EditingNG is disabled by default. We will enabling EditingNG gradually rather than fully enabled for ease of rollback when there are issues. Tested either of following commands enables EditingNG: % content_shell --enable-features=EditingNG % content_shell --enable-blink-features=EditingNG Bug: 707656 Change-Id: I2cc591a7a9c6f308582484708966a407a0c6f833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390928Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806065}
-
Xianzhu Wang authored
Bug: 1126582 Change-Id: Ie1c29eda2f7c05a96eef708041b15eed9de4d098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404398 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806064}
-
Chris Lu authored
Adds user metric actions for default browser and first party URL opens. This will be used observe user action sequences. Bug: 1107489 Change-Id: I7ba0290912a5568219c13b8c4c246d86d4ebf3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399084Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#806063}
-
Kent Tamura authored
We had an assumption that line items in input[type=file] didn't have padding. However, ::before or ::after with padding can be in the line items. The |static_width_right| computation was wrong in this case because NGLogicalLineItem::inline_size doesn't contain padding size. We should compute it from NGLogicalLineItem::InlineOffset(). Fixed: 1125428 Change-Id: I290d9f148480569fba75655bae5fd03d80f2132f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404225 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
ssid authored
This reverts commit 3533f3d0. Reason for revert: Fix X86 build. X86-64 builds support frame pointers. Explicitly specify ARM64 in code. Original change's description: > Revert "Android: Add support for tracing sampling profiler on arm64" > > This reverts commit 659b4301. > > Reason for revert: Likely caused compile failure in android x86 builders since: > * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2148 > * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1252 > > Tracking bug: crbug.com/1126519 > > Original change's description: > > Android: Add support for tracing sampling profiler on arm64 > > > > Support stack unwinding for tracing sampling profiler, in arm64 > > builds. The builds always enable frame pointers, so stack unwinding can > > be done using frame pointers. > > > > > > Future work: Support module cache for arm 64. > > > > BUG=1110044 > > > > Change-Id: If98bcc5582edc75b61c5a385cd29535f4a6ee195 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321230 > > Commit-Queue: ssid <ssid@chromium.org> > > Reviewed-by: Mike Wittman <wittman@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Reviewed-by: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805274} > > TBR=thakis@chromium.org,wittman@chromium.org,oysteine@chromium.org,ssid@chromium.org > > Change-Id: Ib9b2d1563951937e22b4299b44bdeec21e2c014f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1110044 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401799 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#805367} TBR=thakis@chromium.org,wittman@chromium.org,oysteine@chromium.org,ssid@chromium.org,hypan@google.com # Not skipping CQ checks because this is a reland. Bug: 1110044 Change-Id: Ibb4549185a0db3a9d33ba8b965ca3f6d6a505090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402964Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#806061}
-
Joel Fernandes authored
Uclamp is upstream since kernel 5.4. Add support to use the same. If the interface is not available, it is ignored so as to keep old kernels working. Note that uclamp is the replacement to the out-of-kernel-tree schedtune. This interface improves performance of urgent tasks such as (display and audio) by making them prefer idle CPUs. A small portion of the uclamp kernel support is not upstream which is uploaded at: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2241891 Bug: 1041117 Change-Id: I0f2d89a9cbe4cdb53a8f1105b6b5a29cdd6fde4a Signed-off-by:
Joel Fernandes <joelaf@google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207962Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806060}
-
rbpotter authored
Update ContextMenuOpensFromTouchSelectionMenu to pass with both flag states, and run it as a parameterized test. Also update PdfZoomWithoutBubble to pass with both states in builds with DCHECKs off, but do not enable this test with the PDFViewerUpdate flag since there is a Blink DCHECK triggered by this test (see crbug.com/1048876). Bug: 1120279 Change-Id: I73fc8ebe083aad410c39aeeb26266424192f2f8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400239Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c37bf0f193b..11042f961ca6 2020-09-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If2d95af17cde96f4e2b93c797db573228e053921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405873Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I91f425566ea069bcb16547d0c8ad80cd22f07b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405874Reviewed-by:
-
Sergey Ulanov authored
CastRunner::OnComponentDestroyed() wasn't handling the case when video_capturer_component_ is destroyed. As result video_capturer_component_ would point to a deleted object. CastRunner was crashing when trying to use the invalid video_capture_component_ in OnCameraServiceRequest(). Bug: crbug.com/1122150 Change-Id: I79c8f10cc5964bf9f7ea81e7a026f5276e3d14e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377898Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806056}
-
Joel Hockey authored
Bug: 1085274 Change-Id: I60e0da146077fa5d4773985ffccd08acefddecda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402473 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1ab73f0f8ce7..0c8f66c7169c 2020-09-11 jiawei.shao@intel.com OpenGL: Get VendorID and DeviceID with angle::GetSystemInfo() 2020-09-11 jmadill@chromium.org Enable -Wweak-template-vtables. 2020-09-11 courtneygo@google.com Fix mismatch issue with precision qualifiers. 2020-09-11 courtneygo@google.com Refactor to pass ProgramMergedVaryings to link impl 2020-09-11 jmadill@chromium.org De-templatize ResourceManagerBase. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib3f51e8cbf71c8a28a5b35c4f35f3c52c41a88c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405529Reviewed-by:
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper::StoreRegistrationUserData to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: Ied3777d06dec5813067f729f412271c2dc83e12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388281 Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a4cfaa2dfc7f..617d3f67c3d9 2020-09-10 zzyiwei@google.com Define GPU metrics 2020-09-10 zzyiwei@google.com Fix the scope of counter_span_view If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:167416193 Tbr: perfetto-bugs@google.com Test: Test: <trace_processor_shell> --run-metrics android_gpu \Test: Test: tools/diff_test_trace_processor.py <trace_processor_shell> \ Change-Id: I571468362f4c7be1a844ca142a879d3976514c03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405521Reviewed-by:
-
