GitLab

Test:
1. run chrome with a metrics enabled and with force-fieldtrials to
  get into a search-term-replacement group
2. enter a query, hit return
3. on the search results page, click in the omnibox and press
  return again (no typing), this reissuing the query while keeping
  the omnibox closed.
4. before this change, the browser would crash.  now it does not.

BUG=370119

Review URL: https://codereview.chromium.org/288073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270879 0039d316-1c4b-4281-b951-d872f2087c98

From the browser-side of things, compositing is always on, except for layout
tests.  The places that do test the compositing state on the browser side are
irrelevant for layout tests and/or redundant with existing state (e.g. whether
we received a frame).

BUG=None

Review URL: https://codereview.chromium.org/274163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270878 0039d316-1c4b-4281-b951-d872f2087c98

- Window manager provided window borders
- Custom shapes specified via views::Widget::SetShape()

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/268673017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373540
TEST=see bug for repro; should not DCHECK.

Review URL: https://codereview.chromium.org/290553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270876 0039d316-1c4b-4281-b951-d872f2087c98

When pthread_create create fails, the content of handle becomes
undefined, but PlatformThreadHandle::platform_handle is initialized to
0, which makes the CHECK_EQ fail.

Fix by resetting handle to 0 if pthread_create fails.

BUG=373905

Review URL: https://codereview.chromium.org/289013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270875 0039d316-1c4b-4281-b951-d872f2087c98

Original patch here: https://codereview.chromium.org/251543003/.
Reverted here: https://codereview.chromium.org/278183002/,
due to memory management issues in tests.

Relanding with a better strategy for cleaning up deleted
GestureProviderAura objects.

This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.

BUG=332418
TEST=GestureRecognizer/GestureRecognizerTest.*
MotionEventUITest.*
TBR=jochen

Review URL: https://codereview.chromium.org/282593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270874 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to cause compile failure on Win Builder:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20401

> Mojo: Internalize ServiceConnector<>
> 
> Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/
> 
> R=viettrungluu@chromium.org, darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/284113009

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/287003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270873 0039d316-1c4b-4281-b951-d872f2087c98

* Fixes GetHomeDir() for multi-profiles case on Chrome OS.
* Once user signs in on Chrome OS base::DIR_HOME is overridden with primary user homedir.
* Added content switch --homedir to pass that information to ppapi plugins since they run in a separate process and previous base::DIR_HOME override does not apply there.

This fix doesn't require checking for --multi-profiles switch
since user_id hash is known even without it.

BUG=331530
TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/200473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270872 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/288003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270871 0039d316-1c4b-4281-b951-d872f2087c98

This prep work will allow the interface in blink to be changed.

Blink change is https://codereview.chromium.org/284143002/.

BUG=360254

Review URL: https://codereview.chromium.org/282073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270870 0039d316-1c4b-4281-b951-d872f2087c98

Authored by davemoore@chromium.org, see https://codereview.chromium.org/275363002/

R=viettrungluu@chromium.org, darin@chromium.org

Review URL: https://codereview.chromium.org/284113009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270867 0039d316-1c4b-4281-b951-d872f2087c98

These methods will be used bisect script to track the status of build.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/284493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270865 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270864 0039d316-1c4b-4281-b951-d872f2087c98

While I'm here make it more consistent with the other foo_strings.gyp we have
in the tree.

Some changes:
1) Make it use grit_target.gypi
2) Have a consistent and path oriented grit_out_dir.
3) Prefix the action name with generate_
4) Remove direct_dependent_settings, since that is what grit_target.gypi
is for.

R=jamescook@chromium.org
TBR=thestig@chromium.org # for trivial change in chrome/

Review URL: https://codereview.chromium.org/281183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270863 0039d316-1c4b-4281-b951-d872f2087c98

Upgraded GCC 4.8 for arm with the latest patches from aosp.
Fixes some performance regressions with GCC 4.8

BUG=359106

Review URL: https://codereview.chromium.org/286113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270862 0039d316-1c4b-4281-b951-d872f2087c98

Upstreams AutocompleteController and OmniboxSuggestion on java side.
Upstreams autocomplete_bridge.cc and renames it to
autocomplete_controller_android.cc.

BUG=222130

Review URL: https://codereview.chromium.org/285633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270861 0039d316-1c4b-4281-b951-d872f2087c98

Looks cleaner this way and avoids creating an unnecessary target in a
random place in content.gyp, also helps keeping things self-contained.

R=jam@chromium.org

Review URL: https://codereview.chromium.org/271243004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270859 0039d316-1c4b-4281-b951-d872f2087c98

This is needed for the new avatar button.
See CL https://codereview.chromium.org/240453006/ for how this will be used
to override the text rendering of the button.  Currently the new avatar menu
override the text rendering but does not do so correctly if the button has
an icon.  This change allows the new avatar menu to override the text render
more cleanly.

BUG=311235

Review URL: https://codereview.chromium.org/284033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270858 0039d316-1c4b-4281-b951-d872f2087c98

The actual validating logic will be in a separate CL.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/273233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270857 0039d316-1c4b-4281-b951-d872f2087c98

Also added default build_type as Release to build method arguments.

BUG=373915
NOTRY=true

Review URL: https://codereview.chromium.org/287063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270855 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270853 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=10&start=14755
TBR=
BUG=

Review URL: https://codereview.chromium.org/282323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270852 0039d316-1c4b-4281-b951-d872f2087c98

The env vars are still used in profiling=1 builds, by such
illustrious figures as the deep memory profiler bot and
willchan. Reading from the environment variables uses static
initializers, so this change will eliminate those static
initializers in profiling=0 builds.

As discussed in the chromium-dev thread
"Does anyone use tcmalloc's debugging envvars?".

BUG=94925
NOTRY=true

Review URL: https://codereview.chromium.org/281613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270850 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to cause Android Tests bot failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/13592

> Android: cleans up jni_generator_ptr_type.
> 
> The underlying rule is now "long" by default.
> Mechanical change:
>   git grep -l jni_generator_ptr_type | xargs sed -i /jni_generator_ptr_type/d
> 
> BUG=317523
> TBR=darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/288963002

TBR=bulach@chromium.org

Review URL: https://codereview.chromium.org/292433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373972
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/291533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270848 0039d316-1c4b-4281-b951-d872f2087c98

This is general cleanup to help move to gaia obfuscated as the account id.
The CL just changes the interface for now.  It will be used in reporting
auth errors in the avatar button, see CL https://codereview.chromium.org/284033002/
for details.

BUG=311235

Review URL: https://codereview.chromium.org/288813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270847 0039d316-1c4b-4281-b951-d872f2087c98

Maybe one day I'll consider checking in golden files and making it a
proper (automated) test ... but in the meanwhile it's still useful for
refactoring the bindings generator code.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/288943005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270845 0039d316-1c4b-4281-b951-d872f2087c98

(modelled on https://codereview.chromium.org/183893029)

This will be used when implementing GCMDriverAndroid.

BUG=350384

Review URL: https://codereview.chromium.org/285203005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351055

Review URL: https://codereview.chromium.org/261013010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270842 0039d316-1c4b-4281-b951-d872f2087c98

R=brianderson, enne
BUG=251936

Review URL: https://codereview.chromium.org/279013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270841 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/287563008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270840 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that any IPC sent from a child process that couldn't be deserialized causes that process to be killed.

Today we do this only for a subset of IPCs and not all process types.

R=jar@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/283313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270839 0039d316-1c4b-4281-b951-d872f2087c98

Retry: The first attempt had a memory leak.  It seems that this leak existed
before this CL, but no code exercised it.  This updated CL includes a scoped
deleter that should fix it.

Original commits message was:

Makes the client assign a valid position to incoming bookmarks if the
server has not populated the required fields.  This code should never be
triggered unless there is a bug in the server.  This risks reordering
users' bookmarks, but that's probably preferable to a crash.  This
fallback code is still protected by a NOTREACHED(), as before.

Detects bookmarks that do not have valid position information during
database load.  If these corrupted bookmarks are detected, the entire
database is declared to be corrupt.  Sync will then re-download
all of the user's data, which should fix the problem.

BUG=367247

Review URL: https://codereview.chromium.org/283143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270837 0039d316-1c4b-4281-b951-d872f2087c98

AudioAndroidOutputTest.StartOutputStreamCallbacksNonDefaultParameters
checks to make sure the callbacks are not exceeding 1.3x the average callback
time, but this appears to be a bit too aggressive on some android devices,
and bots are failing the test.

Increasing the threshold to 1.35x for now until some code owner can look at
this and see if there is a better fix.

TBR=dalecurtis@chromium.org, tommi@chromium.org, henrika@chromium.org
BUG=373945

Review URL: https://codereview.chromium.org/289073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270836 0039d316-1c4b-4281-b951-d872f2087c98

Moves the definition of some invalidations-related swtiches into the
newly-created components/invalidation/invalidation_switches.{cc,h}.

Moves invalidation_service_util.{cc,h} into the component, since those
files no longer depend on chrome/common/chrome_switches.h

Moves p2p_invalidation_service.{cc,h} into the component, since its only
chrome/ dependency was invalidation_service_util.h.

TBR=ben
BUG=336571

Review URL: https://codereview.chromium.org/283673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270835 0039d316-1c4b-4281-b951-d872f2087c98

This test is still disabled pending resolution of some mojo message
validation issues, but this version sould be correct given a correct
message validator.

In other words, running this with --gtest_also_run_disabled_tests is
a good way to test a message validator.

BUG=366797

Review URL: https://codereview.chromium.org/284243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270834 0039d316-1c4b-4281-b951-d872f2087c98

This will replace the repeated PerfDataProto field in the UMA protobuf. It
provides for more metadata surrounding the collection of each profile. It
also allows for more types of profiles to be collected, other than perf.

BUG=chromium:358778
TEST=build successfully
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/226273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270832 0039d316-1c4b-4281-b951-d872f2087c98

All the known issues with these telemetry benchmarks have been fixed.

BUG=355952

Review URL: https://codereview.chromium.org/279853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270830 0039d316-1c4b-4281-b951-d872f2087c98

So that eula-extra-controls container div does not cover buttons and
make them not mouse clickable.

BUG=372098

Review URL: https://codereview.chromium.org/289043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270827 0039d316-1c4b-4281-b951-d872f2087c98

This also fix a typo in ninja_toolchain_writer.h:

s/assicoated/associated

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/283193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270826 0039d316-1c4b-4281-b951-d872f2087c98