GitLab

because overflow happens for integer larger than 2^31. 

original review url: http://codereview.chromium.org/10828226

BUG=120328


Review URL: https://chromiumcodereview.appspot.com/10832334

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=pass all existing tests, manually run file browser

Review URL: https://chromiumcodereview.appspot.com/10854180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151858 0039d316-1c4b-4281-b951-d872f2087c98

different default browser.

This is a trivial change, but it will deal with both issues.
Asking for review & owner's review at the same time since this is only 2 lines.

R=sky
BUG=140065, 141181


Review URL: https://chromiumcodereview.appspot.com/10836271

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151857 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10836219

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151856 0039d316-1c4b-4281-b951-d872f2087c98

chromeos.

BUG=142662
TEST=see bug
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10830325

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151855 0039d316-1c4b-4281-b951-d872f2087c98

For some very mysterious reason the flag flip that should have been marking
H264Pictures as outputted on OutputPic has vanished. This CL restores it.

BUG=142451
TEST=by hand



Review URL: https://chromiumcodereview.appspot.com/10855142

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151854 0039d316-1c4b-4281-b951-d872f2087c98

Adds a new pyauto exception for failures caught by automation calls (inherits from JSONInterfaceError).
Improves the error messages generated for automation infrastructure failures.

TEST=Manually caused automation commands to fail and verified error messages.
BUG=132803

Review URL: https://chromiumcodereview.appspot.com/10855161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151853 0039d316-1c4b-4281-b951-d872f2087c98

R=rsleevi@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10836273

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142804


Review URL: https://chromiumcodereview.appspot.com/10828326

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151851 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thakis@chromium.org
R=gbillock@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10827341

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151850 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10831342

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151849 0039d316-1c4b-4281-b951-d872f2087c98

add to the default container, instead you need to go through the
StackingClient.

BUG=137342
TEST=none
R=ben@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10857021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151848 0039d316-1c4b-4281-b951-d872f2087c98

R=kalman@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10837275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151847 0039d316-1c4b-4281-b951-d872f2087c98

r151845 was merge friendly for M21. But since we don't support OS X
10.5 for M22 and onwards, we can clean it up a bit for trunk.

BUG=142782

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142782

https://chromiumcodereview.appspot.com/10830326/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151845 0039d316-1c4b-4281-b951-d872f2087c98

This patch is needed so that we can have a clean patch to merge
to M21.

https://chromiumcodereview.appspot.com/10830326/

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151842 0039d316-1c4b-4281-b951-d872f2087c98

This allows you to filter the perf tests with a hashtag. For example, adding '#testCreateAndDeleteDatabase' will run only tests with that name. This is just a debugging thing.

R=ericu@chromium.org
BUG=


Review URL: https://chromiumcodereview.appspot.com/10826291

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151841 0039d316-1c4b-4281-b951-d872f2087c98

It used to conatin only "stumpy", but recently official image contains
some suffix, and looks like "stumpy-signed-mp-v2keys". That change caused
regression, and this should fix it.

BUG=chromium:126732
TEST=Open some tabs on stumpy and sync, then on the other machine you should see "Chromebox" instead of "Chromebook" in "ohter devices" menu in new tab page.


Review URL: https://chromiumcodereview.appspot.com/10836257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151839 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/142962
R=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151762
Review URL: https://chromiumcodereview.appspot.com/10836266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151838 0039d316-1c4b-4281-b951-d872f2087c98

See previous change for debugging: http://codereview.chromium.org/10826293/

BUG=140688
TBR=jar
Review URL: https://chromiumcodereview.appspot.com/10857025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151837 0039d316-1c4b-4281-b951-d872f2087c98

DeleteFileSystem will be used in Inspector to allow web developers to clear their filesystem.
And DRT support of DeleteFileSystem will help unittest of Inspector.

BUG=139366


Review URL: https://chromiumcodereview.appspot.com/10824305

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151836 0039d316-1c4b-4281-b951-d872f2087c98

background as to what is happening. Long term the observer likely
needs a type parameter, but this is to stop the crashing.

BUG=142999
TEST=none
R=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10830345

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151835 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139773


Review URL: https://chromiumcodereview.appspot.com/10855186

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151834 0039d316-1c4b-4281-b951-d872f2087c98

All sync-specific encryption state (types, encrypt everything, explicit
passphrase, keys) is now tracked within the new class SyncEncryptionHandler.
It's owned by the sync manager, and unifies some of the observer logic
we previously had. In addition, it's capable of creating its own
transactions, taking us a step closer to have a nigori datatype. 

In addition, we add a NigoriHandler to abstract the chrome-side of
encryption from the sync visible side of encryption.

BUG=139848


Review URL: https://chromiumcodereview.appspot.com/10827266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151833 0039d316-1c4b-4281-b951-d872f2087c98

Removed an unneeded function in the process

TBR=thakis@chromium.org
BUG=137085



Review URL: https://chromiumcodereview.appspot.com/10825352

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151832 0039d316-1c4b-4281-b951-d872f2087c98

* Remove gdata_files.h from gdata_directory_service.h
* Add gdata_files.h where necessary.
* Remove unnecessary includes from gdata_directory_service.* and gdata_files.*

BUG=140317
TEST=compiles.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151829
Review URL: https://chromiumcodereview.appspot.com/10836275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151831 0039d316-1c4b-4281-b951-d872f2087c98

This broke the build.

* Remove gdata_files.h from gdata_directory_service.h
* Add gdata_files.h where necessary.
* Remove unnecessary includes from gdata_directory_service.* and gdata_files.*

BUG=140317
TEST=compiles.
Review URL: https://chromiumcodereview.appspot.com/10836275

TBR=achuith@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832331

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151830 0039d316-1c4b-4281-b951-d872f2087c98

* Remove gdata_files.h from gdata_directory_service.h
* Add gdata_files.h where necessary.
* Remove unnecessary includes from gdata_directory_service.* and gdata_files.*

BUG=140317
TEST=compiles.
Review URL: https://chromiumcodereview.appspot.com/10836275

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151829 0039d316-1c4b-4281-b951-d872f2087c98

button it is entirely possible for Layout() to be invoked before the
button_ has been created.

BUG=143001
TEST=none
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10857024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151828 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151827 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141766
TEST=1) manual with Lumpy 2) the new unit test passed on try

Review URL: https://chromiumcodereview.appspot.com/10837211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151826 0039d316-1c4b-4281-b951-d872f2087c98

BUG=


Review URL: https://chromiumcodereview.appspot.com/10827324

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151825 0039d316-1c4b-4281-b951-d872f2087c98

TBR=epoger@chromium.org
BUG=none


Review URL: https://chromiumcodereview.appspot.com/10825355

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151824 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151821 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10837278

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151819 0039d316-1c4b-4281-b951-d872f2087c98

This will be a considerably more visible bug when the autoclose timeout is longer.

R=estade@chromium.org
BUG=128070


Review URL: https://chromiumcodereview.appspot.com/10855181

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151818 0039d316-1c4b-4281-b951-d872f2087c98

They will be used in views_examples_with_content_lib, so later we can have
a views_examples_lib with examples_window.* that does not include anything from
content/ module.

BUG=141187
R=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827309

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151817 0039d316-1c4b-4281-b951-d872f2087c98

BUG=121496


Review URL: https://chromiumcodereview.appspot.com/10824316

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151816 0039d316-1c4b-4281-b951-d872f2087c98

Allow closing root window, or pressing the power button to shutdown ash_shell, and chrome /w chromeos flag (not running on chromeos) to exit the application


BUG=113123


Review URL: https://chromiumcodereview.appspot.com/10825191

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151815 0039d316-1c4b-4281-b951-d872f2087c98

To support single instance in chrome windows 8. This requires change 27816
on the delegate_execute to be rolled in.

BUG=141032
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/10824321

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151814 0039d316-1c4b-4281-b951-d872f2087c98