- 22 Dec, 2020 13 commits
-
-
Camillo Bruni authored
Additionally add checks to make the contract as per spec [1] for the source_url and base_url clear that kExternalFile modules have source_url == base_url. [1] https://html.spec.whatwg.org/multipage/webappapis.html#concept-script-base-url Bug: 1154943 Change-Id: I761e5fcdef2298c43b908ba09257e9d99dc40df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595415 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838762}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4e2b6d6b0102..11c31e0a4a73 2020-12-21 senorblanco@chromium.org Changes to build inside a Dawn checkout. 2020-12-21 cclao@google.com Vulkan: MapBufferRange should avoid wait if INVALIDATE_BUFFER is set If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id2311c896715079c6c04b9fe3ffb4adee7779ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599921Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838761}
-
Alex Ilin authored
cr-customize-themes isn't fully accessible because the custom elements used to display color buttons don't have any associated aria roles. This CL improves the accessibility of cr-customize-themes by assigning role="radio" and aria-checked attributes to the color buttons. Bug: 1158409 Change-Id: I04f07e569bb11dbd9c04c82578ad0b07ea131037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591127 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#838760}
-
Andrew Nicols authored
When an element is no longer attached to the page's DOM a StaleElementException should be thrown per the JsonWire specification. R=johnchen@chromium.org, shengfa@google.com Bug: chromedriver:3675 Change-Id: I96e300388737ab62cebe07ac851254059ccaef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596290Reviewed-by:
Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Auto-Submit: Andrew Nicols <andrewrn@gmail.com> Cr-Commit-Position: refs/heads/master@{#838759}
-
David Black authored
In order to support forking of the holding space welcome banner text for tablet mode, tablet mode change events needed to be dispatched to the files app extension and the files app extension needs to be able to request tablet mode enabled state at runtime. This CL adds a 'tablet-mode-enabled' class to the DOM when tablet mode is enabled. This can be used in CSS to apply tablet mode specific UI treatments. In the case of holding space, two elements are added to the DOM for welcome text. Only one text element is displayed at a time, depending on whether or not tablet mode is enabled. Note that the actual tablet mode string will be implemented in a follow up CL. Bug: 1154347 Change-Id: I4e6be688da6348a7908f48cd59bbeef6c9d2727d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591712 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#838758}
-
Aya ElAttar authored
- Partial follow-up to crrev.com/c/2461372 where originated_from_renderer_ wasn't copied in Clone(), This fixes Clone() by copying orginated_from_renderer_. - Adds unittests for OSExchangeDataProviderNonBacked to ensure Clone works properly in the future. Bug: 1154232 Change-Id: I7fcbe3d6162ac7f5a500c1292ad72d8e8c7ea8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597596Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#838757}
-
Aaron Leventhal authored
If the role logic needs to be overridden, do it via DetermineAccessibilityRole() or Init(). Do not allow RoleValue() to be overridden, as the role must no vary during the lifetime of an object. Bug: None Change-Id: I14bda422895924f495be13e67de1a598ccbebeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598621 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#838756}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c65f224a7259..8986f3ce67ec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I501c0815fac3a2da3d170a178304f523a72664ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600239Reviewed-by:
-
Aaron Krajeski authored
Throughout cc callers sometimes need to check if a transformation matrix preserves axis alignment or is a perspective projection. These functions already exist on SkMatrix, but we're trying to move away from SkMatrix towards SkM44. Add the helper functions to cc itself with a note to maybe add them to Skia if they start getting used outside of cc. Bug: 1155544 Change-Id: Ieb90af59775b9ec22029e9e941acbb937179c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595831Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838754}
-
Shengfa Lin authored
This change assumes that json/list returns chronological order; the first tab is the newest opened. ChromeDriver defaults to use the first tab of type page from json/list; however, this tab could be opened and closed by user, which could cause ChromeDriver failed to connect to the tab. Instead, we will use the last tab. Bug: chromedriver:3690 Change-Id: I813ee6e6802fba122d819fa6232dbf07f2b2cb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600237Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/37fb5ece29fd..70441189dfa1 2020-12-21 paulirish@chromium.org [Lighthouse] Roll Lighthouse 7.0.0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:772558 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9efd30bb8e9cc9bf7b6bea12fe69add2f3ee5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599886Reviewed-by:
-
Lan Wei authored
Use testdriver Action API to simulate mouse actions in css/selectors/focus-visible-006.html and css/selectors/focus-visible-008.html. TBR=lanwei@chromium.org,mustaq@chromium.org Bug: 1145677 Change-Id: I41347fbe7a1fc2c1d88c548b0f2f6ef86ee75154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600018Reviewed-by:
Lan Wei <lanwei@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#838751}
-
kenkangxgwe authored
Bug: None Test: run cast_media_audio_unittests --gtest_filter=*PostProcessorTest.* Change-Id: I742ed1cad68d81677d90b98682f1d473c05e20a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591915Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mingyu Kang <kenkangxgwe@google.com> Cr-Commit-Position: refs/heads/master@{#838750}
-
- 21 Dec, 2020 27 commits
-
-
Javier Fernández García-Boente authored
Since r807457 we changed the TextBreakIterator default's behavior so that it breaks always after a space, instead of before any space run. In order to implement this new behavior, we needed to compute as well the end of the non-hangable run of the Item being processed. In the mentioned change, we forgot to apply this behavior in the code path used when the soft-hypenation is not enabled. This CL fixes that by determining the non-hangable run end in that case. Bug: 1158747 Change-Id: I1a1324b3d775c24e44aa29b097c45e626d0ad76f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597581 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#838749}
-
Jeffrey Young authored
Mock out all Ambient mode disk access in unit tests. BUG=b:165481552,b:169813071 TEST=ash_unittests --gtest_filter="AmbientPhotoControllerTest.*" TEST=ash_unittests --gtest_filter="AmbientPhotoCacheTest.*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ic063e6b7686a74c67fbe7a23e146a9e1640abfd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558590 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#838748}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdff3fcba638..960bd2dbaa6a 2020-12-21 mtklein@google.com allow arbitrary Builder Features 2020-12-21 brianosman@google.com SkSL: In the front-end, rename PipelineStage to RuntimeEffect 2020-12-21 rmistry@google.com Update go.skia.org/infra in go.mod/go.sum 2020-12-21 bsalomon@google.com compare kernel in GrBicubicEffect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: Iddbd56b825422c30996b495f59bc6702abc0a5c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599919Reviewed-by:
-
Ella Ge authored
Bug: 1152282 Change-Id: Ieced102dbf0f15feadd688c5cc990438d0cdec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595846Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#838746}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb4a68ccf148..ec26b8d2b2f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC liberato@google.com,juanmihd@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1106990 Tbr: liberato@google.com,juanmihd@google.com Change-Id: I5bcc2fd092fb87ad70f9cf1c6a20e768d4cb01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599675Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838745}
-
David Black authored
Note that this CL also updates the lifecycle of the holding space keyed service. Previously it was created with browser context but is now delayed until start of the user session. Also note modifications to DownloadManagerUtils to address tests broken by this CL which assumed DownloadManagerImpl would not be created until after tests bodies executed. Bug: 1155387 Change-Id: I7e0f226cb275465c72eb8d63f1348b44f5412685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572694 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#838744}
-
Camillo Bruni authored
Also clear out the cache handler and the script streamer, since we should no longer access the script's source after clearing it. Bug: 1154943 Change-Id: I89c142f3b33994599483581d3e9f0b3ecf80d073 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595745Reviewed-by:
-
Fabrice de Gans-Riberi authored
Bug: 1073821 Change-Id: If4de5c5c4c1a2c272ec881b553ddc0e7a1bd5937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432133 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#838742}
-
Peter Kotwicz authored
This CL: - Rolls Chromium's guava version to 30.1 This is closer to the version of Guava used by the internal version of Chrome. - Updates the fetch_all.py script to force usage of the listenablefuture 1.0 library version. - Suppresses incorrect vulnerability warning for com_google_guava_failureaccess and com_google_guava_listenablefuture. The https://nvd.nist.gov/vuln/detail/CVE-2020-8908 vulnerability report is overlay broad. BUG=1159853 Change-Id: I4c5828aa3433214f28c6c0ee531f59a27a03973f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596140 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#838741}
-
Shubham Aggarwal authored
Migrate uses of the relevant set_* functions on the sql::Database object to use the new DatabaseOptions constructor instead. This change should have no intended behavioral effect. Bug: 1126968 Change-Id: Ib6bd7558e682dd00a1b40924b86e39275b2dfe64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596219Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Shubham Aggarwal <shuagga@microsoft.com> Cr-Commit-Position: refs/heads/master@{#838740}
-
Thomas Lukaszewicz authored
Update browser command tests for Tab Search to explicitly set the kTabSearch flag when testing and remove the dependency on the default flag state. Bug: None Change-Id: I9fcad4093b50d57079667b373b7d98019a4d3f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598740Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#838739}
-
Zach Trudo authored
RecordHandlerImpl needs to be able to accept either since the server doesn't care which it sends. Bug: chromium:169883262 Change-Id: I72a2d9b52df36326f1f81e66be2b1ca4de4d5950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599809Reviewed-by:
Kyle Williams <kdgwill@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#838738}
-
Nicholas Verne authored
When the disk image for a component is corrupt, it is rejected by dm_verity and fails to mount via the imagloader service. In this case, it is necessary to download a fresh version of the component and try again. Bug: 1068948 Change-Id: Id7607b625ee43b0a1ccc06cfebdb8d4059cdf63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598307Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#838737}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c65f224a7259..8986f3ce67ec 2020-12-21 primiano@google.com Merge "base: rename subprocess.cc -> subprocess_posix.cc" 2020-12-21 primiano@google.com Merge "Move ftrace format_parser into its own subdirectory" 2020-12-21 skyostil@google.com Merge "tracing: Add a way to observe track event sessions" 2020-12-21 primiano@google.com Merge "base::Pipe: Use HANDLE on Windows" 2020-12-21 delphick@google.com metrics: Remap all RAIL_MODE_LOAD to RAIL_MODE_ANIMATION 2020-12-21 delphick@google.com Merge "metrics: Use touch events in modified_rail_slices" 2020-12-21 treehugger-gerrit@google.com Merge "processor: Fix a stack overflow in memory snapshot parsing" 2020-12-19 primiano@google.com install-build-deps: Use different paths for clang on Win vs Linux 2020-12-19 primiano@google.com base::CircularQueue give up on const correctness for MSVC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:174454879,chromium:175871311,chromium:176078470 Tbr: perfetto-bugs@google.com Change-Id: I67ab37041b2397cbfd8e9e8a2228f3e80b2dd5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600063Reviewed-by:
-
Michael Hansen authored
This updates NearbyShareAction to implement content::WebContentsDelegate so that we can handle keyboard events. This was preventing users from opening the feedback window. This change also removes the need to subclass views::WebView, so NearbyShareWebView is deleted. I confirmed via manual testing that links are still working. WebViewExample was used as a reference: https://source.chromium.org/chromium/chromium/src/+/master:ui/views/examples/webview_example.h;drc=d5caa87ad320cc8ceb307f9cc525b7d4f9604dd1 Fixed: 1133817 Change-Id: Id9122ac0a92229a1ebbff66232d31d78ef2ddfcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597900 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#838735}
-
Jeroen Dhollander authored
This is a reland of ef97c140, which was reverted in crrev.com/c/2597250. The original CL introduced a race condition, where LibassistantServiceHostImpl::SetInitializeCallback() assumed LibassistantServiceHostImpl::Launch() had completed, but both ran on different threads so this was not guaranteed. Code (and a lock) has been added to prevent this race condition. Original change's description: > Simplify Libassistant startup (and fix crashes) > > Currently starting Libassistant happens in 2 steps: > 1. (On background thread) ServiceController::Start() creates the > |AssistantManager|. > 2. (On main thread) ServiceControllerProxy::FinishAssistantStart() > sets some extra fields on |AssistantManager| and calls > AssistantManager::Start(). > > This causes a race condition if Libassistant is immediately stopped, > as that happens on the background thread and can collide with step 2 > above. > > To prevent this from happening, this CL collapses both starting steps in > a single step that runs on the background thread. We do this by > registering a callback which is called by the background thread in step > 1 above. > > This callback is temporary but necessary as some parts of the > initialization code still use objects that have not been migrated to the > Libassistant mojom service yet. > > Bug: 1157177, b/171748795, 1128032 > Test: chromeos_unittests "Assistant*:ServiceController*" > Change-Id: Ifab9705839ad5d3e5c9f2b7f7fba4c336b9f7c9d > Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594090 > Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#838277} Bug: 1157177 Bug: b/171748795 Bug: 1128032 Change-Id: I694f71a959ca7d6effd40c9f75422ec2a979d5e9 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599762 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
Yutaka Hirano authored
We kept such resources when they came from plain HTTP (as opposed to HTTPS). As we now prefer HTTPS to HTTP, we don't need optimizations that are effective only for plain HTTP. Bug: None Change-Id: Iab0aa7bc4550f01a6ed7340a99e5b8677b771cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598305 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Bruce Dawson authored
Exiting a process cleanly is difficult and expensive. Avoiding race conditions becomes almost impossible with complex software and a clean exit can be quite slow. Waiting on all threads, paging in code and data, and race conditions make it not worthwhile. We have been gradually moving towards using TerminateProcess for more process types. Although the majority of the shutdown processes tracked by this bug are in utility processes this change uses TerminateProcess for all process types. We should not need to let destructors run so it should be safe to never use exit() (or to make it opt-in). This change also adds TerminateProcess to windows_types.h to avoid having to add a Windows.h include to another source file. Bug: 896565 Change-Id: I720c692b3315544c09fe9ae438fb65f6f77fc657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598043Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#838732}
-
Bailey Berro authored
Uses the correct key to parse the discharge routine result Bug: 1128204 Change-Id: I5948494b513736f8b5bc0bc87cd9eece42d2c2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573387 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Cr-Commit-Position: refs/heads/master@{#838731}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iad8d59a51884e1f3083529dbbc5eb8189b244f87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600022Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#838730}
-
Sophie Chang authored
The bloom filter and optimization filter can get destructed on background thread when a new component comes in after initial load Bug: 1160660 Change-Id: Ia1dd5925d7513391148b677fb3e75b818a9fa190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600040Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#838729}
-
Fredrik Söderqvist authored
Text nodes does not have resources associated with them, so calling WriteResources() should never output anything. Bug: 1160415 Change-Id: I223c20eda8fc2a465cc1394850778e78094cfe9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599523 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#838728}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6aea07880248..cdff3fcba638 2020-12-21 johnstiles@google.com Add support for nulls in BasicBlock::Node::description. 2020-12-21 scroggo@google.com SkAnimatedImage: Always respect exif orientation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bungeman@google.com Change-Id: I2da02f3ba58f14f287ac8b9fc88505da9c9bdcf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599466Reviewed-by:
-
Judy Wang authored
Add new full screen capture function in accelerator, hide behind capture mode flag for now. Test: Manual test Bug: 1149725 Change-Id: I0ca1beb067aaa98d4c0099f6803515142ec5c616 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572686 Commit-Queue: Judy Wang <shidi@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#838726}
-
Aaron Leventhal authored
Code simplification. The ax_list class doesn't add unique logic, and causes role="directory" to be ignored. Bug: None Change-Id: Ie120fceb27b0ba231eb5f631bc7622f9e6fc7fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598618 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/5d4fd88a7403..ec56b90ceab0 2020-12-21 jiawei.shao@intel.com Skip all the dawn_end2end_tests using glTextureView() on GLES If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I9049d49899f69dd94fd9ad6a7ed99c0598736d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598332Reviewed-by:
-
James Cook authored
When the component updater detects that a new Lacros image is available for download, show a notification in the system tray. This is similar to what we used to do for Flash component updates. The only subtlety is that we have to start watching for updates after the initial install of the lacros component. Otherwise the user gets an "update available" notification for a binary they just chose to install by enabling the LacrosSupport flag. Bug: 1154427 Test: added to ash_unittests and unit_tests Change-Id: I0cabc8aad7963d07447a23a812ac5ec2f8ffec6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594320 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#838723}
-
