- 05 Oct, 2016 40 commits
-
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/98c6c15abfec..958e57cbe864 $ git log 98c6c15ab..958e57cbe --date=short --no-merges --format='%ad %ae %s' 2016-10-04 kcwu Fix cmdStageAllocMatrix parameter swap BUG=651849 TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2396753002 Cr-Commit-Position: refs/heads/master@{#423073}
-
dmurph authored
R=michaeln@chromium.org, jww@chromium.org BUG=521183,652853,521082 Review-Url: https://codereview.chromium.org/2385653005 Cr-Commit-Position: refs/heads/master@{#423072}
-
nhiroki authored
A resource list retrieved from ServiceWorkerDatabase must contain the main script. With this CL, ServiceWorkerDatabase checks it when retrieving resource records from the database and notifies ServiceWorkerStorage of database corruption if the records doesn't contain the main script. ServiceWorkerStorage sweeps out the database in the case. BUG=485900 Review-Url: https://codereview.chromium.org/2394443002 Cr-Commit-Position: refs/heads/master@{#423071}
-
raymes authored
This hooks up the plugin placeholder to the Flash permission prompt such that the prompt is displayed when the placeholder is clicked. BUG=641615 TBR=calamity Review-Url: https://codereview.chromium.org/2385033002 Cr-Commit-Position: refs/heads/master@{#423070}
-
horo authored
Revert of Disable ClientOnReceivedError2Test#testUserGestureForIframeSubresource test (patchset #1 id:1 of https://codereview.chromium.org/2398513002/ ) Reason for revert: This test failure was fixed by 64f8e6ee. Original issue's description: > Disable ClientOnReceivedError2Test#testUserGestureForIframeSubresource test > > BUG=652943 > TBR=michaelbai@chromium.org > > Committed: https://crrev.com/163501bc4d0431cf33ddb920af2e1e8fb68606af > Cr-Commit-Position: refs/heads/master@{#423053} TBR=michaelbai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652943 Review-Url: https://codereview.chromium.org/2395713002 Cr-Commit-Position: refs/heads/master@{#423069}
-
yurak authored
Specs: https://html.spec.whatwg.org/#html-element-constructors Replaced V8HTMLElementCustom with V8HTMLConstructor Add new extended attribute [HTMLConstructor] to bindings and IDLExtendedAttributes.txt Added description to IDLExtendedAttributes.md and re-organized descriptions Added checks for conflicting extended attributes with [HTMLConstructor] in v8_interface.py Edited jinja templates for [HTMLConstructor] interface Replaced [CustomConstructor] with [HTMLConstructor] in HTMLElement.idl BUG=648828 Review-Url: https://codereview.chromium.org/2385073002 Cr-Commit-Position: refs/heads/master@{#423068}
-
einbinder authored
BUG=244032 Review-Url: https://codereview.chromium.org/2398473002 Cr-Commit-Position: refs/heads/master@{#423067}
-
jrummell authored
Rather than use a TypeConvertor, reference the existing IPC_STRUCT_TRAITS. BUG=611750 TEST=media_mojo_unittests pass Review-Url: https://codereview.chromium.org/2388383002 Cr-Commit-Position: refs/heads/master@{#423066}
-
xidachen authored
Two of the newly added pixel tests have been picked up by all GPU bots. One of the tests failed on Mac Retina with Nvidia GPU, it is likely due to the device ratio, marking it as failure for now, and will fix it later. BUG=563852 TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2389313003 Cr-Commit-Position: refs/heads/master@{#423065}
-
suzyh authored
This patch implements AnimationEffectTimingReadOnly, an interface of the Web Animations API that is currently missing (http://w3c.github.io/web-animations/#the-animationeffecttimingreadonly-interface). The interface is only exposed behind the experimental-web-platform-features flag. BUG=624639 Review-Url: https://codereview.chromium.org/2379863003 Cr-Commit-Position: refs/heads/master@{#423064}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#423063}
-
tsergeant authored
This adds a screen reader announcement of "Found X search results for 'Y'" when the user performs a search. BUG=425625,606527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2388413002 Cr-Commit-Position: refs/heads/master@{#423062}
-
alemate authored
BUG=604119 TEST=none Review-Url: https://codereview.chromium.org/2393523003 Cr-Commit-Position: refs/heads/master@{#423061}
-
spqchan authored
- Fix the User Account text colors: - For themed windows, the text color should be the same as the selected tab's title - In Guest Mode, the text color should only be white if the browser is not using MD BUG=646060,648890 Review-Url: https://codereview.chromium.org/2369663002 Cr-Commit-Position: refs/heads/master@{#423060}
-
ericwilligers authored
We require offset-path to appear first, then offset-distance and offset-rotation. Standards discussion is continuing, this is intentionally conservative. Spec (not yet updated): https://drafts.fxtf.org/motion-1/#offset-shorthand BUG=638055 Review-Url: https://codereview.chromium.org/2375343002 Cr-Commit-Position: refs/heads/master@{#423059}
-
jbauman authored
video_decode_accelerator_unittest does this, and there's no fundamental reason it shouldn't work. Review-Url: https://codereview.chromium.org/2366213004 Cr-Commit-Position: refs/heads/master@{#423058}
-
prashant.n authored
Currently it sounds like Wait() will return only iff the CV is signaled. But as wait functions are susceptible to spurious wakeups, it may make them singalled before actual signal gets triggered. BUG=None Review-Url: https://codereview.chromium.org/2391893003 Cr-Commit-Position: refs/heads/master@{#423057}
-
haraken authored
Now that ActiveDOMObject::stop() is called almost at the same timing as ContextLifecycleObserver::contextDestroyed(). This CL replaces stop() with contextDestroyed() and removes stop(). BUG=610176 Review-Url: https://codereview.chromium.org/2366253002 Cr-Commit-Position: refs/heads/master@{#423056}
-
pdfium-deps-roller authored
https://pdfium.googlesource.com/pdfium.git/+log/4d29e78fc802..98c6c15abfec $ git log 4d29e78fc..98c6c15ab --date=short --no-merges --format='%ad %ae %s' 2016-10-04 tsepez Fix ownership when making a private annot dictionary into a shared one. TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2389413002 Cr-Commit-Position: refs/heads/master@{#423055}
-
kbr authored
(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved) GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with DEPTH and STENCIL attachments. This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the WebGL side, so that the ES3 implementation can consistently track which attachment is active, in accordance to ES3 rules. BUG=630568 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2389363002 Cr-Commit-Position: refs/heads/master@{#423054}
-
horo authored
BUG=652943 TBR=michaelbai@chromium.org Review-Url: https://codereview.chromium.org/2398513002 Cr-Commit-Position: refs/heads/master@{#423053}
-
Rebaseline Bot authored
https://chromium.googlesource.com/chromium/src/+/6b08cd23a TBR=bokan@chromium.org Review URL: https://codereview.chromium.org/2388163006 . Cr-Commit-Position: refs/heads/master@{#423052}
-
hidehiko authored
This CL switches the interface between ArcBridgeBootstrap and ArcBridgeServiceImpl from Delegate to Observer. Also, ArcBridgeHost will be instantiated in ArcBridgeBootstrap and kept in it. BUG=633258 TEST=Trybots. Review-Url: https://codereview.chromium.org/2379223004 Cr-Commit-Position: refs/heads/master@{#423051}
-
thakis authored
BUG=563793 Review-Url: https://codereview.chromium.org/2395543002 Cr-Commit-Position: refs/heads/master@{#423050}
-
kozyatinskiy authored
BUG=593937 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2388903004 Cr-Commit-Position: refs/heads/master@{#423049}
-
dcheng authored
Noticed this while reading some random code. Nothing appears to actually depend on this early return, so just remove it. BUG=none Review-Url: https://codereview.chromium.org/2390353002 Cr-Commit-Position: refs/heads/master@{#423048}
-
skau authored
Chrome OS uses ENABLE_BASIC_PRINTING but has no system dialog. Disable the shortcut as invoking printing in this state causes a crash. BUG=652220 TEST=Verify printing still works. Ctrl+Shift+P is a nop. Review-Url: https://codereview.chromium.org/2376193006 Cr-Commit-Position: refs/heads/master@{#423047}
-
mcasas authored
This CL introduces type mapping (via StructTraits) between video_capture::mojom::VideoCaptureFormatDataView and media::VideoCaptureFormat and adapts the code in services/video_capture accordingly. This is needed to progress in the migration of Video Capture messages between renderer and browser being tracked in the mentioned bug. BUG=651897, 642387 TEST= video_capture_unittests working. Review-Url: https://codereview.chromium.org/2379253003 Cr-Commit-Position: refs/heads/master@{#423046}
-
sievers authored
This tears down the GLHelperHolder in RenderWidgetHostViewAndroid when all activities get stopped. But it only does this if there are no more readback requests in flight. BUG=641962,636630 Review-Url: https://codereview.chromium.org/2383613005 Cr-Commit-Position: refs/heads/master@{#423045}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/121563eb4a02..85a45d93ed6f $ git log 121563eb4..85a45d93e --date=short --no-merges --format='%ad %ae %s' 2016-10-04 mtklein more debugging for this test. 2016-10-04 ccameron Mac: Remove use of deprecated font APIs CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=stephana@google.com Review-Url: https://codereview.chromium.org/2389373002 Cr-Commit-Position: refs/heads/master@{#423044}
-
imcheng authored
Revert of Reformat comments in core/layout up until LayoutBox (patchset #5 id:80001 of https://codereview.chromium.org/2391893004/ ) Reason for revert: May have broken webkit_tests: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/24637 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Precise%20Leak/builds/472 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/15569 Original issue's description: > Reformat comments in core/layout up until LayoutBox > > BUG=563793 > R=ikilpatrick@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/f88ea2d39f753432656ab06970e7792f012b9104 TBR=ikilpatrick@chromium.org,eae@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563793 Review-Url: https://codereview.chromium.org/2395683002 Cr-Commit-Position: refs/heads/master@{#423043}
-
tedchoc authored
BUG=640549 Review-Url: https://codereview.chromium.org/2391193002 Cr-Commit-Position: refs/heads/master@{#423042}
-
imcheng authored
Revert of Refactor ScrollableArea::setScrollPosition. (patchset #6 id:100001 of https://codereview.chromium.org/2383113003/ ) Reason for revert: Blocks revert of another patch: https://codereview.chromium.org/2395683002/ Original issue's description: > Refactor ScrollableArea::setScrollPosition. > > - Eliminate some redundant PaintLayerScrollableArea methods and > indirection. > > - ScrollableArea::setScrollPosition now always clamps its argument. > Code inspection revealed that nearly all callers were clamping > the position argument anyway. > > - ScrollableArea::setScrollPosition returns immediately if the scroll > position did not change. This avoids a bunch of unnecessary > work. > > - For the rare instances where the scroll position should not be > clamped, or the scroll position update code should run even if the > scroll position didn't change, add the method > setScrollPositionUnconditionally. > > - When modifying the scroll position due to a change in effective > zoom, preserve the offset from beginning of flow, rather than the > distance from top-left of overflow area. > > BUG=417782 > R=skobes@chromium.org,bokan@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/cddc823c56d453758003a831fd5a2475e94c0387 > Cr-Commit-Position: refs/heads/master@{#423033} TBR=bokan@chromium.org,skobes@chromium.org,pdr@chromium.org,szager@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=417782 Review-Url: https://codereview.chromium.org/2387393003 Cr-Commit-Position: refs/heads/master@{#423041}
-
rockot authored
This makes crash dumping optional for RPH::ShutdownForBadMessage, and changes the thread-safe bad_message::ReceivedBadMessage to generate its own crash dump immediately, before potentially posting a UI thread task. All other call sites have been updated to opt into crash dumping, preserving previous behavior. This ensures that bad message reports from the IO thread have a useful crash stack. BUG=652755 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2387113004 Cr-Commit-Position: refs/heads/master@{#423040}
-
allada authored
This patch is to increase perceived performance of network panel by using requestAnimationFrame instead of setTimeout for scheduled refreshes. R=lushnikov BUG=None Review-Url: https://codereview.chromium.org/2392123002 Cr-Commit-Position: refs/heads/master@{#423039}
-
sashab authored
Changed EListStylePosition to an enum class and gave it an unsigned underlying type so it can be stored in a bitfield in the future. Also renamed its members to match its keywords from CSSValueKeywords.in. This is pre-work to move EListStylePosition to be generated in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2380233002 Cr-Commit-Position: refs/heads/master@{#423038}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d561772ce644..f68d5268f877 $ git log d561772ce..f68d5268f --date=short --no-merges --format='%ad %ae %s' 2016-10-04 benjhayden Add a test_data trace containing LayoutTrees. 2016-10-04 aiolos Remove dev build platforms that aren't used in Catapult tests. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2396703002 Cr-Commit-Position: refs/heads/master@{#423037}
-
xiaochengh authored
This patch prunes createVisibleSelectionDeprecated from DragController by either having an explicit layout update before each call site, or confirming that the layout is already clean. Note: Layout is clean at the call site in |dispatchTextInputEventFor()| because it's called directly after a hit test, which is performed in |elementUnderMouse()|. BUG=651373 Review-Url: https://codereview.chromium.org/2386083002 Cr-Commit-Position: refs/heads/master@{#423036}
-
zmo authored
Also adding some missing validation for MapBufferRange. BUG=429053,651843 TEST=gpu_unittests R=piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2221173002 Cr-Commit-Position: refs/heads/master@{#423035}
-
pwnall authored
We don't plan to fix the bug, because the FileSystem API is in maintenance mode. We document the bug as a heads-up to anyone (most likely us in the future) who might want to reuse the code. BUG=171284 Review-Url: https://codereview.chromium.org/2390323003 Cr-Commit-Position: refs/heads/master@{#423034}
-