- 26 Oct, 2018 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bb69b988..954de5bd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I24da46138da7edfac9d4e51784e0327c58190ee5 Reviewed-on: https://chromium-review.googlesource.com/c/1301555Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603055}
-
Adam Rice authored
https://chromium-review.googlesource.com/c/1262055 introduced CHECK statements to BodyStreamBuffer::CloseAndLockAndDisturb to verify that the stream is not garbage collected during execution of the function. None of the CHECK statements have been hit, so we can reasonably conclude that this is not happening in practice. These CHECKs should not be included in a stable release, so remove them. BUG=882599 Change-Id: I6c132ffd81c6642df7f4d9628b76f108f24bc2ed Reviewed-on: https://chromium-review.googlesource.com/c/1296571Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#603054}
-
Adam Rice authored
Copy the the original values of selected DOM constructors, methods and getters to the binding object during global object initialisation. Then access them via the binding object in the V8 extras transferable streams implementation. This protects the implementation from modifications to the global object. Constructors copied: MessageChannel DOMException Methods copied: EventTarget.prototype.addEventListener MessagePort.prototype.postMessage MessagePort.prototype.close MessagePort.prototype.start Accessors copied: MessageChannel.prototype.port1 MessageChannel.prototype.port2 MessageEvent.prototype.data DOMException.prototype.message DOMException.prototype.name BUG=897046 Change-Id: I72e40951e5c45f51c957dfa277044a210b054675 Reviewed-on: https://chromium-review.googlesource.com/c/1291191 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#603053}
-
Joshua Bell authored
Now that base::BindLambdaForTesting() can be used, tasks posted to the Indexed DB task runner in tests don't need to explicitly bring along ambient state. Also, use an explicit RunLoop's Run()/Quit() instead of RunAllTasksUntilIdle() where possible, and 'auto' for readability. Change-Id: Iede419cda01c166e8fe2047c901f528f687f940d Reviewed-on: https://chromium-review.googlesource.com/c/1298416 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#603052}
-
Koji Ishii authored
fast/writing-mode/border-image-vertical-lr.html produces different results because, in legacy, block direction borders applied to inline boxes affect positioning of the line box in vertical-lr writing-mode, when they should not. This patch rebaselines it, and also adds a minimized test to check such borders do not affect line box positioning. Gecko, and WebKit fail the test. Edge passes this test, though it paints the border at the incorrect position. Testing the border positoin is not ref-testable and that it is not included. Bug: 636993 Change-Id: I2568d19dac7f7ea886a46d45620bc22feb172c53 Reviewed-on: https://chromium-review.googlesource.com/c/1301698Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#603051}
-
Sami Kyostila authored
TBR=gab@chromium.org Bug: 891670 Change-Id: I66e545c6bdbf04333cbd9178f8af9f8b2419e543 Reviewed-on: https://chromium-review.googlesource.com/c/1301456Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#603050}
-
Fredrik Söderquist authored
All of the 'blink::*' directives should be unnecessary (now that the code is within Blink.) Remove the testing::StrictMock 'using' too, and just "expand" it at its single usage point. Change-Id: I3171d05f41364fa134c2ee781e93178d831d4eab Reviewed-on: https://chromium-review.googlesource.com/c/1301458 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#603049}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4fa2f815257c..0d828e8bb275 git log 4fa2f815257c..0d828e8bb275 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 primiano@google.com Merge "trace_processor: Fix MacOS build (attempt two)" 2018-10-26 primiano@google.com Merge "Export symbols of ScatteredStreamWriter::Delegate" Created with: gclient setdep -r src/third_party/perfetto@0d828e8bb275 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib0dcb40563381f7c584d852130548d697c5a5d83 Reviewed-on: https://chromium-review.googlesource.com/c/1301533Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603048}
-
Hitoshi Yoshida authored
Generally we use type names of each member as accessor names in generated union implementations. But for annotated types, the difference from its inner type is the conversion from V8 values to native values. i.e. NativeValueTraits. It means that their C++ accessors for each member work as same with their inner types' ones. And it is annoying to use annotated type's names for other objectives like IsLongClamp() and SetStringTreatNullAsEmptyString("foo"). So this CL makes the generator to use inner type names in IDLUnion member accessors. It means we do not have to consider if a member has extended attributes or not, when we access the members. Bug: 894469 Change-Id: I80a6ea2366405a7ae344d740e1611cea20b88d9e Reviewed-on: https://chromium-review.googlesource.com/c/1280382 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#603047}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4f6d8fb43536..0607ea1bb336 Created with: gclient setdep -r src-internal@0607ea1bb336 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia9831c1abcd61ddcaf3e05cb216c8f78181a2a70 Reviewed-on: https://chromium-review.googlesource.com/c/1301236Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603046}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: If241906ba3024ff6f4aa6ef7a5ff06dc682a130b Reviewed-on: https://chromium-review.googlesource.com/c/1293255Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#603045}
-
Mario Sanchez Prada authored
Reimplement callbacks GoogleSigninSucceeded and GoogleSignedOut as OnPrimaryAccountSet and OnPrimaryAccountCleared, from IdentityManager. Bug: 887461 Change-Id: I6a0f5758b8c07f21a8b06b4993a9f58528ee7c7e Reviewed-on: https://chromium-review.googlesource.com/c/1261637 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#603044}
-
Christian Dullweber authored
The style guide says that static functions shouldn't be in the global namespace. TBR: dschuyler@chromium.org, dtrainor@chromium.org Change-Id: I48230748abf496eb312ad0901bf88cbbf9307bcc Reviewed-on: https://chromium-review.googlesource.com/c/1299233 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#603043}
-
Yi Su authored
Generate a searchable URL when a <form> is submitted. When the Js file is injected, it will add listeners to all the submit element(i.e. <button> and <input type="submit"> in all <form>s. This CL doesn't add listeners on <form>s' "submit" events. Most of the code in this CL is based on code from Blink: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/exported/web_searchable_form_data.cc Bug: 433824 Change-Id: Ib56808281265e5605d48148d4504eee0e51d1743 Reviewed-on: https://chromium-review.googlesource.com/c/1293914 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#603042}
-
Greg Thompson authored
ExternalProtocolHandler::GetBlockState queries for a value in a dict pref. Previously, it was using DictionaryPrefUpdate to get the dict. This causes the pref file to be written out in its dtor. This CL switches to ordinary read-only ops to avoid spurious pref file writes. BUG=none R=benwells@chromium.org Change-Id: I9a42441cdee70e7bd9b0f67afefb67d411bef2dd Reviewed-on: https://chromium-review.googlesource.com/c/1298715Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#603041}
-
Ivan Sandrk authored
Test follow-up to crrev.com/c/1234334 [Locked Fullscreen] Fix regression in locked fullscreen mode Bug: 883104 Change-Id: I31c28083b04513c640090a55659612b8b5c4ae8c Reviewed-on: https://chromium-review.googlesource.com/c/1280248 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603040}
-
Fredrik Söderquist authored
The lone 'IDBCursor' can collide with the blink::IDBCursor. Remove the 'using' and specify the namespace instead. TBR=pwnall@chromium.org Bug: 717812 Change-Id: I092b6d3c30931f45d13fd5c35af24539884fa686 Reviewed-on: https://chromium-review.googlesource.com/c/1301434 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#603039}
-
Hitoshi Yoshida authored
To work with IDL types with extended attributes (aka. annotated types), this CL defines IdlAnnotatedType class. https://heycam.github.io/webidl/#idl-annotated-types Bug: 894469 Change-Id: I2b59a391ada7657057f79685bad89f56a32a9349 Reviewed-on: https://chromium-review.googlesource.com/c/1296929 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Dominik Röttsches authored
Contains 2346cb3742fe0f8cfafe8c36a4bd5 and other commits that help with forming clusters for emoji sequences. Add a test to Blink layout tests ensuring that male/female sign sequences are no longer broken up if the primary font contains male/female sign characters. Bug: 708604 Change-Id: I34d22a48ec8e4a9a627b12c68efefaabdcd015c7 Reviewed-on: https://chromium-review.googlesource.com/c/1264519 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
-
Zhuoyu Qian authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: I5c64c32974787491071b8cef410626c5568ad713 Reviewed-on: https://chromium-review.googlesource.com/c/1301136Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#603036}
-
Adam Rice authored
These operations will be used for transferable streams. The operations are implemented in JavaScript and exposed to C++ on the ReadableStreamOperations object. See design doc at https://docs.google.com/document/d/1_KuZzg5c3pncLJPFa8SuVm23AP4tft6mzPCL5at3I9M/edit The new operations are not used outside of tests so far. The implementation currently has the serious issue that if the page modifies the MessagePort or MessageChannel interfaces, it will use the modified versions instead of the originals. Because the operations are still unused this CL by itself it safe. It will be fixed in a followup CL. BUG=894838 Change-Id: Iff40cd9fdd5de39dfce8fbb2b845c1fbd5cbcab0 Reviewed-on: https://chromium-review.googlesource.com/c/1282516Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 11098 11096 11095 11092 11090 11089 11086 11082 11079 11078 11075 11069 11068 11101 3 lines were removed and 11 lines were deflaked by consecutive results since 11075. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I57badc35cbed219bdb41bbea45887b3b2fa82258 Reviewed-on: https://chromium-review.googlesource.com/c/1297852 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#603034}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14d9c293..bb69b988 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6d4e5eb7e498ce7bc254ea9afb674e923bdbd1ca Reviewed-on: https://chromium-review.googlesource.com/c/1301118Reviewed-by:
-
Henrik Grunell authored
TBR=pdr@chromium.org Bug: 899087 Change-Id: Ib988d2211c232c60605e8b24946d564577c59f86 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1301513Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#603032}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb9e116dc8cf..4f6d8fb43536 Created with: gclient setdep -r src-internal@4f6d8fb43536 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8651beac0fcea32de4e6b79852a7de315a619e82 Reviewed-on: https://chromium-review.googlesource.com/c/1301235Reviewed-by:
-
Simon Que authored
Bug: 835732 Change-Id: I551fb49ec4e3790d090985a7a79dbcd1630f63fa Reviewed-on: https://chromium-review.googlesource.com/c/1297213Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#603030}
-
David 'Digit' Turner authored
Since this header, after several refactoring steps, is now only used to define the TracedValue class, renaming it makes sense. This CL only updates base/. Note that a forwarding trace_event_argument.h header is still provided, since a _lot_ of callers outside of base/ need to be updated before we can get rid of it. BUG=898787 R=primiano@chromium.org, oysteine@chromium.org, chiniforooshan@chromium.org, nyquist@chromium.org, fdoray@chromium.org Change-Id: I1156198070353429a6a9933ced3203335d1d874d Reviewed-on: https://chromium-review.googlesource.com/c/1298955Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#603029}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/5abd54166ae7..95dfa5223ac6 git log 5abd54166ae7..95dfa5223ac6 --date=short --no-merges --format='%ad %ae %s' 2018-10-25 zstein@webrtc.org Clarify the desired semantics of AsyncResolverInterface::GetResolvedAddress. 2018-10-25 yujo@chromium.org Split out a separate target for VP8EncoderSimulcastProxy Created with: gclient setdep -r src/third_party/webrtc@95dfa5223ac6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7d9a8528e1214978345387e1f03d4d5310eb21b5 Reviewed-on: https://chromium-review.googlesource.com/c/1300578Reviewed-by:
-
Christopher Lam authored
Logs for unhandled interfaces are spammy and unnecessary. This CL removes them. Bug: None Change-Id: I7135cee2db71edef5ca900395aab7536ff70fb77 Reviewed-on: https://chromium-review.googlesource.com/c/1301135Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#603027}
-
Yue Li authored
Bug: b/118401289 Test: Local build Change-Id: I49d75120af0d75df23772b55b9593bc09eefae2c Reviewed-on: https://chromium-review.googlesource.com/c/1300094Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#603026}
-
sangseok.jang authored
Delete MenuButton in PermissionSelectorRow. It seems it's not used after material refresh. It was replaced with ComboBox. Bug: none Change-Id: I30804d833f78113a60f8ac4a9dce737ccf19e3ad Reviewed-on: https://chromium-review.googlesource.com/c/1293289 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#603025}
-
Julie Jeongeun Kim authored
It introduces DesktopDragDropClientOzone class to manage drag-and-drop. 'DesktopWindowTreeHostPlatform::CreateDragDropClient' creates DesktopDragDropClientOzone and it's connected to platform windows and has an internal runloop like other DragDropClients. It adds WmDragHandler and sets the platform window as a WmDragHandler. When DesktopWindowTreeHostPlatform starts dragging, it gets WmDragHandler through the platform window and sends the dragging request to the platform layer. It implements 'StartDragAndDrop' of 'DragDropClient' for Ozone and adds 'OnDragSessionClosed' to DesktopDragDropClientOzone to finish dragging session. As Wayland platform window has the drag and drop implementation at the platform layer already, it extends WaylandWindow interfaces, StartDrag. With this change, Ozone/Wayland build can start dragging from an application to the Chromium browser. Test=DesktopDragDropClientOzoneTest.StartDrag BUG=875164 Change-Id: I4ebaedfae5f6affb80b4d6c7c6d8ed3ba86ef4ca Reviewed-on: https://chromium-review.googlesource.com/c/1218446Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#603024}
-
Adam Rice authored
The beacon/headers/header-referrer-no-referrer.html test no longer flakily leaks memory. Remove it from LeakExpectations. BUG=762353 Change-Id: I6f9e1e5259c4985e7d50a4f18ac8ac766ee76fab Reviewed-on: https://chromium-review.googlesource.com/c/1299094Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3f5b4ee4adfd..603c5da17491 git log 3f5b4ee4adfd..603c5da17491 --date=short --no-merges --format='%ad %ae %s' 2018-10-26 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@603c5da17491 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I052410197aa0349d0cfc783ab77cc235f3c1902d Reviewed-on: https://chromium-review.googlesource.com/c/1301233Reviewed-by:
-
Artur Khachatryan authored
Due to reverting the commit r602299, now tests in the classes FrameSwitchingTest and GetLogsTest are passing. Enabling these tests on Waterfall. Change-Id: Ia7df623e8eac41ec2272de3c17f1030c91948e18 Reviewed-on: https://chromium-review.googlesource.com/c/1300688Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#603021}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I135531b0410e88cd902e8f9fd4d17703e569e9a2 Reviewed-on: https://chromium-review.googlesource.com/c/1301234Reviewed-by:
-
Ivan Sandrk authored
The controller currently tracks ash::kWindowStateTypeKey which doesn't capture the state transitions properly, instead use aura::client::kShowStateKey for regular stuff and ash::kWindowPinTypeKey for pinned modes (locked fullscreen). Bug: 897260 Change-Id: I9e0160f4cbf4951f147954f222c52c11670fc466 Reviewed-on: https://chromium-review.googlesource.com/c/1299238Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Currently the initial navigation URL is used for handling Signed Exchange in SignedExchangeLoader. But this URL must be updated after redirection. This CL adds |request_url| argument to MaybeCreateLoaderForResponse() method of NavigationLoaderInterceptor to update the URL. And also, this CL moves the location where SignedExchangeRequestHandler is created when NetworkService is disabled from CreateNonNetworkServiceURLLoader() to StartWithoutNetworkService() where ServiceWorkerRequestHandler is created. Bug: 898128 Change-Id: I6fe34c7de2decd7d541988e026cef4ae4067fddf Reviewed-on: https://chromium-review.googlesource.com/c/1296573 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Tarun Bansal authored
Add an experiment to dispatch requests that have been queued for a long time. This provides a fail-safe mechanism for requests to be eventually dispatched to the network in case the scheduler blocks them for too long behind long polling XHRs. Dispatching such requests would allow the page load to proceed. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I02e30452f243dcd6369540c360b2b462cf6b6ea7 Bug: 897371 Reviewed-on: https://chromium-review.googlesource.com/c/1285072 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603017}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c2540ca187ba..cb9e116dc8cf Created with: gclient setdep -r src-internal@cb9e116dc8cf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I62687d72b6f710d8a8b2e36e66c907ee63593a20 Reviewed-on: https://chromium-review.googlesource.com/c/1300577Reviewed-by:
-
