- 27 Oct, 2020 40 commits
-
-
Jan Wilken Dörrie authored
This change simplifies PasswordFormGenerationData by turning it into an aggregate struct. This allows the removal of explicitly listing constructors, assignment operators and destructors, and also allows the usage of designated initializers for more type safety. Bug: 1075444 Change-Id: I9bab98cebb43d45e8a0ea29702a1e326f1bd63d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498595Reviewed-by:
Maria Kazinova <kazinova@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#821211}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I7d45f7b58da0b18ec2eb152b859e3f0a8933d86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821210}
-
Gayane Petrosyan authored
TextFragmentSelectorGenerator gets initialized only for main frame as link to text is supported only for those. Therefore, clients shouldn't call TextFragmentSelectorGenerator for iframes. Also adding a DCHECK that selection happened on the same frame as remote interface is being bind to. Bug: 1139864 Change-Id: Ibe4b03e04ef995ebb000a0488ffaa64e378bf20d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487703Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#821209}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f6c1edff2f42..fc7525b95bfe 2020-10-27 bmeurer@chromium.org [wasm] Roll wasmparser 3.3.1 2020-10-27 alexrudenko@chromium.org Revert theme patching change 2020-10-27 wolfi@chromium.org Update URL for link to mixed content explainer 2020-10-27 sigurds@chromium.org Remove unrestricted annotations to enable more type checking If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1115871,chromium:1119722,chromium:1136484,chromium:1140516,chromium:1141798 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2ac074a699b8834fe0b1ecba63f6b0c4adbbced2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821208}
-
Sigurður Ásgeirsson authored
This reverts commit 39fc8ffd. Reason for revert: https://crbug.com/1142776. Original change's description: > [PM] Add service worker clients to the graph. > > This is lifted from Pat's change at > https://chromium-review.googlesource.com/c/chromium/src/+/2355089 > > Bug: 993029, 1088353, 1121069 > Change-Id: Ibdc91c07a235be347cbe1704f0fe5e77cff73470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490221 > Reviewed-by: Patrick Monette <pmonette@chromium.org> > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820771} TBR=pmonette@chromium.org,siggi@chromium.org Change-Id: I3f7f5694c7e2ed98a176a9521eea551f51e2eb61 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993029 Bug: 1088353 Bug: 1121069 Bug: 1142776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502788Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821207}
-
Stephen McGruer authored
This marks status=test features from runtime_enabled_features.json5 as enabled, which moves run_wpt_test.py closer to the test configuration that run_web_tests.py tests. Bug: None Change-Id: Iba1a92e0f01e9b8211c2875255d0c1c556a58fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498870 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821206}
-
Sylvain Defresne authored
The script build/config/mac/sdk_info.py expects a relative path for `--create_symlinks_at` parameter. The path as constructed was at `$root_out_dir/$root_out_dir_relative_to_src/sdk/xcode_links` while it is at `$root_out_dir/sdk/xcode_links` for iOS. The path used on iOS makes more sense (and was necessary to fix a bug, see https://crrev.com/c/2102544) so use the same path on mac. Bug: 1015730 Change-Id: If234d3f598dc7abdd70d78a8af8d3d140b47cadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501742 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#821205}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/41c24933da1e..25eeaa3d39af 2020-10-27 cwallez@chromium.org Make Surface reference its attached SwapChain If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I60fe4fc31989b98383bc3d263eece9ae32981b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501730Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821204}
-
David Roger authored
The startup performance metrics were recorded when Chrome is restored from background. This was not intedended, as these metrics were designed to measure only startup performance. Bug: 1141011 Change-Id: I20e1ff5f634d2a629349e34f7ced4f0cf2c5b790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489919 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#821203}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/d84ef00c9666..89fe24dbb1e2 $ git log d84ef00c9..89fe24dbb --date=short --no-merges --format='%ad %ae %s' 2020-10-26 vasilvv Use absl::StartsWith/EndsWith in QUIC directly. 2020-10-26 wub If B2H2 option is set in QUIC BBR2, when PROBE_UP exits due to loss, it will set the inflight_hi to the max of (inflight_at_send, inflight_target, max_bytes_delivered_in_round). 2020-10-26 bnc Add code counts for gfe2_reloadable_flag_quic_do_not_clip_received_error_code. 2020-10-26 bnc Add code count for gfe2_reloadable_flag_http2_use_fast_huffman_encoder. 2020-10-23 bnc Move protocol flags out of platform so that they are included in QUICHE. 2020-10-23 mattm Move num_failed_authentication_packets_received to QuicConnectionStats and fix QuicConnectionTest.IntegrityLimitDoesNotApplyWithoutDecryptionKey 2020-10-23 vasilvv Replace QUIC_FALLTHROUGH_INTENDED with ABSL_FALLTHROUGH_INTENDED. 2020-10-23 wub If B2SL option is set in QUIC BBR2, when STARTUP exits due to loss, it will set the inflight_hi to the max of bdp and max_bytes_delivered_in_round. 2020-10-23 mattm Add QuicConfig::KeyUpdateSupportedRemotely getter. 2020-10-23 dschinazi Add code counts for building version negotiation packets 2020-10-23 dschinazi Remove unused QuicPacketCreator::SerializeVersionNegotiationPacket 2020-10-23 haoyuewang Reduce quic::ConnectionId size from 24 bytes to 16 bytes on 64 bit system. This reduces some memory usage of connection & session on the server side. 2020-10-23 mattm Add QuicFramer::PotentialPeerKeyUpdateAttemptCount() method. 2020-10-23 vasilvv Downgrade a QUIC_BUG to a warning. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ie36d80a7626c9e899f51a5e298b6a41f9f9f4474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500568 Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#821202}
-
Titouan Rigoudy authored
Second try, this time minus the flaky test? I am hoping that with the parent CL fixing crbug.com/1134601, UseCounter behavior will be a bit more deterministic. In any case, I broke out the flaky test to its own follow-up CL so that it can be more easily reverted in isolation. This mostly reverts commit fb82736e. Bug: chromium:1134601, chromium:1124358, chromium:1135654 Change-Id: I8ded2e0651f9efee2489b5e45de4ebd5b2df6169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490012 Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821201}
-
Robbie Gibson authored
When the FullscreenProvider is used, the layout of the browser views is slightly different. Instead of having the web content views start from the bottom of the toolbar, the web content extends all the way to the top of the BrowserContainerViewController, behind the tab strip. This means that the prior approach of making all the top background views clear does not work when using FullscreenProvider. Instead, this CL uses the following approach: set these background views to have the same background color as the tab grid. As soon as the panning gesture starts, make them clear so the tab grid shows through and the animations appear correctly. At the same time, move the web content views down so they don't obstruct the animations either. Bug: 1094335 Change-Id: Ieea7d268e781da5e1ccd4c2c0ad3c0925407d133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489898Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#821200}
-
Side Yilmaz authored
This CL removes the unnecessary profile checks for OTR profile, since IncognitoTabModelImpl guarantees to return non null profile for getProfile function with the recent change. Force profile creation is also not needed, since IncognitoTabModelImpl forces for the creation now. Bug: 1140892, 1060940, 1126532 Change-Id: Ie07c15399b3270d3b268213f84fc4a96431cd3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494889 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#821199}
-
Javier Ernesto Flores Robles authored
Bug: N/A Change-Id: I0438521c1adfb54d551cf0953687597690d66cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498837Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821198}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Idb938ef5478ed1372e6ad0d98433aa4872108f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501665Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821197}
-
Wojciech Bielawski authored
Summary: Python3 doesn't support comparison between NoneType objects. Jinja uses sort function within 'groupby' and that leads to "TypeError: '<' not supported between instances of 'NoneType' and 'NoneType'" when template tries to group by attribute that is empty. This commit adds 'stringifykeygroupby' which mimics jinja's groupby but converts keys to string during sort, so comparison always succeeds. Bug: 1138872 Change-Id: If604b4b8c405b5d924c934a04ffc763132b72061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495062Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#821196}
-
Thiabaud Engelbrecht authored
Change-Id: I0cb181ef36a5379b65dbeb000a3958d6f01b21e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499415Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Thiabaud Engelbrecht <thiabaud@google.com> Cr-Commit-Position: refs/heads/master@{#821195}
-
Caroline Rising authored
This change is behind kReadLater feature flag. Originally closing the tab after it was added to read later was the desired behavior. Based on fishfood feedback we have changed this decision and want tabs to remain open after being added to read later. Bug: 1117023, 1117023 Change-Id: I84bcf1d2203a950c62c56ac4fb1f0e8cb2f99f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498103Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#821194}
-
Illia Klimov authored
As part of http://crbug.com/1064647 this CL removes DefaultPluginsSetting policy. Bug: 1083496 Change-Id: I58f28291d6ed191aad8f0c2d743c886d1ddab832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489648Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Illia Klimov <elklm@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#821193}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ea929126..da4b0932 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8cd0f38b454e546dbc2e8ebc05d3d73248e6cb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502141Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821192}
-
Chromium WPT Sync authored
Using wpt-import in Chromium cb73fbe5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I16879c47d22f1986fede07b4b516451e1ae84fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502101Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821191}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=engedy@chromium.org Bug: 1142671 Change-Id: Iaad90fd28073bddc82dc6e318889c2c6114e1b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500555 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#821190}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=tommi@chromium.org Bug: 1142671 Change-Id: I9168be064413b1d515799a0be1ad9140d6672eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500495 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#821189}
-
Aaron Colwell authored
Enabling test to see if it is still flaky on Windows. Bug: 980446 Change-Id: I6f1b0dce68cce9bd359ebe315ee8782b26888c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498957 Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#821188}
-
Henrique Ferreiro authored
On Ozone/Wayland, the cursor bitmap as obtained by CursorLoader already matches the device scale factor, after selecting the most appropriate asset (100P, 200P, etc.). The Wayland surface needs to know about this scale, so that it doesn't scale it further in some cases (e.g. HiDPI). On Linux, this was previously working in HiDPI displays because of a bug in mutter: https://gitlab.gnome.org/GNOME/mutter/-/issues/1215, where cursor surfaces aren't scaled. The issue was present on Lacros though, but resulted in cursors being blurry instead of too big, because, when Chrome was launched, the initial display configuration wasn't being passed to CursorLoader. This meant that the 1.0 default scale was used, so that the 100P cursor image assets were loaded and then scaled by the compositor. A fix for the latter issue landed in https://crrev.com/c/2443610. Bug: 1127962, 1141426 Change-Id: I1511fe9fc24f85db77e1bcc66ebbb720a8ce3375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470626 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821187}
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. BUG=b:158955123 TEST=unit_tests. Change-Id: I901403863794308619bec161354884808988b2f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497386Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#821186}
-
Mario Sanchez Prada authored
As a followup to the migration of PageMsg_SetRendererPrefs to mojo, this CL continues now the process of moving more parts into Blink by changing the ownership of blink::RendererPreferences from RenderViewImpl into WebViewImpl. It also gets rid of render_view_linux.cc and render_view_fuchsia.cc since that logic has now moved to Blink, into web_view_impl.cc. We can't get rid of all the code in render_view_win.cc yet, though, because of the dependency that RenderViewImpl::UpdateThemePrefs() has on //content/child's WebThemeEngineDefault class, but that's a small part really, so this CL removes that file and moves the 5 lines we still need into RenderViewImpl::DidUpdateRendererPreferences(). Bug: 1102442 Change-Id: Iff8de455b3204e48649337b34fc24f215a4e5226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490047 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#821185}
-
Rushan Suleymanov authored
Added experiment: InvalidateBookmarkSyncMetadataIfClientTagMissing. Bug: None Change-Id: Ib72d022f5292ec8fc9a10cdb73d92ff37391f74f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494880Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821184}
-
dpapad authored
- Add new resource_path_prefix option to generate_grd(), which makes it possible to generate grdp files in subfolders of the parent grd file. - Move preprocess_grit() for cr_elements/ under cr_elements/BUILD.gn - Add new generate_grd() target in cr_elements/ - Remove now obsolete alias in shared_resources_data_source.cc. Bug: 1132403 Change-Id: Ia1920b2eb799bcce325bf0087c9f3450b153b816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494781 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821183}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=karandeepb@chromium.org Bug: 1142671 Change-Id: I8c2164e9841f1470aba590d8b8a3e4e1c2d116c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500211 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#821182}
-
Rune Lillesveen authored
We optimized away the fetch of CSS image resources for display:none and display:contents. When an image is inherited from a display:contents into a rendered element, we did not do LoadPendingResources. This caused a crash trying to paint a pending image. Instead of loading explicitly inherited pending images, remove the optimization for display:contents. Bug: 1105850 Change-Id: Id0d45c78a86daecd2e2cb5f0d20accb6b73f1207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494947 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821181}
-
Hidehiko Abe authored
Currently, there are two issues. - Delegate method is called after resetting preedit cursor so the passed value is always -1. - According to the protocol definition, it is the byte-offset, but we need to convert it to the string16's offset. Bug: 1140536 Test: Ran manually with Lacros. Change-Id: I06b018b7e945208f9f1f166ecf0dcf36d882a2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486010Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821180}
-
Henrique Ferreiro authored
In renderer to browser messages, this field isn't used and, because WTF::String supports nullability, the value was serialized as null. In addition, this CL adds and fixes some of the checks done in the DragData Mojo type mapping. Bug: 1136901 Change-Id: Ifc9f9343817d2e06d734470573ce3785cbe885d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489897 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821179}
-
David Roger authored
This reverts commit cf5951dd. Reason for revert: Likely culprit for GeolocationServiceUnitTest.UrlWithApiKey flakiness on Mac Original change's description: > Separate Core Location flag into 2 flags for backend and permission UI > > The Permission UI for getting location permission from mac is completely > separate from the actual Core Location backend. Furthermore, once we > have location permission from macOS our Network Location Provider works > as intended. This CL separates those 2 independent workflows and allows > the Network Location Provider to monitor permission and act accordingly. > > Bug: 1112630 > Change-Id: I4e3141f756eadcb3d7ecc66c347fc24148505edc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2454307 > Commit-Queue: James Hollyer <jameshollyer@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821050} TBR=reillyg@chromium.org,jameshollyer@chromium.org Change-Id: Icf38bfb889a62ee4e6d70eff0bc1adc2316d9ed6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502368Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#821178}
-
Richard Knoll authored
- Android.[BTS].ExactTaskCreated: Extended until M91 as this is part of the metrics for Notification Triggers currently running as an OT. - Android.[BTS].MigrationToProto: Expired as the migration is now pretty much over and we don't look at this metric anymore. Bug: 1140008 Change-Id: Iafffbcdcc6904d0d0214e40004d7fb0c6872a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491364Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#821177}
-
nohe@chromium.org authored
This implements an append option so we can append images to an existing clipboard data object. This allows us to preserve existing clipboard metadata and copy images to the system clipboard. Bug: 827333 Change-Id: I89062055d21f252274c6a77cc72cfaf2eed3598a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463851Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alexander Nohe <nohe@chromium.org> Cr-Commit-Position: refs/heads/master@{#821176}
-
henrika authored
Initial work in this area landed in https://chromium-review.googlesource.com/c/chromium/src/+/2440055 This CL adds two new UMA histograms: 1) Media.Audio.Capture.Win.DefaultEffectType 2) Media.Audio.Capture.Win.RawEffectType Each histogram can contain 17 different values and they indicate support of different audio effect components such as AEC, NS, AGC etc. The idea is to monitor how common each of these audio effects are. There is one histogram for each audio processing mode: Default and Raw. The CL changes no real-time functionality but it uses Windows UWP APIs to enumerate the supported and active capture effects when opening audio input streams on Windows. Bug: 1133643 Change-Id: I3d866b96a5d240cf8fcbaa299f8f318615f6be0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2450195Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#821175}
-
Rainhard Findling authored
Bug: 1087263 Change-Id: I85e269707a7579c8894a25ab1d8dc7da71009906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494766 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#821174}
-
Caitlin Fischer authored
Bug: 1126640, 1024661 Change-Id: I1243ce07f422d95b85df81bc68962c1443868f7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500702Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#821173}
-
Lucas Furukawa Gadani authored
This CL was uploaded by git cl split. R=eladalon@chromium.org Bug: 1142671 Change-Id: I7d3e1a64045a53d85d3358916d87fda0ec01323e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500608 Auto-Submit: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Elad Alon <eladalon@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#821172}
-